diff --git a/radio/1.0/vts/functional/radio_hidl_hal_cell_broadcast.cpp b/radio/1.0/vts/functional/radio_hidl_hal_cell_broadcast.cpp index 53d1b90a64..bbca9e4062 100644 --- a/radio/1.0/vts/functional/radio_hidl_hal_cell_broadcast.cpp +++ b/radio/1.0/vts/functional/radio_hidl_hal_cell_broadcast.cpp @@ -75,7 +75,10 @@ TEST_F(RadioHidlTest, setGsmBroadcastConfig) { EXPECT_EQ(serial, radioRsp->rspInfo.serial); if (cardStatus.cardState == CardState::ABSENT) { - EXPECT_EQ(RadioError::NONE, radioRsp->rspInfo.error); + ASSERT_TRUE(CheckGeneralError() || + radioRsp->rspInfo.error == RadioError::INVALID_ARGUMENTS || + radioRsp->rspInfo.error == RadioError::INVALID_STATE || + radioRsp->rspInfo.error == RadioError::NONE); } } @@ -92,7 +95,9 @@ TEST_F(RadioHidlTest, getGsmBroadcastConfig) { EXPECT_EQ(serial, radioRsp->rspInfo.serial); if (cardStatus.cardState == CardState::ABSENT) { - EXPECT_EQ(RadioError::NONE, radioRsp->rspInfo.error); + ASSERT_TRUE(CheckGeneralError() || + radioRsp->rspInfo.error == RadioError::INVALID_STATE || + radioRsp->rspInfo.error == RadioError::NONE); } } @@ -117,7 +122,8 @@ TEST_F(RadioHidlTest, setCdmaBroadcastConfig) { EXPECT_EQ(serial, radioRsp->rspInfo.serial); if (cardStatus.cardState == CardState::ABSENT) { - EXPECT_EQ(RadioError::NONE, radioRsp->rspInfo.error); + ASSERT_TRUE(CheckGeneralError() || + radioRsp->rspInfo.error == RadioError::INVALID_ARGUMENTS); } } @@ -134,7 +140,7 @@ TEST_F(RadioHidlTest, getCdmaBroadcastConfig) { EXPECT_EQ(serial, radioRsp->rspInfo.serial); if (cardStatus.cardState == CardState::ABSENT) { - EXPECT_EQ(RadioError::NONE, radioRsp->rspInfo.error); + ASSERT_TRUE(CheckGeneralError()); } } @@ -152,7 +158,8 @@ TEST_F(RadioHidlTest, setCdmaBroadcastActivation) { EXPECT_EQ(serial, radioRsp->rspInfo.serial); if (cardStatus.cardState == CardState::ABSENT) { - EXPECT_EQ(RadioError::NONE, radioRsp->rspInfo.error); + ASSERT_TRUE(CheckGeneralError() || + radioRsp->rspInfo.error == RadioError::INVALID_ARGUMENTS); } } @@ -170,6 +177,10 @@ TEST_F(RadioHidlTest, setGsmBroadcastActivation) { EXPECT_EQ(serial, radioRsp->rspInfo.serial); if (cardStatus.cardState == CardState::ABSENT) { - EXPECT_EQ(RadioError::NONE, radioRsp->rspInfo.error); + ASSERT_TRUE(CheckGeneralError() || + radioRsp->rspInfo.error == RadioError::INVALID_ARGUMENTS || + radioRsp->rspInfo.error == RadioError::INVALID_STATE || + radioRsp->rspInfo.error == RadioError::NONE || + radioRsp->rspInfo.error == RadioError::OPERATION_NOT_ALLOWED); } } diff --git a/radio/1.0/vts/functional/radio_hidl_hal_data.cpp b/radio/1.0/vts/functional/radio_hidl_hal_data.cpp index 526cb047d1..4eeabe8406 100644 --- a/radio/1.0/vts/functional/radio_hidl_hal_data.cpp +++ b/radio/1.0/vts/functional/radio_hidl_hal_data.cpp @@ -75,7 +75,13 @@ TEST_F(RadioHidlTest, setupDataCall) { EXPECT_EQ(serial, radioRsp->rspInfo.serial); if (cardStatus.cardState == CardState::ABSENT) { - ASSERT_FALSE(RadioError::NONE == radioRsp->rspInfo.error); + ASSERT_TRUE(radioRsp->rspInfo.error == RadioError::NONE || + radioRsp->rspInfo.error == RadioError::RADIO_NOT_AVAILABLE || + radioRsp->rspInfo.error == + RadioError::OP_NOT_ALLOWED_BEFORE_REG_TO_NW || + radioRsp->rspInfo.error == + RadioError::OP_NOT_ALLOWED_DURING_VOICE_CALL || + CheckOEMError()); } } @@ -94,7 +100,7 @@ TEST_F(RadioHidlTest, deactivateDataCall) { EXPECT_EQ(serial, radioRsp->rspInfo.serial); if (cardStatus.cardState == CardState::ABSENT) { - EXPECT_EQ(RadioError::INVALID_ARGUMENTS, radioRsp->rspInfo.error); + EXPECT_EQ(RadioError::INVALID_CALL_ID, radioRsp->rspInfo.error); } } @@ -111,7 +117,8 @@ TEST_F(RadioHidlTest, getDataCallList) { EXPECT_EQ(serial, radioRsp->rspInfo.serial); if (cardStatus.cardState == CardState::ABSENT) { - EXPECT_EQ(RadioError::NONE, radioRsp->rspInfo.error); + ASSERT_TRUE(radioRsp->rspInfo.error == RadioError::NONE || + radioRsp->rspInfo.error == RadioError::RADIO_NOT_AVAILABLE); } } @@ -152,7 +159,11 @@ TEST_F(RadioHidlTest, setInitialAttachApn) { EXPECT_EQ(serial, radioRsp->rspInfo.serial); if (cardStatus.cardState == CardState::ABSENT) { - ASSERT_FALSE(RadioError::NONE == radioRsp->rspInfo.error); + ASSERT_TRUE(radioRsp->rspInfo.error == RadioError::NONE || + radioRsp->rspInfo.error == RadioError::RADIO_NOT_AVAILABLE || + radioRsp->rspInfo.error == + RadioError::SUBSCRIPTION_NOT_AVAILABLE || + CheckOEMError()); } } diff --git a/radio/1.0/vts/functional/radio_hidl_hal_icc.cpp b/radio/1.0/vts/functional/radio_hidl_hal_icc.cpp index 107feb40a2..1547c33b07 100644 --- a/radio/1.0/vts/functional/radio_hidl_hal_icc.cpp +++ b/radio/1.0/vts/functional/radio_hidl_hal_icc.cpp @@ -316,6 +316,8 @@ TEST_F(RadioHidlTest, supplyNetworkDepersonalization) { EXPECT_EQ(serial, radioRsp->rspInfo.serial); if (cardStatus.cardState == CardState::ABSENT) { - ASSERT_TRUE(radioRsp->rspInfo.error == RadioError::PASSWORD_INCORRECT); + ASSERT_TRUE(CheckGeneralError() || + radioRsp->rspInfo.error == RadioError::INVALID_ARGUMENTS || + radioRsp->rspInfo.error == RadioError::PASSWORD_INCORRECT); } } diff --git a/radio/1.0/vts/functional/radio_hidl_hal_ims.cpp b/radio/1.0/vts/functional/radio_hidl_hal_ims.cpp index 0ec2e5c03c..ddf6b7eec8 100644 --- a/radio/1.0/vts/functional/radio_hidl_hal_ims.cpp +++ b/radio/1.0/vts/functional/radio_hidl_hal_ims.cpp @@ -31,9 +31,8 @@ TEST_F(RadioHidlTest, getClir) { EXPECT_EQ(serial, radioRsp->rspInfo.serial); if (cardStatus.cardState == CardState::ABSENT) { - ASSERT_TRUE(radioRsp->rspInfo.error == RadioError::MODEM_ERR || - radioRsp->rspInfo.error == RadioError::SYSTEM_ERR || - radioRsp->rspInfo.error == RadioError::INTERNAL_ERR); + ASSERT_TRUE(CheckGeneralError() || + radioRsp->rspInfo.error == RadioError::MODEM_ERR); } } @@ -73,10 +72,9 @@ TEST_F(RadioHidlTest, getFacilityLockForApp) { EXPECT_EQ(serial, radioRsp->rspInfo.serial); if (cardStatus.cardState == CardState::ABSENT) { - ASSERT_TRUE(radioRsp->rspInfo.error == RadioError::INVALID_ARGUMENTS || - radioRsp->rspInfo.error == RadioError::MODEM_ERR || - radioRsp->rspInfo.error == RadioError::SYSTEM_ERR || - radioRsp->rspInfo.error == RadioError::INTERNAL_ERR); + ASSERT_TRUE(CheckGeneralError() || + radioRsp->rspInfo.error == RadioError::INVALID_ARGUMENTS || + radioRsp->rspInfo.error == RadioError::MODEM_ERR); } } @@ -99,10 +97,9 @@ TEST_F(RadioHidlTest, setFacilityLockForApp) { EXPECT_EQ(serial, radioRsp->rspInfo.serial); if (cardStatus.cardState == CardState::ABSENT) { - ASSERT_TRUE(radioRsp->rspInfo.error == RadioError::INVALID_ARGUMENTS || - radioRsp->rspInfo.error == RadioError::MODEM_ERR || - radioRsp->rspInfo.error == RadioError::SYSTEM_ERR || - radioRsp->rspInfo.error == RadioError::INTERNAL_ERR); + ASSERT_TRUE(CheckGeneralError() || + radioRsp->rspInfo.error == RadioError::INVALID_ARGUMENTS || + radioRsp->rspInfo.error == RadioError::MODEM_ERR); } } @@ -122,10 +119,11 @@ TEST_F(RadioHidlTest, setBarringPassword) { EXPECT_EQ(serial, radioRsp->rspInfo.serial); if (cardStatus.cardState == CardState::ABSENT) { - ASSERT_TRUE(radioRsp->rspInfo.error == RadioError::INVALID_ARGUMENTS || - radioRsp->rspInfo.error == RadioError::MODEM_ERR || - radioRsp->rspInfo.error == RadioError::SYSTEM_ERR || - radioRsp->rspInfo.error == RadioError::INTERNAL_ERR); + ASSERT_TRUE(CheckGeneralError() || + radioRsp->rspInfo.error == RadioError::INVALID_ARGUMENTS || + radioRsp->rspInfo.error == RadioError::NONE || + radioRsp->rspInfo.error == RadioError::MODEM_ERR || + radioRsp->rspInfo.error == RadioError::FDN_CHECK_FAILURE); } } @@ -142,9 +140,8 @@ TEST_F(RadioHidlTest, getClip) { EXPECT_EQ(serial, radioRsp->rspInfo.serial); if (cardStatus.cardState == CardState::ABSENT) { - ASSERT_TRUE(radioRsp->rspInfo.error == RadioError::MODEM_ERR || - radioRsp->rspInfo.error == RadioError::SYSTEM_ERR || - radioRsp->rspInfo.error == RadioError::INTERNAL_ERR); + ASSERT_TRUE(CheckGeneralError() || + radioRsp->rspInfo.error == RadioError::MODEM_ERR); } } @@ -180,7 +177,7 @@ TEST_F(RadioHidlTest, requestIsimAuthentication) { EXPECT_EQ(serial, radioRsp->rspInfo.serial); if (cardStatus.cardState == CardState::ABSENT) { - EXPECT_EQ(RadioError::NONE, radioRsp->rspInfo.error); + ASSERT_TRUE(CheckGeneralError()); } } diff --git a/radio/1.0/vts/functional/radio_hidl_hal_misc.cpp b/radio/1.0/vts/functional/radio_hidl_hal_misc.cpp index 5515b8d28e..6879c90fc3 100644 --- a/radio/1.0/vts/functional/radio_hidl_hal_misc.cpp +++ b/radio/1.0/vts/functional/radio_hidl_hal_misc.cpp @@ -108,7 +108,10 @@ TEST_F(RadioHidlTest, setNetworkSelectionModeAutomatic) { EXPECT_EQ(serial, radioRsp->rspInfo.serial); if (cardStatus.cardState == CardState::ABSENT) { - ASSERT_TRUE(radioRsp->rspInfo.error == RadioError::ILLEGAL_SIM_OR_ME); + ASSERT_TRUE(CheckGeneralError() || + radioRsp->rspInfo.error == RadioError::ILLEGAL_SIM_OR_ME || + radioRsp->rspInfo.error == RadioError::NONE || + radioRsp->rspInfo.error == RadioError::OPERATION_NOT_ALLOWED); } } @@ -124,7 +127,11 @@ TEST_F(RadioHidlTest, setNetworkSelectionModeManual) { EXPECT_EQ(serial, radioRsp->rspInfo.serial); if (cardStatus.cardState == CardState::ABSENT) { - ASSERT_TRUE(radioRsp->rspInfo.error == RadioError::ILLEGAL_SIM_OR_ME); + ASSERT_TRUE(CheckGeneralError() || + radioRsp->rspInfo.error == RadioError::INVALID_ARGUMENTS || + radioRsp->rspInfo.error == RadioError::ILLEGAL_SIM_OR_ME || + radioRsp->rspInfo.error == RadioError::NONE || + radioRsp->rspInfo.error == RadioError::INVALID_STATE); } } @@ -140,7 +147,11 @@ TEST_F(RadioHidlTest, getAvailableNetworks) { EXPECT_EQ(serial, radioRsp->rspInfo.serial); if (cardStatus.cardState == CardState::ABSENT) { - ASSERT_TRUE(radioRsp->rspInfo.error == RadioError::NONE); + ASSERT_TRUE(CheckGeneralError() || + radioRsp->rspInfo.error == RadioError::NONE || + radioRsp->rspInfo.error == RadioError::DEVICE_IN_USE || + radioRsp->rspInfo.error == RadioError::CANCELLED || + radioRsp->rspInfo.error == RadioError::OPERATION_NOT_ALLOWED); } } @@ -284,7 +295,9 @@ TEST_F(RadioHidlTest, getCdmaRoamingPreference) { EXPECT_EQ(serial, radioRsp->rspInfo.serial); if (cardStatus.cardState == CardState::ABSENT) { - ASSERT_TRUE(radioRsp->rspInfo.error == RadioError::NONE); + ASSERT_TRUE(CheckGeneralError() || + radioRsp->rspInfo.error == RadioError::NONE || + radioRsp->rspInfo.error == RadioError::MODEM_ERR); } } @@ -462,7 +475,9 @@ TEST_F(RadioHidlTest, getCellInfoList) { EXPECT_EQ(serial, radioRsp->rspInfo.serial); if (cardStatus.cardState == CardState::ABSENT) { - ASSERT_TRUE(radioRsp->rspInfo.error == RadioError::NONE); + ASSERT_TRUE(CheckGeneralError() || + radioRsp->rspInfo.error == RadioError::NONE || + radioRsp->rspInfo.error == RadioError::NO_NETWORK_FOUND); } } @@ -565,7 +580,12 @@ TEST_F(RadioHidlTest, setUiccSubscription) { EXPECT_EQ(serial, radioRsp->rspInfo.serial); if (cardStatus.cardState == CardState::ABSENT) { - ASSERT_TRUE(radioRsp->rspInfo.error == RadioError::NONE); + ASSERT_TRUE(CheckGeneralError() || + radioRsp->rspInfo.error == RadioError::INVALID_ARGUMENTS || + radioRsp->rspInfo.error == RadioError::NONE || + radioRsp->rspInfo.error == + RadioError::SUBSCRIPTION_NOT_SUPPORTED || + radioRsp->rspInfo.error == RadioError::MODEM_ERR); } } @@ -597,7 +617,8 @@ TEST_F(RadioHidlTest, requestShutdown) { EXPECT_EQ(serial, radioRsp->rspInfo.serial); if (cardStatus.cardState == CardState::ABSENT) { - ASSERT_TRUE(radioRsp->rspInfo.error == RadioError::NONE); + ASSERT_TRUE(CheckGeneralError() || + radioRsp->rspInfo.error == RadioError::NONE); } } @@ -632,7 +653,9 @@ TEST_F(RadioHidlTest, setRadioCapability) { EXPECT_EQ(serial, radioRsp->rspInfo.serial); if (cardStatus.cardState == CardState::ABSENT) { - ASSERT_TRUE(radioRsp->rspInfo.error == RadioError::NONE); + ASSERT_TRUE(CheckGeneralError() || + radioRsp->rspInfo.error == RadioError::INVALID_ARGUMENTS || + radioRsp->rspInfo.error == RadioError::INVALID_STATE); } } @@ -648,8 +671,9 @@ TEST_F(RadioHidlTest, startLceService) { EXPECT_EQ(serial, radioRsp->rspInfo.serial); if (cardStatus.cardState == CardState::ABSENT) { - ASSERT_TRUE(radioRsp->rspInfo.error == RadioError::NONE || - radioRsp->rspInfo.error == RadioError::LCE_NOT_SUPPORTED); + ASSERT_TRUE(radioRsp->rspInfo.error == RadioError::RADIO_NOT_AVAILABLE || + radioRsp->rspInfo.error == RadioError::LCE_NOT_SUPPORTED || + radioRsp->rspInfo.error == RadioError::INTERNAL_ERR); } } @@ -682,8 +706,8 @@ TEST_F(RadioHidlTest, pullLceData) { EXPECT_EQ(serial, radioRsp->rspInfo.serial); if (cardStatus.cardState == CardState::ABSENT) { - ASSERT_TRUE(radioRsp->rspInfo.error == RadioError::NONE || - radioRsp->rspInfo.error == RadioError::LCE_NOT_SUPPORTED); + ASSERT_TRUE(radioRsp->rspInfo.error == RadioError::RADIO_NOT_AVAILABLE || + CheckOEMError()); } } @@ -755,7 +779,8 @@ TEST_F(RadioHidlTest, sendDeviceState) { EXPECT_EQ(serial, radioRsp->rspInfo.serial); if (cardStatus.cardState == CardState::ABSENT) { - ASSERT_TRUE(radioRsp->rspInfo.error == RadioError::NONE); + ASSERT_TRUE(CheckGeneralError() || + radioRsp->rspInfo.error == RadioError::INVALID_ARGUMENTS); } } @@ -771,7 +796,8 @@ TEST_F(RadioHidlTest, setIndicationFilter) { EXPECT_EQ(serial, radioRsp->rspInfo.serial); if (cardStatus.cardState == CardState::ABSENT) { - ASSERT_TRUE(radioRsp->rspInfo.error == RadioError::NONE); + ASSERT_TRUE(CheckGeneralError() || + radioRsp->rspInfo.error == RadioError::INVALID_ARGUMENTS); } } diff --git a/radio/1.0/vts/functional/radio_hidl_hal_sms.cpp b/radio/1.0/vts/functional/radio_hidl_hal_sms.cpp index 7caf4712d7..b8a50c0c70 100644 --- a/radio/1.0/vts/functional/radio_hidl_hal_sms.cpp +++ b/radio/1.0/vts/functional/radio_hidl_hal_sms.cpp @@ -34,11 +34,10 @@ TEST_F(RadioHidlTest, sendSms) { EXPECT_EQ(serial, radioRsp->rspInfo.serial); if (cardStatus.cardState == CardState::ABSENT) { - ASSERT_TRUE(radioRsp->rspInfo.error == RadioError::INVALID_ARGUMENTS || - radioRsp->rspInfo.error == RadioError::MODEM_ERR || - radioRsp->rspInfo.error == RadioError::SYSTEM_ERR || - radioRsp->rspInfo.error == RadioError::INVALID_STATE); - EXPECT_EQ(0, radioRsp->sendSmsResult.errorCode); + ASSERT_TRUE(CheckGeneralError() || + radioRsp->rspInfo.error == RadioError::INVALID_ARGUMENTS || + radioRsp->rspInfo.error == RadioError::INVALID_STATE); + EXPECT_EQ(0, radioRsp->sendSmsResult.errorCode); } } @@ -61,10 +60,9 @@ TEST_F(RadioHidlTest, sendSMSExpectMore) { EXPECT_EQ(serial, radioRsp->rspInfo.serial); if (cardStatus.cardState == CardState::ABSENT) { - ASSERT_TRUE(radioRsp->rspInfo.error == RadioError::INVALID_ARGUMENTS || - radioRsp->rspInfo.error == RadioError::MODEM_ERR || - radioRsp->rspInfo.error == RadioError::SYSTEM_ERR || - radioRsp->rspInfo.error == RadioError::INVALID_STATE); + ASSERT_TRUE(CheckGeneralError() || + radioRsp->rspInfo.error == RadioError::INVALID_ARGUMENTS || + radioRsp->rspInfo.error == RadioError::INVALID_STATE); } } @@ -83,7 +81,9 @@ TEST_F(RadioHidlTest, acknowledgeLastIncomingGsmSms) { EXPECT_EQ(serial, radioRsp->rspInfo.serial); if (cardStatus.cardState == CardState::ABSENT) { - EXPECT_EQ(RadioError::INVALID_ARGUMENTS, radioRsp->rspInfo.error); + ASSERT_TRUE(CheckGeneralError() || + radioRsp->rspInfo.error == RadioError::INVALID_ARGUMENTS || + radioRsp->rspInfo.error == RadioError::INVALID_STATE); } } @@ -144,10 +144,9 @@ TEST_F(RadioHidlTest, sendCdmaSms) { EXPECT_EQ(serial, radioRsp->rspInfo.serial); if (cardStatus.cardState == CardState::ABSENT) { - ASSERT_TRUE(radioRsp->rspInfo.error == RadioError::INVALID_ARGUMENTS || - radioRsp->rspInfo.error == RadioError::MODEM_ERR || - radioRsp->rspInfo.error == RadioError::SYSTEM_ERR || - radioRsp->rspInfo.error == RadioError::INVALID_STATE); + ASSERT_TRUE(CheckGeneralError() || + radioRsp->rspInfo.error == RadioError::INVALID_ARGUMENTS || + radioRsp->rspInfo.error == RadioError::INVALID_STATE); } } @@ -169,7 +168,9 @@ TEST_F(RadioHidlTest, acknowledgeLastIncomingCdmaSms) { EXPECT_EQ(serial, radioRsp->rspInfo.serial); if (cardStatus.cardState == CardState::ABSENT) { - EXPECT_EQ(RadioError::NO_SMS_TO_ACK, radioRsp->rspInfo.error); + ASSERT_TRUE(CheckGeneralError() || + radioRsp->rspInfo.error == RadioError::INVALID_ARGUMENTS || + radioRsp->rspInfo.error == RadioError::NO_SMS_TO_ACK); } } @@ -219,7 +220,8 @@ TEST_F(RadioHidlTest, sendImsSms) { EXPECT_EQ(serial, radioRsp->rspInfo.serial); if (cardStatus.cardState == CardState::ABSENT) { - EXPECT_EQ(RadioError::INVALID_ARGUMENTS, radioRsp->rspInfo.error); + ASSERT_TRUE(CheckGeneralError() || + radioRsp->rspInfo.error == RadioError::INVALID_ARGUMENTS); } } @@ -236,11 +238,9 @@ TEST_F(RadioHidlTest, getSmscAddress) { EXPECT_EQ(serial, radioRsp->rspInfo.serial); if (cardStatus.cardState == CardState::ABSENT) { - ASSERT_TRUE(radioRsp->rspInfo.error == RadioError::INVALID_ARGUMENTS || - radioRsp->rspInfo.error == RadioError::MODEM_ERR || - radioRsp->rspInfo.error == RadioError::SYSTEM_ERR || - radioRsp->rspInfo.error == RadioError::INVALID_STATE || - radioRsp->rspInfo.error == RadioError::INVALID_MODEM_STATE); + ASSERT_TRUE(CheckGeneralError() || + radioRsp->rspInfo.error == RadioError::INVALID_STATE || + radioRsp->rspInfo.error == RadioError::INVALID_MODEM_STATE); } } @@ -258,7 +258,9 @@ TEST_F(RadioHidlTest, setSmscAddress) { EXPECT_EQ(serial, radioRsp->rspInfo.serial); if (cardStatus.cardState == CardState::ABSENT) { - EXPECT_EQ(RadioError::INVALID_SMS_FORMAT, radioRsp->rspInfo.error); + ASSERT_TRUE(CheckGeneralError() || + radioRsp->rspInfo.error == RadioError::INVALID_ARGUMENTS || + radioRsp->rspInfo.error == RadioError::INVALID_SMS_FORMAT); } } @@ -279,10 +281,14 @@ TEST_F(RadioHidlTest, writeSmsToSim) { EXPECT_EQ(serial, radioRsp->rspInfo.serial); if (cardStatus.cardState == CardState::ABSENT) { - ASSERT_TRUE(radioRsp->rspInfo.error == RadioError::INVALID_ARGUMENTS || - radioRsp->rspInfo.error == RadioError::MODEM_ERR || - radioRsp->rspInfo.error == RadioError::INVALID_MODEM_STATE || - radioRsp->rspInfo.error == RadioError::INTERNAL_ERR); + ASSERT_TRUE(CheckGeneralError() || + radioRsp->rspInfo.error == RadioError::INVALID_ARGUMENTS || + radioRsp->rspInfo.error == RadioError::NONE || + radioRsp->rspInfo.error == RadioError::MODEM_ERR || + radioRsp->rspInfo.error == RadioError::ENCODING_ERR || + radioRsp->rspInfo.error == RadioError::NO_RESOURCES || + radioRsp->rspInfo.error == RadioError::NETWORK_NOT_READY || + radioRsp->rspInfo.error == RadioError::INVALID_SMSC_ADDRESS); } } @@ -300,10 +306,11 @@ TEST_F(RadioHidlTest, deleteSmsOnSim) { EXPECT_EQ(serial, radioRsp->rspInfo.serial); if (cardStatus.cardState == CardState::ABSENT) { - EXPECT_EQ(RadioError::INVALID_SMS_FORMAT, radioRsp->rspInfo.error); - ASSERT_TRUE(radioRsp->rspInfo.error == RadioError::INVALID_ARGUMENTS || - radioRsp->rspInfo.error == RadioError::MODEM_ERR || - radioRsp->rspInfo.error == RadioError::SYSTEM_ERR); + ASSERT_TRUE(CheckGeneralError() || + radioRsp->rspInfo.error == RadioError::INVALID_ARGUMENTS || + radioRsp->rspInfo.error == RadioError::NONE || + radioRsp->rspInfo.error == RadioError::MODEM_ERR || + radioRsp->rspInfo.error == RadioError::NO_SUCH_ENTRY); } } @@ -350,10 +357,14 @@ TEST_F(RadioHidlTest, writeSmsToRuim) { EXPECT_EQ(serial, radioRsp->rspInfo.serial); if (cardStatus.cardState == CardState::ABSENT) { - ASSERT_TRUE(radioRsp->rspInfo.error == RadioError::INVALID_ARGUMENTS || - radioRsp->rspInfo.error == RadioError::MODEM_ERR || - radioRsp->rspInfo.error == RadioError::INVALID_MODEM_STATE || - radioRsp->rspInfo.error == RadioError::INTERNAL_ERR); + ASSERT_TRUE(CheckGeneralError() || + radioRsp->rspInfo.error == RadioError::INVALID_ARGUMENTS || + radioRsp->rspInfo.error == RadioError::INVALID_STATE || + radioRsp->rspInfo.error == RadioError::INVALID_SMS_FORMAT || + radioRsp->rspInfo.error == RadioError::NONE || + radioRsp->rspInfo.error == RadioError::MODEM_ERR || + radioRsp->rspInfo.error == RadioError::NO_SUCH_ENTRY || + radioRsp->rspInfo.error == RadioError::INVALID_SMSC_ADDRESS); } } @@ -401,9 +412,7 @@ TEST_F(RadioHidlTest, deleteSmsOnRuim) { EXPECT_EQ(serial, radioRsp->rspInfo.serial); if (cardStatus.cardState == CardState::ABSENT) { - ASSERT_TRUE(radioRsp->rspInfo.error == RadioError::INVALID_ARGUMENTS || - radioRsp->rspInfo.error == RadioError::MODEM_ERR || - radioRsp->rspInfo.error == RadioError::SYSTEM_ERR); + ASSERT_TRUE(CheckGeneralError()); } } @@ -421,9 +430,9 @@ TEST_F(RadioHidlTest, reportSmsMemoryStatus) { EXPECT_EQ(serial, radioRsp->rspInfo.serial); if (cardStatus.cardState == CardState::ABSENT) { - ASSERT_TRUE(radioRsp->rspInfo.error == RadioError::INVALID_ARGUMENTS || - radioRsp->rspInfo.error == RadioError::MODEM_ERR || - radioRsp->rspInfo.error == RadioError::SYSTEM_ERR || - radioRsp->rspInfo.error == RadioError::INVALID_STATE); + ASSERT_TRUE(CheckGeneralError() || + radioRsp->rspInfo.error == RadioError::INVALID_ARGUMENTS || + radioRsp->rspInfo.error == RadioError::INVALID_STATE || + radioRsp->rspInfo.error == RadioError::MODEM_ERR); } } diff --git a/radio/1.0/vts/functional/radio_hidl_hal_test.cpp b/radio/1.0/vts/functional/radio_hidl_hal_test.cpp index d40f15aadb..794c60f2f8 100644 --- a/radio/1.0/vts/functional/radio_hidl_hal_test.cpp +++ b/radio/1.0/vts/functional/radio_hidl_hal_test.cpp @@ -58,3 +58,16 @@ std::cv_status RadioHidlTest::wait() { count--; return status; } + +bool RadioHidlTest::CheckGeneralError() { + return (radioRsp->rspInfo.error == RadioError::RADIO_NOT_AVAILABLE || + radioRsp->rspInfo.error == RadioError::NO_MEMORY || + radioRsp->rspInfo.error == RadioError::INTERNAL_ERR || + radioRsp->rspInfo.error == RadioError::SYSTEM_ERR || + radioRsp->rspInfo.error == RadioError::REQUEST_NOT_SUPPORTED); +} + +bool RadioHidlTest::CheckOEMError() { + return (radioRsp->rspInfo.error >= RadioError::OEM_ERROR_1 && + radioRsp->rspInfo.error <= RadioError::OEM_ERROR_25); +} \ No newline at end of file diff --git a/radio/1.0/vts/functional/radio_hidl_hal_utils.h b/radio/1.0/vts/functional/radio_hidl_hal_utils.h index 51db87b08f..735e5759cc 100644 --- a/radio/1.0/vts/functional/radio_hidl_hal_utils.h +++ b/radio/1.0/vts/functional/radio_hidl_hal_utils.h @@ -500,6 +500,12 @@ class RadioHidlTest : public ::testing::VtsHalHidlTargetTestBase { /* Test code calls this function to wait for response */ std::cv_status wait(); + /* Used for checking General Errors */ + bool CheckGeneralError(); + + /* Used for checking OEM Errors */ + bool CheckOEMError(); + sp radio; sp radioRsp; sp radioInd; @@ -510,4 +516,4 @@ class RadioHidlEnvironment : public ::testing::Environment { public: virtual void SetUp() {} virtual void TearDown() {} -}; +}; \ No newline at end of file diff --git a/radio/1.0/vts/functional/radio_hidl_hal_voice.cpp b/radio/1.0/vts/functional/radio_hidl_hal_voice.cpp index ef10d101c3..b96269a3a3 100644 --- a/radio/1.0/vts/functional/radio_hidl_hal_voice.cpp +++ b/radio/1.0/vts/functional/radio_hidl_hal_voice.cpp @@ -48,10 +48,18 @@ TEST_F(RadioHidlTest, dial) { EXPECT_EQ(serial, radioRsp->rspInfo.serial); if (cardStatus.cardState == CardState::ABSENT) { - ASSERT_TRUE(radioRsp->rspInfo.error == RadioError::INVALID_ARGUMENTS || - radioRsp->rspInfo.error == RadioError::INVALID_STATE || - radioRsp->rspInfo.error == RadioError::MODEM_ERR || - radioRsp->rspInfo.error == RadioError::INTERNAL_ERR); + ASSERT_TRUE(CheckGeneralError() || + radioRsp->rspInfo.error == RadioError::INVALID_ARGUMENTS || + radioRsp->rspInfo.error == RadioError::INVALID_STATE || + radioRsp->rspInfo.error == RadioError::MODEM_ERR || + radioRsp->rspInfo.error == RadioError::FDN_CHECK_FAILURE || + radioRsp->rspInfo.error == RadioError::NO_SUBSCRIPTION || + radioRsp->rspInfo.error == RadioError::NO_NETWORK_FOUND || + radioRsp->rspInfo.error == RadioError::INVALID_CALL_ID || + radioRsp->rspInfo.error == RadioError::DEVICE_IN_USE || + radioRsp->rspInfo.error == RadioError::MODE_NOT_SUPPORTED || + radioRsp->rspInfo.error == RadioError::INVALID_MODEM_STATE || + radioRsp->rspInfo.error == RadioError::CANCELLED); } } @@ -67,10 +75,10 @@ TEST_F(RadioHidlTest, hangup) { EXPECT_EQ(serial, radioRsp->rspInfo.serial); if (cardStatus.cardState == CardState::ABSENT) { - ASSERT_TRUE(radioRsp->rspInfo.error == RadioError::INVALID_ARGUMENTS || - radioRsp->rspInfo.error == RadioError::INVALID_STATE || - radioRsp->rspInfo.error == RadioError::MODEM_ERR || - radioRsp->rspInfo.error == RadioError::INTERNAL_ERR); + ASSERT_TRUE(CheckGeneralError() || + radioRsp->rspInfo.error == RadioError::INVALID_ARGUMENTS || + radioRsp->rspInfo.error == RadioError::INVALID_STATE || + radioRsp->rspInfo.error == RadioError::MODEM_ERR); } } @@ -86,9 +94,9 @@ TEST_F(RadioHidlTest, hangupWaitingOrBackground) { EXPECT_EQ(serial, radioRsp->rspInfo.serial); if (cardStatus.cardState == CardState::ABSENT) { - ASSERT_TRUE(radioRsp->rspInfo.error == RadioError::INVALID_STATE || - radioRsp->rspInfo.error == RadioError::MODEM_ERR || - radioRsp->rspInfo.error == RadioError::INTERNAL_ERR); + ASSERT_TRUE(CheckGeneralError() || + radioRsp->rspInfo.error == RadioError::INVALID_STATE || + radioRsp->rspInfo.error == RadioError::MODEM_ERR); } } @@ -104,9 +112,9 @@ TEST_F(RadioHidlTest, hangupForegroundResumeBackground) { EXPECT_EQ(serial, radioRsp->rspInfo.serial); if (cardStatus.cardState == CardState::ABSENT) { - ASSERT_TRUE(radioRsp->rspInfo.error == RadioError::INVALID_STATE || - radioRsp->rspInfo.error == RadioError::MODEM_ERR || - radioRsp->rspInfo.error == RadioError::INTERNAL_ERR); + ASSERT_TRUE(CheckGeneralError() || + radioRsp->rspInfo.error == RadioError::INVALID_STATE || + radioRsp->rspInfo.error == RadioError::MODEM_ERR); } } @@ -122,9 +130,9 @@ TEST_F(RadioHidlTest, switchWaitingOrHoldingAndActive) { EXPECT_EQ(serial, radioRsp->rspInfo.serial); if (cardStatus.cardState == CardState::ABSENT) { - ASSERT_TRUE(radioRsp->rspInfo.error == RadioError::INVALID_STATE || - radioRsp->rspInfo.error == RadioError::MODEM_ERR || - radioRsp->rspInfo.error == RadioError::INTERNAL_ERR); + ASSERT_TRUE(CheckGeneralError() || + radioRsp->rspInfo.error == RadioError::INVALID_STATE || + radioRsp->rspInfo.error == RadioError::MODEM_ERR); } } @@ -140,9 +148,9 @@ TEST_F(RadioHidlTest, conference) { EXPECT_EQ(serial, radioRsp->rspInfo.serial); if (cardStatus.cardState == CardState::ABSENT) { - ASSERT_TRUE(radioRsp->rspInfo.error == RadioError::INVALID_STATE || - radioRsp->rspInfo.error == RadioError::MODEM_ERR || - radioRsp->rspInfo.error == RadioError::INTERNAL_ERR); + ASSERT_TRUE(CheckGeneralError() || + radioRsp->rspInfo.error == RadioError::INVALID_STATE || + radioRsp->rspInfo.error == RadioError::MODEM_ERR); } } @@ -158,9 +166,9 @@ TEST_F(RadioHidlTest, rejectCall) { EXPECT_EQ(serial, radioRsp->rspInfo.serial); if (cardStatus.cardState == CardState::ABSENT) { - ASSERT_TRUE(radioRsp->rspInfo.error == RadioError::INVALID_STATE || - radioRsp->rspInfo.error == RadioError::MODEM_ERR || - radioRsp->rspInfo.error == RadioError::INTERNAL_ERR); + ASSERT_TRUE(CheckGeneralError() || + radioRsp->rspInfo.error == RadioError::INVALID_STATE || + radioRsp->rspInfo.error == RadioError::MODEM_ERR); } } @@ -176,7 +184,8 @@ TEST_F(RadioHidlTest, getLastCallFailCause) { EXPECT_EQ(serial, radioRsp->rspInfo.serial); if (cardStatus.cardState == CardState::ABSENT) { - ASSERT_TRUE(radioRsp->rspInfo.error == RadioError::NONE); + ASSERT_TRUE(CheckGeneralError() || + radioRsp->rspInfo.error == RadioError::NONE); } } @@ -191,11 +200,10 @@ TEST_F(RadioHidlTest, sendUssd) { EXPECT_EQ(serial, radioRsp->rspInfo.serial); if (cardStatus.cardState == CardState::ABSENT) { - ASSERT_TRUE(radioRsp->rspInfo.error == RadioError::INVALID_ARGUMENTS || - radioRsp->rspInfo.error == RadioError::INVALID_STATE || - radioRsp->rspInfo.error == RadioError::MODEM_ERR || - radioRsp->rspInfo.error == RadioError::SYSTEM_ERR || - radioRsp->rspInfo.error == RadioError::INTERNAL_ERR); + ASSERT_TRUE(CheckGeneralError() || + radioRsp->rspInfo.error == RadioError::INVALID_ARGUMENTS || + radioRsp->rspInfo.error == RadioError::INVALID_STATE || + radioRsp->rspInfo.error == RadioError::MODEM_ERR); } } @@ -211,9 +219,9 @@ TEST_F(RadioHidlTest, cancelPendingUssd) { EXPECT_EQ(serial, radioRsp->rspInfo.serial); if (cardStatus.cardState == CardState::ABSENT) { - ASSERT_TRUE(radioRsp->rspInfo.error == RadioError::INVALID_STATE || - radioRsp->rspInfo.error == RadioError::MODEM_ERR || - radioRsp->rspInfo.error == RadioError::INTERNAL_ERR); + ASSERT_TRUE(CheckGeneralError() || + radioRsp->rspInfo.error == RadioError::INVALID_STATE || + radioRsp->rspInfo.error == RadioError::MODEM_ERR); } } @@ -232,10 +240,10 @@ TEST_F(RadioHidlTest, getCallForwardStatus) { EXPECT_EQ(serial, radioRsp->rspInfo.serial); if (cardStatus.cardState == CardState::ABSENT) { - ASSERT_TRUE(radioRsp->rspInfo.error == RadioError::INVALID_ARGUMENTS || - radioRsp->rspInfo.error == RadioError::INVALID_STATE || - radioRsp->rspInfo.error == RadioError::MODEM_ERR || - radioRsp->rspInfo.error == RadioError::INTERNAL_ERR); + ASSERT_TRUE(CheckGeneralError() || + radioRsp->rspInfo.error == RadioError::INVALID_ARGUMENTS || + radioRsp->rspInfo.error == RadioError::INVALID_STATE || + radioRsp->rspInfo.error == RadioError::MODEM_ERR); } } @@ -254,10 +262,10 @@ TEST_F(RadioHidlTest, setCallForward) { EXPECT_EQ(serial, radioRsp->rspInfo.serial); if (cardStatus.cardState == CardState::ABSENT) { - ASSERT_TRUE(radioRsp->rspInfo.error == RadioError::INVALID_ARGUMENTS || - radioRsp->rspInfo.error == RadioError::INVALID_STATE || - radioRsp->rspInfo.error == RadioError::MODEM_ERR || - radioRsp->rspInfo.error == RadioError::INTERNAL_ERR); + ASSERT_TRUE(CheckGeneralError() || + radioRsp->rspInfo.error == RadioError::INVALID_ARGUMENTS || + radioRsp->rspInfo.error == RadioError::INVALID_STATE || + radioRsp->rspInfo.error == RadioError::MODEM_ERR); } } @@ -273,10 +281,10 @@ TEST_F(RadioHidlTest, getCallWaiting) { EXPECT_EQ(serial, radioRsp->rspInfo.serial); if (cardStatus.cardState == CardState::ABSENT) { - ASSERT_TRUE(radioRsp->rspInfo.error == RadioError::INVALID_ARGUMENTS || - radioRsp->rspInfo.error == RadioError::NONE || - radioRsp->rspInfo.error == RadioError::MODEM_ERR || - radioRsp->rspInfo.error == RadioError::INTERNAL_ERR); + ASSERT_TRUE(CheckGeneralError() || + radioRsp->rspInfo.error == RadioError::INVALID_ARGUMENTS || + radioRsp->rspInfo.error == RadioError::NONE || + radioRsp->rspInfo.error == RadioError::MODEM_ERR); } } @@ -292,10 +300,10 @@ TEST_F(RadioHidlTest, setCallWaiting) { EXPECT_EQ(serial, radioRsp->rspInfo.serial); if (cardStatus.cardState == CardState::ABSENT) { - ASSERT_TRUE(radioRsp->rspInfo.error == RadioError::INVALID_ARGUMENTS || - radioRsp->rspInfo.error == RadioError::INVALID_STATE || - radioRsp->rspInfo.error == RadioError::MODEM_ERR || - radioRsp->rspInfo.error == RadioError::INTERNAL_ERR); + ASSERT_TRUE(CheckGeneralError() || + radioRsp->rspInfo.error == RadioError::INVALID_ARGUMENTS || + radioRsp->rspInfo.error == RadioError::INVALID_STATE || + radioRsp->rspInfo.error == RadioError::MODEM_ERR); } } @@ -311,9 +319,9 @@ TEST_F(RadioHidlTest, acceptCall) { EXPECT_EQ(serial, radioRsp->rspInfo.serial); if (cardStatus.cardState == CardState::ABSENT) { - ASSERT_TRUE(radioRsp->rspInfo.error == RadioError::INVALID_STATE || - radioRsp->rspInfo.error == RadioError::MODEM_ERR || - radioRsp->rspInfo.error == RadioError::INTERNAL_ERR); + ASSERT_TRUE(CheckGeneralError() || + radioRsp->rspInfo.error == RadioError::INVALID_STATE || + radioRsp->rspInfo.error == RadioError::MODEM_ERR); } } @@ -329,11 +337,10 @@ TEST_F(RadioHidlTest, separateConnection) { EXPECT_EQ(serial, radioRsp->rspInfo.serial); if (cardStatus.cardState == CardState::ABSENT) { - ASSERT_TRUE(radioRsp->rspInfo.error == RadioError::INVALID_ARGUMENTS || - radioRsp->rspInfo.error == RadioError::INVALID_STATE || - radioRsp->rspInfo.error == RadioError::SYSTEM_ERR || - radioRsp->rspInfo.error == RadioError::MODEM_ERR || - radioRsp->rspInfo.error == RadioError::INTERNAL_ERR); + ASSERT_TRUE(CheckGeneralError() || + radioRsp->rspInfo.error == RadioError::INVALID_ARGUMENTS || + radioRsp->rspInfo.error == RadioError::INVALID_STATE || + radioRsp->rspInfo.error == RadioError::MODEM_ERR); } } @@ -349,9 +356,9 @@ TEST_F(RadioHidlTest, explicitCallTransfer) { EXPECT_EQ(serial, radioRsp->rspInfo.serial); if (cardStatus.cardState == CardState::ABSENT) { - ASSERT_TRUE(radioRsp->rspInfo.error == RadioError::INVALID_STATE || - radioRsp->rspInfo.error == RadioError::MODEM_ERR || - radioRsp->rspInfo.error == RadioError::INTERNAL_ERR); + ASSERT_TRUE(CheckGeneralError() || + radioRsp->rspInfo.error == RadioError::INVALID_STATE || + radioRsp->rspInfo.error == RadioError::MODEM_ERR); } } @@ -367,11 +374,12 @@ TEST_F(RadioHidlTest, sendCDMAFeatureCode) { EXPECT_EQ(serial, radioRsp->rspInfo.serial); if (cardStatus.cardState == CardState::ABSENT) { - ASSERT_TRUE(radioRsp->rspInfo.error == RadioError::INVALID_ARGUMENTS || - radioRsp->rspInfo.error == RadioError::INVALID_STATE || - radioRsp->rspInfo.error == RadioError::MODEM_ERR || - radioRsp->rspInfo.error == RadioError::INTERNAL_ERR || - radioRsp->rspInfo.error == RadioError::SYSTEM_ERR); + ASSERT_TRUE(CheckGeneralError() || + radioRsp->rspInfo.error == RadioError::INVALID_ARGUMENTS || + radioRsp->rspInfo.error == RadioError::NONE || + radioRsp->rspInfo.error == RadioError::INVALID_CALL_ID || + radioRsp->rspInfo.error == RadioError::INVALID_MODEM_STATE || + radioRsp->rspInfo.error == RadioError::MODEM_ERR); } } @@ -387,9 +395,11 @@ TEST_F(RadioHidlTest, sendDtmf) { EXPECT_EQ(serial, radioRsp->rspInfo.serial); if (cardStatus.cardState == CardState::ABSENT) { - ASSERT_TRUE(radioRsp->rspInfo.error == RadioError::INVALID_ARGUMENTS || - radioRsp->rspInfo.error == RadioError::NO_RESOURCES || - radioRsp->rspInfo.error == RadioError::MODEM_ERR); + ASSERT_TRUE(CheckGeneralError() || + radioRsp->rspInfo.error == RadioError::INVALID_ARGUMENTS || + radioRsp->rspInfo.error == RadioError::NONE || + radioRsp->rspInfo.error == RadioError::INVALID_CALL_ID || + radioRsp->rspInfo.error == RadioError::MODEM_ERR); } } @@ -405,10 +415,11 @@ TEST_F(RadioHidlTest, startDtmf) { EXPECT_EQ(serial, radioRsp->rspInfo.serial); if (cardStatus.cardState == CardState::ABSENT) { - ASSERT_TRUE(radioRsp->rspInfo.error == RadioError::INVALID_ARGUMENTS || - radioRsp->rspInfo.error == RadioError::SYSTEM_ERR || - radioRsp->rspInfo.error == RadioError::MODEM_ERR || - radioRsp->rspInfo.error == RadioError::INTERNAL_ERR); + ASSERT_TRUE(CheckGeneralError() || + radioRsp->rspInfo.error == RadioError::INVALID_ARGUMENTS || + radioRsp->rspInfo.error == RadioError::NONE || + radioRsp->rspInfo.error == RadioError::INVALID_CALL_ID || + radioRsp->rspInfo.error == RadioError::MODEM_ERR); } } @@ -424,9 +435,10 @@ TEST_F(RadioHidlTest, stopDtmf) { EXPECT_EQ(serial, radioRsp->rspInfo.serial); if (cardStatus.cardState == CardState::ABSENT) { - ASSERT_TRUE(radioRsp->rspInfo.error == RadioError::SYSTEM_ERR || - radioRsp->rspInfo.error == RadioError::MODEM_ERR || - radioRsp->rspInfo.error == RadioError::INTERNAL_ERR); + ASSERT_TRUE(CheckGeneralError() || + radioRsp->rspInfo.error == RadioError::NONE || + radioRsp->rspInfo.error == RadioError::INVALID_CALL_ID || + radioRsp->rspInfo.error == RadioError::MODEM_ERR); } } @@ -442,8 +454,9 @@ TEST_F(RadioHidlTest, setMute) { EXPECT_EQ(serial, radioRsp->rspInfo.serial); if (cardStatus.cardState == CardState::ABSENT) { - ASSERT_TRUE(radioRsp->rspInfo.error == RadioError::INVALID_ARGUMENTS || - radioRsp->rspInfo.error == RadioError::NONE); + ASSERT_TRUE(CheckGeneralError() || + radioRsp->rspInfo.error == RadioError::INVALID_ARGUMENTS || + radioRsp->rspInfo.error == RadioError::NONE); } } @@ -475,10 +488,9 @@ TEST_F(RadioHidlTest, sendBurstDtmf) { EXPECT_EQ(serial, radioRsp->rspInfo.serial); if (cardStatus.cardState == CardState::ABSENT) { - ASSERT_TRUE(radioRsp->rspInfo.error == RadioError::INVALID_ARGUMENTS || - radioRsp->rspInfo.error == RadioError::SYSTEM_ERR || - radioRsp->rspInfo.error == RadioError::MODEM_ERR || - radioRsp->rspInfo.error == RadioError::INTERNAL_ERR || - radioRsp->rspInfo.error == RadioError::INVALID_STATE); + ASSERT_TRUE(CheckGeneralError() || + radioRsp->rspInfo.error == RadioError::INVALID_ARGUMENTS || + radioRsp->rspInfo.error == RadioError::INVALID_STATE || + radioRsp->rspInfo.error == RadioError::MODEM_ERR); } } \ No newline at end of file