tequilaOS/platform_hardware_interfaces
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

audio VTS: Use the right device type in PcmOnlyConfigInputStreamTest

Browse source 
The fix in https://r.android.com/2322475 modifies the device
address, which becomes 'IN_DEFAULT' for the telephony case.
As a result, tests that verify capture position were not
skipped, and they do fail on certain platforms when there is
no active telephone call. The fix is to use the initial device
type which was passed to the test as a parameter, not the adjusted
one.

Bug: 263305254
Test: atest VtsHalAudioV7_0TargetTest
Test: atest VtsHalAudioV7_1TargetTest
Change-Id: Ied7134a1bd97e70dcc2400e0827810f9d71a6438
This commit is contained in:
Mikhail Naganov 2022-12-21 23:14:37 +00:00
parent 4c4ebb3208
commit 7029707e34
1 changed files with 6 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
audio/core/all-versions/vts/functional/7.0/AudioPrimaryHidlHalTest.cpp
View file

@ -687,7 +687,12 @@ class PcmOnlyConfigInputStreamTest : public InputStreamTest {
InputStreamTest::TearDown();
}
bool canQueryCapturePosition() const { return !xsd::isTelephonyDevice(address.deviceType); }
bool canQueryCapturePosition() const {
// See b/263305254 and b/259636577. Must use the device initially passed in
// as a parameter, not 'address' which gets adjusted during test setup for
// the telephony case.
return !xsd::isTelephonyDevice(getAttachedDeviceAddress().deviceType);
}
void createPatchIfNeeded() {
if (areAudioPatchesSupported()) {