tequilaOS/platform_hardware_interfaces
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

Merge "ExternalCameraHAL: Check for empty native handle instead of null." into main

Browse source
This commit is contained in:
Treehugger Robot 2023-11-03 01:10:16 +00:00 committed by Gerrit Code Review
commit 7e4037cf01
1 changed files with 5 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
camera/device/default/ExternalCameraUtils.cpp
View file

@ -402,7 +402,10 @@ aidl::android::hardware::camera::common::Status importBufferImpl(
buffer_handle_t buf,
/*out*/ buffer_handle_t** outBufPtr) {
using ::aidl::android::hardware::camera::common::Status;
if (buf == nullptr && bufId == BUFFER_ID_NO_BUFFER) {
// AIDL does not have null NativeHandles. It sends empty handles instead.
// We check for when the buf is empty instead of when buf is null.
bool isBufEmpty = buf == nullptr || (buf->numFds == 0 && buf->numInts == 0);
if (isBufEmpty && bufId == BUFFER_ID_NO_BUFFER) {
ALOGE("%s: bufferId %" PRIu64 " has null buffer handle!", __FUNCTION__, bufId);
return Status::ILLEGAL_ARGUMENT;
}