Camera: Don't hold 'mLock' when closing the camera session
After flushing the camera requests don't try to close the camera session while still holding 'mLock'. Different Hals could still try and return additional results which then will get blocked on 'mLock'. Closing the session could potentially introduce a deadlock if the Hal implementation waits for any of the result calls to return. Bug: 111836165 Test: vts-tradefed run commandAndExit vts --skip-all-system-status-check --skip-preconditions --module VtsHalCameraProviderV2_4Target -l INFO Change-Id: I0f309f435cc76db3f9b6ba500da65a232b014717
This commit is contained in:
parent
5e3ee74b95
commit
8e92056837
1 changed files with 3 additions and 3 deletions
|
@ -4046,12 +4046,12 @@ TEST_F(CameraHidlTest, flushPreviewRequest) {
|
|||
<< static_cast<uint32_t>(inflightReq.errorCode);
|
||||
}
|
||||
}
|
||||
}
|
||||
|
||||
ret = session->close();
|
||||
ASSERT_TRUE(ret.isOk());
|
||||
}
|
||||
}
|
||||
}
|
||||
|
||||
// Verify that camera flushes correctly without any pending requests.
|
||||
TEST_F(CameraHidlTest, flushEmpty) {
|
||||
|
|
Loading…
Reference in a new issue