From a23aa3ba711b2d33b6ad49e2a98ae47855d0070a Mon Sep 17 00:00:00 2001 From: Yu-Han Yang Date: Tue, 2 Feb 2021 10:13:52 -0800 Subject: [PATCH] Update HAL comment of AGC Bug: 179157665 Test: doc update only Change-Id: I9395a68d3154e8b4e47fd2fb6b0d8f5f33e48805 --- current.txt | 2 +- gnss/1.0/IGnssMeasurementCallback.hal | 29 +++++++++---------- .../hardware/gnss/GnssMeasurement.aidl | 22 ++++++-------- 3 files changed, 23 insertions(+), 30 deletions(-) diff --git a/current.txt b/current.txt index bf6829a353..fb9b056a43 100644 --- a/current.txt +++ b/current.txt @@ -769,7 +769,7 @@ a64467bae843569f0d465c5be7f0c7a5b987985b55a3ef4794dd5afc68538650 android.hardwar # ABI preserving changes to HALs during Android S e042522daa4b5f7fd4a0a19bcdadb93c79a1b04c09ef2c9813a3a8941032f3f5 android.hardware.contexthub@1.0::IContexthub c2f64133b83ede65c9939ef97ab5bd867b73faf3dba0e7e69f77c3c43d9e487e android.hardware.contexthub@1.0::IContexthubCallback -1ca372cd67d197df099e87616a613ba6ede6552638a603e18f86c8834302c3d1 android.hardware.gnss@1.0::IGnssMeasurementCallback +bda492ec4021d13869de72bd6f8c15c5837b78d6136b8d538efec5320573a5ec android.hardware.gnss@1.0::IGnssMeasurementCallback 6a271e493907e8ba20912e42771bd0d99ae45431a851d5675ef9496d02510a34 android.hardware.gnss@1.1::IGnssMeasurementCallback 2c331a9605f3a08d9c1e0a36169ca57758bc43c11a78ef3f3730509885e52c15 android.hardware.graphics.composer@2.4::IComposerClient 3da3ce039247872d95c6bd48621dbfdfa1c2d2a91a90f257862f87ee2bc46300 android.hardware.health@2.1::types diff --git a/gnss/1.0/IGnssMeasurementCallback.hal b/gnss/1.0/IGnssMeasurementCallback.hal index d219af0bd1..603680d0b4 100644 --- a/gnss/1.0/IGnssMeasurementCallback.hal +++ b/gnss/1.0/IGnssMeasurementCallback.hal @@ -644,22 +644,19 @@ interface IGnssMeasurementCallback { */ double snrDb; - /** - * Automatic gain control (AGC) level. AGC acts as a variable gain - * amplifier adjusting the power of the incoming signal. The AGC level - * may be used to indicate potential interference. When AGC is at a - * nominal level, this value must be set as 0. Higher gain (and/or lower - * input power) must be output as a positive number. Hence in cases of - * strong jamming, in the band of this signal, this value must go more - * negative. - * - * Note: Different hardware designs (e.g. antenna, pre-amplification, or - * other RF HW components) may also affect the typical output of of this - * value on any given hardware design in an open sky test - the - * important aspect of this output is that changes in this value are - * indicative of changes on input signal power in the frequency band for - * this measurement. - */ + + /** + * Automatic gain control (AGC) level. AGC acts as a variable gain amplifier adjusting the power + * of the incoming signal. The AGC level may be used to indicate potential interference. Higher + * gain (and/or lower input power) must be output as a positive number. Hence in cases of strong + * jamming, in the band of this signal, this value must go more negative. This value must be + * consistent given the same level of the incoming signal power. + * + * Note: Different hardware designs (e.g. antenna, pre-amplification, or other RF HW components) + * may also affect the typical output of this value on any given hardware design in an open sky + * test - the important aspect of this output is that changes in this value are indicative of + * changes on input signal power in the frequency band for this measurement. + */ double agcLevelDb; }; diff --git a/gnss/aidl/android/hardware/gnss/GnssMeasurement.aidl b/gnss/aidl/android/hardware/gnss/GnssMeasurement.aidl index 2c56a41643..4468b63e26 100644 --- a/gnss/aidl/android/hardware/gnss/GnssMeasurement.aidl +++ b/gnss/aidl/android/hardware/gnss/GnssMeasurement.aidl @@ -547,20 +547,16 @@ parcelable GnssMeasurement { double snrDb; /** - * Automatic gain control (AGC) level. AGC acts as a variable gain - * amplifier adjusting the power of the incoming signal. The AGC level - * may be used to indicate potential interference. When AGC is at a - * nominal level, this value must be set as 0. Higher gain (and/or lower - * input power) must be output as a positive number. Hence in cases of - * strong jamming, in the band of this signal, this value must go more - * negative. + * Automatic gain control (AGC) level. AGC acts as a variable gain amplifier adjusting the power + * of the incoming signal. The AGC level may be used to indicate potential interference. Higher + * gain (and/or lower input power) must be output as a positive number. Hence in cases of strong + * jamming, in the band of this signal, this value must go more negative. This value must be + * consistent given the same level of the incoming signal power. * - * Note: Different hardware designs (e.g. antenna, pre-amplification, or - * other RF HW components) may also affect the typical output of this - * value on any given hardware design in an open sky test - the - * important aspect of this output is that changes in this value are - * indicative of changes on input signal power in the frequency band for - * this measurement. + * Note: Different hardware designs (e.g. antenna, pre-amplification, or other RF HW components) + * may also affect the typical output of this value on any given hardware design in an open sky + * test - the important aspect of this output is that changes in this value are indicative of + * changes on input signal power in the frequency band for this measurement. */ double agcLevelDb;