From a76d4d889979a732bf01e3eeac4e1ae1028c24ac Mon Sep 17 00:00:00 2001
From: Bart Van Assche <bvanassche@google.com>
Date: Mon, 6 Nov 2023 12:51:38 -0800
Subject: [PATCH] audio: Simplify AudioHalBinderServiceUtil::waitForFired()

Return the std::condition::wait_for() return value instead of reading
the variable 'fired' again. See also
https://en.cppreference.com/w/cpp/thread/condition_variable/wait_for.

Change-Id: I48c270f5446f61b2ad828b19a1fc294737a123dd
Signed-off-by: Bart Van Assche <bvanassche@google.com>
---
 audio/aidl/vts/AudioHalBinderServiceUtil.h | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/audio/aidl/vts/AudioHalBinderServiceUtil.h b/audio/aidl/vts/AudioHalBinderServiceUtil.h
index b4b46326a6..403690ebf7 100644
--- a/audio/aidl/vts/AudioHalBinderServiceUtil.h
+++ b/audio/aidl/vts/AudioHalBinderServiceUtil.h
@@ -71,8 +71,7 @@ class AudioHalBinderServiceUtil {
 
         bool waitForFired(std::chrono::milliseconds timeoutMs) {
             std::unique_lock<std::mutex> lock(mutex);
-            condition.wait_for(lock, timeoutMs, [this]() { return fired; });
-            return fired;
+            return condition.wait_for(lock, timeoutMs, [this]() { return fired; });
         }
 
       private: