tequilaOS/platform_hardware_interfaces
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

wifi: check all possible returning codes for connect/cancelConnect

Browse source 
Before R, those two calls are not going to work with fake values.
After enabling auto-join, it will success always.

Bug: 169890122
Bug: 170271410
Test: atest VtsHalWifiSupplicantP2pV1_0TargetTest
Change-Id: I7d94e797e140520a5df33bba854d5cb2b015eacf
This commit is contained in:
Jimmy Chen 2020-10-07 11:28:31 +08:00 committed by Hongguang Chen
parent d973ce2ac1
commit b5c7e1813d
1 changed files with 28 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

33
wifi/supplicant/1.0/vts/functional/supplicant_p2p_iface_hidl_test.cpp
View file

@ -282,8 +282,17 @@ TEST_P(SupplicantP2pIfaceHidlTest, Connect) {
mac_addr_, ISupplicantP2pIface::WpsProvisionMethod::PBC,
kTestConnectPin, false, false, kTestConnectGoIntent,
[](const SupplicantStatus& status, const hidl_string& /* pin */) {
// After enabling auto-join, it will succeed always.
EXPECT_EQ(SupplicantStatusCode::SUCCESS, status.code);
/*
* Before R, auto-join is not enabled and it is not going to work
* with fake values. After enabling auto-join, it will succeed
* always.
*/
LOG(INFO) << "ISupplicantP2pIface::connect() ret: "
<< toString(status);
if (SupplicantStatusCode::FAILURE_UNKNOWN != status.code &&
SupplicantStatusCode::SUCCESS != status.code) {
FAIL();
}
});
}
@ -295,12 +304,26 @@ TEST_P(SupplicantP2pIfaceHidlTest, CancelConnect) {
mac_addr_, ISupplicantP2pIface::WpsProvisionMethod::PBC,
kTestConnectPin, false, false, kTestConnectGoIntent,
[](const SupplicantStatus& status, const hidl_string& /* pin */) {
// After enabling auto-join, it will succeed always.
EXPECT_EQ(SupplicantStatusCode::SUCCESS, status.code);
/*
* Before R, auto-join is not enabled and it is not going to work
* with fake values. After enabling auto-join, it will succeed
* always.
*/
LOG(INFO) << "ISupplicantP2pIface::connect() ret: "
<< toString(status);
if (SupplicantStatusCode::FAILURE_UNKNOWN != status.code &&
SupplicantStatusCode::SUCCESS != status.code) {
FAIL();
}
});
p2p_iface_->cancelConnect([](const SupplicantStatus& status) {
EXPECT_EQ(SupplicantStatusCode::SUCCESS, status.code);
LOG(INFO) << "ISupplicantP2pIface::cancelConnect() ret: "
<< toString(status);
if (SupplicantStatusCode::FAILURE_UNKNOWN != status.code &&
SupplicantStatusCode::SUCCESS != status.code) {
FAIL();
}
});
}