tequilaOS/platform_hardware_interfaces
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

Add -Wno-missing-permission-annotation for soundtrigger3

Browse source 
Soundtrigger3 has been built with "-Werror -Weverything" (from
Android.bp) and "-Weverything -Wno-missing-permission-annotation" (from
the AIDL build system). The former is added only for the ToT version of
an AIDL interface.

So far, soundtrigger3 wasn't frozen and therefore the implicit version 1
was the ToT version. As a result, absence of @RequiresPermission in its
interface didn't break the build due to the automatically added
"-Wno-missing-permission-annotation" despite that it had "-Werror".

However, this is causing build breakage as soundtrigger3 now has version
1 and 2 (ToT) and the version 1 is built *without*
  "-Wno-missing-permission-annotation".

Fixing this by manually adding the diag flag so that it's applied to all
versions.

Bug: 225941299
Test: m
Change-Id: I3a43fc77997ef900b0f173c88530f570e436bc77
This commit is contained in:
Jiyong Park 2022-03-23 17:43:54 +09:00
parent 3c4b1725fa
commit bb73ba4e68
1 changed files with 1 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
soundtrigger/aidl/Android.bp
View file

@ -14,6 +14,7 @@ aidl_interface {
flags: [ flags: [
"-Werror", "-Werror",
"-Weverything", "-Weverything",
"-Wno-missing-permission-annotation",
], ],
srcs: [ srcs: [
"android/hardware/soundtrigger3/ISoundTriggerHw.aidl", "android/hardware/soundtrigger3/ISoundTriggerHw.aidl",