tequilaOS/platform_hardware_interfaces
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

VTSHalPowerTarget: Add condition check for FMQAidl teardown

Browse source 
While FMQAidl Setup() was skipped, some uninitialized objects would be
used in FMQAidl Teardown() which caused the test failed.
Add some condition check to prevent from using uninitialized objects.

Test: atest VTSHalPowerTarget
Bug: 328330332
Change-Id: I83081cbef66da1d74d87e191f266cb16fb559b85
This commit is contained in:
jimmyshiu 2024-03-19 08:56:42 +00:00
parent c26e3123f3
commit d3753ec91d
1 changed files with 6 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
power/aidl/vts/VtsHalPowerTargetTest.cpp
View file

@ -180,9 +180,13 @@ class FMQAidl : public PowerAidl {
ASSERT_NE(mEventFlag, nullptr); ASSERT_NE(mEventFlag, nullptr);
} }
virtual void TearDown() { virtual void TearDown() {
if (mSession) {
mSession->close(); mSession->close();
if (mChannel->isValid()) {
ASSERT_TRUE(power->closeSessionChannel(getpid(), getuid()).isOk()); ASSERT_TRUE(power->closeSessionChannel(getpid(), getuid()).isOk());
} }
}
}
protected: protected:
std::shared_ptr<IPowerHintSession> mSession; std::shared_ptr<IPowerHintSession> mSession;