tequilaOS/platform_hardware_interfaces
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

nfc: reflect style guide.

Browse source 
Test: make android.hardware.nfc@1.0
Change-Id: I60c1589492752753c362dc9766ebc7776b5e6e6e
This commit is contained in:
Steven Moreland 2016-09-26 12:40:29 -07:00
parent 242b34edd5
commit e0c416a6f2
4 changed files with 44 additions and 80 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

58
nfc/1.0/Android.mk
View file

@ -13,9 +13,9 @@ intermediates := $(local-generated-sources-dir)
HIDL := $(HOST_OUT_EXECUTABLES)/hidl-gen$(HOST_EXECUTABLE_SUFFIX) HIDL := $(HOST_OUT_EXECUTABLES)/hidl-gen$(HOST_EXECUTABLE_SUFFIX)
# #
# Build types.hal (nfc_data_t) # Build types.hal (NfcEvent)
# #
GEN := $(intermediates)/android/hardware/nfc/1.0/nfc_data_t.java GEN := $(intermediates)/android/hardware/nfc/1.0/NfcEvent.java
$(GEN): $(HIDL) $(GEN): $(HIDL)
$(GEN): PRIVATE_HIDL := $(HIDL) $(GEN): PRIVATE_HIDL := $(HIDL)
$(GEN): PRIVATE_DEPS := $(LOCAL_PATH)/types.hal $(GEN): PRIVATE_DEPS := $(LOCAL_PATH)/types.hal
@ -23,16 +23,16 @@ $(GEN): PRIVATE_OUTPUT_DIR := $(intermediates)
$(GEN): PRIVATE_CUSTOM_TOOL = \ $(GEN): PRIVATE_CUSTOM_TOOL = \
$(PRIVATE_HIDL) -o $(PRIVATE_OUTPUT_DIR) \ $(PRIVATE_HIDL) -o $(PRIVATE_OUTPUT_DIR) \
-Ljava -randroid.hardware:hardware/interfaces \ -Ljava -randroid.hardware:hardware/interfaces \
android.hardware.nfc@1.0::types.nfc_data_t android.hardware.nfc@1.0::types.NfcEvent
$(GEN): $(LOCAL_PATH)/types.hal $(GEN): $(LOCAL_PATH)/types.hal
$(transform-generated-source) $(transform-generated-source)
LOCAL_GENERATED_SOURCES += $(GEN) LOCAL_GENERATED_SOURCES += $(GEN)
# #
# Build types.hal (nfc_event_t) # Build types.hal (NfcStatus)
# #
GEN := $(intermediates)/android/hardware/nfc/1.0/nfc_event_t.java GEN := $(intermediates)/android/hardware/nfc/1.0/NfcStatus.java
$(GEN): $(HIDL) $(GEN): $(HIDL)
$(GEN): PRIVATE_HIDL := $(HIDL) $(GEN): PRIVATE_HIDL := $(HIDL)
$(GEN): PRIVATE_DEPS := $(LOCAL_PATH)/types.hal $(GEN): PRIVATE_DEPS := $(LOCAL_PATH)/types.hal
@ -40,24 +40,7 @@ $(GEN): PRIVATE_OUTPUT_DIR := $(intermediates)
$(GEN): PRIVATE_CUSTOM_TOOL = \ $(GEN): PRIVATE_CUSTOM_TOOL = \
$(PRIVATE_HIDL) -o $(PRIVATE_OUTPUT_DIR) \ $(PRIVATE_HIDL) -o $(PRIVATE_OUTPUT_DIR) \
-Ljava -randroid.hardware:hardware/interfaces \ -Ljava -randroid.hardware:hardware/interfaces \
android.hardware.nfc@1.0::types.nfc_event_t android.hardware.nfc@1.0::types.NfcStatus
$(GEN): $(LOCAL_PATH)/types.hal
$(transform-generated-source)
LOCAL_GENERATED_SOURCES += $(GEN)
#
# Build types.hal (nfc_status_t)
#
GEN := $(intermediates)/android/hardware/nfc/1.0/nfc_status_t.java
$(GEN): $(HIDL)
$(GEN): PRIVATE_HIDL := $(HIDL)
$(GEN): PRIVATE_DEPS := $(LOCAL_PATH)/types.hal
$(GEN): PRIVATE_OUTPUT_DIR := $(intermediates)
$(GEN): PRIVATE_CUSTOM_TOOL = \
$(PRIVATE_HIDL) -o $(PRIVATE_OUTPUT_DIR) \
-Ljava -randroid.hardware:hardware/interfaces \
android.hardware.nfc@1.0::types.nfc_status_t
$(GEN): $(LOCAL_PATH)/types.hal $(GEN): $(LOCAL_PATH)/types.hal
$(transform-generated-source) $(transform-generated-source)
@ -116,9 +99,9 @@ intermediates := $(local-generated-sources-dir)
HIDL := $(HOST_OUT_EXECUTABLES)/hidl-gen$(HOST_EXECUTABLE_SUFFIX) HIDL := $(HOST_OUT_EXECUTABLES)/hidl-gen$(HOST_EXECUTABLE_SUFFIX)
# #
# Build types.hal (nfc_data_t) # Build types.hal (NfcEvent)
# #
GEN := $(intermediates)/android/hardware/nfc/1.0/nfc_data_t.java GEN := $(intermediates)/android/hardware/nfc/1.0/NfcEvent.java
$(GEN): $(HIDL) $(GEN): $(HIDL)
$(GEN): PRIVATE_HIDL := $(HIDL) $(GEN): PRIVATE_HIDL := $(HIDL)
$(GEN): PRIVATE_DEPS := $(LOCAL_PATH)/types.hal $(GEN): PRIVATE_DEPS := $(LOCAL_PATH)/types.hal
@ -126,16 +109,16 @@ $(GEN): PRIVATE_OUTPUT_DIR := $(intermediates)
$(GEN): PRIVATE_CUSTOM_TOOL = \ $(GEN): PRIVATE_CUSTOM_TOOL = \
$(PRIVATE_HIDL) -o $(PRIVATE_OUTPUT_DIR) \ $(PRIVATE_HIDL) -o $(PRIVATE_OUTPUT_DIR) \
-Ljava -randroid.hardware:hardware/interfaces \ -Ljava -randroid.hardware:hardware/interfaces \
android.hardware.nfc@1.0::types.nfc_data_t android.hardware.nfc@1.0::types.NfcEvent
$(GEN): $(LOCAL_PATH)/types.hal $(GEN): $(LOCAL_PATH)/types.hal
$(transform-generated-source) $(transform-generated-source)
LOCAL_GENERATED_SOURCES += $(GEN) LOCAL_GENERATED_SOURCES += $(GEN)
# #
# Build types.hal (nfc_event_t) # Build types.hal (NfcStatus)
# #
GEN := $(intermediates)/android/hardware/nfc/1.0/nfc_event_t.java GEN := $(intermediates)/android/hardware/nfc/1.0/NfcStatus.java
$(GEN): $(HIDL) $(GEN): $(HIDL)
$(GEN): PRIVATE_HIDL := $(HIDL) $(GEN): PRIVATE_HIDL := $(HIDL)
$(GEN): PRIVATE_DEPS := $(LOCAL_PATH)/types.hal $(GEN): PRIVATE_DEPS := $(LOCAL_PATH)/types.hal
@ -143,24 +126,7 @@ $(GEN): PRIVATE_OUTPUT_DIR := $(intermediates)
$(GEN): PRIVATE_CUSTOM_TOOL = \ $(GEN): PRIVATE_CUSTOM_TOOL = \
$(PRIVATE_HIDL) -o $(PRIVATE_OUTPUT_DIR) \ $(PRIVATE_HIDL) -o $(PRIVATE_OUTPUT_DIR) \
-Ljava -randroid.hardware:hardware/interfaces \ -Ljava -randroid.hardware:hardware/interfaces \
android.hardware.nfc@1.0::types.nfc_event_t android.hardware.nfc@1.0::types.NfcStatus
$(GEN): $(LOCAL_PATH)/types.hal
$(transform-generated-source)
LOCAL_GENERATED_SOURCES += $(GEN)
#
# Build types.hal (nfc_status_t)
#
GEN := $(intermediates)/android/hardware/nfc/1.0/nfc_status_t.java
$(GEN): $(HIDL)
$(GEN): PRIVATE_HIDL := $(HIDL)
$(GEN): PRIVATE_DEPS := $(LOCAL_PATH)/types.hal
$(GEN): PRIVATE_OUTPUT_DIR := $(intermediates)
$(GEN): PRIVATE_CUSTOM_TOOL = \
$(PRIVATE_HIDL) -o $(PRIVATE_OUTPUT_DIR) \
-Ljava -randroid.hardware:hardware/interfaces \
android.hardware.nfc@1.0::types.nfc_status_t
$(GEN): $(LOCAL_PATH)/types.hal $(GEN): $(LOCAL_PATH)/types.hal
$(transform-generated-source) $(transform-generated-source)

30
nfc/1.0/INfc.hal
View file

@ -27,7 +27,7 @@ interface INfc {
* NCI initialization - ie accept CORE_RESET and subsequent commands through * NCI initialization - ie accept CORE_RESET and subsequent commands through
* the write() call. * the write() call.
* *
* If open() returns 0, the NCI stack will wait for a HAL_NFC_OPEN_CPLT_EVT * If open() returns 0, the NCI stack will wait for a NfcEvent.OPEN_CPLT
* before continuing. * before continuing.
* *
* If open() returns any other value, the NCI stack will stop. * If open() returns any other value, the NCI stack will stop.
@ -41,32 +41,32 @@ interface INfc {
* This method may queue writes and return immediately. The only * This method may queue writes and return immediately. The only
* requirement is that the writes are executed in order. * requirement is that the writes are executed in order.
*/ */
write(nfc_data_t data) generates (int32_t retval); write(NfcData data) generates (int32_t retval);
/* /*
* core_initialized() is called after the CORE_INIT_RSP is received from the NFCC. * coreInitialized() is called after the CORE_INIT_RSP is received from the NFCC.
* At this time, the HAL can do any chip-specific configuration. * At this time, the HAL can do any chip-specific configuration.
* *
* If core_initialized() returns 0, the NCI stack will wait for a HAL_NFC_POST_INIT_CPLT_EVT * If coreInitialized() returns 0, the NCI stack will wait for a NfcEvent.POST_INIT_CPLT
* before continuing. * before continuing.
* *
* If core_initialized() returns any other value, the NCI stack will continue * If coreInitialized() returns any other value, the NCI stack will continue
* immediately. * immediately.
*/ */
core_initialized(vec<uint8_t> data) generates (int32_t retval); coreInitialized(NfcData data) generates (int32_t retval);
/* /*
* pre_discover is called every time before starting RF discovery. * prediscover is called every time before starting RF discovery.
* It is a good place to do vendor-specific configuration that must be * It is a good place to do vendor-specific configuration that must be
* performed every time RF discovery is about to be started. * performed every time RF discovery is about to be started.
* *
* If pre_discover() returns 0, the NCI stack will wait for a HAL_NFC_PRE_DISCOVER_CPLT_EVT * If prediscover() returns 0, the NCI stack will wait for a NfcEvent.PREDISCOVER_CPLT
* before continuing. * before continuing.
* *
* If pre_discover() returns any other value, the NCI stack will start * If prediscover() returns any other value, the NCI stack will start
* RF discovery immediately. * RF discovery immediately.
*/ */
pre_discover() generates (int32_t retval); prediscover() generates (int32_t retval);
/* /*
* Close the NFC controller. Should free all resources. * Close the NFC controller. Should free all resources.
@ -75,15 +75,15 @@ interface INfc {
/* /*
* Grant HAL the exclusive control to send NCI commands. * Grant HAL the exclusive control to send NCI commands.
* Called in response to HAL_REQUEST_CONTROL_EVT. * Called in response to NfcEvent.REQUEST_CONTROL.
* Must only be called when there are no NCI commands pending. * Must only be called when there are no NCI commands pending.
* HAL_RELEASE_CONTROL_EVT will notify when HAL no longer needs exclusive control. * NfcEvent.RELEASE_CONTROL will notify when HAL no longer needs exclusive control.
*/ */
control_granted() generates (int32_t retval); controlGranted() generates (int32_t retval);
/* /*
* Restart controller by power cyle; * Restart controller by power cyle;
* HAL_OPEN_CPLT_EVT will notify when operation is complete. * NfcEvent.OPEN_CPLT will notify when operation is complete.
*/ */
power_cycle() generates (int32_t retval); powerCycle() generates (int32_t retval);
}; };

4
nfc/1.0/INfcClientCallback.hal
View file

@ -21,11 +21,11 @@ interface INfcClientCallback {
* The callback passed in from the NFC stack that the HAL * The callback passed in from the NFC stack that the HAL
* can use to pass events back to the stack. * can use to pass events back to the stack.
*/ */
sendEvent(nfc_event_t event, nfc_status_t event_status); sendEvent(NfcEvent event, NfcStatus status);
/* /*
* The callback passed in from the NFC stack that the HAL * The callback passed in from the NFC stack that the HAL
* can use to pass incomming data to the stack. * can use to pass incomming data to the stack.
*/ */
sendData(nfc_data_t data); sendData(NfcData data);
}; };

32
nfc/1.0/types.hal
View file

@ -16,24 +16,22 @@
package android.hardware.nfc@1.0; package android.hardware.nfc@1.0;
enum nfc_event_t : uint32_t { enum NfcEvent : uint32_t {
HAL_NFC_OPEN_CPLT_EVT = 0, OPEN_CPLT = 0,
HAL_NFC_CLOSE_CPLT_EVT = 1, CLOSE_CPLT = 1,
HAL_NFC_POST_INIT_CPLT_EVT = 2, POST_INIT_CPLT = 2,
HAL_NFC_PRE_DISCOVER_CPLT_EVT = 3, PRE_DISCOVER_CPLT = 3,
HAL_NFC_REQUEST_CONTROL_EVT = 4, REQUEST_CONTROL = 4,
HAL_NFC_RELEASE_CONTROL_EVT = 5, RELEASE_CONTROL = 5,
HAL_NFC_ERROR_EVT = 6 ERROR = 6
}; };
enum nfc_status_t : uint32_t { enum NfcStatus : uint32_t {
HAL_NFC_STATUS_OK = 0, OK = 0,
HAL_NFC_STATUS_FAILED = 1, FAILED = 1,
HAL_NFC_STATUS_ERR_TRANSPORT = 2, ERR_TRANSPORT = 2,
HAL_NFC_STATUS_ERR_CMD_TIMEOUT = 3, ERR_CMD_TIMEOUT = 3,
HAL_NFC_STATUS_REFUSED = 4 REFUSED = 4
}; };
struct nfc_data_t { typedef vec<uint8_t> NfcData;
vec<uint8_t> data;
};