From f082902b41cb9151e0336c78550f11e6959d512e Mon Sep 17 00:00:00 2001 From: Mikhail Naganov Date: Tue, 18 Jul 2023 14:46:18 -0700 Subject: [PATCH] audio: Fix state machine initial and final state symbols In UML, the initial state is a solid circle, the final state is a double circle. In the Core HAL diagrams it was the opposite. Test: dot -Tpng stream-{in|out}-[async-]sm.gv -o ... Change-Id: Id69f17d0a47227e744eb6dadcb5fee08c07bb0bd --- audio/aidl/android/hardware/audio/core/stream-in-async-sm.gv | 4 ++-- audio/aidl/android/hardware/audio/core/stream-in-sm.gv | 4 ++-- audio/aidl/android/hardware/audio/core/stream-out-async-sm.gv | 4 ++-- audio/aidl/android/hardware/audio/core/stream-out-sm.gv | 4 ++-- 4 files changed, 8 insertions(+), 8 deletions(-) diff --git a/audio/aidl/android/hardware/audio/core/stream-in-async-sm.gv b/audio/aidl/android/hardware/audio/core/stream-in-async-sm.gv index 818b18eda7..6b69845f40 100644 --- a/audio/aidl/android/hardware/audio/core/stream-in-async-sm.gv +++ b/audio/aidl/android/hardware/audio/core/stream-in-async-sm.gv @@ -14,8 +14,8 @@ // To render: dot -Tpng stream-in-async-sm.gv -o stream-in-async-sm.png digraph stream_in_async_state_machine { - node [shape=doublecircle style=filled fillcolor=black width=0.5] I; - node [shape=point width=0.5] F; + node [shape=point style=filled fillcolor=black width=0.5] I; + node [shape=doublecircle width=0.5] F; node [shape=oval width=1]; node [fillcolor=lightgreen] STANDBY; // buffer is empty node [fillcolor=tomato] CLOSED; diff --git a/audio/aidl/android/hardware/audio/core/stream-in-sm.gv b/audio/aidl/android/hardware/audio/core/stream-in-sm.gv index 805dc3267c..aa7af54fcf 100644 --- a/audio/aidl/android/hardware/audio/core/stream-in-sm.gv +++ b/audio/aidl/android/hardware/audio/core/stream-in-sm.gv @@ -14,8 +14,8 @@ // To render: dot -Tpng stream-in-sm.gv -o stream-in-sm.png digraph stream_in_state_machine { - node [shape=doublecircle style=filled fillcolor=black width=0.5] I; - node [shape=point width=0.5] F; + node [shape=point style=filled fillcolor=black width=0.5] I; + node [shape=doublecircle width=0.5] F; node [shape=oval width=1]; node [fillcolor=lightgreen] STANDBY; // buffer is empty node [fillcolor=tomato] CLOSED; diff --git a/audio/aidl/android/hardware/audio/core/stream-out-async-sm.gv b/audio/aidl/android/hardware/audio/core/stream-out-async-sm.gv index 501dc0169d..a3f0de9e59 100644 --- a/audio/aidl/android/hardware/audio/core/stream-out-async-sm.gv +++ b/audio/aidl/android/hardware/audio/core/stream-out-async-sm.gv @@ -14,8 +14,8 @@ // To render: dot -Tpng stream-out-async-sm.gv -o stream-out-async-sm.png digraph stream_out_async_state_machine { - node [shape=doublecircle style=filled fillcolor=black width=0.5] I; - node [shape=point width=0.5] F; + node [shape=point style=filled fillcolor=black width=0.5] I; + node [shape=doublecircle width=0.5] F; node [shape=oval width=1]; node [fillcolor=lightgreen] STANDBY; // buffer is empty node [fillcolor=lightgreen] IDLE; // buffer is empty diff --git a/audio/aidl/android/hardware/audio/core/stream-out-sm.gv b/audio/aidl/android/hardware/audio/core/stream-out-sm.gv index 47e7fda568..23fb5d9cde 100644 --- a/audio/aidl/android/hardware/audio/core/stream-out-sm.gv +++ b/audio/aidl/android/hardware/audio/core/stream-out-sm.gv @@ -14,8 +14,8 @@ // To render: dot -Tpng stream-out-sm.gv -o stream-out-sm.png digraph stream_out_state_machine { - node [shape=doublecircle style=filled fillcolor=black width=0.5] I; - node [shape=point width=0.5] F; + node [shape=point style=filled fillcolor=black width=0.5] I; + node [shape=doublecircle width=0.5] F; node [shape=oval width=1]; node [fillcolor=lightgreen] STANDBY; // buffer is empty node [fillcolor=lightgreen] IDLE; // buffer is empty