tequilaOS/platform_hardware_interfaces
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

Revert "compatibility_matrices: add vintf_compatibility_matrix.c..."

Browse source 
Revert submission 2652627-vintf_compatibility_matrix_core_hals

Reason for revert: core HALs on product/system_ext FCMs are okay, just
  not deprecated versions.

Reverted changes: /q/submissionid:2652627-vintf_compatibility_matrix_core_hals

Bug: 290408770
Change-Id: I72480d05ac9efc101c7045820d1a0ef10f191f80
This commit is contained in:
Yifan Hong 2023-11-17 19:22:54 +00:00
parent ddfa614de3
commit f4e2519fff
1 changed files with 3 additions and 31 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

34
compatibility_matrices/build/vintf_compatibility_matrix.go
View file

@ -35,10 +35,10 @@ var (
pctx = android.NewPackageContext("android/vintf")
assembleVintfRule = pctx.AndroidStaticRule("assemble_vintf", blueprint.RuleParams{
Command: `${assembleVintfCmd} -i ${inputs} -o ${out} ${extraParams}`,
Command: `${assembleVintfCmd} -i ${inputs} -o ${out}`,
CommandDeps: []string{"${assembleVintfCmd}"},
Description: "assemble_vintf -i ${inputs}",
}, "inputs", "extraParams")
}, "inputs")
xmllintXsd = pctx.AndroidStaticRule("xmllint-xsd", blueprint.RuleParams{
Command: `$XmlLintCmd --quiet --schema $xsd $in > /dev/null && touch -a $out`,
@ -64,13 +64,6 @@ type vintfCompatibilityMatrixProperties struct {
// list of kernel_config modules to be combined to final output
Kernel_configs []string
// Default is "default" for compatibility matrices on /vendor
// and /odm, and "disallow" for compatibility matrices on /system,
// /product, and /system_ext.
// If value is "only", only android.* HALs are allowed. If value
// is "disallow", none of android.* HALs are allowed.
Core_hals *string
}
type vintfCompatibilityMatrixRule struct {
@ -173,8 +166,7 @@ func (g *vintfCompatibilityMatrixRule) GenerateAndroidBuildActions(ctx android.M
Implicits: inputPaths,
Output: g.genFile,
Args: map[string]string{
"inputs": strings.Join(inputPaths.Strings(), ":"),
"extraParams": strings.Join(g.getExtraParams(), " "),
"inputs": strings.Join(inputPaths.Strings(), ":"),
},
})
g.generateValidateBuildAction(ctx, g.genFile, schema.Path())
@ -199,23 +191,3 @@ func (g *vintfCompatibilityMatrixRule) AndroidMk() android.AndroidMkData {
},
}
}
// Return extra parameters to assemble_vintf.
func (g *vintfCompatibilityMatrixRule) getExtraParams() []string {
var extraParams []string
coreHalsStrategy := proptools.StringDefault(
g.properties.Core_hals,
g.defaultCoreHalsStrategy(),
)
extraParams = append(extraParams, "--core-hals", proptools.ShellEscape(coreHalsStrategy))
return extraParams
}
func (g *vintfCompatibilityMatrixRule) defaultCoreHalsStrategy() string {
// TODO(b/290408770): default to "disallow" for FCMs
// For Device (vendor, odm) compatibility matrix, default is
// to not check anything.
return "default"
}