Merge "Clarifying comments and todos, update current.txt." into oc-dev

This commit is contained in:
TreeHugger Robot 2017-04-21 15:39:25 +00:00 committed by Android (Google) Code Review
commit f6470873f4
3 changed files with 14 additions and 17 deletions

View file

@ -76,7 +76,7 @@ c9d318df7922bde3b265927b521ff5a965002826fc0cabfcaef52a56760f2d34 android.hardwar
da13bd69282fb275767abb18704c57ff8038e6c139ad17157dc702810f70d06a android.hardware.gatekeeper@1.0::types
37c7da4f823ec958dfa9c960e2d341c48f877e0bfa758f3fa9e2d9c1e1bd66d9 android.hardware.gnss@1.0::IAGnss
7ec9afdb964bfb8369866913caf018f2636592885bcb558a65de2c5436ab4f60 android.hardware.gnss@1.0::IAGnssCallback
f3219d8f33d5186a01f617bb7812b64620f9f28b65758ede939423ab0ba798fa android.hardware.gnss@1.0::IAGnssRil
d16e6a359be6963ea753d7138e84ecf2b93052097938938c4d36d7a47ea2e2ae android.hardware.gnss@1.0::IAGnssRil
2f907708d74d94b1e121ed27651c9c72af65952d347b58ff07dac5d5d7a7f678 android.hardware.gnss@1.0::IAGnssRilCallback
5ac7edad06d76064b882be161f3f9d9692a997ec72e9f36addb7fe8918f49992 android.hardware.gnss@1.0::IGnss
b05c983c87c3376e145223688c3b541b5e11b827f211e38d5a31af1ca3a2e222 android.hardware.gnss@1.0::IGnssBatching
@ -89,7 +89,7 @@ f90e4ddc652706299d8e3d8ba18e0745c3bae9bf4d1be6bd06d9c1f50ec8d28a android.hardwar
9ea8987bb1089c8c5d7b67866575b866ef516045021d9efcc37c6352bce072a3 android.hardware.gnss@1.0::IGnssMeasurement
d6a00007b30f0e3ed196df677f311b3e25b15082c5e82756f392677d3b66ec0a android.hardware.gnss@1.0::IGnssMeasurementCallback
af85aa0f48ae99a39f4688c344e4419304f681f9af818a5c8d759286fc4418de android.hardware.gnss@1.0::IGnssNavigationMessage
8afadd3b15858bba57cfc2a1093e3704cf687245d8267f59604a48ac9d889973 android.hardware.gnss@1.0::IGnssNavigationMessageCallback
649b1b0fb98bdd3a1ace84f4e08bfa2df813afdd4862856693f107c281a929ba android.hardware.gnss@1.0::IGnssNavigationMessageCallback
248bcf51da4273d64f367bf6877baef2feeaca365459842fd3c214a2dc6e0224 android.hardware.gnss@1.0::IGnssNi
e4f2c1b80172a73e2e743fba3ddc24ef58bc42d40bdb8f7352c9e19440b220eb android.hardware.gnss@1.0::IGnssNiCallback
c1142657de16fdb292a502372fe938614d65270ab8359217d6e13604fe4dbca4 android.hardware.gnss@1.0::IGnssXtra

View file

@ -131,14 +131,13 @@ interface IAGnssRil {
generates (bool success);
/**
* Notify GNSS of network status changes.
* Notify GNSS of network status changes and current APN.
*
* @param available Indicates whether network connectivity is available.
* @param apn String containing the Access Point Name.
* @param apn String containing the telephony preferred Access Point Name.
*
* @return success True if all parameters were valid and the operation was
* successful.
* TODO(b/32022567): Add VTS test to validate the format of APN.
*/
updateNetworkAvailability(bool available, string apn) generates (bool success);

View file

@ -51,11 +51,11 @@ interface IGnssNavigationMessageCallback {
/**
* Status of Navigation Message
* When a message is received properly without any parity error in its
* navigation words, the status must be set to PARITY_PASSED. But if a message is
* received with words that failed parity check, but GNSS is able to correct
* those words, the status must be set to PARITY_REBUILT.
* No need to send any navigation message that contains words with parity error
* and cannot be corrected.
* navigation words, the status must be set to PARITY_PASSED.
* If a message is received with words that failed a parity check, but the GNSS
* receiver has corrected those words, the status must be set to PARITY_REBUILT.
* Do not send any navigation message that contains words with parity errors
* that cannot be corrected.
*/
@export(name="navigation_message_status", value_prefix="NAV_MESSAGE_STATUS_")
enum NavigationMessageStatus : uint16_t {
@ -80,7 +80,7 @@ interface IGnssNavigationMessageCallback {
/**
* The status of the received navigation message.
* No need to send any navigation message that contains words with parity
* error and cannot be corrected.
* errors that cannot be corrected.
*/
bitfield<NavigationMessageStatus> status;
@ -125,8 +125,7 @@ interface IGnssNavigationMessageCallback {
/**
* The data of the reported GNSS message. The bytes (or words) are specified
* using big endian format (MSB first). The data is stored and decoded
* in a server for research purposes.
* using big endian format (MSB first).
*
* - For GNSS L1 C/A, Beidou D1 & Beidou D2, each subframe contains 10 30-bit
* words. Each word (30 bits) must fit into the last 30 bits in a
@ -150,10 +149,9 @@ interface IGnssNavigationMessageCallback {
* into 29 bytes, with MSB first (skip B229-B232). The standard followed
* is same as above.
*
* TODO(b/32022567): Describe this relationship with data to the VTS
* via custom annotations and plug in a VTS test to verify that the data
* correctly follows the standard.
*
* The data reported here must be the raw data as demodulated by the GNSS
* receiver, not data received from an external source (i.e. not from a server
* download.)
*/
vec<uint8_t> data;
};