Commit graph

1330 commits

Author SHA1 Message Date
ramindani
caee7cd3f6 [VTS 2.3] Add length check before reading blob
Adding a length check prevents the read() from
reading outside the bounds and prevents OOB crash.

Test: atest VtsHalGraphicsComposerV2_3TargetTest && atest VtsHalGraphicsComposerV2_4TargetTest
BUG: 252764300
Change-Id: I6231e340a925127f9c32ccb76768286f7292df58
Merged-In: I6231e340a925127f9c32ccb76768286f7292df58
2023-05-25 22:12:24 +00:00
Kriti Dang
79bbec97c4 Change the HDR conversion VTS test to take into account sink device
capabilities

Bug: 278467239
Test: atest VtsHalGraphicsComposer3_TargetTest
Change-Id: I69c21b6d8b9753500a7b7a1692448b7151009ba3
2023-05-08 08:28:09 +00:00
Huihong Luo
b7ffedf76a Merge "Reset pending commands" into udc-dev 2023-04-24 16:53:57 +00:00
Huihong Luo
651806f263 Reset pending commands
Allow takePendingCommands to have ownership for mComamnds so commands
are reset on each call. Make reset method to be private.

Bug: 273525126
Test: manual
Change-Id: Ifecad733e5e85d475825969296ddf68081ce9e60
2023-04-22 04:09:10 +00:00
Treehugger Robot
cee699a37b Merge "graphics/common: Link to the Jpeg/R format specification" into udc-dev 2023-04-20 21:52:07 +00:00
Emilian Peev
0794ecb65d graphics/common: Link to the Jpeg/R format specification
Bug: 264927059
Test: Clean build
Change-Id: I40d12b18814099223184877360193aeb315ddb90
2023-04-19 10:48:28 -07:00
Alex Buynytskyy
ec1198d941 UpsideDownCake is now 34
Ignore-AOSP-First: UpsideDownCake Finalization
Bug: 275409981
Test: build
Change-Id: I832ab7a8b5445ba85e27bbcf5be64906bfa0e5be
2023-04-07 23:41:20 +00:00
Ram Indani
946e04580b Merge "VTS add length is not zero check for executeSetClientTarget" into udc-dev 2023-04-03 20:54:03 +00:00
Sally Qi
3972fcdb1f Merge "Fix HDR sluggish issue." into udc-dev 2023-04-03 17:21:26 +00:00
ramindani
708d49cfce VTS add length is not zero check for executeSetClientTarget
Test: atest VtsHalGraphicsComposerV2_1TargetTest
BUG: 252764410
Change-Id: Icd15f6e7bfdd7b3e3d0d4b407195258d4171c560
2023-04-03 09:12:02 -07:00
Brian Lindahl
5d9aedf558 Merge "Fix bug where buffer slots to clear were not set correctly" into udc-dev 2023-04-03 13:29:49 +00:00
TreeHugger Robot
ac28d06464 Merge "Add VTS test for clearing buffer slots to Composer HIDL and AIDL" into udc-dev 2023-03-31 22:34:15 +00:00
Brian Lindahl
c85693d02d Fix bug where buffer slots to clear were not set correctly
Bug: 276417624
Bug: 258196272
Test: VtsHalGraphicsComposer3_TargetTest
Change-Id: Ie077f14140d71f88a497c4a8995d73dd07c31598
2023-03-31 07:45:18 -06:00
Brian Lindahl
25e0d09c76 Add VTS test for clearing buffer slots to Composer HIDL and AIDL
This feature allows SurfaceFlinger to clear buffer slots when buffers
are discarded by SurfaceFlinger clients and will no longer be used,
allowing the graphics memory to be freed immediately.

Bug: 258196272
Test: atest VtsHalGraphicsComposerV2_4TargetTest
Test: atest VtsHalGraphicsComposer3_TargetTest
Change-Id: Ibfbe2078ac419bb8f3880ee3f0512acaad2f5012
2023-03-31 07:26:27 -06:00
Sally Qi
6814c443eb Fix HDR sluggish issue.
- skip writing blobs if empty packet is sent for per-frame metadata.

Bug: 274050717
Test: play HDR video on YouTube
Change-Id: If8716613136c70a5adee29074cc2e9d35a500264
2023-03-30 23:41:29 -07:00
Brian Johnson
9f370be5bb Merge "Revert "Add a DisplayCapability for multi-threaded present"" into udc-dev 2023-03-31 01:55:24 +00:00
John Reck
ffe142751a Update DataSpace.aidl RANGE_EXTENDED
Fixes: 274780844
Test: doc only change
Change-Id: I619894e0bb3f4e6928e5c920af90fb8ce3702397
2023-03-28 11:39:58 -04:00
Leon Scroggins III
4509505ce0 Revert "Add a DisplayCapability for multi-threaded present"
This reverts commit b3e336edd1.

Bug: 274954820
Test: build
Change-Id: I6265f8de3db31f07506906cee82a91fe3baac0bc
2023-03-23 18:23:15 -04:00
Ram Indani
ef9924997b Merge "[VTS] Add interface version check function" into udc-dev 2023-03-21 20:00:04 +00:00
Treehugger Robot
534c5eeea3 Merge "Revert "graphics: improve preloading for IMapper default impl"" am: aab958fef0 am: 3ce3ee6427 am: d95f1801c7
Original change: https://android-review.googlesource.com/c/platform/hardware/interfaces/+/2497376

Change-Id: I1562de76110f9d938f00e3c603f6a2cf69e19a14
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-03-20 20:57:13 +00:00
ramindani
17c7110b70 [VTS] Add interface version check function
Use the interface version check function in
SetRefreshRateChangedCallbackDebug tests

Update the GetOverlaySupport and SkipValidateDeprecatedTest
To use the interface vesion function

Test: atest VtsHalGraphicsComposer3_TargetTest
BUG: 267565265
Change-Id: I3f37f4ff5610f8e9e3dec299ed7c3f0c41a630d7
2023-03-20 18:16:57 +00:00
Chia-I Wu
7ca92515be Revert "graphics: improve preloading for IMapper default impl"
This reverts commit 6d189b71a2.

Reason for revert: b/273884219, beagle_x15

Change-Id: I9706fc46f9aedbeb4bbcff7ebcb45939bcd20680
2023-03-20 16:36:56 +00:00
Kriti Dang
5fcddd74f6 Fixing the HDR conversion aidls
Bug: 251168514
Test: atest VtsHalGraphicsComposer3_TargetTest
Change-Id: I10310dd26809bd546c41d3d16bebcba711e43a50
2023-03-07 14:36:03 +00:00
Ram Indani
47a31d9393 Merge "[VTS] change the bool to lambda" into udc-dev 2023-03-04 00:13:28 +00:00
ramindani
9151889d57 [VTS] change the bool to lambda
BUG: 202734676
Test: atest VtsHalGraphicsComposer3_TargetTest
Change-Id: I5611cd8a6cc23491621470d6457e2bfc859fde4e
2023-03-03 18:51:09 +00:00
Ram Indani
9a7999d1eb Merge "VTS for the Refresh rate callback debug enabled" into udc-dev 2023-03-03 05:24:09 +00:00
ramindani
9dd8c4882b VTS for the Refresh rate callback debug enabled
BUG: 202734676
Test: atest VtsHalGraphicsComposer3_TargetTest
with the patch of
Ibc80d66eae6b21c3cf84d35fa819e97ccc509ede

Change-Id: I02bdf061420fe12ef4548008d66bb73e8cd416e8
2023-03-03 03:29:02 +00:00
Chia-I Wu
34eece60f5 Merge "graphics: improve preloading for IMapper default impl" am: 960c33c599 am: 697fddee77 am: 227a9f4155
Original change: https://android-review.googlesource.com/c/platform/hardware/interfaces/+/2459229

Change-Id: Ic80d75ea9db96d5dce2dd86942bddbecb0c5cd74
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-02-28 21:06:57 +00:00
Chia-I Wu
6d189b71a2 graphics: improve preloading for IMapper default impl
When GraphicBufferMapper::preloadHal dlopens the default impl, make sure
the gralloc module is also dlopen'ed.

Bug: 269664560
Test: android.view.cts.PixelCopyTest#testVideoProducer on grunt

Change-Id: I57418338d5212fb9a2c1ea82eba63d855f69ff32
2023-02-27 14:19:12 -08:00
Dorin Drimus
08212492f8 Fix VtsHalGraphicsComposer3_TargetTest / GetOverlaySupport
Test case is for composer starting with version 2 API, but the test case doesn't check version, so it fails for version 1 API.

Bug: 267565265
Test: 1. Push VtsHalGraphicsComposer3_TargetTest to device
2. Run VtsHalGraphicsComposer3_TargetTest
Test Command:
chmod 777 data/VtsHalGraphicsComposer3_TargetTest
./data/VtsHalGraphicsComposer3_TargetTest

Change-Id: I7bf37061aba84dfdfea5fc9dda5a300a1e5ec680
(cherry picked from commit 7493bbc999)
Merged-In: I7bf37061aba84dfdfea5fc9dda5a300a1e5ec680
2023-02-24 09:24:16 +00:00
Alec Mouri
bedde5e845 Check the correct sysprop for P010 support for gralloc 3 and 4. am: 960c14db22
Original change: https://android-review.googlesource.com/c/platform/hardware/interfaces/+/2441523

Change-Id: I86b2df035255b94e8a682c1870efea0df450aec4
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-02-18 02:10:40 +00:00
Alec Mouri
960c14db22 Check the correct sysprop for P010 support for gralloc 3 and 4.
We need to check the first api level that the vendor shipped with.

Also check P010 support in the preamble of the relevant test rather than in allocate(), since otherwise either allocate() may incorrectly skip some tests or allocate() may succeed but with the wrong layout information.

Bug: 257442231
Test: VtsHalGraphicsMapperV4_0TargetTest
Change-Id: I00ae5aa01117704158c38f0689e91df99473e208
Merged-In: I00ae5aa01117704158c38f0689e91df99473e208
2023-02-16 23:16:14 +00:00
Alec Mouri
b9f8d25652 Merge "Check the correct sysprop for P010 support for gralloc 3 and 4." 2023-02-15 22:23:47 +00:00
Alec Mouri
78d76ea43f Check the correct sysprop for P010 support for gralloc 3 and 4.
We need to check the first api level that the vendor shipped with.

Also check P010 support in the preamble of the relevant test rather than in allocate(), since otherwise either allocate() may incorrectly skip some tests or allocate() may succeed but with the wrong layout information.

Bug: 257442231
Test: VtsHalGraphicsMapperV4_0TargetTest
Change-Id: I00ae5aa01117704158c38f0689e91df99473e208
2023-02-15 02:37:49 +00:00
Kriti Dang
376227694f Update setHdrConversionStrategy to return the preferredHdrOutput type
Bug: 268336382
Test: atest VtsHalGraphicsComposer3_TargetTest
Change-Id: I6ac912ac8a0329f4ea32acad657e44b473660c42
2023-02-14 18:10:16 +00:00
Ram Indani
f08f437e51 Merge changes from topic "hwc-rri"
* changes:
  [HWC3] VTS client updates for onRefreshRateChangedDebug callback And for setRefreshRateChangedCallbackDebugEnabled
  [HWC3] AIDL implementation for Refresh Rate Overlay indicator
2023-02-13 23:00:03 +00:00
ramindani
8345034b53 [HWC3] VTS client updates for onRefreshRateChangedDebug callback
And for setRefreshRateChangedCallbackDebugEnabled

This does not add any implementation for the VTS code.
Implementation will be added with the VTS tests as a followup.

Test: Device boots
BUG: 202734676
Change-Id: If47bbcf87698b346907b3bc1903908ff0a63203f
2023-02-10 14:27:09 -08:00
ramindani
ff0da0bb24 [HWC3] AIDL implementation for Refresh Rate Overlay indicator
Adds IComposerClient method to inform that the Refresh Rate callback is enabled.
Adds IComposerCallback to get the display vsyncPeriod for the Overlay.
Adds Composition type REFRESH_RATE_INDICATOR

Test: Device boots
BUG: 202734676
Change-Id: I48b0c05f49095b15cea444dc5c3ad8f78a043cb0
2023-02-10 09:25:47 -08:00
Sally Qi
2b4ceb6365 Add exception annotation to getOverlaySupport api.
Bug: 268246323
Test: builds
Change-Id: I1979fed444a9fd3d94af729112fff070beb01439
2023-02-08 12:59:54 -08:00
Yi Kong
0214404f6e Fix compiler warning discovered by clang-r484482 am: 07448c2929 am: ba993e51e8 am: 661d9018c7
Original change: https://android-review.googlesource.com/c/platform/hardware/interfaces/+/2402792

Change-Id: I195de8f952c0b9091e4e57d64535e4e2014f3fb5
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-01-25 20:10:23 +00:00
Yi Kong
07448c2929 Fix compiler warning discovered by clang-r484482
external/googletest/googletest/include/gtest/gtest.h:1545:11: error: invalid operands to binary expression ('const std::vector<unsigned char>' and 'const android::hardware::hidl_vec<unsigned char>') [clang-diagnostic-error]
  if (lhs == rhs) {
      ~~~ ^  ~~~

Test: presubmit
Change-Id: Iabe98a58d5dc5b9943c38240da2d8df6ac61fb7f
2023-01-26 01:23:03 +09:00
Sally Qi
a0545e3057 Merge "[Aidl graphics API] split dataspace array into tuples." 2023-01-24 16:34:02 +00:00
Devika Krishnadas
e794f8f5e4 Merge "gralloc4-vts: Remove assert for sizeInBits for RAW formats" 2023-01-20 20:57:09 +00:00
Treehugger Robot
7603d62a20 Merge "Drop <name>I</name> from mapper HAL." am: d2bbda8b32 am: 116ddaf033 am: 81f4ddd0c5
Original change: https://android-review.googlesource.com/c/platform/hardware/interfaces/+/2392038

Change-Id: Ieb1ffe7a2a24c93b6696acd9d9c178475b826aef
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-01-20 18:54:25 +00:00
Treehugger Robot
d2bbda8b32 Merge "Drop <name>I</name> from mapper HAL." 2023-01-20 17:10:47 +00:00
Sally Qi
c2c392fbea [Aidl graphics API] split dataspace array into tuples.
- update VTS test to make sure primaries/transfers/ranges bits are
  correct.

Bug: 242588489
Test: build and flash; atest VtsHalGraphicsComposer3_TargetTest

Change-Id: I77536d97b98e4dead208b7c8aeed9cfbb0d82316
2023-01-19 15:50:17 -08:00
Brian Lindahl
348bc9d779 Merge changes from topic "revert-uncache-hal-buffers-vts"
* changes:
  Revert "Add VTS test for clearing buffer slots to Composer HIDL and AIDL"
  Revert "Add VTS readback tests for buffer slot clearing"
  Revert "Add VTS for new API for clearing buffer slots"
2023-01-19 20:53:54 +00:00
Brian Lindahl
14bd07b195 Revert "Add VTS test for clearing buffer slots to Composer HIDL and AIDL"
This reverts commit ca3eef29b0.

NOTE: This is not a full revert, it leaves the production code in place and only reverts the VTS test changes.

Reason for revert: b/262370410

Test: atest VtsHalGraphicsComposerV2_1TargetTest on Oriole
Test: atest VtsHalGraphicsComposerV2_2TargetTest on Oriole
Test: atest VtsHalGraphicsComposerV2_3TargetTest on Oriole
Test: atest VtsHalGraphicsComposerV2_4TargetTest on Oriole
Bug: 262370410
Change-Id: Ie5ba7402cda2828ba33131d527ab0c3a66937648
2023-01-18 21:18:55 +00:00
Brian Lindahl
e887a25203 Revert "Add VTS readback tests for buffer slot clearing"
This reverts commit d103cd6828.

NOTE: This is not a full revert, it leaves the production code in place and only reverts the VTS test changes.

Reason for revert: b/262370410

Test: atest VtsHalGraphicsComposerV2_1TargetTest on Oriole
Test: atest VtsHalGraphicsComposerV2_2TargetTest on Oriole
Test: atest VtsHalGraphicsComposerV2_3TargetTest on Oriole
Test: atest VtsHalGraphicsComposerV2_4TargetTest on Oriole
Bug: 262370410
Change-Id: I336beb9f0ed81b305b26c6d8e9da70cfabe04bbd
2023-01-18 21:18:21 +00:00
Brian Lindahl
952057044b Revert "Add VTS for new API for clearing buffer slots"
This reverts commit 78ff2d6491.

NOTE: This is not a full revert, it leaves the production code in place and only reverts the VTS test changes.

Reason for revert: b/262370410

Test: atest VtsHalGraphicsComposerV2_1TargetTest on Oriole
Test: atest VtsHalGraphicsComposerV2_2TargetTest on Oriole
Test: atest VtsHalGraphicsComposerV2_3TargetTest on Oriole
Test: atest VtsHalGraphicsComposerV2_4TargetTest on Oriole
Bug: 262370410
Change-Id: Ica725cfaae6e2a08ed9c53eb9f17d6db1656bc93
2023-01-18 21:16:20 +00:00