Commit graph

449 commits

Author SHA1 Message Date
Roman Kiryanov
46ca02f425 Merge "(reland) Link libqemu_pipe into a.h.a.vehicle@2.0-default-impl-lib" 2020-12-10 04:15:58 +00:00
Roman Kiryanov
ecb6fb64a9 (reland) Link libqemu_pipe into a.h.a.vehicle@2.0-default-impl-lib
libqemu_pipe is an implementation detail in
android.hardware.automotive.vehicle@2.0-default-impl-lib
and not exposed to the outside.

Bug: 175046060
Bug: 154348162
Test: m android.hardware.automotive.vehicle@2.0-virtualization-service
Signed-off-by: Roman Kiryanov <rkir@google.com>
Change-Id: I769da5d707e378ce212b9957ea5c116b08eae382
2020-12-09 12:27:27 -08:00
Roman Kiryanov
936f30e611 Merge "Revert "Link libqemu_pipe into a.h.a.vehicle@2.0-default-impl-lib"" am: b22fba9f02
Original change: https://android-review.googlesource.com/c/platform/hardware/interfaces/+/1520552

MUST ONLY BE SUBMITTED BY AUTOMERGER

Change-Id: Ic02f901a685892c62beef6df0e4775e4723d2b3e
2020-12-09 02:14:46 +00:00
Roman Kiryanov
d03966ab30 Revert "Link libqemu_pipe into a.h.a.vehicle@2.0-default-impl-lib"
Revert "Remove dependency on libqemu_pipe"

Revert submission 1518674-car-no-qemu-pipe

Reason for revert: b/175157953
Reverted Changes:
Iac833becd:Remove dependency on libqemu_pipe
I00de16c55:Link libqemu_pipe into a.h.a.vehicle@2.0-default-i...

Change-Id: Icd5d21576479fd250e95955222ebca20e665bb3f
2020-12-09 00:39:45 +00:00
Treehugger Robot
5d2db50930 Merge "Link libqemu_pipe into a.h.a.vehicle@2.0-default-impl-lib" am: b2670c6f88
Original change: https://android-review.googlesource.com/c/platform/hardware/interfaces/+/1518674

MUST ONLY BE SUBMITTED BY AUTOMERGER

Change-Id: I4c02424f46053d8dc85f6592669344ec1a81f062
2020-12-08 23:33:58 +00:00
Roman Kiryanov
aa5e7bcd13 Link libqemu_pipe into a.h.a.vehicle@2.0-default-impl-lib
libqemu_pipe is an implementation detail in
android.hardware.automotive.vehicle@2.0-default-impl-lib.

libqemu_pipe module will be replaced with one
from device/generic/goldfish.

Bug: 175046060
Test: m android.hardware.automotive.vehicle@2.0-virtualization-service
Signed-off-by: Roman Kiryanov <rkir@google.com>
Change-Id: I00de16c55797e3aaf650aee6d0ec400fd12c2de2
2020-12-07 14:15:42 -08:00
Lakshman Annadorai
fd45e7404b Remove MIN and MAX checking for hidl_enum in UserHalHelper native library. am: bfaf79c9c6
Original change: https://googleplex-android-review.googlesource.com/c/platform/hardware/interfaces/+/12663093

Change-Id: Icf2fa91a0bf466ce93c4b8365773801c8d7c9755
2020-09-25 05:24:55 +00:00
Lakshman Annadorai
bfaf79c9c6 Remove MIN and MAX checking for hidl_enum in UserHalHelper native library.
VehiclePropValue enums is not sorted by their values. Thus obtaining MIN and MAX values for this enum is O(N), which is the same as looping through all the values and checking whether a given int32_t is in the enum.

Test: Tested with `atest -c android.hardware.automotive.vehicle@2.0-utils-unit-tests`.
Bug: 168249409

Change-Id: I296a56e31caa7a5ee69eac49806810f83e46571e
(cherry picked from commit b7d50b91eb)
2020-09-22 21:54:42 +00:00
Kai Wang
551b891e9e Merge "Add configArray for Gear_Selection in google VHAL" into rvc-qpr-dev am: f10a9af711
Original change: https://googleplex-android-review.googlesource.com/c/platform/hardware/interfaces/+/12600691

Change-Id: I8380ebf6cd987728cc52e8803b4c123b89a204cd
2020-09-22 02:40:01 +00:00
Kai Wang
f10a9af711 Merge "Add configArray for Gear_Selection in google VHAL" into rvc-qpr-dev 2020-09-22 01:50:03 +00:00
Eric Jeong
d0d568fa21 Return immediately when prop is not found am: 3648ac967a
Original change: https://googleplex-android-review.googlesource.com/c/platform/hardware/interfaces/+/12640905

Change-Id: Ie6c4d68b6edcc9a9be54aa37044ad81a0cb28467
2020-09-18 23:40:04 +00:00
Eric Jeong
3648ac967a Return immediately when prop is not found
- when VHAL prop is not supported, getPropConfigs calls hidl callback
with INVALID_ARG and has to return.
- otherwise, there will be two callbacks invoked from VHAL.

Bug: 168834308
Test: seahawk should boot up
Change-Id: I41f5ddf26b9ba70221d59bae10d7ca9a2133a9eb
Merged-In: I41f5ddf26b9ba70221d59bae10d7ca9a2133a9eb
(cherry picked from commit 26abceefbe)
2020-09-18 16:13:41 -07:00
Kai
b1aa30c3c1 Add configArray for Gear_Selection in google VHAL
ConfigArray in Gear_Selection indicates the supported Gear

Bug: 165942804
Test: build and check value in emulator
Change-Id: I4567031a072edda550b671bc190934d24d5b5eba
(cherry picked from commit a3b16c2d8e)
2020-09-15 20:35:56 +00:00
Lakshman Annadorai
8eb03223e9 Update EmulatedUserHal to use UserHalHelper native library.
Bug: 150409377
Fixes: 167588307
Test: Tested using lshal commands in go/user-hal-emulation.

Change-Id: I79486a715c92111d3d6f5c011b7e1cd8c5501c25
Merged-In: I4ba2202e28ef9260b38ebbf21083d55d7aa07fc9
(cherry picked from commit 92ad8215e7)
2020-09-15 02:54:35 +00:00
felipeal
5d40b783d1 Fixed EmulatedUserHal so it supports SwitchUserMessageType::VEHICLE_REQUEST
Test: adb shell lshal debug android.hardware.automotive.vehicle@2.0::IVehicle/default --set 299896584 a 1 i -42 i 4 i 11
Fixes: 161574356
Bug: 167588307

Change-Id: Iaf5d8e35f556c72350cdb9b6665adb31fca26871
Merged-In: Iaf5d8e35f556c72350cdb9b6665adb31fca26871
(cherry picked from commit 3e9d442fa1)
2020-09-11 17:43:34 +00:00
Lakshman Annadorai
3568c5c3b7 Add a native UserHalHelper library.
This library contains helper functions to convert the User HAL reponse
structs to VehiclePropValues and request VehiclePropValues to HAL
structs.

Test: atest android.hardware.automotive.vehicle@2.0-utils-unit-tests
Bug: 150409377
Bug: 167588307

Change-Id: I978b39e2f3ee58eb3b154f507c714ca1ba2d1e3b
Merged-In: I978b39e2f3ee58eb3b154f507c714ca1ba2d1e3b
(cherry picked from commit b33e2abbfe)
2020-09-11 16:06:42 +00:00
TreeHugger Robot
76907bbf13 Merge "Add INFO_MODEL and INFO_MODEL_YEAR default values" into rvc-qpr-dev am: 0e2072ce4b
Original change: https://googleplex-android-review.googlesource.com/c/platform/hardware/interfaces/+/12371555

Change-Id: Id7365f87e72e454c7e6808369eee0a17de72435c
2020-08-19 21:21:51 +00:00
TreeHugger Robot
0e2072ce4b Merge "Add INFO_MODEL and INFO_MODEL_YEAR default values" into rvc-qpr-dev 2020-08-19 21:03:56 +00:00
TreeHugger Robot
182b84b23e Merge "Update EmulatedUserHal to use UserHalHelper native library." into rvc-qpr-dev am: da9014f5e0
Original change: https://googleplex-android-review.googlesource.com/c/platform/hardware/interfaces/+/12317659

Change-Id: Ibb70112d7bbd06927b05498de9dc368b08c34e97
2020-08-18 23:40:38 +00:00
Lakshman Annadorai
92ad8215e7 Update EmulatedUserHal to use UserHalHelper native library.
Bug: 150409377
Test: Tested using lshal commands in go/user-hal-emulation.

Change-Id: I79486a715c92111d3d6f5c011b7e1cd8c5501c25
Merged-In: I4ba2202e28ef9260b38ebbf21083d55d7aa07fc9
2020-08-18 22:30:38 +00:00
Jordan Jozwiak
590607780a Add INFO_MODEL and INFO_MODEL_YEAR default values
Bug: 162611157
Test: adb shell cmd car_service get-carpropertyconfig | grep MODEL
Change-Id: Iff9f763aa624a2002b0dd326316410a93a47d5c0
Merged-In: Iff9f763aa624a2002b0dd326316410a93a47d5c0
(cherry picked from commit 5aa08b7d59)
2020-08-13 16:47:44 +00:00
TreeHugger Robot
3c9fc82e34 Merge "Add a native UserHalHelper library." into rvc-qpr-dev am: d155658f1e
Original change: https://googleplex-android-review.googlesource.com/c/platform/hardware/interfaces/+/12240869

Change-Id: Ic14bd12a654ac73bea9cd2772e9f7a372dda94e7
2020-08-06 16:58:54 +00:00
TreeHugger Robot
d155658f1e Merge "Add a native UserHalHelper library." into rvc-qpr-dev 2020-07-31 17:20:19 +00:00
Lakshman Annadorai
b33e2abbfe Add a native UserHalHelper library.
This library contains helper functions to convert the User HAL reponse
structs to VehiclePropValues and request VehiclePropValues to HAL
structs.

Test: Tested with unit tests.
Bug: 150409377

Change-Id: I978b39e2f3ee58eb3b154f507c714ca1ba2d1e3b
2020-07-30 15:15:32 -07:00
TreeHugger Robot
8de72df496 Merge "Fixed EmulatedUserHal so it supports SwitchUserMessageType::VEHICLE_REQUEST" into rvc-qpr-dev am: 6e5eedbfef
Original change: https://googleplex-android-review.googlesource.com/c/platform/hardware/interfaces/+/12182996

Change-Id: Ic801c82c89df1858a073f7caeffafbce1825c9fc
2020-07-20 19:44:56 +00:00
TreeHugger Robot
6e5eedbfef Merge "Fixed EmulatedUserHal so it supports SwitchUserMessageType::VEHICLE_REQUEST" into rvc-qpr-dev 2020-07-20 19:29:15 +00:00
felipeal
5b46a339d0 Fixed EmulatedUserHal merge issues.
Some changes were not properly auto-merged, and it's quite impossible to
cherry-pick them automatically (using git), so this CL is manually fixing
it.

Test: adb shell lshal debug android.hardware.automotive.vehic
le@2.0::IVehicle/default --user-hal

Bug: 150413515

Change-Id: Ibb8bef2c1ae8df32369dff5c5e5de76480b3a66f
Merged-In: I5c8b99b8027b5ec10ace323d872cd85f9a0d4177
2020-07-18 02:12:23 +00:00
felipeal
3e9d442fa1 Fixed EmulatedUserHal so it supports SwitchUserMessageType::VEHICLE_REQUEST
Test: adb shell lshal debug android.hardware.automotive.vehicle@2.0::IVehicle/default --set 299896584 a 1 i -42 i 4 i 11
Fixes:  161574356

Change-Id: Iaf5d8e35f556c72350cdb9b6665adb31fca26871
2020-07-17 18:25:08 -07:00
Jooyung Han
d18cba85fe update hidl .bp
HIDL libs are not necessarily part of VNDK now. Because some are
used by VNDK libs, they are still VNDK. But rest are now just
vendor-available.

.hidl_for_test files are also removed because they are used to exclude
test-purpose hidl libs from VNDK libs.

Instead, .hidl_for_system_ext files are added to tests/lazy to
distinguish them from others which are installed /system.

Bug: 143933769
Test: update-makefiles.sh && m com.android.vndk.current
Merged-In: Ia81312dda340b6b5cbdd7a3c21e1d323bda39a4a
Change-Id: Ia81312dda340b6b5cbdd7a3c21e1d323bda39a4a
(cherry picked from commit b0907a6bb8)
2020-07-02 12:26:37 +09:00
TreeHugger Robot
59b6c890c2 Merge "Yet more minor fixes on User HAL:" into rvc-dev am: f04be179a7
Original change: https://googleplex-android-review.googlesource.com/c/platform/hardware/interfaces/+/12000988

Change-Id: I4d99cb1d89ca49f493798eede6e0afcaf59360c0
2020-06-30 01:16:00 +00:00
TreeHugger Robot
f04be179a7 Merge "Yet more minor fixes on User HAL:" into rvc-dev 2020-06-30 01:09:22 +00:00
felipeal
bc366009a6 Yet more minor fixes on User HAL:
- Minor fixes on docs.
- Switched order of String fields on InitialUserInfoResponse to be consistent
  with doc.

Test: $ANDROID_BUILD_TOP/development/vndk/tools/header-checker/utils/create_reference_dumps.py  -l android.hardware.automotive.vehicle@2.0
Bug: 159856152

Change-Id: I7b05a64fcea7512101436df7c93a3204274a4d6b
2020-06-25 18:47:42 -07:00
felipeal
1972df27b9 Fixed EmulatedUserHal::get(USER_IDENTIFICATION_ASSOCIATION).
It must set the requestId in the response.

Test: adb shell lshal debug android.hardware.automotive.vehicle@2.0::IVehicle/default --set 299896587 a 1 i 666 i 1 i 1 i 2 && \
      adb shell cmd car_service get-user-auth-association --hal-only KEY_FOB
Fixes: 159497444
Bug: 159498909

Change-Id: Ib3f87b45714883c3e5b72464813df24ec4124dbb
2020-06-22 16:06:19 -07:00
TreeHugger Robot
2334a510a5 Merge "Added DISABLED flag to users flag for HAL" into rvc-dev am: 110f2bef7f
Original change: https://googleplex-android-review.googlesource.com/c/platform/hardware/interfaces/+/11870725

Change-Id: I920005003ba19b99a68a56bc118c0e3cd2bc0455
2020-06-19 01:57:51 +00:00
TreeHugger Robot
110f2bef7f Merge "Added DISABLED flag to users flag for HAL" into rvc-dev 2020-06-19 01:42:15 +00:00
Hao Chen
76b49a0c55 Merge "Add server library build rules for both host and target" into rvc-dev am: c539468f28
Original change: https://googleplex-android-review.googlesource.com/c/platform/hardware/interfaces/+/11889122

Change-Id: I429282c294294d86eab6db701b901b899d7f0e19
2020-06-18 22:16:19 +00:00
Hao Chen
c324db992e Add server library build rules for both host and target
Bug: 157603385
Test: build and create Acloud local instance
Change-Id: I80951eb4192360c62a5f72902d20e2dee84d97ad
2020-06-17 14:14:12 -07:00
Mayank Garg
ffb1ffdd0e Added DISABLED flag to users flag for HAL
Bug: 158681378
Test: m (successful build)
Change-Id: I46af767c2cb4716bfbe45f51f59f9c670d6c0a0b
2020-06-16 12:07:24 -07:00
TreeHugger Robot
5ba48ac055 Merge "Fixed EmulatedUserHal so it doesn't reply to a LEGECY_ANDROID_LEGACY request." into rvc-dev am: d5a237964f
Original change: https://googleplex-android-review.googlesource.com/c/platform/hardware/interfaces/+/11764584

Change-Id: I362b3966717e7d41cbad820347691b07ef30d7be
2020-06-10 20:49:57 +00:00
TreeHugger Robot
d5a237964f Merge "Fixed EmulatedUserHal so it doesn't reply to a LEGECY_ANDROID_LEGACY request." into rvc-dev 2020-06-10 20:35:19 +00:00
TreeHugger Robot
4ba2b85a44 Merge "Clarified that USER_IDENTIFICATION_ASSOCIATION is optional." into rvc-dev am: b35c0cd494
Original change: https://googleplex-android-review.googlesource.com/c/platform/hardware/interfaces/+/11796048

Change-Id: I92e72ed9642f3a351729dd015ac17fc5a25341b0
2020-06-08 21:47:55 +00:00
felipeal
04b84ed8b2 Clarified that USER_IDENTIFICATION_ASSOCIATION is optional.
Test: none
Bug: 157938045

Change-Id: Ie010a0452ce545457ff06223ebfe24cf6522f04a
2020-06-08 12:11:41 -07:00
felipeal
7a3d7c96fc Fixed EmulatedUserHal so it doesn't reply to a LEGECY_ANDROID_LEGACY request.
Bug: 158336360
Test: m -j android.hardware.automotive.vehicle@2.0-service && adb push $OUT/vendor/bin/hw/android.hardware.automotive.vehicle@2.0-service /vendor/bin/hw/ && adb shell kill `pid android.hardware.automotive.vehicle`

Change-Id: I0b506ba5a4b53ada94bc4afc081d3e4222f5e92d
2020-06-08 12:06:16 -07:00
felipeal
d1803412f6 Implemented CREATE_USER and REMOVE_USER on VHAL reference implementation.
Test: adb shell lshal debug android.hardware.automotive.vehicle@2.0::IVehicle/default --set 299896585 a 1 i 666 i 1 && \
      adb shell lshal debug android.hardware.automotive.vehicle@2.0::IVehicle/default --user-hal

Bug: 150408921
Bug: 150409600

Change-Id: If971c262ecaba604f55582b3ef0a850410d82ff9
2020-05-28 14:47:02 -07:00
TreeHugger Robot
e1d802ae43 Merge "Added userLocales to InitialUserInfoResponse." into rvc-dev am: 38cbff9027
Change-Id: I7810b73ae561314328883b98374073806048b6e8
2020-05-20 02:12:33 +00:00
felipeal
26d9314911 Added userLocales to InitialUserInfoResponse.
Test: $ANDROID_BUILD_TOP/development/vndk/tools/header-checker/utils/create_reference_dumps.py  -l android.hardware.automotive.vehicle@2.0
Bug: 156611139

Change-Id: I0e296dc49f25087714e4dc1d6d4e302c63bedbc8
2020-05-19 17:06:40 -07:00
TreeHugger Robot
e4e9daae6b Merge "Implemented USER_IDENTIFICATION_ASSOCIATION on EmulatedUserHal." into rvc-dev 2020-05-13 19:29:47 +00:00
TreeHugger Robot
63d0cf3641 Merge "Minor clarificaton on USER_IDENTIFICATION_ASSOCIATION doc." into rvc-dev am: 501169a9fb
Change-Id: Ic5f0cb5f0ac5a48e1ce984958b1de0ab7c7d44df
2020-05-12 20:43:44 +00:00
TreeHugger Robot
501169a9fb Merge "Minor clarificaton on USER_IDENTIFICATION_ASSOCIATION doc." into rvc-dev 2020-05-12 17:05:45 +00:00
felipeal
5a944183d6 Implemented USER_IDENTIFICATION_ASSOCIATION on EmulatedUserHal.
Bug: 150409351

Test: adb shell lshal debug android.hardware.automotive.vehicle@2.0::IVehicle/default --set 299896587  a 1 i 666 i 1 i 101 i 2
Test: adb shell lshal debug android.hardware.automotive.vehicle@2.0::IVehicle/default --get 299896587

Change-Id: I4890ae5c0cea22bf024b1d7429449390237ab244
2020-05-08 19:04:40 -07:00