Add more information to the failure message: now it looks something like `Failed to get a callback for Display 0 switching from {Config 38: vsyncPeriod 4166666, minFrameIntervalNs 16666667} to {Config 37: vsyncPeriod 8333333, minFrameIntervalNs 8333333}` instead of `failed to get a callback for the display 0 with config 37`
Test: atest VtsHalGraphicsComposer3_TargetTest:PerInstance/GraphicsComposerAidlCommandV2Test#SetRefreshRateChangedCallbackDebugEnabled_SetActiveConfigWithConstraints/0_android_hardware_graphics_composer3_IComposer_default
Bug: 340971724
Change-Id: Id2a1030a9b12e86bda8f6031e79a8374227f4061
This appears to have been broken with
Ic3c0415612b1387671ab8efa0ec95ed727f6bf68, which attempts to destroy
layers for all displays using a single writer. The display command that
destroys a layer must be in the writer for that display, in order for
the displays to run independently. Do so in the test itself, rather than
relying on TearDown to destroy all of them.
Bug: 333974982
Test: atest VtsHalGraphicsComposer3_TargetTest
Flag: TEST_ONLY
Change-Id: Ib6807c85bc6cb32c56cc72126a9fa68363365912
With different VRR modes we may have 2 modes with
exactly the same minFrameIntervalNs, and in this case we can't
differentiate between 2 modes.
Test: atest VtsHalGraphicsComposer3_TargetTest
BUG: 328350178
Change-Id: I5cddfee8b789ed6ce1b223ec345175f19a0db091
Some HWC implementations which do not support DISPLAY_DECORATION are
handling DISPLAY_DECORATION layers in VTS by reporting an error (as
required by the test) AND by proposing ChangedCompositionTypes. The
latter is unnecessary, as SF will never read the changed types. Update
the documentation to be more specific that this is unnecessary.
Bug: b/324977561
Bug: b/329119344
Bug: b/329017438
Bug: b/327322951
Bug: b/327090469
Test: GraphicsComposerAidlCommandTest#DisplayDecoration
Change-Id: I09c90e40818dc43b968c3e79e61e8b13a13e6344
As of VNDK deprecation, any libraries that defines vndk is no longer
valid anymore. This change removes all VNDK definition(s) from modules
which was VNDK. Any former VNDK-SP libraries will be marked as double-loadable,
so it can keep be able to be referenced by LLNDK libraries.
Bug: 328994089
Test: AOSP CF build succeeded
Change-Id: Ic4f19113c1a25dc1fb60cdfbf9c0f2d8d7d09726
Ignore-AOSP-First: Merge conflict
- add sRGB and DisplayP3 layers in HWC, if mixedColorSpaces is
supported, only DPU composition happens.
Bug: 311252937
Test: this
Change-Id: I400a6dd18a05bbdf69e249907e13a4fa7eafbf01
Includes VTS for notifyExpectedPresent call,
frameRate change in the present call and
notifyExpectedPresent after timeout.
Test: atest VtsHalGraphicsComposer3_TargetTest
BUG: 291792736
Change-Id: I1ef7011d7dcbdd6bb378b80ca0b0d7cd52832897
I6c436b6b80b27930d82aabf22107216172773b56 adds a dependency for
librenderengine on flags. Add that dependency so we can use
librenderengine here, too.
Bug: 305445199
Test: atest VtsHalGraphicsComposerV2_2TargetTest
Test: atest VtsHalGraphicsComposer3_TargetTest
Change-Id: If339ac94a6eff4af34e60cf1c1135289b8915441
This CL is created as a best effort to migrate test targets
to the new android ownership model. If you find incorrect or unnecessary
attribution in this CL, please create a separate CL to fix that.
For more details please refer to the link below,
<add g3 doc link>
Bug: 304529413
Test: N/A
Change-Id: I3322344f595f974f730dc824af0110388076d838
Fixing a bug that caused Teardown to clear the errors before
checking them
Bug: 303735490
Test: presubmit
Change-Id: Ieb02ab3015fc21bcef6624f8f45c3b84549005c2
When the tests fail, ensure we continue running so we can run the
remainder of the tests.
Bug: 304976052
Test: atest GraphicsComposerAidlCommandTest
Change-Id: Ia6ab2bbd284bb7eddeb49164dcbe7285829ad9c3
Ensure the primary display to set power on before running
getClientTargetSupport tests for VTS 2.1 - 2.3.
Bug: 308252481
Test: atest VtsHalGraphicsComposerV2_1TargetTest
Test: atest VtsHalGraphicsComposerV2_2TargetTest
Test: atest VtsHalGraphicsComposerV2_3TargetTest
Change-Id: I6b793537ee42c87f37c4c1d7141364541f448134
Update the timeoutNs description to specify what 0 and not absent value
expected behavior is
BUG: 294102485
Test: VTS
Change-Id: I3954c8f1efad8190ed6d608e2968fe1dc15c2f11
Ensure the primary display power on before run the
SetDisplayBrightness test item.
Bug: 313794734
Test: atest VtsHalGraphicsComposer3_TargetTest:PerInstance/
GraphicsComposerAidlCommandTest#SetDisplayBrightness/
0_android_hardware_graphics_composer3_IComposer_default
-- --abi arm64-v8a
Change-Id: I94fb700704bcbd8543f2a608dd75b9e745e40e37
Merged-In: I94fb700704bcbd8543f2a608dd75b9e745e40e37
Ensure the primary display power on before run the
SetDisplayBrightness test item.
Bug: 313794734
Test: atest VtsHalGraphicsComposer3_TargetTest:PerInstance/
GraphicsComposerAidlCommandTest#SetDisplayBrightness/
0_android_hardware_graphics_composer3_IComposer_default
-- --abi arm64-v8a
Change-Id: I94fb700704bcbd8543f2a608dd75b9e745e40e37
* changes:
[Composer3-VTS] Test Composer3-V3 for refreshPeriodNanos and vsyncPeriodNanos
[HWC3] AIDL change to add refreshPeriodNanos to RefreshRateChangedDebugData
This CL adds the new aidl/apis for HWC command batching feature.
Bug: 290685621
Test: atest VtsHalGraphicsComposer3_TargetTest
atest PerInstance/GraphicsComposerAidlBatchedCommandTest
Change-Id: Ibccc2cb30954f5d054f8e45e59a0b831fd15a304
This CL adds the new aidl/apis for HWC command batching feature.
Bug: 290685621
Test: atest VtsHalGraphicsComposer3_TargetTest
atest PerInstance/GraphicsComposerAidlBatchedCommandTest
Change-Id: I9e8a8afefb03e04a4cd4d8db36d72e29d30e975f
IIUC, oneway makes the callback a non-blocking call. Hwcomposer
implementations are expected to call onHotplug/onHotplugEvent during
the initial hwcomposer->registerCallback(). However, a oneway callback
would not block and cause the hwcomposer's implementation of
registerCallback() to return immediately. Example log:
11-30 23:32:32.962 508 508 E RanchuHwc: registerCallback
11-30 23:32:32.962 508 508 E RanchuHwc: registerCallback:
display:0
11-30 23:32:32.962 508 508 E RanchuHwc: setCallbacks for display:0
11-30 23:32:32.962 508 508 E RanchuHwc: registerCallback:
display:1
11-30 23:32:32.962 508 508 E RanchuHwc: setCallbacks for display:1
11-30 23:32:32.962 508 508 E RanchuHwc: registerCallback initial
registration, hotplug connecting display:0
11-30 23:32:32.962 508 508 E RanchuHwc: registerCallback initial
registration, hotplug connecting display:1
11-30 23:32:32.962 572 592 E SurfaceFlinger: jasonjason
SurfaceFlinger::onComposerHalHotplugEvent()
11-30 23:32:32.962 572 572 F SurfaceFlinger: Initial display
configuration failed: HWC did not hotplug
11-30 23:32:32.962 572 592 E SurfaceFlinger: jasonjason SurfaceFlinger::onComposerHalHotplugEvent()
<SurfaceFlinger aborts from the Fatal "HWC did not hotplug">
Bug: b/314208907
Test: Launch Cuttlefish with ag/25521493 then
vts -m VtsHalGraphicsComposer3_TargetTest
Change-Id: Ibfea0b21e1d4c8b0de17bbe25dc55483050700b7
Introduce the concept of hdrSdrRatio for ClientTargets, so that:
* 1.0 is treated as SDR luminance
* hdrSdrRatio is provided to scale the content into display luminance
range during composition. That is, 1.0 maps to SDR max, and
hdrSdrRatio maps to display max luminance
Bug: 236745178
Test: builds
Change-Id: Id82a102eaca82f85bf3982538786dd2ae6cb8e61
When a display is connected, error may occur, this new api introduces
an event variable to specify the hotplug event, including errors.
This new api should be used, and the old onHotplug method is deprecated.
Bug: 241286153
Test: manual
Change-Id: I20ea685c5012015836024e7cab4dc0e68ebb835f
Originally landed as I5dbb01fc23abd5e0108c565f96d25e62c77fc16d and
previously reverted in I6265f8de3db31f07506906cee82a91fe3baac0bc due to
timeline constraints.
Add a test presenting from multiple threads. Split up execute() so that
it can be called for a single display. Update MultiThreadedPresent
(test) to offload presentDisplay to a separate thread, similar to how
Ib9d074671e32c95875ef7e0791dd95d6e595e47a does it, as described in
go/multi-threaded-present.
Bug: 259132483
Bug: 284156408
Fixes: 251842321
Fixes: 295841597
Test: VtsHalGraphicsComposer3_TargetTest
Change-Id: If975ee9bb0b9c6f64ef50401e2aee32f934e3f08
We deliberately use a deprecated API to test that it is not used. Ignore
warnings from using it in this test.
In PresentDisplayNoLayerStateChanges, remove the check for
SKIP_VALIDATE, removing the other warning. As written, the test would be
skipped without SKIP_VALIDATE support. But devices should *not* claim
Capability::SKIP_VALIDATE, meaning the test would always be skipped. The
docs state that the behavior previously indicated by SKIP_VALIDATE is
now the default, so we should always be running the test.
Bug: NA
Test: atest VtsHalGraphicsComposer3_TargetTest (no warnings)
Change-Id: Icc89a82b4850428c2f0940be0f78f5ebff1881b3
Right now this only makes sure that extended sRGB buffers aren't
corrupted by the time it hits the display. This is especially important
for Ultra HDR, because display compensation is defined by the spec.
Bug: 276331687
Bug: 259144781
Test: VtsHalGraphicsComposer3_ReadbackTest
Change-Id: Ib6c39858289d5559ae76280ca1a0ef756f2daef0
