Commit graph

53996 commits

Author SHA1 Message Date
Eric Biggers
1832038ebb Simplify Weaver VTS test am: 42d76ae5df am: cf54aa6cea
Original change: https://googleplex-android-review.googlesource.com/c/platform/hardware/interfaces/+/24151462

Change-Id: I38fbda1101471d45126e9e8e5351f8d46f9a051f
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-07-25 20:02:13 +00:00
Eric Biggers
b36abd4c33 Remove redundant HIDL Weaver VTS test am: c9691dd624 am: 8494e310c8
Original change: https://googleplex-android-review.googlesource.com/c/platform/hardware/interfaces/+/24151461

Change-Id: I2ce8c7ba4f0240d545b84d6da59e643acfd26729
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-07-25 20:02:11 +00:00
Eric Biggers
75fb598bab Move VtsHalWeaverTargetTest to common directory am: a8fc1ea054 am: afcbc88882
Original change: https://googleplex-android-review.googlesource.com/c/platform/hardware/interfaces/+/24151460

Change-Id: Ic83f073f014b224c3a982868700fe785c0b8287c
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-07-25 20:02:09 +00:00
Eric Biggers
f2e902fbb3 Make VtsHalWeaverTargetTest test both HIDL and AIDL services am: 1cd59722b6 am: 96981af109
Original change: https://googleplex-android-review.googlesource.com/c/platform/hardware/interfaces/+/24151459

Change-Id: I063fb2ab00025194f63dcd7a2389fbcfca9f3b4e
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-07-25 20:02:06 +00:00
Eric Biggers
c614b58117 Update OWNERS for Weaver am: 0ddd5410e3 am: 3e021bb669
Original change: https://googleplex-android-review.googlesource.com/c/platform/hardware/interfaces/+/24151458

Change-Id: I25e35e8cdd22885a565e034152695bd7336b1bcc
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-07-25 20:02:04 +00:00
Eric Biggers
df736dd151 Merge changes from topic "weaver-vts-fix" into stage-aosp-udc-ts-dev am: ea6fdd2621
Original change: https://googleplex-android-review.googlesource.com/c/platform/hardware/interfaces/+/24180062

Change-Id: I1c41242a383410de0d4ab9aaaa5986d3a6ff89b5
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-07-25 18:55:46 +00:00
Eric Biggers
48325db6c8 Don't overwrite in-use Weaver slots during VTS am: 86b9048544
Original change: https://googleplex-android-review.googlesource.com/c/platform/hardware/interfaces/+/24151703

Change-Id: If753a9fca87239f5401cb66c61a44f09bc5e89d3
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-07-25 18:55:43 +00:00
Eric Biggers
cf54aa6cea Simplify Weaver VTS test am: 42d76ae5df
Original change: https://googleplex-android-review.googlesource.com/c/platform/hardware/interfaces/+/24151462

Change-Id: I8fc0e83da74a793880b4fec72102df7773e0e65f
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-07-25 18:55:41 +00:00
Eric Biggers
8494e310c8 Remove redundant HIDL Weaver VTS test am: c9691dd624
Original change: https://googleplex-android-review.googlesource.com/c/platform/hardware/interfaces/+/24151461

Change-Id: I85f9d3bd3d9e085dff88be1e22c8706ec78ffc1f
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-07-25 18:55:38 +00:00
Eric Biggers
afcbc88882 Move VtsHalWeaverTargetTest to common directory am: a8fc1ea054
Original change: https://googleplex-android-review.googlesource.com/c/platform/hardware/interfaces/+/24151460

Change-Id: Icbccd572741e27371b017f0deb86dbaa63d1ddc3
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-07-25 18:55:35 +00:00
Eric Biggers
96981af109 Make VtsHalWeaverTargetTest test both HIDL and AIDL services am: 1cd59722b6
Original change: https://googleplex-android-review.googlesource.com/c/platform/hardware/interfaces/+/24151459

Change-Id: I426137ec9c1dd33354ff91bb6e884660bd5987bf
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-07-25 18:55:32 +00:00
Eric Biggers
3e021bb669 Update OWNERS for Weaver am: 0ddd5410e3
Original change: https://googleplex-android-review.googlesource.com/c/platform/hardware/interfaces/+/24151458

Change-Id: I31104ec22d1a747b78687fbaf184033220e5c7a0
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-07-25 18:55:29 +00:00
Hugo Drumond Jacob
aeafec3db0 [DO NOT MERGE] Handle unavailable properties
Accommodate the case in which `set()` for an unavailable property is
called as the VHAL may return OK or NOT_AVAILABLE.

Also, it may be the case that certain properties aren't available
while testing and thus, setting a value and getting it right after
might not always work.

Bug: 290882809
Change-Id: I7b7b3f144c4fbd786bf673a86fcac110ec8f79b5
2023-07-25 18:09:28 +00:00
Eric Biggers
ea6fdd2621 Merge changes from topic "weaver-vts-fix" into stage-aosp-udc-ts-dev
* changes:
  Allow uninstantiated WeaverTest
  Don't overwrite in-use Weaver slots during VTS
  Simplify Weaver VTS test
  Remove redundant HIDL Weaver VTS test
  Move VtsHalWeaverTargetTest to common directory
  Make VtsHalWeaverTargetTest test both HIDL and AIDL services
  Update OWNERS for Weaver
2023-07-25 18:05:58 +00:00
Eric Biggers
3d1e0b7555 Allow uninstantiated WeaverTest
Add back GTEST_ALLOW_UNINSTANTIATED_PARAMETERIZED_TEST, which I had
accidentally removed while merging the AIDL and HIDL tests.  I think
this is still needed on devices that don't support Weaver at all.

Bug: 291284381
Test: atest VtsHalWeaverTargetTest
Change-Id: Iac1b4476620e51c645e3ad57444ee386cb879029
(cherry picked from commit 47b145a0d8)
Merged-In: Iac1b4476620e51c645e3ad57444ee386cb879029
2023-07-24 18:52:39 +00:00
Alec Mouri
946b7f61c5 Support per-port display configs in VTS am: 821d5c05c2 am: 29d915f375 am: d37b25fe2a
Original change: https://googleplex-android-review.googlesource.com/c/platform/hardware/interfaces/+/24169145

Change-Id: If4d5c5a73173505b999fcb83dc611aaaf50e91f5
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-07-22 04:38:12 +00:00
Alec Mouri
d37b25fe2a Support per-port display configs in VTS am: 821d5c05c2 am: 29d915f375
Original change: https://googleplex-android-review.googlesource.com/c/platform/hardware/interfaces/+/24169145

Change-Id: Ieadd8e2dcd6dcfd7689590e4283a610204ec4e6b
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-07-22 03:51:33 +00:00
Alec Mouri
29d915f375 Support per-port display configs in VTS am: 821d5c05c2
Original change: https://googleplex-android-review.googlesource.com/c/platform/hardware/interfaces/+/24169145

Change-Id: I4fe99cb07cf870b8e0838e2830496223356ce61b
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-07-22 03:09:30 +00:00
Alec Mouri
821d5c05c2 Support per-port display configs in VTS
Bug: 277855934
(cherry picked from https://googleplex-android-review.googlesource.com/q/commit:be1b4d6ccec45f47bbb9459bf9aa31b4c6875c7b)
Merged-In: I92e1615d8eb9466b40e02f8e2df8b3432e927af6
Change-Id: I92e1615d8eb9466b40e02f8e2df8b3432e927af6
2023-07-22 00:58:03 +00:00
Shunkai Yao
5f02a64141 Update effect AIDL state machine graph
Bug: 271500140
Test: dot -Tpng state.gv -o state.png
(cherry picked from https://android-review.googlesource.com/q/commit:a8c5e014db942d84340fcdd8e75cc5359ef03e44)
Merged-In: Icbabe75e24497594f8bc62985553c1c13d268dae
Change-Id: Icbabe75e24497594f8bc62985553c1c13d268dae
2023-07-21 21:12:18 +00:00
Jeff Pu
bd8f26ea55 Merge "Authentication state stays on enrollment mismatch" into udc-qpr-dev 2023-07-21 15:09:23 +00:00
Tri Vo
e0fb4d0ce5 KeyMint: Add Root-of-Trust test cases
This patch is a squash of following patches:
 - aosp/2514097
 - aosp/2535086
 - aosp/2576910

Bug: 255344624
Test: VtsKeyMintAidlTargetTest
Change-Id: I8b34a94c11d7cc174821483f624fd083ca1763ac
Merged-In: I8b34a94c11d7cc174821483f624fd083ca1763ac
2023-07-20 18:05:24 -04:00
Tri Vo
727b45bf4f KM 4: Add Root-of-Trust test cases
This patch is a squash of following patches:
 - aosp/2582033
 - aosp/2603248

Bug: 255344624
Test: VtsHalKeymasterV4_0TargetTest
Change-Id: I46e62ab9031d3745f99bd214f9e579e80edc9128
Merged-In: I46e62ab9031d3745f99bd214f9e579e80edc9128
2023-07-20 18:05:18 -04:00
Weilin Xu
bce78d1105 Fix null pointer crash in AIDL radio HAL VTS am: cf892db1ef am: e065f848d0 am: 050c07c475
Original change: https://googleplex-android-review.googlesource.com/c/platform/hardware/interfaces/+/24133137

Change-Id: I52e0a5a66e613108fc60371cb382f3713b34f1b2
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-07-20 21:32:03 +00:00
Weilin Xu
050c07c475 Fix null pointer crash in AIDL radio HAL VTS am: cf892db1ef am: e065f848d0
Original change: https://googleplex-android-review.googlesource.com/c/platform/hardware/interfaces/+/24133137

Change-Id: I85df4b07a3e54ea6878c3edc596c3ae240068617
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-07-20 20:40:09 +00:00
Weilin Xu
e065f848d0 Fix null pointer crash in AIDL radio HAL VTS am: cf892db1ef
Original change: https://googleplex-android-review.googlesource.com/c/platform/hardware/interfaces/+/24133137

Change-Id: I8808c3c3ea0d30914597a5199c15bc3eddc9e723
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-07-20 19:55:55 +00:00
Eric Biggers
86b9048544 Don't overwrite in-use Weaver slots during VTS
VtsHalWeaverTargetTest always overwrote the first and last Weaver slots.
Before Android 14, apparently this didn't cause problems because Android
didn't use Weaver for users that never had an LSKF set.  However, now
users get a Weaver slot right away.  That typically means that the first
Weaver slot will be used by user 0.

Fix the test to read /metadata/password_slots/slot_map to determine
which slots are in use by the system, and only write to unused slots.

Bug: 291284381
Test: 'atest -v VtsHalWeaverTargetTest'.  Checked for INFO messages
      showing that slots 1 and 63 were used by the test.  Then rebooted
      and verified that the device can still be unlocked.
Change-Id: Id2cce4240d68999471e7d1e8fc7a8449587eed97
(cherry picked from commit 31380e7bc9)
Merged-In: Id2cce4240d68999471e7d1e8fc7a8449587eed97
2023-07-20 17:35:59 +00:00
Eric Biggers
42d76ae5df Simplify Weaver VTS test
- Get the config in SetUp() so that it's easily available to test cases.
- Rename "weaver" class member to "weaver_" to match coding style.
- Eliminate unnecessary variables when checking WeaverReadResponse.
- Fix a typo.

Bug: 291284381
Test: 'atest VtsHalWeaverTargetTest' on bramble
Change-Id: Ia6dca996103057bfdc9002bc9ab2c039e2333ed9
(cherry picked from commit 961a138e47)
Merged-In: Ia6dca996103057bfdc9002bc9ab2c039e2333ed9
2023-07-20 17:35:55 +00:00
Eric Biggers
c9691dd624 Remove redundant HIDL Weaver VTS test
Now that there is a single Weaver VTS test that covers both the HIDL and
AIDL services (weaver/vts/), the HIDL-specific test can be deleted.

Bug: 291284381
Test: 'atest VtsHalWeaverTargetTest' on bramble
Change-Id: Ie942825c154e6792e6ffdbf0c59248de9de10d92
(cherry picked from commit e2e40d69a6)
Merged-In: Ie942825c154e6792e6ffdbf0c59248de9de10d92
2023-07-20 17:35:51 +00:00
Eric Biggers
a8fc1ea054 Move VtsHalWeaverTargetTest to common directory
Since VtsHalWeaverTargetTest now handles both AIDL and HIDL, move it
from weaver/aidl/vts/ to weaver/vts/.

Bug: 291284381
Test: 'atest VtsHalWeaverTargetTest' on bramble
Change-Id: Icfa0ff3b22b036110df327674fda44820057aabd
(cherry picked from commit f0d6907d20)
Merged-In: Icfa0ff3b22b036110df327674fda44820057aabd
2023-07-20 17:35:47 +00:00
Eric Biggers
1cd59722b6 Make VtsHalWeaverTargetTest test both HIDL and AIDL services
VtsHalWeaverTargetTest and VtsHalWeaverV1_0TargetTest are identical
except for whether they use AIDL or HIDL.  Unfortunately, the HIDL test
is needed for several more years.  For now, we have to make some
substantial fixes to both tests.  To make continued maintenance of this
test easier, update VtsHalWeaverTargetTest to handle both AIDL and HIDL.
The test cases are still written in terms of the AIDL API, so it should
still be straightforward to remove HIDL support when the time comes.

Bug: 291284381
Test: 'atest VtsHalWeaverTargetTest' on bramble
Change-Id: I6b760930146ad1b08f17ef810a86c0058601c3bf
(cherry picked from commit b59654f239)
Merged-In: I6b760930146ad1b08f17ef810a86c0058601c3bf
2023-07-20 17:35:43 +00:00
Eric Biggers
0ddd5410e3 Update OWNERS for Weaver
Weaver does not have a clear owner, but list the people who seem to be
most involved with it currently.

Bug: 291284381
Test: N/A
Change-Id: I69de46f8154bf91272a7197ce71c13c745a7208e
(cherry picked from commit f4483a2ce9)
Merged-In: I69de46f8154bf91272a7197ce71c13c745a7208e
2023-07-20 17:35:38 +00:00
Jeff Pu
8fec556d25 Authentication state stays on enrollment mismatch
Bug: 291778822
Test: atest FakeFingerprintEngineTest
Change-Id: I4566303af982855aa0ebc52652464fb116a23858
2023-07-20 13:51:34 +00:00
Weilin Xu
cf892db1ef Fix null pointer crash in AIDL radio HAL VTS
Bug: 277531858
Test: atest VtsHalBroadcastradioAidlTargetTest
(cherry picked from https://googleplex-android-review.googlesource.com/q/commit:978de0a8a4968774e81e10e716a46bd9e1369479)
Merged-In: Icb67c27b9a747411a9bfbd48647e6e6046cf5e8d
Change-Id: Icb67c27b9a747411a9bfbd48647e6e6046cf5e8d
2023-07-19 19:46:04 +00:00
Treehugger Robot
13b2b44565 Merge "Fix wrong timeout and mock method in radio VTS" into stage-aosp-udc-ts-dev am: d8f18469c3 am: a0dc5d033c am: e25159e0e2
Original change: https://googleplex-android-review.googlesource.com/c/platform/hardware/interfaces/+/24068038

Change-Id: Icbf6430014b72004cfb3ed0035cf704e91344fc3
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-07-18 22:12:41 +00:00
Treehugger Robot
e25159e0e2 Merge "Fix wrong timeout and mock method in radio VTS" into stage-aosp-udc-ts-dev am: d8f18469c3 am: a0dc5d033c
Original change: https://googleplex-android-review.googlesource.com/c/platform/hardware/interfaces/+/24068038

Change-Id: I256b20f1485a04f98b40475b9c333df2968a5add
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-07-18 21:24:39 +00:00
Treehugger Robot
a0dc5d033c Merge "Fix wrong timeout and mock method in radio VTS" into stage-aosp-udc-ts-dev am: d8f18469c3
Original change: https://googleplex-android-review.googlesource.com/c/platform/hardware/interfaces/+/24068038

Change-Id: I9bba12078e13aa4c21a1e7794e171c1aaf333a44
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-07-18 20:42:08 +00:00
Treehugger Robot
d8f18469c3 Merge "Fix wrong timeout and mock method in radio VTS" into stage-aosp-udc-ts-dev 2023-07-18 19:50:07 +00:00
xiaoshun.xu
360c71ddab Fix vts sco test fail for usb interface
[Description]
If bt controller device is usb interface,
sco loopback single pkt and bandwidth test can not pass
because pkt size is limited accroding to core spec

[Root Cause]
USB sco packet size is limited in spec

[Solution]
If is bt usb chip, continuous receive sco packets
  from controller until size is enough

[Test Report]
Test Pass

Bug: 286355871
(cherry picked from https://android-review.googlesource.com/q/commit:4e85c099593a7d337bb277afc178eda3f7e7a818)
Merged-In: Idb150d8a72149f7e1dfaccfd7bc82a91710da59c
Change-Id: Idb150d8a72149f7e1dfaccfd7bc82a91710da59c
2023-07-18 18:03:09 +00:00
Shunkai Yao
5091d1c6cf Make EffectFactory implementation thread-safe
Also adjust some log level as verbos

Bug: 271500140
Test: atest --test-mapping hardware/interfaces/audio/aidl/vts:presubmit
Change-Id: I04560c62bdbcfb85dbe223bec0149b112205a323
Merged-In: I04560c62bdbcfb85dbe223bec0149b112205a323
2023-07-18 01:08:49 +00:00
Shunkai Yao
00d87fdae7 Support custom effect type UUID in audio effect AIDL example service
Parse custom effect type uuid in audio_effects_config.xml, so OEM can
add effect types without changing code

Bug: 271500140
Test: atest --test-mapping hardware/interfaces/audio/aidl/vts:presubmit
(cherry picked from https://android-review.googlesource.com/q/commit:80e5850d82f1b311a89367a77bab2c801ac16b37)
Merged-In: I558958cc42c6c4a304e0ab1239ddefec9575a5af
Change-Id: I558958cc42c6c4a304e0ab1239ddefec9575a5af
2023-07-18 01:08:17 +00:00
Jaideep Sharma
dfd1d0632e vts: getParameters only if parameters are supported
1) Validate specific parameters before open call,
   send only if parameters are supported.
2) GetParameters only if parameters are in range.

Bug: 288510312
Test: run vts VtsHalNSTargetTest, VtsHalAECTargetTest
(cherry picked from https://android-review.googlesource.com/q/commit:b985903e16929a7378c6c8ff6281e6748164ce51)
Merged-In: Idb20d819b3eb8a4ba56b4d50311c1aa7659f3616
Change-Id: Idb20d819b3eb8a4ba56b4d50311c1aa7659f3616
2023-07-18 01:03:34 +00:00
Jeff Pu
750c778f60 Merge "Update fingerprint VHAL operation lifecycle" into udc-qpr-dev 2023-07-17 15:40:25 +00:00
Jeff Pu
073af1802e Update fingerprint VHAL operation lifecycle
Bug: 289410175
Test: atest FakeFingerprintEngineTest
Change-Id: I6da68047be9bf5357c1b4c75ba28fc66c2e3bcc0
2023-07-17 13:23:47 +00:00
Gabriel Biren
b99ff556f2 Merge "Use a 64-bit instance of 0x1 when creating the event bitmask." into stage-aosp-udc-ts-dev am: e410f8ccc0 am: f479d8837b am: 065901cf4d
Original change: https://googleplex-android-review.googlesource.com/c/platform/hardware/interfaces/+/24060409

Change-Id: Ib2e6dd0f22fe51ecb51d2ba05efc202b30cd73ae
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-07-14 23:03:03 +00:00
Gabriel Biren
065901cf4d Merge "Use a 64-bit instance of 0x1 when creating the event bitmask." into stage-aosp-udc-ts-dev am: e410f8ccc0 am: f479d8837b
Original change: https://googleplex-android-review.googlesource.com/c/platform/hardware/interfaces/+/24060409

Change-Id: Ie655498707b4c3b3ad84652804f5a573359ef8da
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-07-14 22:14:14 +00:00
Gabriel Biren
f479d8837b Merge "Use a 64-bit instance of 0x1 when creating the event bitmask." into stage-aosp-udc-ts-dev am: e410f8ccc0
Original change: https://googleplex-android-review.googlesource.com/c/platform/hardware/interfaces/+/24060409

Change-Id: I0deb0bdd1825027a80ab90dcbf9fe8e633effe7e
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-07-14 21:05:54 +00:00
Gabriel Biren
e410f8ccc0 Merge "Use a 64-bit instance of 0x1 when creating the event bitmask." into stage-aosp-udc-ts-dev 2023-07-14 20:06:21 +00:00
Yusuke Yoshimura
42c050de92 Merge "Skip ATTEST_KEY using variant on waivered devices" into stage-aosp-udc-ts-dev am: bc88f61afb am: 8cae7cb490 am: 3e20b3b749
Original change: https://googleplex-android-review.googlesource.com/c/platform/hardware/interfaces/+/23899247

Change-Id: I37a476ebec9980827439951f4c76d1225f2346f8
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-07-14 08:35:34 +00:00
Yusuke Yoshimura
3e20b3b749 Merge "Skip ATTEST_KEY using variant on waivered devices" into stage-aosp-udc-ts-dev am: bc88f61afb am: 8cae7cb490
Original change: https://googleplex-android-review.googlesource.com/c/platform/hardware/interfaces/+/23899247

Change-Id: Ic3fc0b65bb565f6e7bda5b22973da6c034ab8b14
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-07-14 07:50:47 +00:00