Commit graph

292 commits

Author SHA1 Message Date
Treehugger Robot
55a93f6c79 Merge "vibrator: turn off vibrator after testing ChangeVibrationAmplitude" am: 05eb1a279b am: fa0ac0f30c am: 70d2180d62 am: 8cc45e8b18
Original change: https://android-review.googlesource.com/c/platform/hardware/interfaces/+/2104024

Change-Id: Ia4f8c02105a85075f97dddbdc826921edc406e55
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-06-08 15:45:50 +00:00
Treehugger Robot
70d2180d62 Merge "vibrator: turn off vibrator after testing ChangeVibrationAmplitude" am: 05eb1a279b am: fa0ac0f30c
Original change: https://android-review.googlesource.com/c/platform/hardware/interfaces/+/2104024

Change-Id: Ie43d991e7d0a79be679b8bf64ae1922c499d6921
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-06-08 14:53:56 +00:00
Treehugger Robot
05eb1a279b Merge "vibrator: turn off vibrator after testing ChangeVibrationAmplitude" 2022-06-08 13:48:44 +00:00
Simon Bowden
608655b450 Use a shared ref for Vibrator when passed to a worker thread.
To try to protect against this easy mistake, I removed the implicit
capture from thread lambdas.

Bug: 228523213
Test: atest
Change-Id: I8fa37dacb4acf89848a8b17db8db317a988809d4
2022-06-01 12:15:42 +00:00
Fenglin Wu
a464fb4db6 vibrator: turn off vibrator after testing ChangeVibrationAmplitude
Turn off vibrator explicitly after testing ChangeVibrationAmplitude.

Bug: 232319176
Test: VtsHalVibratorTargetTest
Change-Id: I482ea8266378636340c614eda832f4237d22e005
2022-05-24 09:02:58 +08:00
Lais Andrade
f1b4dd3f1d Check primitive duration is positive for supported primitives
Bug: 203629838
Fix: 231486866
Test: VtsHalVibratorTargetTest
Signed-off-by: chasewu <chasewu@google.com>
Change-Id: I2e534f4589c9f594884385a99051c06f518103f7
Merged-In: I2e534f4589c9f594884385a99051c06f518103f7
2022-05-16 16:14:46 +08:00
chasewu
22cb901d1a Correct the PWLE valid duration
Getting the maximum duration from HAL to avoid
different supported duration under different devices.

Fix: 231486866
Test: atest VtsHalVibratorTargetTest
Signed-off-by: chasewu <chasewu@google.com>
Change-Id: I02e96869d9a8e6d5143ae64e3a077bf90dcdb43e
Merged-In: I02e96869d9a8e6d5143ae64e3a077bf90dcdb43e
2022-05-11 15:58:46 +08:00
Treehugger Robot
942f0c579b Merge "Build with upstream lld: Fix incorrect static dependencies" am: 9f18cbd7f6 am: 67a2c6d6f1 am: 8fea839883
Original change: https://android-review.googlesource.com/c/platform/hardware/interfaces/+/2061768

Change-Id: I70b59b3a2197a73415c1ca91b84df1848b14a380
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-04-13 22:46:33 +00:00
Pirama Arumuga Nainar
3be0ec611f Build with upstream lld: Fix incorrect static dependencies
Bug: http://b/197965342

Remove unnecessary `static_libs` dependencies or move them to
`shared_libs` to build with upstream LLD.  See b/197965342#comment1
(internal) for rationale.  Some info is available externally at
https://github.com/llvm/llvm-project/issues/42899.

Per go/android-lld-static-lib-fix, OWNERS are added for visibility.  No
action is needed if the change looks good.  This change will be merged
after two business days with Global Approvers.

Test: Build modules with aosp/2036867 in addition to presubmit
Change-Id: Id3ec5d188d7d0ae364e52b98fb9cf7221274665a
2022-04-11 20:04:20 +00:00
chasewu
a266b2c8f2 Correct the PWLE valid duration
Getting the maximum duration from HAL to avoid
different supported duration under different devices.

Fix: 227606057
Test: atest VtsHalVibratorTargetTest
Signed-off-by: chasewu <chasewu@google.com>
Change-Id: I02e96869d9a8e6d5143ae64e3a077bf90dcdb43e
2022-03-31 23:59:40 +08:00
chasewu
70da3cc0a1 Fix the maximum frequency value calculation
Fix: 205250672
Test: VtsHalVibratorTargetTest
Signed-off-by: chasewu <chasewu@google.com>
Change-Id: I908ab93eaee17de2af163c0fe3c50feea567ee48
Merged-In: I908ab93eaee17de2af163c0fe3c50feea567ee48
2022-03-29 19:32:42 +08:00
chasewu
d1a57eaac5 Fix the default BandwidthAmplitudeMap contant
Fix: 225286612
Test: atest VtsHalVibratorTargetTest
Signed-off-by: chasewu <chasewu@google.com>
Change-Id: I5c550426b7cbbdf6e4e9ad90d6248b6ed0523399
Merged-In: I5c550426b7cbbdf6e4e9ad90d6248b6ed0523399
2022-03-29 19:25:42 +08:00
chasewu
8af5e8479a Fix the default BandwidthAmplitudeMap contant
Fix: 225286612
Fix: 224650717
Test: forrest test
Signed-off-by: chasewu <chasewu@google.com>
Change-Id: I5c550426b7cbbdf6e4e9ad90d6248b6ed0523399
2022-03-23 07:17:29 +00:00
Chase Wu
be3069df36 Merge "Fix the maximum frequency value calculation" into tm-dev 2022-03-18 04:10:42 +00:00
Steven Moreland
0347ea978c Merge "Fuzzer for default vibrator service." am: 5ceed8997b am: 4b572a4d5a am: 650468afcc
Original change: https://android-review.googlesource.com/c/platform/hardware/interfaces/+/2025684

Change-Id: Iae65dca0d8370dce428f97311c30143cbb22d83d
2022-03-15 17:22:03 +00:00
chasewu
2456a147a5 Fix the maximum frequency value calculation
Fix: 205250672
Test: VtsHalVibratorTargetTest
Signed-off-by: chasewu <chasewu@google.com>
Change-Id: I908ab93eaee17de2af163c0fe3c50feea567ee48
2022-03-15 21:21:39 +08:00
Steven Moreland
2e96b9dce1 Fuzzer for default vibrator service.
As an example for a fuzzer of an AIDL service.

Bug: 224646709
Test: run fuzzer for a few minutes (doesn't get very
    deep in the fuzzer - will follow-up with a dictionary
    or a corpus if the fuzzer can't get past the header
    and interface token)
Change-Id: Iac02a1f02500a0098d67823ac22de1706778927b
2022-03-15 01:48:16 +00:00
Chih-hung Hsieh
34593d4e2a Merge "Add timed out test files to tidy_timeout_srcs" am: ff54f73b4f am: fa83970b3a am: 581616e658
Original change: https://android-review.googlesource.com/c/platform/hardware/interfaces/+/1992232

Change-Id: I2eac13fe3b5ab0b4f15d6ceadf376e5e74124a81
2022-02-24 01:32:09 +00:00
Chih-Hung Hsieh
ad1bf31b78 Add timed out test files to tidy_timeout_srcs
* Timed out runs do not show any warning messages.
* These test files cannot finish clang-tidy runs with
  the following settings:
    TIDY_TIMEOUT=90
    WITH_TIDY=1
    CLANG_ANALYZER_CHECKS=1
* When TIDY_TIMEOUT is set, in Android continuous builds,
  tidy_timeout_srcs files will not be compiled by clang-tidy.
  When developers build locally without TIDY_TIMEOUT,
  tidy_timeout_srcs files will be compiled.
* Some of these test modules may be split into smaller ones,
  or disable some time consuming checks, and then
  enable clang-tidy to run within limited time.

Bug: 201099167
Test: make droid tidy-hardware-interfaces_subset
Change-Id: I1de28f1572fff368f67eab512fffec9f2e5c2a9b
2022-02-18 17:25:41 -08:00
Tai Kuo
a90257463d vibrator: aidl: update OWNERS file
Remove leungv@ and add taikuo@ into the OWNERS file.

Bug: 219384042
Test: Presubmit
Change-Id: I191fdf2500a1bec54f2f55671c99b7b1120aee74
2022-02-14 12:33:12 +08:00
Tai Kuo
af798d4d2c vibrator: aidl: update OWNERS file
Remove leungv@ and add taikuo@ into the OWNERS file.

Bug: 219384042
Test: Presubmit
Change-Id: I191fdf2500a1bec54f2f55671c99b7b1120aee74
2022-02-14 12:27:15 +08:00
Steven Moreland
77b74ffc0a Merge "CHECK -> CHECK_EQ copy pasta" am: a8138bfbf6 am: dd39b5c9d0 am: f711c9d406 am: 53c7517b02
Original change: https://android-review.googlesource.com/c/platform/hardware/interfaces/+/1921302

Change-Id: I3f32bf37c1c025e82e14ee6c9f0ffde87f6bcbd6
2021-12-14 18:40:32 +00:00
Steven Moreland
ffb03995e6 CHECK -> CHECK_EQ copy pasta
Hey did I start this? We can take a little bit better errors. :)

Bug: N/A
Test: N/A
Change-Id: I0e96f7f49dae9968904333da9b8269694058c11c
2021-12-14 01:45:47 +00:00
Lais Andrade
1c8a5a1b6a Check primitive duration is positive for supported primitives
Fix: 203629838
Test: VtsHalVibratorTargetTest
Change-Id: I2e534f4589c9f594884385a99051c06f518103f7
2021-11-09 16:40:51 +00:00
Treehugger Robot
a99d927ae5 Merge "Backfill owner information for VtsHalVibrator*." am: ad56c830f3 am: 7253b8fdcc am: 612c47898d am: b88a0cf1d5 am: dce5d18766
Original change: https://android-review.googlesource.com/c/platform/hardware/interfaces/+/1814058

Change-Id: Ic9ce332f201618e494e8696b4ef137b9c215d0b2
2021-10-18 19:20:18 +00:00
Yiming Pan
f3f344a134 Backfill owner information for VtsHalVibrator*.
Owner information is backfilled for the following modules:
VtsHalVibratorTargetTest
VtsHalVibratorV1_0TargetTest
VtsHalVibratorV1_1TargetTest
VtsHalVibratorV1_2TargetTest
VtsHalVibratorV1_3TargetTest

Each VTS module is required to have OWNERS file. The ownership is based on
go/vts-owners. For more information about ownership policy, please visit
go/xts-owners-policy.

Test: Tree Hugger
Bug: 143903671
Change-Id: I72b6f2312cd1863e24a05160d688bac86378e37a
2021-10-15 16:29:59 -07:00
Lais Andrade
a2f4ca07c6 Update haptic owners to include frameworks file am: 157418535e am: b2ef6e4be5 am: a8e821bbe2 am: 3776ab3910 am: 729f23a381
Original change: https://android-review.googlesource.com/c/platform/hardware/interfaces/+/1854183

Change-Id: Ib058bb3c5b0158e9a2ebf6fce91182468f3f9735
2021-10-12 17:14:56 +00:00
Lais Andrade
157418535e Update haptic owners to include frameworks file
Change-Id: I4c089df77dc2b8cf5d43535fbc9dc5f80cd4ca9c
2021-10-12 14:44:23 +00:00
Daniel Norman
e98099957e Merge "Merge "Creates a vendor APEX for the default vibrator HAL service." am: dca9f88513" into stage-aosp-master am: 9e0ab80bb6 am: 2fdcd81183 am: f13bf1a153 am: a252ec3844
Original change: https://googleplex-android-review.googlesource.com/c/platform/hardware/interfaces/+/15925131

Change-Id: I32ac331e4671876e071b680b399fed1a21d23b6e
2021-09-28 16:46:01 +00:00
Daniel Norman
7a17de7333 Merge "Creates a vendor APEX for the default vibrator HAL service." am: dca9f88513
Original change: https://android-review.googlesource.com/c/platform/hardware/interfaces/+/1828079

Change-Id: I580ded8f6f8a19ece2769398aef92bd79936a01e
2021-09-27 23:00:26 +00:00
Daniel Norman
938b862996 Creates a vendor APEX for the default vibrator HAL service.
Bug: 200168006
Test: Ensure vibrator service is running on device.
Change-Id: I218b79f589cfae4f36cdc964ef2f2d0deaf7254e
2021-09-24 16:16:19 +00:00
TreeHugger Robot
3a90a1e4b6 Merge "Update ActivePwle description for amplitude values" into stage-aosp-master am: 1f81aeea7b am: 8d9b5150ea am: b1205f9cd0 am: 234838c23c
Original change: https://googleplex-android-review.googlesource.com/c/platform/hardware/interfaces/+/15827549

Change-Id: I3364e9d6cb5538001fab27af498e7dad0f64312d
2021-09-21 20:34:01 +00:00
Lais Andrade
22754c5fa7 Update ActivePwle description for amplitude values
Update description to clarify that the value 1 should map to the maximum
output acceleration supported by the device at any frequency, not exclusively
to the one at resonant frequency.

Also add information linking the  ActivePwle input parameters of composePwle
to the output values returned by getBandwidthAmplitudeMap, and update
the bandwidth description as well.

Change-Id: Id6e02c5d323aec57db7e7127e219a9705d0289a3
Fix: 199753151
Test: VtsHalVibratorTargetTest
2021-09-21 15:48:15 +00:00
Jiyong Park
e0f2d29b7f Remove ndk_platform backend. Use the ndk backend.
The ndk_platform backend will soon be deprecated because the ndk backend
can serve the same purpose. This is to eliminate the confusion about
having two variants (ndk and ndk_platform) for the same ndk backend.

Bug: 161456198
Test: m
Merged-In: I0652f1efe920111d79dd8c2ecd52e55dda54538f
Merged-In: Ib58c9f1cb80d083a3c62d03415610be855b80f03
Change-Id: Ied92f2784ed7d6a73693c640042c8a66fbbcfa17
2021-08-17 14:48:50 +00:00
Jiyong Park
d55d28a1d0 Remove ndk_platform backend. Use the ndk backend.
The ndk_platform backend will soon be deprecated because the ndk backend
can serve the same purpose. This is to eliminate the confusion about
having two variants (ndk and ndk_platform) for the same ndk backend.

Bug: 161456198
Test: m
Merged-In: I0652f1efe920111d79dd8c2ecd52e55dda54538f
Change-Id: Ib58c9f1cb80d083a3c62d03415610be855b80f03
(cherry picked from commit c426c6dbdc)
2021-08-09 11:20:04 +09:00
Jiyong Park
c426c6dbdc Remove ndk_platform backend. Use the ndk backend.
The ndk_platform backend will soon be deprecated because the ndk backend
can serve the same purpose. This is to eliminate the confusion about
having two variants (ndk and ndk_platform) for the same ndk backend.

Bug: 161456198
Test: m
Change-Id: I0652f1efe920111d79dd8c2ecd52e55dda54538f
2021-08-04 12:48:07 +09:00
Lais Andrade
46819a1675 Update vibrator VTS to only validate support from required primitives
Change-Id: I93cf92636af7a89371f1e87a5a0b40de9d3ee3ed
Fix: 193196353
Test: VtsHalVibratorTargetTest
Merged-In: Icb69a799d204102880efd685312d3a0e2e22b7bb
Merged-In: I7ec2f0d82290f42259f8383db9ff00a126a2a7a4
2021-07-15 12:23:40 +00:00
TreeHugger Robot
ec922a4065 Merge "Update vibrator VTS to only validate support from required primitives" into sc-dev am: afb4bfa127 am: 3a9afd3a0f
Original change: https://googleplex-android-review.googlesource.com/c/platform/hardware/interfaces/+/15244130

Change-Id: Icb69a799d204102880efd685312d3a0e2e22b7bb
2021-07-14 16:55:24 +00:00
Lais Andrade
7e643777e1 Update vibrator VTS to only validate support from required primitives
Bug: 193196353
Test: VtsHalVibratorTargetTest
Change-Id: I7ec2f0d82290f42259f8383db9ff00a126a2a7a4
2021-07-09 15:01:00 +01:00
Lais Andrade
6d4c0482fc Fix default vibrator HAL to check support on getPrimitiveDuration
Change-Id: I09219cca0a1b0bb985cae70734b0dd03cca441fc
Merged-In: I09219cca0a1b0bb985cae70734b0dd03cca441fc
Fix: 191115802
Fix: 191952216
Test: VtsHalVibratorTargetTest
2021-06-26 05:07:37 +00:00
TreeHugger Robot
df724e3c9d Merge "Fix default vibrator HAL to check support on getPrimitiveDuration" into sc-dev am: cca7e93111 am: 3594703db5
Original change: https://googleplex-android-review.googlesource.com/c/platform/hardware/interfaces/+/14985772

Change-Id: I32dbdf4e7e50c7d0fee27b404e3628c8679ce8c3
2021-06-18 14:04:50 +00:00
TreeHugger Robot
cca7e93111 Merge "Fix default vibrator HAL to check support on getPrimitiveDuration" into sc-dev 2021-06-18 13:43:45 +00:00
TreeHugger Robot
dedb4a24b0 Merge "Fix vibrator VTS failure on older HAL versions" into sc-dev am: c1d25eb84f am: 81a8e67f79
Original change: https://googleplex-android-review.googlesource.com/c/platform/hardware/interfaces/+/14985778

Change-Id: I440de6e23d8b30e36ebb95475f9196099a8827ee
2021-06-18 12:10:37 +00:00
Lais Andrade
149320003e Fix vibrator VTS failure on older HAL versions
Fixing tests missed by ag/14937086.

Fix: 186481596
Test: VtsHalVibratorTargetTest
Change-Id: Ib4b4885a99effb6c010573146f5b016872f7a202
2021-06-16 13:37:37 +01:00
Lais Andrade
3c7f0d90ba Fix default vibrator HAL to check support on getPrimitiveDuration
Change-Id: I09219cca0a1b0bb985cae70734b0dd03cca441fc
Fix: 191115802
Test: VtsHalVibratorTargetTest
2021-06-16 10:28:22 +00:00
Lais Andrade
f8dcd3f1e4 Update AIDL vibrator version for benchmarks
Change-Id: I2574bf18b633feedbc0484a347360b3bc89b9dfd
Fix: 191147627
Test: VibratorHalIntegrationBenchmark
2021-06-15 15:40:16 +00:00
Lais Andrade
4b54b1fc49 Fix vibrator VTS failure on older HAL versions
Fix tests to expect STATUS_UNKNOWN_TRANSACTION as well as
EX_UNSUPPORTED_OPERATION when the vibrator does not have a capability
required for the method being tested.

Older versions of the HAL will return that status code instead of
unsupported, as explained at:
https://source.android.com/devices/architecture/aidl/stable-aidl#versioning-interfaces

Fix: 190526054
Test: VtsHalVibratorTargetTest & VtsHalVibratorManagerTargetTest
Change-Id: I538843fbbdbf8353cd57f1c83392baeabdcbadd2
2021-06-11 12:29:11 +01:00
Jiyong Park
72b6359859 Freeze AIDL APIs for SC
Ignore-AOSP-First: part of SC finalization

Bug: 188713899
Test: m
Change-Id: Iee18cd05954dc8ea08cc4f985499a70977d1af4f
2021-05-25 10:13:26 +09:00
Vince Leung
7b8606eaa1 Increase timeout values for callback
We need to increase the timeout values for waiting for the callback to
be called.

Bug: 184719072
Test: atest to verify that the affected tests pass on P21
Change-Id: I5a5b2ae1fb99f98e3d94cd956685fabc45b89b30
2021-05-04 14:07:46 -07:00
Jooyung Han
2af836b6e9 Merge changes from topic "fix-aidl-warnings" am: a886a5c4be am: 5235704ac4 am: bf1ec6e83e
Original change: https://android-review.googlesource.com/c/platform/hardware/interfaces/+/1688165

Change-Id: I2eedb65bacef6075d5cf825749915262c25f4727
2021-04-27 23:49:08 +00:00