Commit graph

869 commits

Author SHA1 Message Date
Chih-hung Hsieh
34593d4e2a Merge "Add timed out test files to tidy_timeout_srcs" am: ff54f73b4f am: fa83970b3a am: 581616e658
Original change: https://android-review.googlesource.com/c/platform/hardware/interfaces/+/1992232

Change-Id: I2eac13fe3b5ab0b4f15d6ceadf376e5e74124a81
2022-02-24 01:32:09 +00:00
Chih-hung Hsieh
fa83970b3a Merge "Add timed out test files to tidy_timeout_srcs" am: ff54f73b4f
Original change: https://android-review.googlesource.com/c/platform/hardware/interfaces/+/1992232

Change-Id: Ic6072a539d185abc0bcce2ef1dd4a96ddf70e3b8
2022-02-24 00:40:48 +00:00
TreeHugger Robot
0bd7074e39 Merge "Camera: Use 64bit integers for dynamic range profile values" into tm-dev 2022-02-24 00:27:29 +00:00
Emilian Peev
4ce76d242c Camera: Use 64bit integers for dynamic range profile values
Additionally extend the dynamic range profile map to include
hints about extra lookahead latency.

Bug: 215396395
Test: Camera CTS
Change-Id: I600a3147d94a9aad1a312b92aacee014c05db16f
2022-02-23 00:26:22 +00:00
Jayant Chowdhary
cb4853941b camera: Address ANAPIC review comments and additional cleanup
Bug: 218911443

Test: build

Change-Id: Ia6d3f4d73e9ff29fa5fca2e11e0b9cb5a8d1e2ac
Signed-off-by: Jayant Chowdhary <jchowdhary@google.com>
2022-02-22 23:35:25 +00:00
Chih-Hung Hsieh
ad1bf31b78 Add timed out test files to tidy_timeout_srcs
* Timed out runs do not show any warning messages.
* These test files cannot finish clang-tidy runs with
  the following settings:
    TIDY_TIMEOUT=90
    WITH_TIDY=1
    CLANG_ANALYZER_CHECKS=1
* When TIDY_TIMEOUT is set, in Android continuous builds,
  tidy_timeout_srcs files will not be compiled by clang-tidy.
  When developers build locally without TIDY_TIMEOUT,
  tidy_timeout_srcs files will be compiled.
* Some of these test modules may be split into smaller ones,
  or disable some time consuming checks, and then
  enable clang-tidy to run within limited time.

Bug: 201099167
Test: make droid tidy-hardware-interfaces_subset
Change-Id: I1de28f1572fff368f67eab512fffec9f2e5c2a9b
2022-02-18 17:25:41 -08:00
TreeHugger Robot
1d78299027 Merge "Camera: Update constrained HFR VTS test." 2022-02-16 01:45:31 +00:00
Rucha Katakwar
18aa2d952b Camera: Update constrained HFR VTS test.
Added a check that HAL does not advertise multiple preview rates for
the same recording rate and size.

Bug: 200310682

Change-Id: Ia213f152ad00c846a533577e552b668efdde6f3d
2022-02-15 16:38:25 -08:00
Xin Li
0bf8f21279 Merge sc-v2-dev-plus-aosp-without-vendor@8084891
Bug: 214455710
Merged-In: Id9e06f88539b59480d5cf57a4ba67cef4676c1d5
Change-Id: Id6b1ea4f8700446b044255e80f21c137aeb7acf1
2022-02-11 07:27:13 +00:00
Bob Badour
13cb922a05 [LSC] Add LOCAL_LICENSE_KINDS to hardware/interfaces
Added SPDX-license-identifier-Apache-2.0 to:
  camera/common/aidl/Android.bp
  camera/device/aidl/Android.bp
  camera/metadata/aidl/Android.bp
  usb/aidl/Android.bp
  usb/aidl/default/Android.bp

Bug: 68860345
Bug: 151177513
Bug: 151953481

Test: m all
Change-Id: Ie530a51faa37d782428a20238e78573658697be8
2022-02-10 13:39:55 -08:00
Jayant Chowdhary
198398724e Merge "Add stream use cases to camera aidl interfaces." 2022-02-07 19:51:15 +00:00
Jayant Chowdhary
9ca871ae24 Add stream use cases to camera aidl interfaces.
Bug: 196432585

Test: build

Change-Id: I1b2628056949d05aa553bdbba7983628ec54d65b
Signed-off-by: Jayant Chowdhary <jchowdhary@google.com>
2022-02-05 15:37:56 -08:00
Changyeon Jo
7853416a07 Camera: Add automotive metadata section
This CL adds a new automotive metadata section with below fields:
- AUTOMOTIVE_LOCATION describes where the camera exists.
- AUTOMOTIVE_LENS_FACING tells where the camera's lens is facing toward.

Bug: 205156620
Test: m -j
Change-Id: Idc88d26a6834f30bbfd66d5a1ae74409dcf7b0dd
2022-02-04 19:54:51 -08:00
Shuzhen Wang
68ace478f1 Merge "Camera: Add stream use case API" 2022-02-05 03:13:08 +00:00
Jayant Chowdhary
0b0d7332f1 Add AIDL interface files for android.hardware.camera.common .
Bug: 196432585

Test: build; implementation will be submitted later.

Change-Id: Ic7577c557195464d9ef99506d8ceba172db14e0b
Signed-off-by: Jayant Chowdhary <jchowdhary@google.com>
2022-02-04 09:47:05 -08:00
Jayant Chowdhary
fd3b3c6c72 Add AIDL interfaces for camera device hal functionality.
Bug: 196432585

Test: build; Implementation will submitted later.

Change-Id: Ibc9477a6b088e85822087776e93e65f3243ea0bb
Signed-off-by: Jayant Chowdhary <jchowdhary@google.com>
2022-02-04 09:47:05 -08:00
Jayant Chowdhary
75aec9028a Add AIDL interfaces for camera HAL provider.
Bug: 196432585

Test: build; Implementation will be submitted later.

Change-Id: Ia50fe0502c811dddd706781c653f038e0415eb4d
Signed-off-by: Jayant Chowdhary <jchowdhary@google.com>
2022-02-04 09:47:03 -08:00
Jayant Chowdhary
33e7fef887 Add AIDL interfaces for camera metadata.
Bug: 196432585

Test: build; Implementation will be submitted later.

Change-Id: I1fe9488bb34ef5c0a755d7bb8f284cc1fbc8f298
Signed-off-by: Jayant Chowdhary <jchowdhary@google.com>
2022-02-04 07:53:30 -08:00
Shuzhen Wang
7267abff25 Camera: Add stream use case API
- Add availableStreamUseCase static metadata tag
- Add STREAM_USE_CASE camera capability
- Add useCase flag in camera stream interface

Test: atest VtsHalCameraProviderV2_4TargetTest
Bug: 200307880
Change-Id: I4e473edcb52a97fa0e1b27cf94603cf9f9984f82
2022-02-03 17:46:44 -08:00
Greg Kaiser
754fcb8c33 Avoid multiple map lookups
We directly use erase(), and its return value, so we only need
to look up 'deviceName' once.

Test: TreeHugger
Bug: 191248460
Change-Id: I7c229e7d1de5f76071f55f965eab447b6c868bcc
2022-01-21 07:00:25 -08:00
Iavor-Valentin Iftime
cd3e66327f Merge "Add external lazy camera provider 2.7" 2022-01-20 16:48:21 +00:00
Shuzhen Wang
1320f88af2 Camera: VTS: Remove GRF MultiCamera for Android 12
Certain OEMs' new S launches with vendor freeze cannot implement
multi-camera API.

Bug: 189053514
Bug: 211709637
Change-Id: I71b46f1e8343a5848cbe3fa55bbcd427c87b05dd
Merged-In: I71b46f1e8343a5848cbe3fa55bbcd427c87b05dd
(cherry picked from commit 30a198ded0)
2022-01-20 05:50:37 +00:00
TreeHugger Robot
714f9596c3 Merge "Camera: VTS: Remove GRF MultiCamera for Android 12" 2022-01-20 05:49:39 +00:00
Shuzhen Wang
ea3ab4f3f3 Camera: VTS: Remove GRF MultiCamera for Android 12
Certain OEMs' new S launches with vendor freeze cannot implement
multi-camera API.

Test: Build
Bug: 189053514
Bug: 211709637
Change-Id: I71b46f1e8343a5848cbe3fa55bbcd427c87b05dd
(cherry picked from commit 30a198ded0)
2022-01-19 13:21:42 -08:00
Emilian Peev
b5f634fc37 Camera: Add device 3.8 and HDR10 native APIs
Initial set of native API extensions to support 10-bit
output capable device:
- Identification
- Configuration
- Data plumbing

Bug: 195946346
Test: adb shell
/data/nativetest64/VtsHalCameraProviderV2_4TargetTest/VtsHalCameraProviderV2_4TargetTest
--gtest_filter=PerInstance/CameraHidlTest.process10BitDynamicRangeRequest/0_internal_0

Change-Id: I526120944232ce211259cbd215935db7e445a6c5
2022-01-05 15:46:50 -08:00
Jayant Chowdhary
c40bae7dc8 Merge "VTS test for previewStabilization" 2021-12-29 19:52:56 +00:00
Valentin Iftime
23d32a1fc3 Add external lazy camera provider 2.7
Add default implementation for external camera
 provider with lazy HAL support v2.7.

 Test configuration for devices:
 PRODUCT_PACKAGES += android.hardware.camera.provider@2.7-impl
 PRODUCT_PACKAGES += android.hardware.camera.provider@2.7-external-service-lazy
 PRODUCT_PROPERTY_OVERRIDES += ro.camera.enableLazyHal=true

Test: atest CtsCameraTestCases
      atest VtsHalCameraProviderV2_4TargetTest

Bug: 191248460

Change-Id: I57c8130d7c331028eff35dc68e360fdd8d8c32e2
2021-12-27 18:59:47 +01:00
Jayant Chowdhary
bf39d4db34 VTS test for previewStabilization
Bug: 200197440

Test: VtsHalCameraProviderV2_4TargetTest
     --gtest_filter=PerInstance/CameraHidlTest.processCaptureRequestPreviewStab*

Change-Id: Iba71983a69d20af605924fa6f1c0697e49d911f8
Signed-off-by: Jayant Chowdhary <jchowdhary@google.com>
2021-12-15 14:41:03 -08:00
Rucha Katakwar
5ad93755c8 Camera: Add 3.8 version of ICameraDevice.
The new version of ICameraDevice supports interfaces for torch
strength control feature. New VTS test has been added to test the
emulator HAL-side implementation of the newly added interfaces.

bug: 200174275

Test: Camera VTS test pass.
Change-Id: Ia5652a96e09bd716b5079fe9ed071dffc53b5b12
2021-12-13 12:02:51 -08:00
Shuzhen Wang
8136c00c7e Camera: Update readoutTimeout requirement
Due to sensor crop, readoutTimeout - startOfExposure may be larger than
exposureTime. Update the VTS test to reflect the spec change.

Test: processCaptureRequestPreview
Bug: 208270993
Change-Id: I51a373ecbc5c7c086f84c5479a43dffbe8fcc0c2
2021-12-01 18:34:03 -08:00
Rucha Katakwar
f67194b6ee Merge "Camera: Update torch strength control API name." 2021-11-22 18:44:01 +00:00
Rucha Katakwar
ba757a0f44 Camera: Update torch strength control API name.
bug: 200174275
Change-Id: I0934d0181a58ae37f1c8d094295329d8126fb90a
2021-11-18 17:22:12 -08:00
Shuzhen Wang
cd9af6c1ce Camera: Add version 3.8 of ICameraDeviceCallback
The new version of ICameraDeviceCallback supports shutter notify with readout
timestamp.

The readout timestamp is used to re-time viewfinder frames to reduce
jitter. When camera runs at fixed frame rate, the start_of_exposure time
intervals may change, but start_or_readout intervals are constant.

Test: Camera VTS test
Bug: 189380857
Change-Id: I4c3856a4e30caa8cdf8417d437de1de3190c6fd6
2021-11-17 13:48:10 -08:00
Valentin Iftime
b4fcc57952 Use sp<>::make in external camera HAL
Fix external camera HAL crash (android::RefBase::incStrongRequireStrong)

Bug: 184190315
Test: android.hardware.camera.provider@2.5-external-service does not crash
Change-Id: I2406099078fd3c9bddf05afc4011fbece5072139
2021-11-16 22:48:52 +01:00
Bob Badour
ce854e5605 [LSC] Add LOCAL_LICENSE_KINDS to hardware/interfaces
Added SPDX-license-identifier-Apache-2.0 to:
  camera/metadata/3.7/Android.bp
  camera/metadata/3.8/Android.bp

Bug: 68860345
Bug: 151177513
Bug: 151953481

Test: m all
Change-Id: I31cece41e97d4b6cc8e425c05ba84d94b6b59065
2021-11-11 17:25:08 -08:00
Xin Li
8f6d361f15 Merge sc-qpr1-dev-plus-aosp-without-vendor@7810918
Bug: 205056467
Merged-In: I96a417467346a57b13c2efae12a183d78506afc3
Change-Id: I570a3b599281f519af7a440562c83f8484684fd5
2021-11-10 08:05:55 +00:00
Jayant Chowdhary
71d51acb33 Merge "Add CONTROL_VIDEO_STABILIZATION_MODE_PREVIEW_STABILIZATION to allow for better preview stabilization." 2021-11-05 17:01:26 +00:00
Shuzhen Wang
8d7222335e Camera: VTS for test_pattern tag requirement for physical camera am: 5ee43a6d24 am: dcfd36a1ef
Original change: https://googleplex-android-review.googlesource.com/c/platform/hardware/interfaces/+/16175076

Change-Id: I6c39ce56fce986b6121f1c479551240dfbd709e5
2021-11-04 21:04:26 +00:00
Shuzhen Wang
dcfd36a1ef Camera: VTS for test_pattern tag requirement for physical camera am: 5ee43a6d24
Original change: https://googleplex-android-review.googlesource.com/c/platform/hardware/interfaces/+/16175076

Change-Id: Ica4b42dc02429bc7d1082d9c0ff7bb5078b6e968
2021-11-04 20:46:50 +00:00
Shuzhen Wang
5ee43a6d24 Camera: VTS for test_pattern tag requirement for physical camera
Ensure that if TEST_PATTERN_MODE is listed in physical request keys, the
corresponding physical camera must support the privacy related test
pattern modes.

Test: Run Camera VTS with Cuttlefish emulator
Bug: 204108650
Change-Id: I8f378ab642c7c010a2ba73a8e89e65c91ba780eb
2021-11-03 22:56:16 +00:00
TreeHugger Robot
6d6f21dd42 Merge "VtsHalCameraProviderV2_4TargetTest: Override rotate&crop" into sc-v2-dev am: 3c2ebae81c am: f51c54566f
Original change: https://googleplex-android-review.googlesource.com/c/platform/hardware/interfaces/+/16144607

Change-Id: I2b8901f212176dda1904a2ef4458a13d7152d427
2021-11-02 19:40:23 +00:00
TreeHugger Robot
f51c54566f Merge "VtsHalCameraProviderV2_4TargetTest: Override rotate&crop" into sc-v2-dev am: 3c2ebae81c
Original change: https://googleplex-android-review.googlesource.com/c/platform/hardware/interfaces/+/16144607

Change-Id: I386dc4cb7c0fda8b21ffc394fdcb8852cc031e55
2021-11-02 19:27:08 +00:00
TreeHugger Robot
3c2ebae81c Merge "VtsHalCameraProviderV2_4TargetTest: Override rotate&crop" into sc-v2-dev 2021-11-02 19:06:21 +00:00
Shuzhen Wang
4aec71e7ff Camera: Adjust VTS test to relax multi-camera requirement am: dc6da704ed am: 0e9dcbff44
Original change: https://googleplex-android-review.googlesource.com/c/platform/hardware/interfaces/+/16149860

Change-Id: I6a3768b5f7ddd5233aaba81bddb43a511ffb54cf
2021-10-29 20:18:06 +00:00
Shuzhen Wang
0e9dcbff44 Camera: Adjust VTS test to relax multi-camera requirement am: dc6da704ed
Original change: https://googleplex-android-review.googlesource.com/c/platform/hardware/interfaces/+/16149860

Change-Id: I86be1b078702be7324b2e6241e6a44ad5347e9f3
2021-10-29 20:05:50 +00:00
Shuzhen Wang
dc6da704ed Camera: Adjust VTS test to relax multi-camera requirement
The multi-camera Grf requirement is now only applicable to rear facing
camera.

Test: Run test on Pixel devices
Bug: 204252005
Change-Id: Idb7735eebdc104f6ee6a5946b50c11aea809eb85
2021-10-29 11:24:03 -07:00
Shuzhen Wang
55190e272d Camera: Adjust VTS test to relax multi-camera requirement
The multi-camera Grf requirement is now only applicable to rear facing
camera.

Test: Run test on Pixel devices
Bug: 204252005
Change-Id: Idb7735eebdc104f6ee6a5946b50c11aea809eb85
2021-10-29 18:21:36 +00:00
Emilian Peev
06ec563f55 VtsHalCameraProviderV2_4TargetTest: Override rotate&crop
As per documentation the default auto rotate&crop mode must
be overriden before passing the capture request back to the
camera provider.

Bug: 204407427
Test:
atest
VtsHalCameraProviderV2_4TargetTest:PerInstance/CameraHidlTest#processCaptureRequestPreview/0_internal_0
atest
VtsHalCameraProviderV2_4TargetTest:PerInstance/CameraHidlTest#processMultiCaptureRequestPreview/0_internal_0
atest
VtsHalCameraProviderV2_4TargetTest:PerInstance/CameraHidlTest#processCaptureRequestBurstISO/0_internal_0
atest
VtsHalCameraProviderV2_4TargetTest:PerInstance/CameraHidlTest#flushPreviewRequest/0_internal_0

Change-Id: I1e1d387a04add8be9a281fcc3f78a867990248b3
2021-10-28 17:49:19 -07:00
Jayant Chowdhary
763d122fd2 Add CONTROL_VIDEO_STABILIZATION_MODE_PREVIEW_STABILIZATION to allow for better preview stabilization.
Add CONTROL_VIDEO_STABILIZATION_MODE_PREVIEW_STABILIZATION. This CaptureRequest key may be
advertised by devices which can support applying the same quality of
stabilization to preview and other non-RAW streams. This helps clients
achieve a what you see is what you get effect.

Bug: 170230992

Test: builds

Change-Id: I6e115f5b98cdb07ba20055c2a1fba9cdad7e595c
Signed-off-by: Jayant Chowdhary <jchowdhary@google.com>
2021-10-27 17:26:03 +00:00
Rucha Katakwar
abe080d6e3 Camera: Add torch brightness control keys.
1.FLASH_INFO_STRENGTH_MAXIMUM_LEVEL : Number of brightness levels.
2.FLASH_INFO_STRENGTH_DEFAULT_LEVEL : Default brightness level to be set
via setTorchBrightnessLevel API.

bug: 200174275
Change-Id: Iab35bc3cbc8c8ede0b1729f45be4b8ba1b3fed78
2021-10-14 11:59:18 -07:00