Commit graph

243 commits

Author SHA1 Message Date
Scott Randolph
3fea05cd40 Fix name of Wheel to VehicleAreaWheel
All but this enum follow the naming pattern.  Now Wheels do too.

Test:  Build Mojave and Owl
Bug: 79995183
Change-Id: Ifa9efd50aaae13ac7f437c5efe8cf70aa64218e9
2018-05-21 18:27:39 -07:00
TreeHugger Robot
cf31bf85a9 Merge "Remove ConfigFlags" into pi-dev 2018-05-21 22:26:28 +00:00
Steve Paik
3de778f448 Remove ConfigFlags
ConfigArray replaces the need for configFlags.  Deprecate this before it
gets released.

Bug: 74133619
Test: grep -ril configflag shows all instances removed
Change-Id: I645862507959738eb2739e70a53827b749e88aeb
2018-05-16 17:48:49 -07:00
Steve Paik
de2feefd4d Update default config areaId's
Bug: 79752968
Test: Embedded Kitchen Sink

Change-Id: I9b32c22ae2f141c1ead7d3969186fa513e785ccf
2018-05-16 15:45:51 -07:00
Kiran Rachuri
e9a39e2714 Update types.hal comments
(1) Specify rules for property to area mapping
(2) Fix comment for WHEEL_TICK property
(3) Document the need for supported gears from vhal. CURRENT_GEAR and GEAR_SELECTION should report the list of available gears in the vehicle. This helps in determining the driving state of the vehicle.
Merge changes from ag/4051112 ag/4026897

Bug: 79434788
Bug: 77849652
Bug: 79260189
Test: Build and Flash
Change-Id: Ib2bd488a5ec09fe3bdf8807c253aebcdb240324b
2018-05-15 17:18:09 +00:00
Chao Yan
7a53d3e9af Merge "Added fake VHAL value generator based on JSON file" into pi-dev 2018-05-10 22:41:17 +00:00
Chao Yan
f63c2cad23 Added fake VHAL value generator based on JSON file
Note: It only supports a single generation task at any time. Mixed value
properties like diagnostics frame is not implemented yet. It only
supports properties with ON_CHANGE mode for now.

Bug: 76017041
Test: lunch bat_land-userdebug & m -j8; adb push <json_data>
/data/local/tmp; use python emulator to inject fake value "start" command
specifying the JSON data path on device; verify values on KitchenSink app

Change-Id: Ic964ef52a19422bab7015fe54c7e4c5ef8b47a55
2018-05-10 11:05:28 -07:00
Kiran Rachuri
73bfa71121 Merge "Add HVAC properties" into pi-dev 2018-05-07 22:15:01 +00:00
Kiran Rachuri
74570ecb71 Add HVAC properties
Bug: 79265187
Test: Build and flash locally. Test using GAS Vehicle APIs Test App
Change-Id: I3e127af55716c29eddc4f844e431a9efb397afa0
2018-05-05 08:08:10 -07:00
Scott Randolph
ba7d8361f7 Merge "Remove ENV_CABIN_TEMPERATURE from VHal" into pi-dev 2018-04-30 23:08:31 +00:00
Scott Randolph
3c807a5ca4 Remove ENV_CABIN_TEMPERATURE from VHal
This property was an inadvertent duplicate of HVAC_TEMPERATURE_CURRENT.

Test:  Build OWL and Mojave
Bug: 78599196
Change-Id: I698217de0fa91ed817ec95a375a0949160ae8be5
2018-04-25 19:48:26 -07:00
Steve Paik
24139744a5 Use configArray for HVAC_POWER_ON
Bug: 77167122
Test: EmbeddedKitchenSink
Change-Id: I6a178396c3c44c37b33b74b8481ef39b53a36189
2018-04-25 17:53:03 -07:00
Steve Paik
5fc65ccafc Rename EV_CONNECTOR_TYPE enums
Bug: 78571971
Test: Documentation / naming update
Change-Id: I6ca65a9a745d9f5dd109f5b47a3a4af4d818fe39
2018-04-25 11:09:14 -07:00
TreeHugger Robot
e6da8cb609 Merge "Update Android.bp via update-makefiles.sh" into pi-dev 2018-04-20 09:21:55 +00:00
Michael Butler
23ee97e748 Update Android.bp via update-makefiles.sh
When calling update-makefiles.sh there are
some unrelated changes that were missed in
previous commits.

Bug: 68112778
Test: mma
Change-Id: I22b76f3d5bcd084afd2f06e613d2f9f37c1a0c9c
2018-04-18 19:34:10 +00:00
Scott Randolph
7400d1c5f5 Update VHAL comments to clarify useage
Window position and motion updated.
Also added comments calling out explicit temperature units.

Test:  Build mojave
Change-Id: If283a5f0de1ff6e9b2d3c21bcd652de55e2d7046
Bug: 77983671
2018-04-18 08:59:28 -07:00
Steve Paik
28b9f8be0b Update VHAL types.hal
Revised types.hal:
  - Add documentation to everything
  - Remove radio property
  - Update Power Manager properties
  - Cleanup formatting

Bug: 77301298
Test: It compiles
Change-Id: I05a1b3269092c05e7f56c57166d2aebe420d7f6a
2018-04-02 22:45:20 -07:00
Ram Periathiruvadi
899d09c3ff Merge "Deprecate DRIVING_STATUS vehicle property." into pi-dev 2018-03-30 20:37:50 +00:00
Enrico Granata
e0bce7913b Merge "Teach VehiclePropertyStore to not propagate the status value when a set() operation comes from Android" into pi-dev 2018-03-30 18:07:22 +00:00
Ram Periathiruvadi
b4ec3dd5cf Deprecate DRIVING_STATUS vehicle property.
DRIVING_STATUS is not required from VHAL.  It will be derived from other
car sensor vehicle properties in higher layers.

Bug: 71793754
Test: compile and boot.
Change-Id: Ia9f9aeb0e7ff0f16c66422ecb4dc9ad9c152a844
2018-03-29 15:43:32 -07:00
Pavel Maltsev
f0cd5e146a Extend VHAL test property to allow inject events
This is needed for e2e testing, specifically to emulate steering-wheel
buttons from KitchenSink app

Bug: 74616964
Test: manual through kitchensink app
Change-Id: I08de2404f9e17af6b08c2cb1f0fbdc45c655a405
2018-03-29 14:12:59 -07:00
Enrico Granata
8acfc2246a Teach VehiclePropertyStore to not propagate the status value when a set() operation comes from Android
The status field of a property represents properties of the underlying implementation and it should thus
be read-only to Android. Add a way for VehiclePropertyStore to be told whether it does (or does not) need to
propagate the field to the stored property value.

Test: build
Bug: 76034442
Change-Id: I333fab7e296f425cf5c4a35ae136ccfbaa542379
2018-03-27 16:29:40 -07:00
TreeHugger Robot
3df7964f07 Merge "Fix AP_POWER_BOOTUP_REASON to be static" into pi-dev 2018-03-26 19:03:04 +00:00
Enrico Granata
ad7b927993 Make toInt() a little bit shorter by moving std::underlying_type to a template argument
No feature change.

Bug: b/75328113
Test: build
Change-Id: I262493821da7bb06618680932cf93ec25671cfe4
2018-03-23 22:41:40 +00:00
Steve Paik
25aa123f7d Fix AP_POWER_BOOTUP_REASON to be static
Bug: 69284418
Test: VTS passes
Change-Id: Ia4816b4d9329c8bd02bf325aed6cfe5bdda30c70
2018-03-23 14:26:35 -07:00
Nathan Harold
c893754c0d Update Makefiles Missed In Previous Commits
When calling update-makefiles.sh there are
some unrelated changes that were missed in
previous commits.

Bug: 8675309
Test: compilation
Change-Id: I5bf67fbcc809de36bde1869ada7b835566a5198b
2018-03-19 16:37:46 -07:00
TreeHugger Robot
7371502a1f Merge "VehicleHal::set() should not be able to tamper with a property's AVAILABLE status Properties being (UN)AVAILABLE is used as a one-way communication mechanism from the hardware to the operating system, and not viceversa." into pi-dev 2018-03-17 03:43:20 +00:00
Enrico Granata
74268e6490 VehicleHal::set() should not be able to tamper with a property's AVAILABLE status
Properties being (UN)AVAILABLE is used as a one-way communication mechanism from the hardware
to the operating system, and not viceversa.

Add safety checks in our default HAL implementation to:
  - prevent Android from marking a property as UNAVAILABLE;
  - prevent Android from writing to an UNAVAILABLE property.

The combined effect of these two check is that only AVAILABLE properties are writable,
and they can never be flipped to UNAVAILABLE outside of the HAL implementation itself.

Bug: 74805437
Test: manual
Change-Id: Ib830427d604579015fa142f0fa76f8b73a68a452
2018-03-16 18:31:27 -07:00
Enrico Granata
0dd64f7b78 When writing a VehiclePropValue to the store, update its status
Bug: 74805437
Test: manual
Change-Id: I0269ae3b2584af3959d3fd3beaf06e3c4272f793
2018-03-15 17:16:10 -07:00
Steve Paik
1b48bba00e Add power properties
Refactor handling of property specific code in emulator.  The
AP_POWER_STATE property is different from other properties in the system
because it has different values for get/set.  Thus, it needs to be
special cased by the default emulator.

Bug: 32061842
Test: VHAL emulator
Change-Id: Ic325ef401abbcf09a7808a9eca01cbfe8b3cc94f
2018-02-26 14:51:26 -08:00
Kamaljeet Maini
8c0b8275a3 Revert "Add power properties"
This reverts commit fe360dec66.

Bug: b/73780849
Test: Build and flash locally
Change-Id: I19370fce3508439575c1e0587bcedd5ed4528e8e
2018-02-22 16:31:37 -08:00
Steve Paik
fe360dec66 Add power properties
Bug: 32061842
Test: VHAL emulator
Change-Id: I39e73b57b0951566a692339b30bdce8bf2a33d12
2018-02-21 13:40:44 -08:00
Aditi Nagaraj
666a2a22a1 AreaId is not expected for the Vms VehicleProperty
Bug: 72972190
Test: ran manager-unit-test on mojave
Change-Id: I7d7d93aca19aaa1abf67bd69b59c27e3f9140ed1
2018-02-13 11:08:42 -08:00
Steve Paik
27bfe5ce9f Merge "Add ENGINE_OIL_LEVEL, PARKING_BRAKE_AUTO_APPLY" 2018-02-06 19:33:13 +00:00
TreeHugger Robot
441becc921 Merge "Modify FAN_DIRECTION to be a bit mask" 2018-02-03 00:09:15 +00:00
Steve Paik
84b5aeaaf9 Add ENGINE_OIL_LEVEL, PARKING_BRAKE_AUTO_APPLY
Bug: 62337898
Bug: 62337346
Test: Vehicle emulator test
Change-Id: If2ea2ccb0b128e7f30a747e329fd3b7bd0d0234b
2018-02-02 14:47:14 -08:00
TreeHugger Robot
bc72cdf1ea Merge "Remove unused property from Vehicle HAL" 2018-01-31 01:30:30 +00:00
Steve Paik
ded5e17510 Modify FAN_DIRECTION to be a bit mask
We are changing VehicleHvacFanDirection to be a bit mask so that any
combination of fan directions can be made.  This means that
HVAC_FAN_DIRECTION_AVAILABLE must now be a int32_vector.

Bug: 72221544
Test: Unit tests pass
Change-Id: I602871c95aa2429ea334ec85a879610c68979184
2018-01-29 16:52:52 -08:00
Pavel Maltsev
eccbbf8538 Remove unused property from Vehicle HAL
Fix: b/72159812

Test: m -j ; verified device is booting up

Change-Id: I99b59d58dd713d48c50be1a12d9ee2019861c080
2018-01-26 11:59:31 -08:00
Steve Paik
54f2ac6994 Fix missing copies of status member variable
Bug: 72348165
Test: Status appears in Embedded Kitchen Sink
Change-Id: Ia6a672fa44f0c1d5a7fe04234897d73b3f45e939
2018-01-26 11:10:45 -08:00
TreeHugger Robot
a4c3b60c2c Merge "Update emulator protobuf to include status" 2018-01-26 03:24:18 +00:00
Steve Paik
5160ba3455 Update emulator protobuf to include status
Add status
Remove supported_areas

Bug: 72348165
Test: Use python emulator to get/set values
Change-Id: Iad84305a49b260ff02b28685f581a82ca7ff8195
2018-01-25 16:26:38 -08:00
TreeHugger Robot
f30add84f8 Merge "Refactor VHAL" 2018-01-25 00:36:29 +00:00
Asaf Rosenfeld
743bc7450b Merge "Adding missing VMS PublisherId functionality to vehicle hidl. VMS latest functionality which was added as part of the API review." 2018-01-24 07:28:20 +00:00
Asaf Rosenfeld
dbb17a280d Adding missing VMS PublisherId functionality to vehicle hidl.
VMS latest functionality which was added as part of the API review.

Change-Id: I8866d659e0df750eb86f1f3916aababf37e40649
Test: pending on later ref hal impl similar to other enums.
2018-01-23 17:12:21 -08:00
Steve Paik
1ae977d6e8 Refactor VHAL
This CL contains the following modifications:
- Add INT64_VEC type
- Rename VehiclePropertyType:COMPLEX to MIXED
- Remove supportedAreas from VehiclePropConfig
- Allow an areaId to contain multiple zones/seats/windows
- Remove ROW_* zones
- Remove zone/areaId from subscribe() interface
- CLANG formatting

Bug: 72348165
Test:  Compiles
Change-Id: I274dc69b6532a06433a0409c7ca44d0a5bce65af
2018-01-23 14:52:18 -08:00
Anthony Mah
a9d8c0d0f1 interfaces: Automotive Vehicle HAL shared lib def
Revise the definitions for Vehicle HAL bp file.

Bug: b/67430788
Test: Buits and boots

Change-Id: I57ca7ed41de3fd58860b6a1f226c53dcdd6287bf
2018-01-19 13:20:09 -08:00
Hongwei Wang
8655bc3e59 Removes deprecated audio property in vehicle hal
Bug: 72054677
Test: None
Change-Id: I68a29c786dabf99afb4c44b49586f372a97abae6
2018-01-18 21:01:24 +00:00
TreeHugger Robot
43a354641e Merge "Remove AUDIO_* properties." 2018-01-13 04:17:30 +00:00
Scott Randolph
525ff2d2e7 Remove AUDIO_* properties.
See go/aae-audio for an implementation guide for automotive that does
not rely upon these car specific properties.  The very small remaining
automotive specific elements will be represented in the automotive audio
control HAL.

Change-Id: Ia2147a8e486bdb896097771970f0527fc630b9c4
Test:  not yet.  Will run vhal VTS tests.
2018-01-11 15:07:26 -08:00