Commit graph

137 commits

Author SHA1 Message Date
Kevin Chyn
6424d7ea26 Address HIDL review comments
Fixes: 127852175

Test: builds
Test: hidl-gen -L hash -r android.hardware:hardware/interfaces android.hardware.biometrics.face@1.0
      hash added to current.txt
Test: make -j56 VtsHalBiometricsFaceV1_0TargetTest

Change-Id: I4a8b6db5824a686ec742ed826ff26e721ff26dc8
2019-03-11 18:56:17 -07:00
Kevin Chyn
b936d1d684 Add SENSOR_DIRTY constant
Fixes: 127993599

Test: Test: hidl-gen -L hash -r android.hardware:hardware/interfaces android.hardware.biometrics.face@1.0
      add updated hash to current.txt
Test: Builds

Change-Id: I98a7953f3a99f263709a15f143a3ca5fd062b489
2019-03-11 11:21:14 -07:00
Kevin Chyn
41b986fb1a Merge "Finalize IBiometricsFace@1.0" 2019-03-06 19:29:58 +00:00
Kevin Chyn
25fe23f55f Finalize IBiometricsFace@1.0
Also update VTS tests

Fixes: 125936336
Fixes: 124512763
Fixes: 123262389

Test: hidl-gen -L hash -r android.hardware:hardware/interfaces android.hardware.biometrics.face@1.0
      add updated hash to current.txt
Test: Builds

Change-Id: I7949b251064d4578a89f6da834aadbfdf7e9a94f
2019-03-05 18:14:51 -08:00
Steven Moreland
87f43604b9 Merge "Update makefies: no 'types' internal" 2019-03-05 17:40:03 +00:00
Steven Moreland
7f4e21adda Merge "Update makefies: no 'types'" am: 4ee5ec1469 am: bab622f6a6
am: 7224bc9bcf

Change-Id: I434939e0770afa436c532a945542fce30a71ef7d
2019-03-04 16:05:59 -08:00
Steven Moreland
b91ac5c6a0 Update makefies: no 'types' internal
Bug: 123976090
Test: N/A
Change-Id: I84b659b163b63d39535b462a3df8a9c19f680976
2019-03-04 14:09:25 -08:00
Steven Moreland
a878aee9ab Update makefies: no 'types'
Bug: 123976090
Test: N/A
Change-Id: I30fb04c81889b62775e1b764b965fdb0f893de17
2019-03-04 11:27:17 -08:00
Ilya Matyukhin
1a34e407bf Implemented VTS tests for BiometricsFace.hal
Test: manually built and ran the tests
Fixes: 110708105
Change-Id: Id2882436b2346032b080cee16a9fc289ee3dbdc2
2019-03-01 10:54:38 -08:00
Kevin Chyn
1c16445989 resetLockout should return Status instead of bool
The actual lockout reset is asynchronous and returns its result in the
onLockoutChanged() callback

Bug: 121196511
Bug: 121198195
Bug: 123262389

Test: Builds
Change-Id: Ia5fd34d77ae1f8dba1a943e0e1fc51d458753090
2019-02-13 14:11:29 -08:00
Kevin Chyn
2065f80836 Merge "Add onLockoutChanged for IBiometricsFace" 2019-02-13 17:40:27 +00:00
Kevin Chyn
99625ae670 Add onLockoutChanged for IBiometricsFace
Lockout is moved to the HAL (as compared to IBiometricsFingerprint@2.1)
To maintain public API behavior (BiometricPrompt) there needs to be a
way to synchronously retrieve the lockout status.

Bug: 121196511
Bug: 121198195
Bug: 123262389

Test: Builds
Change-Id: Idb0a1225451e9f123ccb42accbbbd2914ad6cabc
2019-02-12 17:33:16 -08:00
Steven Moreland
f8a47b7f01 Update makefiles.
Bug: 123976090
Test: N/A
Change-Id: I5fb6c126a090a3fe0fa4829ea9224564133dc1ae
2019-02-11 21:14:16 -08:00
TreeHugger Robot
b5556e576b Merge "Fix incorrect comments in types.hal" 2019-02-01 22:31:18 +00:00
Kevin Chyn
fbdc22e7b8 Fix incorrect comments in types.hal
Bug: 123262389

Test: Builds
Change-Id: I56f60c5ac61be6fdd1f1c49f5a7d8ac0e41d2572
2019-01-31 16:16:28 -08:00
Zachary Iqbal
a4c77b9edd Removed completed TODOs from IBiometricsFace HIDL.
Change-Id: I6ef9de184acfe3e1b7dd7f3519c64cc74fb6506d
Test: Built locally.
2019-01-31 15:55:12 -08:00
Kevin Chyn
448e2cf84c Add ACQUIRED_START message
Fixes: 123520106
Bug: 117060268

Test: Builds
Change-Id: Ie2fda4f2cdbae1d9b5f2ed08975f3cd8e98c169b
2019-01-28 12:44:32 -08:00
Kevin Chyn
54c13ddf60 Add additional acquired constants
Fixes: 123101870

Test: Builds
Change-Id: I67365b4a821c43ac01810119e9f1fa24f27d3c7f
2019-01-24 11:20:00 -08:00
Kevin Chyn
16d891dd3d Move lockout to below the HAL
Fixes: 120630211

Test: builds
Change-Id: I87ae317110d0ef6cf5b82afe6ee7724527f9f64e
2018-12-14 16:44:26 -08:00
Kevin Chyn
a009f89d01 Allow multiple accessibility features
Fixes: 120578823

Test: builds
Change-Id: I9f823f0f00e6a6030d777844aedf90b982b2e291
2018-12-11 19:52:27 -08:00
Keun Soo YIM
68ae05dd2d pack VTS cc_test binaries as general-tests
Test: make general-tests
Bug: 120093339
Merged-In: I363450d205868f900e4925ccff1430e2a569f2a4
Change-Id: I363450d205868f900e4925ccff1430e2a569f2a4
2018-12-07 10:49:56 -08:00
Andrew LeCain
c812b022ed Adding uhid permissions to default fingerprint rc
Test: Sailfish has fingerprint present
Bug: 120112580

Change-Id: I11c3bf02ddb2102a6d326a35e360e067812b0b75
2018-12-03 23:18:37 +00:00
Keun Soo YIM
ff84c37bc1 pack VTS cc_test binaries as general-tests
Test: make general-tests
Bug: 120093339
Change-Id: I363450d205868f900e4925ccff1430e2a569f2a4
2018-11-27 16:11:41 -08:00
Kevin Chyn
b480f01178 Add face acquired constants
Fixes: 118382625

Test: Builds
Change-Id: I3c9203c7e593aee3b110dd00e31687e364ff78bc
2018-10-25 10:53:58 -07:00
Kevin Chyn
ba9ec8795a Add IBiometricsFace#userActivity
Fixes: 116821097

Test: builds
Change-Id: I88363e186a41ce65665122606b357c7d31d8c18d
2018-10-03 18:16:30 -07:00
Kevin Chyn
2acfd2aab6 Add timeout parameter to generateChallenge
Fixes: 115925222

Test: builds
Change-Id: Idac1730b36eadb5acdb6420cc330585ebb2f3197
2018-09-24 15:27:03 -07:00
Kevin Chyn
0a9e402efe Update FaceAcquiredInfo comments
Fixes: 110887097

Test: builds
Change-Id: Ia38043cf292401aea15a34118c2cc59cacd743f0
2018-09-19 17:01:49 -07:00
Kevin Chyn
af5d0a6d1d Add setter/getter for requireAttention
Also renames pre/postEnroll to get/revokeChallenge

Bug: 110597778

Test: builds
Change-Id: I5547504b27e0f6d304f016e02be91aa15e548e5f
2018-09-05 01:46:36 -07:00
Kevin Chyn
57acf9749a Update Face HIDL enroll method
Bug: 110597778

Test: builds
Change-Id: I61e4f4a61ad0561448bc50a29b84b668e9569551
2018-09-05 00:32:11 -07:00
Steven Moreland
7a8b83e1ee vts fingerprint: IWYU utils/Condition.h am: 75023074cf am: 7f55da96a7 am: 342802f1f5
am: c11f6da572

Change-Id: I48596a08a52e3661d05c52edcd7e79d48bcbbed5
2018-08-08 11:12:39 -07:00
Steven Moreland
75023074cf vts fingerprint: IWYU utils/Condition.h
The standard library should be used instead of this class in new code,
but for simplicity, just IWYU (exposed by removing some headers from
some HIDL).

Bug: 65843592
Test: m only
Change-Id: Ib27c4c89a6aae551ebaeed05fc1bbadd780f4ba0
2018-08-07 21:36:11 +00:00
Zachary Iqbal
1f7007465d Added initial HIDL interface for the biometric face HAL.
Notes:
- Added a basic interface, a stub callback interface and a stubs for
  needed public types.
- Ran make hidl-gen -j64 && hardware/interfaces/update-makefiles.sh
  to create build files for the interface.

Bug: 79577138
Test: None added. This commit simply adds a new interface.
Change-Id: I14b7238dd9ee1076f77c1b60117bdaa156a4f0f5
2018-06-19 12:04:43 -07:00
joshmccloskey
7897d0f573 Modified tests to account for different directories being used based on
different first API levels

Fixes: 80028983
Test: Ran tests on P17 and P18
Change-Id: I2752c5b8e15dc5e3ee386b0079a75b482a21543f
2018-05-29 21:44:10 +00:00
Tim Murray
d0fdb4431d fpc: keep fpc in system-background
The fingerprint HAL is insensitive to increased CPU throughput, but it also
has a tendency to spin while waiting for FP hardware. Limit FPC to the
system-background cpuset in order to avoid increased power consumption
when accidentally touching the fingerprint sensor.

bug 76115243
Test: fingerprint in system-background cpuset on taimen

Change-Id: Iaffe6f63bd76b7a1c4acaf0cae980840af515961
2018-03-21 15:42:09 -07:00
Zhuoyao Zhang
4d413de2e7 Convert fingerprint hal test to use VtsHalHidlTargetTestEnvBase am: e95d49ac44 am: 8c85bdb217
am: 1d56f169e2

Change-Id: Icc48f25f2800a5780f467c406c8d7a59e483ad04
2018-02-09 17:50:28 +00:00
Zhuoyao Zhang
e95d49ac44 Convert fingerprint hal test to use VtsHalHidlTargetTestEnvBase
Bug: 64203181
Test: make vts
      vts-tradefed run vts -m VtsHalBiometricsFingerprintV2_0Target

Change-Id: Ia5be72669a8abae64009c659b6c991a0e64c2d0d
2018-02-08 22:24:04 -08:00
TreeHugger Robot
7d7eae9f78 Merge "Remove subdirs" into stage-aosp-master 2017-11-29 01:16:32 +00:00
TreeHugger Robot
fb9588efc0 Merge "Remove subdirs" 2017-11-29 00:48:42 +00:00
Chih-Hung Hsieh
bbeae6fe23 Use -Werror in hardware/interfaces/biometrics/fingerprint am: 5631258f07 am: a5d28736f4
am: f5f555522b

Change-Id: Ic3bc06c4a3a404f395ced8a64b04d4d27905d3b7
2017-11-29 00:19:02 +00:00
Chih-Hung Hsieh
a5d28736f4 Use -Werror in hardware/interfaces/biometrics/fingerprint
am: 5631258f07

Change-Id: I6c81b78c4d00faccefdaa3e40ebcecc26222c5e9
2017-11-29 00:02:41 +00:00
Steven Moreland
e5c6548346 Remove subdirs
Removing whenever I see these in code reviews.

Test: none
Merged-In: I4322f533a837d55618ec2ed2125e8966ace9d61d
Change-Id: I4322f533a837d55618ec2ed2125e8966ace9d61d
2017-11-28 14:23:43 -08:00
Steven Moreland
fcca4e23b7 Remove subdirs
Removing whenever I see these in code reviews.

Test: none
Merged-In: I4322f533a837d55618ec2ed2125e8966ace9d61d
Change-Id: I4322f533a837d55618ec2ed2125e8966ace9d61d
2017-11-28 14:22:43 -08:00
Chih-Hung Hsieh
5631258f07 Use -Werror in hardware/interfaces/biometrics/fingerprint
* Fix warning of unused function call result.

Bug: 66996870
Test: build with WITH_TIDY=1
Change-Id: I91da207b80d0715d015195357d645f8cf324fa1e
2017-11-28 13:40:33 -08:00
Xin Li
bb9e38fef9 Merge commit '1a06284b24f5eb7bb9c1fea0817da8898b3b1bff' from
oc-mr1-dev-plus-aosp into stage-aosp-master

Change-Id: I2a044eb8c9981d0a8198ffe2df55559afbd76341
Merged-In: I4fb9f18884f7ef21162015a0032c4431444f7025
2017-11-14 12:08:38 -08:00
Steven Moreland
8db261bc99 Updating makefiles for hidl_interface.
Bug: 64487114
Test: manual
Merged-In: Ie13d9e014cf2b81c18c67f551b4644fb9f0ba812
Change-Id: Ie13d9e014cf2b81c18c67f551b4644fb9f0ba812
2017-11-13 10:00:18 -08:00
Steven Moreland
a1169dd600 Update makefiles for hidl_interface.
Bug: 35570956
Test: manual
Change-Id: I7a220b78ee081240e1dc30ef5672ba39e3e98375
2017-11-10 09:06:55 -08:00
Steven Moreland
d28c1bdf62 Merge "Automatic mk -> bp." am: e5fd969f19 am: 72c720a4e3
am: 26013bf6ac

Change-Id: Id936fb4806d122045c771c951220361efeef10c6
2017-11-07 21:24:49 +00:00
Steven Moreland
26013bf6ac Merge "Automatic mk -> bp." am: e5fd969f19
am: 72c720a4e3

Change-Id: Icfc8b46117e94461906806023852836a0ace3a55
2017-11-07 21:21:40 +00:00
Steven Moreland
90e3a50f03 Automatic mk -> bp.
Automatic mk -> bp conversion for all modules here
which can be converted and built automatically.

Test: Soong resolves all dependencies
Bug: 37512442
Change-Id: Ib789212cb88d55731397c600d132e7c672c0d8be
2017-11-03 16:30:28 +00:00
Tri Vo
dce01a0e64 Merge "Change tmp dir to /data/system/users/0/fpdata/." am: 3f4e982fbc am: 05a6820b76 am: 245ae95aa1
am: 75a193f6dc

Change-Id: Ic0a809c865d5bc4546483fff5dc34609ab024915
2017-10-15 04:00:09 +00:00