Commit graph

103 commits

Author SHA1 Message Date
Steven Moreland
146405b58a Note confusion-causing breaks in HIDL convention.
These were either made at a time when the convention was not fully
formed or missed during review.

It is somewhat misleading since method overloading isn't supported
and method names need this kind of prefix, but nothing else does.

The reason for this is that everything is namespaced, but methods are
all in the same namespace. The reason method overloading is not supported
in HIDL is because the HIDL types may map to types that collide in the
target languages, and this would cause any sort of overloading rules
to require complicated machinery.

Bug: N/A
Test: hidl-gen -Lcheck android.hardware.usb@1.1 android.hardware.vibrator@1.1 && echo ":)"
:)

Change-Id: Iac23c9311925ed140ff1e15d1366829b078c8866
2018-09-09 12:31:05 -07:00
Hsin-Yi Chen
bf03ebe580 Merge "Fix IUsb version number in vts test"
am: a85e213544

Change-Id: If12009a78905e1e0639767a8b01acdabda17e715
2018-07-09 19:47:57 -07:00
Hsin-Yi Chen
b4193b855c Fix IUsb version number in vts test
Bug: 110913709
Test: vts-tradefed run vts -m VtsHalUsbV1_1Target
Change-Id: I9ae6add2fe8ff7138e07797c3a191b6dfe611948
2018-07-04 11:19:38 +08:00
Steven Moreland
913c071391 Update comments for doc comments.
Doc comments look like "/** ... */" and they
can only be in certain places.

Bug: 79865343
Test: m
Change-Id: Ic15c08ff7dc6e4f9827c1dbe7f7236c11a572ec1
Merged-In: Ic15c08ff7dc6e4f9827c1dbe7f7236c11a572ec1
2018-05-21 14:36:29 -07:00
Steven Moreland
4ee4582230 Update comments for doc comments.
Doc comments look like "/** ... */" and they
can only be in certain places.

Bug: 79865343
Test: m
Change-Id: Ic15c08ff7dc6e4f9827c1dbe7f7236c11a572ec1
2018-05-18 10:10:32 -07:00
Zhuoyao Zhang
3818705c2d Merge "Convert usb hal test to use VtsHalHidlTargetTestEnvBase" am: a5123bb1b8 am: ef151c3693
am: 5c5382e428

Change-Id: I1723f96bd7e05320db3b89ef75d70f9051750251
2018-02-09 20:43:01 +00:00
Zhuoyao Zhang
f5b45790b1 Convert usb hal test to use VtsHalHidlTargetTestEnvBase
Bug: 64203181
Test: make vts
      vts-tradefed run vts -m VtsHalUsbV1_0Target
      vts-tradefed run vts -m VtsHalUsbV1_1Target

Change-Id: I49d8af2b53e484cc68fcb72f75f8bfafc6d02f59
2018-02-09 17:56:55 +00:00
Badhri Jagan Sridharan
d537eaa72f Merge "Usb: HIDL: UsbGadget hal" am: 204314ace2 am: bf0de22c38
am: 61eca713bc

Change-Id: Id0adc5b8280d54fd2c54055800231c06ef948a4a
2018-01-23 18:56:59 +00:00
Badhri Jagan Sridharan
4a93dec03c Usb: HIDL: UsbGadget hal
Hal interface for runtime management of USB gadget confiuguration.

Bug: 63669128
Test: Manually tested usb gadget hal for usb configurations
Change-Id: I1913dd5b99fdf4d710a2b0695c616c1d27575c53
2018-01-22 19:23:51 +00:00
Badhri Jagan Sridharan
eebbb9eaf0 Merge "usb: Add owner file" am: 75b87347aa am: 576cd45e62
am: 2d329121fb

Change-Id: I335f5b2349bf9ee2fa808135c02c594f86b5e049
2017-11-29 17:49:05 +00:00
Badhri Jagan Sridharan
576cd45e62 Merge "usb: Add owner file"
am: 75b87347aa

Change-Id: I9a56bb1d38634494dbc48446b313bd4077b4862d
2017-11-29 17:40:57 +00:00
Treehugger Robot
75b87347aa Merge "usb: Add owner file" 2017-11-29 17:34:32 +00:00
Steven Moreland
e5c6548346 Remove subdirs
Removing whenever I see these in code reviews.

Test: none
Merged-In: I4322f533a837d55618ec2ed2125e8966ace9d61d
Change-Id: I4322f533a837d55618ec2ed2125e8966ace9d61d
2017-11-28 14:23:43 -08:00
Steven Moreland
fcca4e23b7 Remove subdirs
Removing whenever I see these in code reviews.

Test: none
Merged-In: I4322f533a837d55618ec2ed2125e8966ace9d61d
Change-Id: I4322f533a837d55618ec2ed2125e8966ace9d61d
2017-11-28 14:22:43 -08:00
Badhri Jagan Sridharan
2520bb2aaa usb: Add owner file
Test: build/make/tools/checkowners.py -c -v OWNERS
Change-Id: I0fe896da5eb1bf416d4c305a0188b52922a2e292
2017-11-27 20:51:09 +00:00
Badhri Jagan Sridharan
1be1d4aad0 Initialize usb_count in the setup funtion. am: 9272727df8 am: cf105b679d
am: f437c82c13

Change-Id: I058823dd372fa34aa6d87dfde06329dfefd08731
2017-11-20 18:03:20 +00:00
Badhri Jagan Sridharan
cf105b679d Initialize usb_count in the setup funtion.
am: 9272727df8

Change-Id: I8ca47ee5d3481319f36d3a58e9410d65ed442fdc
2017-11-20 17:58:43 +00:00
Badhri Jagan Sridharan
9272727df8 Initialize usb_count in the setup funtion.
Spurious wakeups can cause the test thread to return even if the
callback was not actually called as the usb_count isnt initialized.

Bug: 65469351
Test: mma and pushed locally to the device & tested.
--skip-preconditions --module VtsHalUsbV1_0Target
Change-Id: Ib0e838cf4a44807142eab6aa5e9df0cc462bb973
2017-11-17 12:58:34 -08:00
Xin Li
bb9e38fef9 Merge commit '1a06284b24f5eb7bb9c1fea0817da8898b3b1bff' from
oc-mr1-dev-plus-aosp into stage-aosp-master

Change-Id: I2a044eb8c9981d0a8198ffe2df55559afbd76341
Merged-In: I4fb9f18884f7ef21162015a0032c4431444f7025
2017-11-14 12:08:38 -08:00
Steven Moreland
8db261bc99 Updating makefiles for hidl_interface.
Bug: 64487114
Test: manual
Merged-In: Ie13d9e014cf2b81c18c67f551b4644fb9f0ba812
Change-Id: Ie13d9e014cf2b81c18c67f551b4644fb9f0ba812
2017-11-13 10:00:18 -08:00
Steven Moreland
a1169dd600 Update makefiles for hidl_interface.
Bug: 35570956
Test: manual
Change-Id: I7a220b78ee081240e1dc30ef5672ba39e3e98375
2017-11-10 09:06:55 -08:00
Steven Moreland
c5bc4c7cbb Update makefiles after AOSP push.
Test: none
Change-Id: If3ce74f4d2250d33820cbd864ff56bba6f9e6b67
2017-11-01 16:42:15 -07:00
Chih-Hung Hsieh
1024478de1 Use -Werror in hardware/interfaces am: ceb435f2ba am: 1e48a3c563 am: 8247f4a2f3
am: 9d8731e255

Change-Id: Ibe4022b6f8b8089540931e47e78b5f4d8901e855
2017-10-18 00:24:55 +00:00
Chih-Hung Hsieh
9d8731e255 Use -Werror in hardware/interfaces am: ceb435f2ba am: 1e48a3c563
am: 8247f4a2f3

Change-Id: Ib3ac309a84c503eadc5dfa67996b2a9576a0fca5
2017-10-18 00:21:54 +00:00
Chih-Hung Hsieh
1e48a3c563 Use -Werror in hardware/interfaces
am: ceb435f2ba

Change-Id: I34ad0374c02d3733e7901a8296d229f74313fb52
2017-10-18 00:17:51 +00:00
Chih-Hung Hsieh
ceb435f2ba Use -Werror in hardware/interfaces
* Fix warning of unused result.

Bug: 66996870
Test: build with WITH_TIDY=1
Change-Id: I68e35ddcdeec4290b075ececf14f82335b43e22e
2017-10-17 10:12:29 -07:00
Steven Moreland
f390f03aa4 Update for Soong-only makefiles.
Test: pass
Bug: 33420795
Change-Id: Ibec6d1e38939b9e7566a96381439be2aac3bf8ca
2017-10-11 18:30:28 +00:00
Steven Moreland
1d7374c5e1 Update for Soong java makefiles. am: c3e80fa01e am: 0fff75dee1 am: 6c811964a1
am: 116161d94e

Change-Id: I33643636e2511de77fdf7de57777eb67edee2e52
2017-10-11 16:39:21 +00:00
Steven Moreland
116161d94e Update for Soong java makefiles. am: c3e80fa01e am: 0fff75dee1
am: 6c811964a1

Change-Id: I85ccbb4a15cd18938607f5bca4e065b9d7e0182b
2017-10-11 16:31:07 +00:00
Steven Moreland
0fff75dee1 Update for Soong java makefiles.
am: c3e80fa01e

Change-Id: Ia8835f9c95bd98a96f5fd3aff11191e7d3726fb9
2017-10-11 16:23:54 +00:00
Steven Moreland
c3e80fa01e Update for Soong java makefiles.
Test: pass
Bug: 33420795
Change-Id: Id9b1919a19b8ff682738cfb0869a479b4dbb4293
2017-10-10 23:07:20 +00:00
Steven Moreland
8bd117fa0f Merge "Convert usb service .mk -> .bp." am: 16b3e062ce am: de00740271 am: 9a54427e71
am: 7e8a24f2af

Change-Id: Ia9a13bbcc8c1674474b0f24f7efc97245f0f4540
2017-10-05 17:46:56 +00:00
Steven Moreland
7e8a24f2af Merge "Convert usb service .mk -> .bp." am: 16b3e062ce am: de00740271
am: 9a54427e71

Change-Id: Ifbbb16ddd3321be04e7a31664362f1d63e424313
2017-10-05 17:44:57 +00:00
Steven Moreland
de00740271 Merge "Convert usb service .mk -> .bp."
am: 16b3e062ce

Change-Id: Ic8011399e470a1c62156c656a0ea1987ed999382
2017-10-05 17:38:27 +00:00
Treehugger Robot
16b3e062ce Merge "Convert usb service .mk -> .bp." 2017-10-05 17:33:49 +00:00
Steven Moreland
cb7fc21f1a Convert usb service .mk -> .bp.
Test: none
Bug: 33420795
Change-Id: I4b489a08d850b7c49231e0daadcb9d96e57a7e55
2017-10-04 16:02:59 -07:00
Steven Moreland
70bfb9d250 Merge "Update for hidl adapter module defaults." am: 988c977079 am: 861651985f am: b53e6ad535
am: 9a17f41f6f

Change-Id: I78d9292068b372238554fd9d35128e69f5b5f9d2
2017-10-04 21:54:11 +00:00
Steven Moreland
9a17f41f6f Merge "Update for hidl adapter module defaults." am: 988c977079 am: 861651985f
am: b53e6ad535

Change-Id: I23269fb7a9bdd352e670a80f390527d9eef31412
2017-10-04 21:51:00 +00:00
Steven Moreland
861651985f Merge "Update for hidl adapter module defaults."
am: 988c977079

Change-Id: I289818be1b30397391847ba1c532d1014fdbed27
2017-10-04 21:45:09 +00:00
Steven Moreland
527fd76a0e Update for hidl adapter module defaults.
Test: pass
Change-Id: Idc6a943149a279bf17cfcfd0f2571473e53bbbbf
2017-10-04 12:47:03 -07:00
Steven Moreland
3788a7321f Update makefiles for hidl-adapter (2/2).
Bug: 37518178
Test: none
Change-Id: I77fe67964f89da8b66aeb8df6d424de0f8689f8d
2017-09-27 08:55:47 -07:00
Steven Moreland
91799c6cc7 Merge "Fix typo in update makefiles." am: 9960148420 am: f07e364ce3 am: 71a193a425
am: 9fdd241905

Change-Id: I1c852fa6600fecc44d5afd1a65a5f51c43ecf71c
2017-09-27 00:02:52 +00:00
Steven Moreland
9fdd241905 Merge "Fix typo in update makefiles." am: 9960148420 am: f07e364ce3
am: 71a193a425

Change-Id: I45ae43f07323254212532acbf0f891d11143b05f
2017-09-26 23:58:51 +00:00
Steven Moreland
f07e364ce3 Merge "Fix typo in update makefiles."
am: 9960148420

Change-Id: I949634e72f817f3a5411130e968acd8efd1d7725
2017-09-26 23:51:07 +00:00
Steven Moreland
a5299ee739 Fix typo in update makefiles.
Bug: 37518178
Test: pass
Change-Id: Ic401b3a473f15ca4c01e58b3072e19db7c31b653
2017-09-26 21:59:43 +00:00
Steven Moreland
7741c0e17b Update makefiles for hidl adapter. am: 26a0bb2762 am: 73949c1d7e am: b94d0c7290
am: 97228c0b7d

Change-Id: Ic4b459b7c1a4325453945b0b00db8f44e4e77c26
2017-09-26 13:36:09 +00:00
Steven Moreland
97228c0b7d Update makefiles for hidl adapter. am: 26a0bb2762 am: 73949c1d7e
am: b94d0c7290

Change-Id: If766cffbcc003cc0cc5eb98969b924aa918fff44
2017-09-26 12:53:13 +00:00
Steven Moreland
73949c1d7e Update makefiles for hidl adapter.
am: 26a0bb2762

Change-Id: I3a811f5cd49bd4e81e8fcd5c8e88922115812539
2017-09-25 23:14:44 +00:00
Steven Moreland
26a0bb2762 Update makefiles for hidl adapter.
Bug: 37518178
Test: manual
Change-Id: I50e999907d3c64d2b039272b823971998da64d1b
2017-09-25 18:35:56 +00:00
Jaekyun Seok
81104ae5ef Add 'vendor.' prefix to a vendor HAL service name
To prevent property name collisions between properties of system and
vendor, 'vendor.' prefix must be added to a vendor HAL service name.
You can see the details in http://go/treble-sysprop-compatibility.

Test: succeeded building and tested on a walleye device
Bug: 36796459
Change-Id: I4e8fbee791ec917a8f627a1366f4d44ec7e6febc
2017-09-12 08:01:42 +09:00