Commit graph

235 commits

Author SHA1 Message Date
Dan Shi
fdbc494c69 Remove references of VtsHalHidlTargetTestBase
Bug: 147894326
Test: build
Change-Id: If847cc3aa5bb17682b92266f5460efe9d3fadfab
2020-04-13 23:15:50 -07:00
Dan Shi
aad51fa000 Rename vts-core to vts
Bug: 151896491
Test: local build
Exempt-From-Owner-Approval: This CL update suite name vts-core to vts as
the suite name is updated. This CL won't change test logic or behavior.

Change-Id: I562b4dc50765e953800a814a8fd84a01c1b9352b
Merged-In: I562b4dc50765e953800a814a8fd84a01c1b9352b
2020-04-07 16:37:40 -07:00
Dan Shi
170a44526c Convert VtsHalBroadcastradioV1_0/1TargetTest to parameterized gtest
Bug: 142397658
Test: atest VtsHalBroadcastradioV1_0TargetTest \
  VtsHalBroadcastradioV1_1TargetTest
Change-Id: I41329305c4c7da117cd6e76cd3950fa38d9db5c2
2020-04-06 10:54:28 -07:00
Haibo Huang
2d2ca3ca41 Add definitions of GMOCK_RESULT_ and GMOCK_ARG_
These two definitions are removed in new googletest. Copy them here.

(Ideally we should not depend on googletest internal.

Change-Id: I399549dc33dce7a464e81978e0697fc649ff01b0
2020-02-10 22:09:18 +00:00
Dan Shi
27506e64f1 Convert VtsHalBroadcastradioV2_0TargetTest to be parameterized test
Removing dependency from VTS infrastructure so that test can run
standalone, for instance with atest/TEST_MAPPING. Once this is
done for every test, VTS can use the core testing infra.

Bug: 142397658
Test: atest VtsHalBroadcastradioV2_0TargetTest
Change-Id: I0298bb78bc37c99dacca0bc6a0d42e41e40b52c0
2019-12-12 12:58:54 -08:00
Joshua Duong
e951f2a640 Fix stack-pointer constructed sp<>.
Seems like the hidl derived objects must be heap allocated.

Bug: 145662746

Test: Does not boot loop.
Change-Id: I55ff94c12d4eb5fcfd680370736db979ddd0b67c
2019-12-04 10:39:14 -08:00
Steven Moreland
b3a4d3832e Remove libhwbinder/libhidltransport deps
Since these were combined into libhidlbase.

Bug: 135686713
Test: build only (libhwbinder/libhidltransport are empty)
Change-Id: I075670b64eebbbbd6a6ae0e84ad51bf1c6f5ba36
2019-09-06 01:07:02 +00:00
Felix
37298a7616 Merge "Add interface info to .rc files"
am: 98d0f4d52c

Change-Id: Ie6cfbacd523c4b09f77bee3369ec8e88b3fa0419
2019-07-08 12:22:23 -07:00
Felix
551b8d15ce Add interface info to .rc files
Signed-off-by: Felix <google@ix5.org>
Change-Id: I6d70bbdb66c3dce280bf6908c3750316a6f6cf70
2019-06-25 20:00:07 +02:00
Steven Moreland
2e7c641b2c Merge "Add dep to ...broadcastradio@common-utils-2x-tests" into qt-dev
am: d64f48a504

Change-Id: Id77ccc02e5c9f6c2696765a9b13cbc4bb0366b23
2019-04-30 19:18:49 -07:00
Steven Moreland
24621daf45 Add dep to ...broadcastradio@common-utils-2x-tests
Required now because iterators use the base hidl_vec constructor.

It's not expected this type of change would be needed in any places.
This test originally came with the introduction of the constructor
that created the hidl_vec.

Bug: 131356202
Test: build only, links (note b/130918604)
Change-Id: Ide3cb13b6afd79489c208af2396e7c02b7da436e
Merged-In: Ide3cb13b6afd79489c208af2396e7c02b7da436e
2019-04-26 11:31:18 -07:00
Steven Moreland
6d494b2346 Merge "Update hidl makefiles for bpfmt" am: ff0bd741ca
am: 96f40f7b02

Change-Id: Idbf030e4993067bdb8181321bca2de00c9b6f7ef
2019-04-18 14:34:45 -07:00
Steven Moreland
1ae4615d9f Update hidl makefiles for bpfmt
hidl-generated makefiles are now generated such that bpfmt(file) == file.

Bug: 67417008
Test: enable bpfmt hook
Change-Id: I1f69d292bc23a7cc293a66110cb02d597e1019ad
2019-04-17 09:38:50 -07:00
Allie
f62374d024 Initial change to add mock DAB stations (hardcoded for now).
Test: VtsHalBroadcastradioV2_0TargetTest

Change-Id: Ice8923490728402ed945e8cc0891fd8b2c5bf9dd
2019-03-18 15:08:04 -07:00
Steven Moreland
7f4e21adda Merge "Update makefies: no 'types'" am: 4ee5ec1469 am: bab622f6a6
am: 7224bc9bcf

Change-Id: I434939e0770afa436c532a945542fce30a71ef7d
2019-03-04 16:05:59 -08:00
Steven Moreland
a878aee9ab Update makefies: no 'types'
Bug: 123976090
Test: N/A
Change-Id: I30fb04c81889b62775e1b764b965fdb0f893de17
2019-03-04 11:27:17 -08:00
Keun Soo YIM
68ae05dd2d pack VTS cc_test binaries as general-tests
Test: make general-tests
Bug: 120093339
Merged-In: I363450d205868f900e4925ccff1430e2a569f2a4
Change-Id: I363450d205868f900e4925ccff1430e2a569f2a4
2018-12-07 10:49:56 -08:00
Tomasz Wasilczyk
af898821d8 Fix program info call over-saturation.
It was an omission to not allow onCurrentProgramInfoChanged
to be called more than once.

Bug: 120186193
Test: atest VtsHalBroadcastradioV2_0TargetTest
Change-Id: I667c552fb88e8fa3be3931901f7ba86ee7743baa
(cherry picked from commit 3f71e6c33ae34065cbf40ce1a2e4f9914383f969)
2018-12-03 22:34:55 +00:00
Keun Soo YIM
ff84c37bc1 pack VTS cc_test binaries as general-tests
Test: make general-tests
Bug: 120093339
Change-Id: I363450d205868f900e4925ccff1430e2a569f2a4
2018-11-27 16:11:41 -08:00
Tomasz Wasilczyk
84ec4e14f6 Migrate broadcast radio default HAL to the new logging API.
Bug: 112540729
Test: flash and boot
Change-Id: I18d8b508971cd9a9b7b2c9c221674d862ff351d6
2018-11-14 09:28:04 -08:00
Chih-hung Hsieh
1ea726b6d7 Merge "Fix implicit-fallthrough warnings." 2018-10-22 20:36:53 +00:00
Chih-Hung Hsieh
9e1793b891 Allow implicit-fallthrough warnings locally.
It will be a global error by default.

Test: make checkbuild
Bug: 112564944
Change-Id: I3e914835fcb4ee97662ab51136f143e665d0ba01
Exempt-From-Owner-Approval: do not block on new warnings
2018-10-22 09:42:57 -07:00
Chih-Hung Hsieh
63f4fe65b2 Fix implicit-fallthrough warnings.
Test: make checkbuild
Bug: 112564944
Change-Id: Ifc8b7444b95d667b0d185c7d45b3f15278d4af2f
2018-10-19 14:24:58 -07:00
Tomasz Wasilczyk
b557e0b748 Fix comments and internal names about SEEK operation.
Legacy radio HAL named it SCAN and the name slipped through HAL 1.x
into HAL 2.0. I finally noticed it after HAL 2.0 was locked down.

Bug: 109740376
Test: build ow
Change-Id: I5ca4147227a7dd0c32248a279f03fb632d97258e
2018-06-07 15:19:27 -07:00
Tomasz Wasilczyk
cea64964dc Improve current program info validation.
Bug: 74022658
Test: atest VtsHalBroadcastradioV2_0TargetTest
Change-Id: Ifee19249a9033363df863480e8a5da24334f5e59
2018-05-23 12:02:39 -07:00
Steven Moreland
4ee4582230 Update comments for doc comments.
Doc comments look like "/** ... */" and they
can only be in certain places.

Bug: 79865343
Test: m
Change-Id: Ic15c08ff7dc6e4f9827c1dbe7f7236c11a572ec1
2018-05-18 10:10:32 -07:00
Tomasz Wasilczyk
8acabf21a4 Add check for empty RDS_PS.
Bug: 78885613
Test: atest VtsHalBroadcastradioV2_0TargetTest
Change-Id: I9ac0e8975972636696504a6eeb0ecce58396e3fd
2018-04-30 10:25:22 -07:00
Tomasz Wasilczyk
55241f7c76 Extend tune workaround time.
Bug: 73963096
Test: atest VtsHalBroadcastradioV2_0TargetTest
Change-Id: I6b722fb4f82005fe468a17f0f29af9dc8bd0e8f7
2018-04-30 08:55:14 -07:00
Tomasz Wasilczyk
674696f92a Clear out ambiguity in broadcastradio@2.0 comments.
Bug: 76798863
Test: it builds
Change-Id: Icd13a187d3a002e6d1d0af8d360de31a75949b69
2018-03-30 16:01:22 -07:00
Tomasz Wasilczyk
5e6bebbd83 Update program list when switching bands.
Test: manual
Bug: 74353024
Change-Id: I893cd4f9c7d14951924759792206af798b0ceefc
2018-03-28 17:48:18 -07:00
Tomasz Wasilczyk
c863a957d4 Fix boadcastradio HAL 1.1 tuneByProgramSelector implementation.
It was not compliant with the HAL definition - it didn't auto-change
band if necessary.

Bug: 74353024
Test: manual
Change-Id: I015faffc42778fa27fca3030306f31b0abe409c7
2018-03-08 11:41:55 -08:00
Tomasz Wasilczyk
b314271b58 Reword ProgramInfo comments.
It makes clear which fields are required for the program list entries,
and which for currently tuned program.

Test: none
Change-Id: If7ec3ad8f99e22b225063ca71a0c249b5d6d2bc1
2018-02-21 13:20:50 -08:00
Zhuoyao Zhang
b46346f9bd Merge "Convert broadcastradio hal test to use VtsHalHidlTargetTestEnvBase" 2018-02-14 17:25:33 +00:00
Zhuoyao Zhang
190548f558 Convert broadcastradio hal test to use VtsHalHidlTargetTestEnvBase
Bug: 64203181
Test: make vts
      vts-tradefed run vts -m VtsHalBroadcastradioV1_0Target
      vts-tradefed run vts -m VtsHalBroadcastradioV1_1Target

Change-Id: I574b54dc95522486f4be9b50da436e90f3f88b9d
2018-02-13 10:15:37 -08:00
Tomasz Wasilczyk
869779ae92 Merge "Drop broadcastradio HAL 1.2." 2018-02-13 14:22:00 +00:00
Tomasz Wasilczyk
67360529f6 Verify physically/logicallyTunedTo field in ProgramInfo.
Test: it builds
Bug: 71614466
Change-Id: Iae6fe660cbadd3a4309c4700fc939289c0528d8f
2018-02-12 11:42:25 -08:00
Tomasz Wasilczyk
7aad611408 Drop broadcastradio HAL 1.2.
Test: it boots
Bug: 62945293
Change-Id: Ie05d50f3084f51aa6e4de53096656b1387503459
2018-02-10 10:49:58 -08:00
Tomasz Wasilczyk
0f5d21ae53 Remove broadcastradio HAL 1.2 support from the framework.
Bug: 62945293
Test: VTS
Change-Id: Ifd54fe476717ae71e5c9ff72498bf702b0c29454
2018-02-10 12:40:41 +00:00
Tomasz Wasilczyk
8c34c8179d Move broadcast radio 1.2 default implementation back to 1.1.
Bug: 62945293
Test: VTS

Change-Id: I95d68ea61f5b50c5b510212b0941bddad1158f97
2018-02-09 19:43:45 +00:00
TreeHugger Robot
6a99a2a901 Merge "Rename getConfigFlag to isConfigFlagSet." 2018-01-20 02:22:21 +00:00
Tomasz Wasilczyk
d773e954a4 Merge "Allow spaces in DAB frequency labels and make it up to 7 characters long." 2018-01-19 19:38:13 +00:00
Tomasz Wasilczyk
a425dedbe8 Allow spaces in DAB frequency labels and make it up to 7 characters long.
There is no standard for DAB label format, the regexp is based on our
partners knowledge.

Bug: 69958423
Test: VTS

Change-Id: I917508408de22f8a75d39d4e9badddd385869b03
2018-01-15 08:34:28 -08:00
Tomasz Wasilczyk
db902860e8 Fix remaining instrumentation tests.
Bug: 69958777
Test: VTS, Instrumentation
Change-Id: I98956ea4b1d2953b9159fb7d53ce61e57f80a90f
2018-01-15 08:10:40 -08:00
Tomasz Wasilczyk
3dd452a979 Rename getConfigFlag to isConfigFlagSet.
The latter matches code guidelines better.

Bug: 69958423
Test: it builds
Change-Id: I520733a061f03bab57544a1451dd763dc53ce5c6
2018-01-12 14:59:07 -08:00
Tomasz Wasilczyk
0d5ef5de01 Rename AnnouncementObserver to AnnouncementListener.
I feel this wording match java naming more closely.

Bug: 68045105
Test: VTS
Change-Id: If30fa9b356b6b45fe8853bc5194c7098d0fb2aa5
2018-01-11 19:26:02 -08:00
Tomasz Wasilczyk
653f766177 Broadcast radio 1.x default implementation: let's support background scan for real.
Bug: 69860743
Test: VTS, instrumentation
Change-Id: Ia636795494c88a82edf681adaa403e3b70f77814
2018-01-09 21:11:38 -08:00
Tomasz Wasilczyk
a72fb98f2b Merge "Broadcast radio 1.x default implementation: let's support background scan." 2018-01-09 22:20:27 +00:00
Tomasz Wasilczyk
06c82dd932 Merge "Fix few typos in broadcast radio HAL 2.0 comments." 2018-01-08 23:54:09 +00:00
Tomasz Wasilczyk
db1386a902 Broadcast radio 1.x default implementation: let's support background scan.
Bug: 69860743
Test: VTS
Change-Id: I7f0dc841e2b3fc218e5e7efa9b102697655cc9d5
2018-01-08 15:37:09 -08:00
Tomasz Wasilczyk
88960f1d3d Fix few typos in broadcast radio HAL 2.0 comments.
Bug: 69958423
Test: none
Change-Id: Ic9e5ddd4fb6d033f6f98eb0b537856abe4e4f025
2018-01-05 13:37:44 -08:00