Commit graph

1412 commits

Author SHA1 Message Date
Treehugger Robot
6cd27b6f2a Merge "Reland "Add a DisplayCapability for multi-threaded present"" into main 2023-10-18 02:21:51 +00:00
Joen Chen
e0a962c8e3 Reland "Add a DisplayCapability for multi-threaded present"
Originally landed as I5dbb01fc23abd5e0108c565f96d25e62c77fc16d and
previously reverted in I6265f8de3db31f07506906cee82a91fe3baac0bc due to
timeline constraints.

Add a test presenting from multiple threads. Split up execute() so that
it can be called for a single display. Update MultiThreadedPresent
(test) to offload presentDisplay to a separate thread, similar to how
Ib9d074671e32c95875ef7e0791dd95d6e595e47a does it, as described in
go/multi-threaded-present.

Bug: 259132483
Bug: 284156408
Fixes: 251842321
Fixes: 295841597
Test: VtsHalGraphicsComposer3_TargetTest
Change-Id: If975ee9bb0b9c6f64ef50401e2aee32f934e3f08
2023-10-16 15:23:59 -04:00
Leon Scroggins III
79d7ae8207 Remove deprecated warnings for SKIP_VALIDATE
We deliberately use a deprecated API to test that it is not used. Ignore
warnings from using it in this test.

In PresentDisplayNoLayerStateChanges, remove the check for
SKIP_VALIDATE, removing the other warning. As written, the test would be
skipped without SKIP_VALIDATE support. But devices should *not* claim
Capability::SKIP_VALIDATE, meaning the test would always be skipped. The
docs state that the behavior previously indicated by SKIP_VALIDATE is
now the default, so we should always be running the test.

Bug: NA
Test: atest VtsHalGraphicsComposer3_TargetTest (no warnings)
Change-Id: Icc89a82b4850428c2f0940be0f78f5ebff1881b3
2023-10-12 08:38:12 -04:00
Jason Macnak
cde05dd247 Merge "Ensure AIMapper and underlying IMPL outlive IMapperProvider" into main am: b8c23a8a7d am: 4c11b51986 am: 8dcf909435 am: f5dbe8113a am: ba4b850b8a
Original change: https://android-review.googlesource.com/c/platform/hardware/interfaces/+/2781709

Change-Id: Ie4edc900be0e48bb00e3913ec75456347a58f81a
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-10-11 02:14:30 +00:00
Jason Macnak
8dcf909435 Merge "Ensure AIMapper and underlying IMPL outlive IMapperProvider" into main am: b8c23a8a7d am: 4c11b51986
Original change: https://android-review.googlesource.com/c/platform/hardware/interfaces/+/2781709

Change-Id: Ie96a5db1377ca841d493b168ffa4c6b2a5c90d8a
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-10-10 23:31:55 +00:00
Alec Mouri
b9556b3aba Merge "Start VTS for color management." into main 2023-10-10 20:40:46 +00:00
Jason Macnak
7d201b58fa Ensure AIMapper and underlying IMPL outlive IMapperProvider
... as a

  static vendor::mapper::IMapperProvider<IMPL> provider;

may be destructed during a clean process exit (during __cxa_finalize())
but the underlying IMPL may still be in use on other threads.

Bug: b/304343434
Test: boot Cuttlefish
Change-Id: I80687494c61210d527908b5a67375950ca45c8ea
2023-10-10 11:54:00 -07:00
Sergiu Ferentz
31b637fd90 Merge "Bump android.hardware.graphics.common V4->V5" into main 2023-10-09 08:27:26 +00:00
Sergiu Ferentz
d2075f0d14 Merge "Modifying Dataspace.aidl to add additional HAL_ Datapoints present in graphics/**/swapchain.cpp" into main 2023-10-09 08:27:26 +00:00
Alec Mouri
f6c039a49e Start VTS for color management.
Right now this only makes sure that extended sRGB buffers aren't
corrupted by the time it hits the display. This is especially important
for Ultra HDR, because display compensation is defined by the spec.

Bug: 276331687
Bug: 259144781
Test: VtsHalGraphicsComposer3_ReadbackTest
Change-Id: Ib6c39858289d5559ae76280ca1a0ef756f2daef0
2023-10-06 23:04:15 +00:00
Alec Mouri
3e82b63ae8 Merge "Setting layer brightness doesn't need nit info for readback tests" into stage-aosp-udc-ts-dev am: be23bf4f23 am: 2d96a0a082
Original change: https://googleplex-android-review.googlesource.com/c/platform/hardware/interfaces/+/24944166

Change-Id: If96b68cdef28070dba0a446b57bea4581e1b3b40
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-10-05 20:41:40 +00:00
Alec Mouri
a47d46affb Setting layer brightness doesn't need nit info for readback tests
The nit information was used when we set exact nit values rather than a
relative brightness per layer. But we only need nit values for the
renderengine interface, which isn't tied to any hwc or panel
capabilities.

Bug: 301261125
Test: VtsHalGraphicsComposer3_TargetTest
(cherry picked from https://googleplex-android-review.googlesource.com/q/commit:712b3d9880b6aff51ab17d539bfcbdf3785cc6ca)
Merged-In: I770dc5620648df2eab608e030c5e76cf190f315d
Change-Id: I770dc5620648df2eab608e030c5e76cf190f315d
2023-10-04 21:14:06 +00:00
sergiuferentz
14960cae33 Modifying Dataspace.aidl to add additional HAL_ Datapoints present in graphics/**/swapchain.cpp
Bug: 291142745
Change-Id: I54a41f3170b6c21f1c1b12aec40a8ce928f9163f
2023-10-03 16:14:06 +00:00
sergiuferentz
7d7a24d5f6 Bump android.hardware.graphics.common V4->V5
Test: Build
Bug: 291142745
Change-Id: Ib0002feb982ffcc37fa7b69493c644b7a835cf4f
2023-10-03 16:14:03 +00:00
Alec Mouri
712b3d9880 Setting layer brightness doesn't need nit info for readback tests
The nit information was used when we set exact nit values rather than a
relative brightness per layer. But we only need nit values for the
renderengine interface, which isn't tied to any hwc or panel
capabilities.

Bug: 301261125
Test: VtsHalGraphicsComposer3_TargetTest
Change-Id: I770dc5620648df2eab608e030c5e76cf190f315d
2023-09-29 00:21:37 +00:00
Treehugger Robot
83dd5881a0 Merge "Add deprecation note" into main 2023-09-07 20:15:54 +00:00
Treehugger Robot
cb0d2eb323 Merge "Revert "[Composer AIDL] Rename notifyExpectedPresentTimeoutNs and"" into main 2023-09-01 23:58:48 +00:00
John Reck
89b26e7623 Add deprecation note
Flag: DOCS_ONLY
Test: doc-only && make
Change-Id: I16638c3772269e4946a002a7e821735423df5084
2023-09-01 16:32:53 -04:00
Ram Indani
82426a4a40 Revert "[Composer AIDL] Rename notifyExpectedPresentTimeoutNs and"
This reverts commit f850701be0.

Reason for revert: Delaying rename to avoid churn for external partner work.

Change-Id: If96786d074a61ac0f781540e98d020a6f7fd673b
2023-09-01 20:02:50 +00:00
Treehugger Robot
7445bd7b80 Merge "Clarify GPU API requirements for BufferUsage" into main 2023-09-01 16:13:38 +00:00
John Reck
9db00ec784 Clarify GPU API requirements for BufferUsage
Bug: 283989374
Test: n/a doc only change
Change-Id: I4caec722420d4fa2089d1f297f377408a1e674ae
2023-08-31 17:42:05 -04:00
ramindani
f850701be0 [Composer AIDL] Rename notifyExpectedPresentTimeoutNs and
notifyExpectedPresentHeadsUpNs
Renamed to timeoutNs and headsUpNs respectively

BUG: 294102485
Test: atest VtsHalGraphicsComposer3_TargetTest
Change-Id: Id890d9634d80700ad2515c9b4fe2a423b6b75d96
2023-08-30 18:51:19 -07:00
ramindani
2b2ec50b56 [Composer VTS] Check Vrr mode is the only mode in the Config Group
BUG: 296636107
Test: atest VtsHalGraphicsComposer3_TargetTest
Change-Id: I4bdf7b0988673a13297d648dcf3360a6821aaecb
2023-08-25 18:48:47 -07:00
Xin Li
879960bdce Merge Android U (ab/10368041)
Bug: 291102124
Merged-In: I7b6fffac2ada0e039f79bad8cc9b4d954e9c3460
Change-Id: I9466127d8d0fa38df36ca99f704853b2db871e67
2023-08-25 13:29:30 -07:00
Alec Mouri
19698cdd0e Merge "Adjust documentation for UNKNOWN dataspaces." into main 2023-08-24 17:44:49 +00:00
Alec Mouri
75a546270a Remove useFramebufferCache parameter in drawLayers()
GLESRenderEngine used it, but GLESRenderEngine is no more.

Bug: 199918329
Test: builds
Change-Id: I9c735e5820bd187f910905e7e77f9445f0ff30db
2023-08-18 15:01:52 +00:00
Alec Mouri
6dd267ee95 Merge "Remove color management configuration in VTS" into main 2023-08-15 15:52:36 +00:00
Alec Mouri
32a41abac3 Remove color management configuration in VTS
Color management is now turned on by default, so there's no reason to
explicitly enable it in renderengine.

Bug: 295966830
Test: builds
Change-Id: I42c8afb30950081cd57072680da06895dcc02f2c
2023-08-15 02:11:49 +00:00
Alec Mouri
d5df919eb7 Merge "Add API level for IMapper 4's bad metadata test" into main 2023-08-08 00:14:55 +00:00
Alec Mouri
2ee3317613 Add API level for IMapper 4's bad metadata test
Some devices shipped with broken validation for HDR metadata. Relax the
test for vendor freeze purposes.

Bug: 276843519
Test: VtsHalGraphicsMapperV4_0TargetTest
Change-Id: I564f4bd12145f7831faa1e5a0f2d2abe074e4769
2023-08-04 21:59:23 +00:00
Treehugger Robot
6d9576d649 Merge "composer3: minor fix to dpi documentation " into main 2023-08-01 21:13:01 +00:00
Ady Abraham
07a826c28c composer3: minor fix to dpi documentation
Change-Id: Ie31cb78f682761d1022592a22867307ab78b5a75
Test: prebuild
2023-08-01 20:00:07 +00:00
Ram Indani
789cd64b73 Merge "[Composer-HAL-AIDL] Deprecates getDisplayAttribute" into main 2023-07-31 19:46:10 +00:00
ramindani
d411bd3bda [Composer-HAL-AIDL] Deprecates getDisplayAttribute
Test: atest VtsHalGraphicsComposer3_TargetTest
BUG: 284866749
BUG: 287518295
Change-Id: Ib4f32d9b60cbbbf127963e0fa4b273951e9d46e6
2023-07-31 10:16:05 -07:00
Treehugger Robot
f2d57b1e40 Merge "composer3: add rust backend " into main 2023-07-28 19:44:38 +00:00
John Reck
631dc15b2e Remove allocator from composer2.1-4 VTS
Bug: 292584923
Test: make VtsHalGraphicsComposerV2_3TargetTest VtsHalGraphicsComposerV2_4TargetTest VtsHalGraphicsComposerV2_2TargetTest VtsHalGraphicsComposerV2_1TargetTest
Change-Id: I6c5e8c8b96450f800bb60b6ed0ce3b3c10ce1565
2023-07-26 16:06:34 -04:00
John Reck
6d0abbb439 Remove mapper from composer2.1 VTS
Bug: 292584923
Test: make VtsHalGraphicsComposerV2_3TargetTest VtsHalGraphicsComposerV2_4TargetTest VtsHalGraphicsComposerV2_2TargetTest VtsHalGraphicsComposerV2_1TargetTest
Change-Id: I3642995e7236a3b9b08ad5419c9d02b67243b24a
2023-07-26 15:54:47 -04:00
Ady Abraham
9118110a15 composer3: add rust backend
Change-Id: I2d3d91fd714130252d63b697958f128c9bd06dc5
Test: presubmit
Bug: 293256928
2023-07-26 19:42:10 +00:00
John Reck
82c666bd8c Remove mapper from composer2.2 VTS
Test: make VtsHalGraphicsComposerV2_2TargetTest
Bug: 292584923
Change-Id: Id281c732535ace4a36750d759b59db7aa6e5cb3a
2023-07-26 10:17:17 -04:00
John Reck
650fe3ed52 Remove mapper from composer2.3 VTS
It was unused anyway

Bug: 292584923
Test: make VtsHalGraphicsComposerV2_3TargetTest
Change-Id: I81fb1be275ef54062a8ae5bddec17a137dda7946
2023-07-25 21:08:42 -04:00
John Reck
7f996c3f1c Remove direct mapper from composer2.4 VTS
Bug: 292584923
Test: make VtsHalGraphicsComposerV2_4TargetTest
Change-Id: I4379df1d673fc709b9a496b5c44cb9420798a05d
2023-07-25 17:35:08 -04:00
John Reck
e849ecd055 Remove unused dependencies from composer3 VTS
Test: atest VtsHalGraphicsComposer3_TargetTest
Change-Id: I1eeb3ad326d91ec317e91bc3c515a8f28baae074
2023-07-25 16:32:49 -04:00
Ram Indani
15e0bb9f83 Merge changes from topic "HWC3-V3-VRR" into main
* changes:
  [Composer VTS] Adds VTS for the vrr configuration
  [Composer-HAL-AIDL] Adds vrr interface configuration
2023-07-22 04:14:52 +00:00
ramindani
2704c5fe12 [Composer VTS] Adds VTS for the vrr configuration
Test getDisplayConfigurations with vrr parameters
Test notifyExpectedPresent does not return error

Test: atest VtsHalGraphicsComposer3_TargetTest
BUG: 287517352
BUG: 284881912
Change-Id: I49d6876922e9fde47e531200a29413495458b8a5
2023-07-21 21:13:37 -07:00
ramindani
bc41c5fb19 [Composer-HAL-AIDL] Adds vrr interface configuration
Test: atest VtsHalGraphicsComposer3_TargetTest
BUG: 287517352
BUG: 284881912
Change-Id: I71ed35acb18a00009cd23afe47f5c48494d08c0c
2023-07-21 21:13:37 -07:00
Alec Mouri
3d978df32d Support per-port display configs in VTS am: 821d5c05c2 am: 29d915f375
Original change: https://googleplex-android-review.googlesource.com/c/platform/hardware/interfaces/+/24169145

Change-Id: I1b799ba8830247d57b37c0df1ab86c68f9bf8ec6
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-07-22 03:52:49 +00:00
Alec Mouri
821d5c05c2 Support per-port display configs in VTS
Bug: 277855934
(cherry picked from https://googleplex-android-review.googlesource.com/q/commit:be1b4d6ccec45f47bbb9459bf9aa31b4c6875c7b)
Merged-In: I92e1615d8eb9466b40e02f8e2df8b3432e927af6
Change-Id: I92e1615d8eb9466b40e02f8e2df8b3432e927af6
2023-07-22 00:58:03 +00:00
Treehugger Robot
d683f7da0b Merge "Support per-port display configs in VTS" into main 2023-07-21 21:13:11 +00:00
Alec Mouri
be1b4d6cce Support per-port display configs in VTS
Bug: 277855934
Change-Id: I92e1615d8eb9466b40e02f8e2df8b3432e927af6
2023-07-21 21:12:16 +00:00
Treehugger Robot
595664a377 Merge "Fix a DimmingStage documentation typo by rewording the doc." into main am: 299db35551 am: 518f74b2f9 am: 7cafdb3073 am: f0c1565ef0 am: d0c6ea82e6
Original change: https://android-review.googlesource.com/c/platform/hardware/interfaces/+/2669815

Change-Id: Ic26033b197832c2ba22c5ce704edc4c1f3a65424
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-07-21 07:30:31 +00:00