Commit graph

153 commits

Author SHA1 Message Date
Chong Zhang
42eca4926f cas: do not use hidl_memory if size is > SIZE_MAX
am: e1ce74509e

Change-Id: I4fe12a4ec828605413329d2f771f66bb12e3e9e9
2018-05-11 14:12:51 -07:00
Chong Zhang
e1ce74509e cas: do not use hidl_memory if size is > SIZE_MAX
Bug: 79376389
Test:
POC in bug; CTS MediaCasTest.

Change-Id: Ia3ecf9664ab69ce293e10b73bc20c37a9992db9f
2018-05-10 14:33:47 -07:00
TreeHugger Robot
6b6b1d2c1a Merge "Correct type of appData field" into pi-dev 2018-04-10 04:25:29 +00:00
Chong Zhang
9c6e0dc952 Correct type of appData field
bug: 77732157

test: CTS MediaCasTest; VTS VtsHalCasV1_0Target.
Change-Id: I18b4e9afb52fee72d55b13a48ac1339cf4728983
2018-04-09 12:36:21 -07:00
Chong Zhang
4aabc95234 cas: fix UAF in descrambler
Change the plugin holder in both CasImpl and DescramblerImpl
to shared_ptr, and use atomic store/load for read/write.

bug: 73172817
Test:CTS MediaCasTest, VTS VtsHalCasV1_0Target, poc in bug
Change-Id: I3f1472d3b9d8d3dc74168c07325c5c319a96807d
2018-03-23 18:50:38 -07:00
Chong Zhang
addcb3aa51 cas: fix UAF in descrambler -- DO NOT MERGE
Change the plugin holder in both CasImpl and DescramblerImpl
to shared_ptr, and use atomic store/load for read/write.

bug: 73172817
Test:CTS MediaCasTest, VTS VtsHalCasV1_0Target, poc in bug
Change-Id: I6b040680c28c38cef2fef3042f570dc64e86bb77
2018-03-24 01:46:21 +00:00
Chong Zhang
d2eb83e668 MediaCas: use HidlMemory to avoid handle leaks
bug: 67710751
test: VTS VtsHalCasV1_0Target test
Change-Id: Ia9a3c38b755a1aeb1d16dba30217055e6f0c27e2
2018-02-15 15:45:35 -08:00
Zhuoyao Zhang
a964d83a1f Merge "Convert cas hal test to use VtsHalHidlTargetTestEnvBase" am: fadafee26a am: 16465a4b37
am: 707258b232

Change-Id: Ia1cd0ec1ed287ff20f64ea840dadcbc539981091
2018-02-09 20:42:12 +00:00
Zhuoyao Zhang
707258b232 Merge "Convert cas hal test to use VtsHalHidlTargetTestEnvBase" am: fadafee26a
am: 16465a4b37

Change-Id: I7b339163bf8a857f7d6409533f35d9c7b740b717
2018-02-09 20:34:39 +00:00
Zhuoyao Zhang
a5e6707e9c Convert cas hal test to use VtsHalHidlTargetTestEnvBase
Bug: 64203181
Test: make vts
      vts-tradefed run vts -m VtsHalCasV1_0Target

Change-Id: If8174499b0fce2404fa3f363bc3ec439092c4068
2018-02-08 21:31:01 -08:00
Steven Moreland
905ca6a633 Merge "Remove conditional vndbinder usage in CAS." am: 231626d43d
am: 897864234e

Change-Id: Ifcd1c61e5655c9667576c5fe38c6ed0fe269b6cf
2017-12-15 20:20:10 +00:00
TreeHugger Robot
58983cb2b2 Merge "cas: manually clear strong ref before callback" 2017-12-14 08:46:11 +00:00
TreeHugger Robot
6658796be0 Merge "Reland "Remove conditional vndbinder usage in CAS."" 2017-12-14 04:01:11 +00:00
Steven Moreland
11a8a0e183 Reland "Remove conditional vndbinder usage in CAS."
Fugu kernels have been updated.
Bug: 70393284
Test: fugu boots

This reverts commit e9fb979b1e.

Change-Id: I976a0df6279e6ae7d334fa22e3c2c83bb3e285b7
2017-12-13 21:35:44 +00:00
Chong Zhang
ea3f07b614 cas: manually clear strong ref before callback
Hidl doesn't guarantee the server side method goes out of scope
before the client side returns. Even when client calls on the
same thread, the next method could overlap the previous call.
Next call can come in as soon as the hidl callback is called.

In case of openSession and release, there is a rare chance that
release call comes in before previous openSession is returned.
If this happens, the cas plugin object destructor is delayed to
the point when openSession goes out of scope (thus let go its
strong ref to the plugin). This violates our contract that the
plugin object and all associated sessions are released by the
time release() returns.

Manually clean up the strong ref before calling hidl callback
in openSession would fix this.

bug: 70544685
Change-Id: Id89a00591a354c8a46def3cc691dd8e28b4c971b
2017-12-12 22:09:20 -08:00
TreeHugger Robot
8573894006 Merge "cas: add vts test to catch oob in descrambling requests" 2017-12-09 06:20:37 +00:00
Steven Moreland
e9fb979b1e Revert "Remove conditional vndbinder usage in CAS."
This reverts commit 5884a6f0f3.
Bug: 70393284

Reason for revert: Fugu doesn't have vndbinder yet.
Exempt-from-owner-approval: Device doesn't boot.

Change-Id: Ib23691c102fd8aca63a4a6755eb7fd1f9e852a4d
2017-12-08 19:34:26 +00:00
Steven Moreland
75673fc6ac Remove conditional vndbinder usage in CAS.
Platform consistency, removing overload of meaning
behind PRODUCT_FULL_TREBLE/treble variable.

Bug: 67975337
Test: boot
Change-Id: I09df37fc0306f80879424334029ab9668cee9d4f
Merged-In: I09df37fc0306f80879424334029ab9668cee9d4f
2017-12-06 16:12:41 -08:00
Steven Moreland
4e1e4081e4 Updating makefiles for hidl_interface.
Bug: 64487114
Test: manual
Merged-In: Ie13d9e014cf2b81c18c67f551b4644fb9f0ba812
Change-Id: Ie13d9e014cf2b81c18c67f551b4644fb9f0ba812
(cherry-picked from commit c2f829a1d2)
2017-12-03 10:31:49 -08:00
Steven Moreland
5884a6f0f3 Remove conditional vndbinder usage in CAS.
Platform consistency, removing overload of meaning
behind PRODUCT_FULL_TREBLE/treble variable.

Bug: 67975337
Test: boot
Change-Id: I09df37fc0306f80879424334029ab9668cee9d4f
2017-11-29 12:51:31 -08:00
Steven Moreland
e5c6548346 Remove subdirs
Removing whenever I see these in code reviews.

Test: none
Merged-In: I4322f533a837d55618ec2ed2125e8966ace9d61d
Change-Id: I4322f533a837d55618ec2ed2125e8966ace9d61d
2017-11-28 14:23:43 -08:00
Steven Moreland
8b76a6b90d Remove subdirs
Removing whenever I see these in code reviews.

Test: none
Merged-In: I4322f533a837d55618ec2ed2125e8966ace9d61d
Change-Id: I4322f533a837d55618ec2ed2125e8966ace9d61d
2017-11-28 14:22:55 -08:00
Steven Moreland
fcca4e23b7 Remove subdirs
Removing whenever I see these in code reviews.

Test: none
Merged-In: I4322f533a837d55618ec2ed2125e8966ace9d61d
Change-Id: I4322f533a837d55618ec2ed2125e8966ace9d61d
2017-11-28 14:22:43 -08:00
Chong Zhang
95cc5af781 cas: add vts test to catch oob in descrambling requests
bug: 67962232

test:
cts MediaCasTest
vts VtsHalCasV1_0Target

Change-Id: I825e8cefb0d6f8e183e96ee2ebfbe0be1572dca8
2017-11-21 10:54:40 -08:00
Steven Moreland
c2f829a1d2 Updating makefiles for hidl_interface.
Bug: 64487114
Test: manual
Merged-In: Ie13d9e014cf2b81c18c67f551b4644fb9f0ba812
Change-Id: Ie13d9e014cf2b81c18c67f551b4644fb9f0ba812
2017-11-13 11:39:07 -08:00
Steven Moreland
8db261bc99 Updating makefiles for hidl_interface.
Bug: 64487114
Test: manual
Merged-In: Ie13d9e014cf2b81c18c67f551b4644fb9f0ba812
Change-Id: Ie13d9e014cf2b81c18c67f551b4644fb9f0ba812
2017-11-13 10:00:18 -08:00
Chong Zhang
5e17666308 Merge "cas: validate shared buffer size before using" into oc-mr1-dev am: 6a8fab9781
am: 66905b8168

Change-Id: Ibeb02056beeef366e1724f8b992b438f2363c997
2017-11-10 09:08:05 +00:00
Chong Zhang
16a3cd0b07 cas: validate shared buffer size before using
bug: 67962232

test:
cts MediaCasTest
vts VtsHalCasV1_0Target

Change-Id: I20b89d5971db4c89704245bb00c281af8c943697
2017-10-31 11:53:39 -07:00
TreeHugger Robot
f3d37254df Merge "Update for Soong-only makefiles." 2017-10-11 20:00:03 +00:00
Suresh Sivaraman
ab4c6f8fde Merge "Added VTS tests for requiresSecureDecoderComponent and release API" into oc-mr1-dev am: 2528c405f3
am: 7c932db240

Change-Id: If5ff8a90992432ee08eb7ed10eb3b2918e86c9dd
2017-10-11 18:42:14 +00:00
TreeHugger Robot
2528c405f3 Merge "Added VTS tests for requiresSecureDecoderComponent and release API" into oc-mr1-dev 2017-10-11 18:33:25 +00:00
Steven Moreland
f390f03aa4 Update for Soong-only makefiles.
Test: pass
Bug: 33420795
Change-Id: Ibec6d1e38939b9e7566a96381439be2aac3bf8ca
2017-10-11 18:30:28 +00:00
Chong Zhang
542be2bcdf Merge "cas-vts: use MemoryDealer to allocate shared memory" into oc-mr1-dev am: de05222287
am: 6643820a0d

Change-Id: I05166e239a97eb034a803b0204f1bc95d30e7bc2
2017-10-11 01:21:35 +00:00
Chong Zhang
704d5861a7 cas-vts: use MemoryDealer to allocate shared memory
cas hal can't (and doesn't need to) use hidl_memory allocated by
hidl allocator. All real clients (MediaDescrambler jni, ACodec)
are using MemoryDealer-allocated ashmem only. Modify the test
to cover these cases.

bug: 67603039
test:
> make vts -j64
> vts-tradefed run vts -m VtsHalCasV1_0Target

Change-Id: Ib9563abc1a14c34781a28d15c7766c6c160d288a
2017-10-10 13:09:32 -07:00
Suresh Sivaraman
6d176aa77d Added VTS tests for requiresSecureDecoderComponent and release API
Bug: 63914034
Bug: 65593293

Test:
Build & test vts:

> make vts -j64

> vts-tradefed run vts -m VtsHalCasV1_0Target

Change-Id: I465735768239f2d53427a18e5ad1fa0069f6e35c
2017-10-09 12:38:13 -07:00
Suresh Sivaraman
1ce1e21517 Merge "Added VTS tests for MediaCas - II" into oc-mr1-dev am: 239a450438
am: 4833ea292c

Change-Id: I780d60287d85d0e25fcfd67f44310fe72a9a94ec
2017-10-06 16:57:06 +00:00
Suresh Sivaraman
0645aec1de Added VTS tests for MediaCas - II
Bug: 63914034
Bug: 65593293

Test:
Build & test vts:

> make vts -j64

> vts-tradefed run vts -m VtsHalCasV1_0Target

Change-Id: If5a0e7cb3d520843ba45147a085c43b94027e584
2017-10-05 19:47:31 +00:00
Steven Moreland
3788a7321f Update makefiles for hidl-adapter (2/2).
Bug: 37518178
Test: none
Change-Id: I77fe67964f89da8b66aeb8df6d424de0f8689f8d
2017-09-27 08:55:47 -07:00
Suresh Sivaraman
9bd69497f8 Merge "Added VTS tests for MediaCas" into oc-mr1-dev am: 6b3d1649bc
am: 71a9489ae1

Change-Id: I61b45281473ca4d10be7152e0d852a74f8099824
2017-09-21 23:36:57 +00:00
Suresh Sivaraman
f1fbb442dc Added VTS tests for MediaCas
Bug: 63914034
Bug: 65593293
Change-Id: I1064ac14513508d2f821a1a27dafcc7389b1a691
2017-09-21 11:44:39 -07:00
Jaekyun Seok
81104ae5ef Add 'vendor.' prefix to a vendor HAL service name
To prevent property name collisions between properties of system and
vendor, 'vendor.' prefix must be added to a vendor HAL service name.
You can see the details in http://go/treble-sysprop-compatibility.

Test: succeeded building and tested on a walleye device
Bug: 36796459
Change-Id: I4e8fbee791ec917a8f627a1366f4d44ec7e6febc
2017-09-12 08:01:42 +09:00
Chong Zhang
3229455a74 Merge "cas: fix missing error code conversion" into oc-mr1-dev am: e1333de647
am: 771b0d75bd

Change-Id: I9f270161dc3057a185427d6e63368c1b9bbe4ac4
2017-08-31 00:02:36 +00:00
TreeHugger Robot
e1333de647 Merge "cas: fix missing error code conversion" into oc-mr1-dev 2017-08-30 22:35:31 +00:00
Steven Moreland
0f6b22147e Merge "Fix HALs to not have transitive depends." into oc-mr1-dev am: cf0ee37180
am: 87b997de66

Change-Id: I44ac13171655c10f10a397b956df9b5c70321983
2017-08-30 16:28:17 +00:00
Chong Zhang
065f08d09b cas: fix missing error code conversion
bug: 22804304
Change-Id: Ia950e12f7feef3eeb16596c0939aaeb61bfdf5df
2017-08-29 18:38:38 -07:00
Steven Moreland
218c6d8b2f Fix HALs to not have transitive depends.
Bug in hidl-gen allowed this to work.

Test: -Lcheck
Bug: 65055216
Change-Id: Ia0cbaac4c8bfd93be169f4fab5c9ce016ee6c473
2017-08-28 11:13:19 -07:00
Steven Moreland
6da35570df Updating all makefiles.
Bug: 64487114
Test: none
Change-Id: I8608c8f636c35f21e4246a805a9eff6d14124e0a
2017-08-10 23:43:46 +00:00
Justin Yun
723c2dbd43 Update make file for vndk enabled. am: 608d773ef8
am: d66371512c

Change-Id: I35b778c39c2349346278deb6dea56b8cd3701f7d
2017-08-05 02:17:38 +00:00
Justin Yun
608d773ef8 Update make file for vndk enabled.
Update the Android.bp generated with hidl-gen.

Test: build with and without BOARD_VNDK_VERSION=current
Bug: 63866913
Change-Id: I1a9db1df49e0f13c5790da2b118ae9ec63ba34a7
2017-08-04 14:12:23 +09:00
Steven Moreland
a1804f2a4b Update makefiles for CAS.
Now that we can generate regular HIDL HAL makefiles
which frameworks.jar can link against, do this for
media cas.

Test: run cts-dev --module CtsMediaTestCases
  --test android.media.cts.MediaCasTest
=>
 Invocation finished in 27s. PASSED: 6, FAILED: 0, MODULES: 1 of 1
Bug: 64294630
Change-Id: I40d9096bd2fa18ec420e1ca5124b92e42d4a68ca
2017-08-03 22:58:23 +00:00
Tri Vo
f5d136c231 Update Android.bp HIDL makefiles
Allow HAL definition libs to be static.

Bug: 32920003
Bug: 64040096
Test: update-all-google-makefiles.sh
Change-Id: I1483d572bea6799717d1614fb7d52fe225e31104
2017-08-03 00:30:01 +00:00
Jiyong Park
2ee400dd9f Build android.hardware.cas@1.0-service with BOARD_VNDK_VERSION
Add libstagefright_foundation_headers and media_plugin_headers
explicitly since global include paths are not provided when building
with BOARD_VNDK_VERSION set.

Bug: 37342627
Test: BOARD_VNDK_VERSION=current m -j android.hardware.cas@1.0-service

Change-Id: I6b0b38a5c66a96d92b00d84904b2254b9e70d458
2017-07-10 18:25:34 +09:00
Chong Zhang
a4f6751e49 cas: add CAS hal
Add CAS hal definitions and default service implementation.

bug: 22804304

Change-Id: I0a89608fe75c5f3c5e6888f9b771305742760707
2017-06-23 16:24:17 -07:00