Commit graph

1894 commits

Author SHA1 Message Date
yomna
efc2c9ab56 Clarify IRadioNetwork also applies to satellite-based cellular connections.
Clarify the functionality specified in IRadioNetwork applies to both
terrestrial (earth-based) and extraterrestrial (satellite-based)
cellular networks.

Bug: 301483855
Test: m
Change-Id: Id8d1508c68cbca868fc3471f0840883eeca163c7
2023-10-05 20:17:33 +00:00
Sarah Chin
0779ca2f23 Update VTS tests with EUTRAN instead of GERAN am: 88aa5f6bcd am: 1b01cb5caf am: 28559ee74b
Original change: https://googleplex-android-review.googlesource.com/c/platform/hardware/interfaces/+/24702788

Change-Id: I92c498e1fcbea0d6d0c8127d1f0e3d9c00544c0c
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-09-15 21:00:33 +00:00
Sarah Chin
88aa5f6bcd Update VTS tests with EUTRAN instead of GERAN
These tests were created for IRadio 1.2 when all devices supported GSM,
and REQUEST_NOT_SUPPORTED was valid for devices that didn't support GSM. Change the VTS logic to test EUTRAN instead of GERAN.
Remove REQUEST_NOT_SUPPORTED for tests now without GERAN and add REQUEST_NOT_SUPPORTED for all GERAN-specific tests.

Test: atest VtsHalRadioTargetTest
Bug: 294965245
Change-Id: Ib36b171e33451bf0c9adc0b065a4c74df357e77e
2023-09-15 18:40:27 +00:00
Sarah Kim
9f7b41ae08 Merge "Add null check for osAppId" into stage-aosp-udc-ts-dev am: 848650fd00 am: b668cff7ff am: 98843a2b8b
Original change: https://googleplex-android-review.googlesource.com/c/platform/hardware/interfaces/+/24698008

Change-Id: Ie974d9a85fa633142080a318ecddf4a69fb84626
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-09-12 22:56:21 +00:00
Treehugger Robot
e2f2569e5a Merge "Merge OWNERS files for radio" into main am: 62431377b5 am: 73794557cf am: 54a26c13fc am: c16f79b27d am: e62e8f72d7
Original change: https://android-review.googlesource.com/c/platform/hardware/interfaces/+/2747193

Change-Id: Ifda51e6d9c5e4baa42f2861356223eae31e27b28
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-09-11 19:52:53 +00:00
Treehugger Robot
54a26c13fc Merge "Merge OWNERS files for radio" into main am: 62431377b5 am: 73794557cf
Original change: https://android-review.googlesource.com/c/platform/hardware/interfaces/+/2747193

Change-Id: I08a7fbdca8f6c6c9f09de0a8a9af5fde3f37a9e0
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-09-11 17:22:35 +00:00
Treehugger Robot
73794557cf Merge "Merge OWNERS files for radio" into main am: 62431377b5
Original change: https://android-review.googlesource.com/c/platform/hardware/interfaces/+/2747193

Change-Id: Ie4457ad03041d85f9c9746dbc01b86dbb8ca5003
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-09-11 17:18:36 +00:00
Devin Moore
4d8a6562e6 Merge OWNERS files for radio
Test: none
Bug: 296950573
Change-Id: I2bb2bc894d7631e41f3651076b1a8d64400d65c1
2023-09-08 23:13:57 +00:00
Sarah Chin
35bf8e1b50 Add null check for osAppId
Test: atest VtsHalRadioTargetTest
Bug: 297467393
Change-Id: Ib94d118765bf527ba51d5e7e29942cec6bff61c4
2023-09-07 23:19:41 +00:00
Xin Li
2b8cabe73b Merge UP1A.230905.019
Merged-In: I421c13e65efa565753337dc21e6520682e726e81
Change-Id: Iaaa4cbec5d7892432e021da508deff68829e3c4b
2023-08-31 12:31:10 -07:00
Xin Li
879960bdce Merge Android U (ab/10368041)
Bug: 291102124
Merged-In: I7b6fffac2ada0e039f79bad8cc9b4d954e9c3460
Change-Id: I9466127d8d0fa38df36ca99f704853b2db871e67
2023-08-25 13:29:30 -07:00
Hakjun Choi
6c346c13ff Merge "Revert "Add setSatellitePlmn() related HAL apis"" into main 2023-08-10 14:37:33 +00:00
Sarah Chin
a2d989f0ff VTS setGetAllowedNetworkTypesBitmap allow reset am: ba1c37e79b am: 80e0490502 am: f553053bb0
Original change: https://googleplex-android-review.googlesource.com/c/platform/hardware/interfaces/+/24304951

Change-Id: Ia4bcf96ca16c915d5fc4dcdae22c351587918bae
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-08-08 21:34:59 +00:00
Hakjun Choi
a7c86be17f Revert "Add setSatellitePlmn() related HAL apis"
Revert submission 23748984-SATELLITE_ROAMING_PLMN

Reason for revert: satellite roaming plmn will be moved from radio network HAL to satellite modem interface, to reduce change revert first

Reverted changes: /q/submissionid:23748984-SATELLITE_ROAMING_PLMN

Change-Id: I292644110472dfa97a94db623d246682afdc90c8
2023-08-08 02:50:44 +00:00
Sarah Chin
ba1c37e79b VTS setGetAllowedNetworkTypesBitmap allow reset
If the test fails, the allowed network type bitmap will not be reset to
the previous value. Instead of using ASSERT_EQ, change to EXPECT_EQ to
allow the test to continue to the reset.

Test: atest VtsHalRadioTargetTest
Bug: 264913330
Change-Id: I719afa2e0d9ebc41a329f38f3eca597c9381f2f9
2023-08-03 09:06:41 +00:00
Sarah Chin
f31ca4ee5c Set per-test timeout for IRadio 1.2-1.6 VTS to 5m am: f0c772199b am: 76474a3b7c am: 77c96ccf13 am: af716de58e am: fad8c02770
Original change: https://googleplex-android-review.googlesource.com/c/platform/hardware/interfaces/+/24232539

Change-Id: I66a416950e7770266d6f37240be1de9f3ba1236f
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-07-28 06:31:25 +00:00
Sarah Chin
9049f9d569 Set per-test timeout for IRadio 1.2-1.6 VTS to 5m
To be consistent with the timeout set in IRadio 1.0/1.1 VTS
This increases the timeout per-test, but there is still a timeout
for all tests in the module to complete.

Test: atest VtsHalRadioV1_*TargetTest for all
Bug: 292197532
(cherry picked from https://googleplex-android-review.googlesource.com/q/commit:f0c772199bde052764a697b6de478851126fa596)
Merged-In: I421c13e65efa565753337dc21e6520682e726e81
Change-Id: I421c13e65efa565753337dc21e6520682e726e81
2023-07-28 01:51:04 +00:00
Sarah Chin
f0c772199b Set per-test timeout for IRadio 1.2-1.6 VTS to 5m
To be consistent with the timeout set in IRadio 1.0/1.1 VTS
This increases the timeout per-test, but there is still a timeout
for all tests in the module to complete.

Test: atest VtsHalRadioV1_*TargetTest for all
Bug: 292197532
Change-Id: I421c13e65efa565753337dc21e6520682e726e81
2023-07-27 20:55:03 +00:00
Aishwarya Mallampati
ad1586dfe8 Merge "Revert "Block data call"" into main 2023-07-18 22:15:39 +00:00
Aishwarya Mallampati
7ee5f52f28 Revert "Block data call"
This reverts commit e94dd21fdc.

Reason for revert: Replace SATELLITE_ENABLED with SERVICE_OPTION_NOT_SUPPORTED

Change-Id: Icda920e607cf4bf0517fbf97547d86144c0051f1
2023-07-18 02:33:02 +00:00
Hakjun Choi
77fe4802dd Add setSatellitePlmn() related HAL apis
Provide api to let modem know which are the satellite plmn

BUG: 287538011
Test: atest VtsHalRadioTargetTest
Test: MO/MT call, SMS, MMS in live network with a phone
Change-Id: I7be865098f67a1c7c0273d7b9b6508968618a0f3
2023-07-14 03:45:06 +00:00
Aishwarya Mallampati
90cbcefd8e Merge "Block data call" into main 2023-07-12 22:39:45 +00:00
liuxiangjun
1d611fec5f Return INVALID_ ARGUMENTS is the expected result am: 7ddd478150
Original change: https://android-review.googlesource.com/c/platform/hardware/interfaces/+/2648141

Change-Id: I3811ee46d22121f0809885efd2ef4cc0818fba76
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-07-12 03:02:37 +00:00
Aishwarya Mallamapti
e94dd21fdc Block data call
If network is a non-terrestrial network, block data requests with
NET_CAPABILITY_INTERNET.

Bug: 287114765
Test: Flashed build on raven-userdebug and performed basic functionality
tests,
atest DataNetworkControllerTest#testNonTerrestrialNetworkChanged

Change-Id: Ie21183b093d006f2d9b0bb00845d06965a52f812
2023-07-11 21:44:50 +00:00
Treehugger Robot
f566028519 Merge "Return INVALID_ ARGUMENTS is the expected result" am: 97af8becd7 am: 5bc5bccb6b am: 3644ef1604 am: 927e1b3bad am: 1b32fe63bd am: 273be36b0c
Original change: https://android-review.googlesource.com/c/platform/hardware/interfaces/+/2648139

Change-Id: I7f5aa3cc5414607cafd0585fe79fa21cf809cde6
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-07-06 09:52:37 +00:00
Treehugger Robot
927e1b3bad Merge "Return INVALID_ ARGUMENTS is the expected result" am: 97af8becd7 am: 5bc5bccb6b am: 3644ef1604
Original change: https://android-review.googlesource.com/c/platform/hardware/interfaces/+/2648139

Change-Id: I6eca7a0cdebc7d61eadfc35b94fdb8bd000e2bd3
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-07-06 07:41:57 +00:00
liuxiangjun
7ddd478150 Return INVALID_ ARGUMENTS is the expected result
For devices not in LTE service, the vts test returns INVALID_ ARGUMENTS is an expected result

Bug:289756066

Test:
VtsHalRadioV1_5TargetTest  PerInstance/RadioHidlTest_v1_5#startNetworkScan/0_slot1
VtsHalRadioV1_5TargetTest  PerInstance/RadioHidlTest_v1_5#startNetworkScan/1_slot2

Change-Id: I873d51e089b27aa0cc0dc9f5f25fd8ffaa4d8f40
Signed-off-by: liuxiangjun <liuxiangjun3@xiaomi.com>
Merged-In: I873d51e089b27aa0cc0dc9f5f25fd8ffaa4d8f40
2023-07-06 05:16:22 +00:00
liuxiangjun
eddc6dc0ad Return INVALID_ ARGUMENTS is the expected result
For devices not in LTE service, the vts test returns INVALID_ ARGUMENTS is an expected result

Bug:289756066

Test:
VtsHalRadioV1_5TargetTest  PerInstance/RadioHidlTest_v1_5#startNetworkScan/0_slot1
VtsHalRadioV1_5TargetTest  PerInstance/RadioHidlTest_v1_5#startNetworkScan/1_slot2

Change-Id: I873d51e089b27aa0cc0dc9f5f25fd8ffaa4d8f40
Signed-off-by: liuxiangjun <liuxiangjun3@xiaomi.com>
2023-07-06 02:10:44 +00:00
Sarah Chin
dc67668dcb Add @hide and @JavaDerive(toString) for IRadio AIDL
Add @hide for all classes
Add @JavaDerive(toString=true) for classes that are missing it
Fix AIDL formatting issues

Bug: 280900995
Test: build
Change-Id: I812fbadd9da272b604ff3dcd6828952bc55239e9
2023-05-06 10:16:16 +00:00
Sarah Chin
bb35a4371e Clean up VtsHalRadioTargetTest
Refactor class design so RadioServiceTest extends TestWithParam and
each individual radio service test extends RadioServiceTest.
Move setup and teardown logic common to all classes to RadioServiceTest.
Add logs to print when each test starts/finishes to help debug issues.
Remove unused imports and fix some typos.
Change unique_lock to lock_guard in notify to prevent MTE errors.

Test: atest VtsHalRadioTargetTest on fullmte build
Bug: 263940636
Change-Id: I2f6844f07d4518c00d47f98e5e15bea0a809fa84
Merged-In: I2f6844f07d4518c00d47f98e5e15bea0a809fa84
2023-05-04 22:35:47 +00:00
Sarah Chin
a1efe7a0dd Clean up VtsHalRadioTargetTest
Refactor class design so RadioServiceTest extends TestWithParam and
each individual radio service test extends RadioServiceTest.
Move setup and teardown logic common to all classes to RadioServiceTest.
Add logs to print when each test starts/finishes to help debug issues.
Remove unused imports and fix some typos.
Change unique_lock to lock_guard in notify to prevent MTE errors.

Test: atest VtsHalRadioTargetTest on fullmte build
Bug: 263940636
Change-Id: I2f6844f07d4518c00d47f98e5e15bea0a809fa84
2023-05-04 15:33:57 -07:00
Sarah Kim
18cd0f0954 Merge "Fix broken and flaky VTS tests" into android12-tests-dev am: 3323c87bfa am: c5bde9bbcd
Original change: https://android-review.googlesource.com/c/platform/hardware/interfaces/+/2572133

Change-Id: I462f8665e402cdeeef80b0babd184400fbc66a40
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-05-01 19:24:06 +00:00
Sarah Kim
c5bde9bbcd Merge "Fix broken and flaky VTS tests" into android12-tests-dev am: 3323c87bfa
Original change: https://android-review.googlesource.com/c/platform/hardware/interfaces/+/2572133

Change-Id: Ia3a9b69291efc526cfe8a2161145d563edf6ee4f
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-05-01 18:47:23 +00:00
Sarah Chin
0aae7cccd0 Backport VTS fixes to previous test versions am: 526a3a297b am: 64816a99b9
Original change: https://android-review.googlesource.com/c/platform/hardware/interfaces/+/2574430

Change-Id: If38943222d0d5687f7f12866ad147401c4ee8292
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-05-01 18:21:42 +00:00
Sarah Kim
3323c87bfa Merge "Fix broken and flaky VTS tests" into android12-tests-dev 2023-05-01 18:06:17 +00:00
Sarah Chin
64816a99b9 Backport VTS fixes to previous test versions am: 526a3a297b
Original change: https://android-review.googlesource.com/c/platform/hardware/interfaces/+/2574430

Change-Id: Icc1838d577a8bd1dae4ca8b5b0524779354346c9
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-05-01 17:43:32 +00:00
Sarah Chin
526a3a297b Backport VTS fixes to previous test versions
Network scan check periodicity only if scan type is PERIODIC.
Fix MCC/MNC checks to handle null strings.

Test: atest VTS
Bug: 259674407
Change-Id: I77e0706f413ce9defb174f00ee145dcc01f5d780
Merged-In: I77e0706f413ce9defb174f00ee145dcc01f5d780
(cherry picked from commit 8ab8f0d1d8)
2023-04-30 23:48:50 +00:00
Sarah Chin
5b303d2fbb Require SIM card for all VTS tests am: 9426eab44a am: 9973f65f95
Original change: https://android-review.googlesource.com/c/platform/hardware/interfaces/+/2569893

Change-Id: I934fe99e216d7e967d30861d6ca8b8e46b3e2b5e
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-04-29 21:35:27 +00:00
Sarah Chin
9973f65f95 Require SIM card for all VTS tests am: 9426eab44a
Original change: https://android-review.googlesource.com/c/platform/hardware/interfaces/+/2569893

Change-Id: I2769b1f7e7da440cfa4d6e8d85d59eaa5af63148
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-04-29 21:01:30 +00:00
Treehugger Robot
13b18534b5 Merge "Backport VTS fixes to previous test versions" into udc-dev am: 3d35c2e75c am: 89d08942d8
Original change: https://googleplex-android-review.googlesource.com/c/platform/hardware/interfaces/+/22912666

Change-Id: I41e75ebdc49d034458e054c6de23f2cb14f59554
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-04-28 23:42:46 +00:00
Sarah Chin
8ab8f0d1d8 Backport VTS fixes to previous test versions
Network scan check periodicity only if scan type is PERIODIC.
Fix MCC/MNC checks to handle null strings.

Test: atest VTS
Bug: 259674407
Change-Id: I77e0706f413ce9defb174f00ee145dcc01f5d780
Merged-In: I77e0706f413ce9defb174f00ee145dcc01f5d780
2023-04-28 16:28:09 -07:00
Treehugger Robot
3d35c2e75c Merge "Backport VTS fixes to previous test versions" into udc-dev 2023-04-28 23:12:07 +00:00
Jayachandran C
98b15ce956 Merge "Fix fail on RadioConfigTest#checkPortInfoExistsAndPortActive for dual-SIM detection" into android13-tests-dev am: 2b072c63c9 am: caf536d72a am: eaeb13c583
Original change: https://android-review.googlesource.com/c/platform/hardware/interfaces/+/2530680

Change-Id: I70a3f5264884508d3ae4da6f27a539d388bb1495
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-04-28 21:58:59 +00:00
Sarah Chin
7f3bd1792f Fix broken and flaky VTS tests
nvResetConfig takes some time to reset the modem, causing subsequent
tests to fail with a timeout since the modem is unavailabe.
Add a timeout after nvResetConfig to allow the modem to be up again
before running the next test.

Bug: 259674407
Test: atest VtsHalRadioTargetTest
Change-Id: Ic7188f9d8ccfcd90d844b45e3b370a3be3c515d6
Merged-In: Ic7188f9d8ccfcd90d844b45e3b370a3be3c515d6
(cherry picked from commit ddaea2e5a4)
2023-04-28 18:33:08 +00:00
Sarah Kim
2facc26b0c Merge "Fix broken and flaky VTS tests" 2023-04-28 18:29:25 +00:00
Sarah Chin
fc35c0797e Backport VTS fixes to previous test versions
Network scan check periodicity only if scan type is PERIODIC.
Fix MCC/MNC checks to handle null strings.

Test: atest VTS
Bug: 259674407
Change-Id: I77e0706f413ce9defb174f00ee145dcc01f5d780
2023-04-28 11:12:01 -07:00
Sarah Chin
9426eab44a Require SIM card for all VTS tests
We check SIM card status is PRESENT before running any VTS tests, so
ensure that it's enforced in the configs as well.

Test: atest VtsHalRadioTargetTest
Bug: 249143796
Change-Id: I1b2c317e21db118e4b957804feb76f266d887b20
Merged-In: I1b2c317e21db118e4b957804feb76f266d887b20
(cherry picked from commit 658fdaaa2a)
2023-04-28 07:05:09 +00:00
Sarah Chin
658fdaaa2a Require SIM card for all VTS tests
We check SIM card status is PRESENT before running any VTS tests, so
ensure that it's enforced in the configs as well.

Test: atest VtsHalRadioTargetTest
Bug: 237504027
Change-Id: I1b2c317e21db118e4b957804feb76f266d887b20
Merged-In: I1b2c317e21db118e4b957804feb76f266d887b20
2023-04-27 18:44:23 -07:00
Sarah Chin
ddaea2e5a4 Fix broken and flaky VTS tests
1. nvResetConfig takes some time to reset the modem, causing subsequent
   tests to fail with a timeout since the modem is unavailabe.
   Add a timeout after nvResetConfig to allow the modem to be up again
   before running the next test.
2. Remove invalid errors for start/stopKeepalive. These tests should
   fail due to invalid arguments, so remove NONE as a possible error.
   RADIO_NOT_AVAILABLE should also be removed.
3. Fix incorrect startNetworkScan_InvalidInterval tests, since we only
   check the interval when the scan type is PERIODIC.
4. Save and reset the previous allowed network type bitmap after the
   test. Combine get/set into one test that tests both behaviors.
5. Fix checks for MCC/MNC in getDataRegistrationState

Bug: 277626718
Bug: 240953393
Bug: 264913330
Bug: 259674407
Bug: 242801688
Test: atest VtsHalRadioTargetTest
Change-Id: Ic7188f9d8ccfcd90d844b45e3b370a3be3c515d6
Merged-In: Ic7188f9d8ccfcd90d844b45e3b370a3be3c515d6
2023-04-27 18:43:06 -07:00
Jayachandran C
1abf1a652e Merge "Fix fail on RadioConfigTest#checkPortInfoExistsAndPortActive for dual-SIM detection" am: 569b04a197 am: e218309f1e am: 0f6b299632 am: c3461e6d77 am: fb6118c256
Original change: https://android-review.googlesource.com/c/platform/hardware/interfaces/+/2527586

Change-Id: I74c79eb095aa2a6a6f7bcba579d5d1d4caf6f9b0
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-04-26 03:49:05 +00:00