Add the initialization of the incrementalResultsPeriodicity and
maxSearchTime in the networkScan request.
The incrementalResultsPeriodicity and maxSearchTime are not
initialized in the networkScan request. So the default value is 0.
But the incrementalResultsPeriodicity and maxSearchTime
are required not to be 0 in subsequent tests.
CL ported from pag/1433565
Bug:140451434
Test: make vts && vts-tradefed run commandAndExit vts -m \
VtsHalRadioV1_2Target -t RadioHidlTest_v1_2#startNetworkScan
Change-Id: I1b4e512a37d3d85ebc905a64987a40af801bce53
(cherry picked from commit f7894eb4d8c395add7c70a20520336057ae2656f)
Update the documentation of NetworkScanRequest to clarify
that the interval between scans is from the completion of
one scan to the start of another. This is the only possible
definition that doesn't possibly result in back-to-back
scans which never complete.
In the initial design of this API, the stated use case was
for scans where "interval" >> "scan duration". For that
use case, this clarification doesn't make a meaningful
difference; however, for the use case of long-duration
scans, the distinction prevents the issue stated above.
Bug: 139935383
Test: compilation (docstring-only change)
Change-Id: Ib8393110bfd3ea883045648ee7dac9c6e6a32d44
Currently tests that check for incremental scan interval
range-checking have incremental scans disabled.
This CL turns on incremental scans for tests where the
invalid interval range checks are being validated.
Set Incremental Results to true for InvalidPeriodicity
Tests in Radio 1.4. This is a spiritual cherry-pick of
the exact same test copied from HAL 1.2.
Related Change-Id: I94874f538d2df70a72913b489d9298f8d1cf9b56
Related Sha: 81c811b895
Bug: 138317383
Test: atest RadioHidlTest_v1_4#startNetworkScan_InvalidPeriodicity1
Test: atest RadioHidlTest_v1_4#startNetworkScan_InvalidPeriodicity2
Change-Id: I20d6423c01dfc1c708514e798589c36666f2c0d4
Since these were combined into libhidlbase.
Bug: 135686713
Test: build only (libhwbinder/libhidltransport are empty)
Change-Id: I075670b64eebbbbd6a6ae0e84ad51bf1c6f5ba36
It's reasonable to update the global variable "currentCalls" before
notifying the reader thread. Otherwise this can cause some issues such
as null pointer dereference in other modem.
Bug: 139264227
Test: Don't have devices that uses the corresponding modem that reports
this issues. This is verified according to a partner CL:
https://partner-android-review.googlesource.com/c/platform/hardware/interfaces/+/1422356
Change-Id: Iee9e18149397c39b7c84ec1dc570b9bac7142eb6
Merged-In: Iee9e18149397c39b7c84ec1dc570b9bac7142eb6
(cherry picked from commit fcd55caafd)
Providing non-dds exemption for HAL 1.2 network scan due to some devices
only perform network scan on preferred data sim. Since logical modem
id(0/1) and physical sim slot id(0/1) are intuitively aligned. Set
first sim as dds sim, and skip the network scan on the second one
(non-dds).
Test: Vts
Bug: 135243177
Change-Id: I58b89473714dc6d3ce6567ba1809baad6cd6d799
(cherry picked from commit fc85e8fa50)
After disconnect calls, we want to verify there are no more current calls
by calling IRadio.getCurrenctCalls
Test: run vts
Bug: 138413412
Change-Id: Iacca49abff11fbdfb4ae6dd060a5f150e9e4a74d
Merged-In: Iacca49abff11fbdfb4ae6dd060a5f150e9e4a74d
(cherry picked from commit 5f68117e87)
After disconnect calls, we want to verify there are no more current calls
by calling IRadio.getCurrenctCalls
Test: run vts
Bug: 138413412
Change-Id: Iacca49abff11fbdfb4ae6dd060a5f150e9e4a74d
Providing non-dds exemption for HAL 1.2 network scan due to some devices
only perform network scan on preferred data sim. Since logical modem
id(0/1) and physical sim slot id(0/1) are intuitively aligned. Set
first sim as dds sim, and skip the network scan on the second one
(non-dds).
Test: Vts
Bug: 135243177
Change-Id: I58b89473714dc6d3ce6567ba1809baad6cd6d799
Network scan tests with parameters are disabled because of vendors
failed to fully implement startNetworkScan in HAL 1.4, and GSM rat scan
with parameters will get REQUEST_NOT_SUPPORTED error from modem.
Test: VTS
Bug: 137298570
Change-Id: I99df8495c5f654cb1420b7da36d7f5128ce14dbc
Change stopNetworkScan from 1_1 to 1_2 when testing VtsHalRadioV1_2Target.
Symptom:
When vts process slot2 "startnetworkscan", it will call "stopnetworkscan()" when startnetworkscan
success. But from current design it will set stopnetworkscan to slot1(wrong slot, expect is slot2)
as bwlow log.
CTS fail log:
hardware/interfaces/radio/1.2/vts/functional/radio_hidl_hal_test.cpp:111
//Device request NwScan on 2nd Sim
06-28 11:30:22.770 radio 873 1213 F RILQ : RIL[1][Log.cpp: 48] [DispatcherModul(873,1213)]
d: [DispatcherModule]: Handling msg = RIL_REQUEST_START_NETWORK_SCAN
//But Device want to abort on Primary Sim
06-28 11:30:22.776 radio 923 1205 F RILQ : RIL[0][Log.cpp: 48] [DispatcherModul(923,1205)]
d: [NasModule]: Handling msg = RIL_REQUEST_STOP_NETWORK_SCAN[Context: IRadio(1681692777)]
Bug: 135982495
Test: Build pass. Local test VTS pass.
Change-Id: Ic53c24ab2a670e806b4ac7f192e6eb81252ade84
(cherry picked from commit 5cef297cb2)
The whole test case run emergencyDial.RadioHidlTest_v1_4 first and then
come after startNetworkScan.RadioHidlTest_v1_4 test case immediately
(within ~3 secs) the NWscan failure is device in emergency call in
progress/connected while doing emergencyDial.RadioHidlTest_v1_4 test
Although emergencyDial.RadioHidlTest_v1_4 only care about command/response
is successful or not and don't care call is established or not, modem do
care about call condition is in idle/progress/connected state before it
can do NWscan
When there's dedicated channel established, modem can not perform AP
request NWscan in parallel as we are single HW modem restriction.
Test: run vts
Bug: 135595082
Change-Id: Iecba54b93b96d33b57bc59e00f082ff133d2e57b
Merged-In: Iecba54b93b96d33b57bc59e00f082ff133d2e57b
(cherry picked from commit 07a53471c4)
The whole test case run emergencyDial.RadioHidlTest_v1_4 first and then
come after startNetworkScan.RadioHidlTest_v1_4 test case immediately
(within ~3 secs) the NWscan failure is device in emergency call in
progress/connected while doing emergencyDial.RadioHidlTest_v1_4 test
Although emergencyDial.RadioHidlTest_v1_4 only care about command/response
is successful or not and don't care call is established or not, modem do
care about call condition is in idle/progress/connected state before it
can do NWscan
When there's dedicated channel established, modem can not perform AP
request NWscan in parallel as we are single HW modem restriction.
Test: run vts
Bug: 135595082
Change-Id: Iecba54b93b96d33b57bc59e00f082ff133d2e57b
Merged-In: Iecba54b93b96d33b57bc59e00f082ff133d2e57b
For some vendors do not supports independent radios, if
there is one manual search ongoing, another manual search
on other SIM is not supported. So sending stop network scan
request once trigger network scan completed to exclude this
modem limitation.
Bug: 135005200
Test: atest RadioHidlTest_v1_2#startNetworkScan
Change-Id: Iacfd59ac2ad4d44e763ee03697c1f8f57162ce38
This vts enforce IRadioConfig is existed when IRadio service is supported.
We didn't add IRadioConfigV1.2, so in this test IRadioConfigV1.1 will be
checked.
Bug: 132379735
Test: atest VtsHalRadioV1_4TargetTest
Change-Id: I2062ed6b191193d9a8af4f25059fed6cc8dc09d8
Currently tests that check for incremental scan interval
range-checking have incremental scans disabled.
This CL turns on incremental scans for tests where the
invalid interval range checks are being validated.
Bug: 112486807
Test: atest RadioHidlTest_v1_2#startNetworkScan_InvalidPeriodicity1;
atest RadioHidlTest_v1_2#startNetworkScan_InvalidPeriodicity2;
Merged-In: I94874f538d2df70a72913b489d9298f8d1cf9b56
Change-Id: I94874f538d2df70a72913b489d9298f8d1cf9b56
(cherry picked from commit f56b9a41dd)
