Commit graph

23 commits

Author SHA1 Message Date
Steven Moreland
db2de2690c Merge "Remove misleading comment in sample dumpstate impl"
am: eac1c71ce4

Change-Id: I18041d79922f6c09161316d9fcf3249f0c46c6b0
2018-07-24 11:08:12 -07:00
Steven Moreland
21d87dde45 Remove misleading comment in sample dumpstate impl
HIDL_FETCH_IDumpstateDevice isn't defined simply
because this is a binderized service and this function
would be called (to no great use) if it was installed
to a device.

Bug: N/A
Test: N/A
Change-Id: I9b660af3fe329977cdcd0c3f485af651c34416cb
2018-07-20 21:06:53 +00:00
Steven Moreland
7d4d1c2156 resolve merge conflicts of d3b6ea09c1 to pi-dev-plus-aosp
BUG: None
Test: I solemnly swear I tested this conflict resolution.
Change-Id: I669dfde4a23d8d995232dfbf6b57745532ff76f2
2018-05-07 13:31:59 -07:00
Steven Moreland
521d15c537 Make dumpstate HAL lazy.
Bug: 78509314
Test: HAL isn't running
Test: adb bugreport HAL runs
Test: HAL isn't running after bugreport finishes
Test: manually inspect state using `lshal` and logs
    using `adb logcat | grep android.hardware.dump`

(cherry picked from commit 711b806727c85d91cf805db4f78b4a9609e2bf43)

Change-Id: Ic97516a4297e7933430fb4fa3fd0109f8c1b1d0a
2018-05-07 09:35:11 -07:00
Wei Wang
af3006428d dumpstate: add interface into rc file
Bug: 7748994
Test: Build
Change-Id: I5e86b0e63928f42ea7b247bd0de0719daf80a10d
Merged-In: I5e86b0e63928f42ea7b247bd0de0719daf80a10d
2018-05-07 09:27:02 -07:00
Wei Wang
aa8a547821 dumpstate: add interface into rc file
Bug: 7748994
Test: Build
Change-Id: I5e86b0e63928f42ea7b247bd0de0719daf80a10d
2018-04-05 13:35:38 -07:00
Chih-Hung Hsieh
609a9b8ffd Merge "Use -Werror in hardware/interfaces/dumpstate/1.0/default" am: 641fc32fc0 am: fc67ecce2a
am: d48225ca56

Change-Id: I4423f2838daac22baa172817254930c76685324b
2017-11-10 18:51:40 +00:00
Chih-Hung Hsieh
4ce5eab989 Use -Werror in hardware/interfaces/dumpstate/1.0/default
Bug: 66996870
Test: build with WITH_TIDY=1
Change-Id: Ic91f44e7410fd5bd8d1231f886a526a5e21a2eae
2017-11-08 13:36:57 -08:00
Steven Moreland
9aec6164fd Merge "dumpstate mk -> bp" am: b1088c6de1 am: 9251e71740
am: d292895d0d

Change-Id: I8bc36d2c12c427e14df46f8a6bec76fa4f99cae6
2017-11-06 18:16:21 +00:00
Steven Moreland
71f26bf5cc dumpstate mk -> bp
Test: compilation finds dependencies
Bug: 37512442
Change-Id: Ib207c2163a07dea03c096283d10b00af966a1728
2017-11-02 15:25:59 -07:00
Jaekyun Seok
81104ae5ef Add 'vendor.' prefix to a vendor HAL service name
To prevent property name collisions between properties of system and
vendor, 'vendor.' prefix must be added to a vendor HAL service name.
You can see the details in http://go/treble-sysprop-compatibility.

Test: succeeded building and tested on a walleye device
Bug: 36796459
Change-Id: I4e8fbee791ec917a8f627a1366f4d44ec7e6febc
2017-09-12 08:01:42 +09:00
Steven Moreland
34ace43a2d Check handle for nullptr
Test: pass
Bug: 37662706
Change-Id: Ia3ec4d8e512d18b679a9d6291a8dfdc0eb0cceec
2017-05-23 16:12:34 -07:00
Sandeep Patil
fd472b82f5 dumpstate hal: use vendor toybox
Bug: 36463595
Test: Dumpstate works

Change-Id: I9f79924fe6c2c7624f97ce24dcf95f61ee165146
Signed-off-by: Sandeep Patil <sspatil@google.com>
2017-04-14 19:14:42 -07:00
Steven Moreland
a5bb877914 Check result of registerAsService in dumpstate.
Test: see change I35f5d4498abd7369b03a04081e8aa26a3933328e
Fixes: 36704363
Change-Id: I5cc8f32592a77994e756438b8d1b7f3255acef19
2017-03-30 18:04:39 +00:00
TreeHugger Robot
2653620a61 Merge "Remove viral dependency on libhwbinder. (2/2)" 2017-02-24 23:25:26 +00:00
Steven Moreland
7e73d5b908 Remove viral dependency on libhwbinder. (2/2)
find hardware/interfaces -name Android.mk -exec sed -i -e '/libhwbinder
\\/d' {} \;
find hardware/interfaces -name Android.bp -exec sed -i -e
'/"libhwbinder"/d' {} \;
./hardware/interfaces/update-makefiles.sh

Note, automotive has some actual dependencies on libhwbinder, filed
b/35758626 for this.

Test: everything links
Test: (sanity) booted marlin on internal master with these changes
Bug: 35710429
Change-Id: I6d0726c8130d00684b978efbdd48e3ae396f12e5
2017-02-24 12:18:01 -08:00
Chris Phoenix
888c2300de dumpstate HAL uses "default" service name
The getService() and registerAsService() methods of interface objects
now have default parameters of "default" for the service name. HALs
will not have to use any service name unless they want to register
more than one service.

Test: builds

Bug: 33844934
Change-Id: I4415e38d0f50884e31feedddf8e4236fa69f1a31
2017-02-23 19:30:56 +00:00
Steven Moreland
a0da1a1c3d Move hidl shims to the vendor partition. (2/2)
We need google shims on the vendor partition because they are providing
an implementation of a vendor defined interface. They were written by
google just as a courtesy/to make the transition easier. They're
basically a set for vendors to assemble their hal implementations
from.

Bug: 34135607
Test: marlin persist.hal.binderization on/off
Change-Id: I2e2af5af39264cf290259755bb9b2eb9827a21f5
2017-02-13 15:03:41 -08:00
Steven Moreland
92a95b2870 Dumpstate: default service implementation.
- dumpstate will not have passthrough mode. All new implementations are
  required anyway. It makes more sense to just have them binderized by
  default.

Test: compiles/put on device in right location/running
Bug: 31982882
Change-Id: Ib0c12a2e0da931060f0e9e990fb63b6c7bc9e872
2017-01-11 16:09:35 -08:00
Steven Moreland
9f8b5c7b16 Added AOSP license headers.
This is only for hals which are currently only in master. Separate
commit for hals currently in AOSP.

Test: pass
Change-Id: I0b1a09798c49f4f0141f36a322c4749e47eded03
2016-11-29 23:07:09 +00:00
Felipe Leme
6a276ba842 Passing title to libdumpstateutil functions.
BUG: 31982882

Test: built and ran it

Change-Id: Icf09ca272b072c78794855157f13be8cafdb6a47
2016-11-28 13:44:30 -08:00
Colin Cross
94a069e8dc Use newly introduced hidl_handle in DumpstateDefault
The dumpstate hal passes a hild_handle, but DumpstateDefault was
expecting a native_handle_t*.  This was exposed when
Id7dbc646b50f132e240bfbba719a2d36585ccc35 caused the Android.mk
file to be picked up.

Bug: 31982882
Bug: 32089785
Test: builds
Change-Id: I48c84b6d19a93ceb0641be517f378fd6aba45962
2016-11-22 21:33:24 -08:00
Felipe Leme
e83f9fbc02 Initial definition of the Dumpstate HIDL interfaces.
BUG: 31982882
Test: manually built it

Change-Id: I3dd1d681061d16059ec9cf67869f20759fb75cd0
2016-11-18 17:05:34 -08:00