Commit graph

158 commits

Author SHA1 Message Date
Kevin Chyn
22a57205e9 Add example IBiometricsFingerprint@2.2 HAL
The exisitng 2.1 default implementation assumes that the device has
a pre-HIDL HAL. Keep this implementation intact for vendors with
legacy implementations.

This change adds a new example 2.2 HAL that does not assume the
existance of a pre-HIDL HAL, which can be used by cuttlefish
and CTS.

Bug: 172957689
Test: make -j android.hardware.biometrics.fingerprint@2.2-service.example
Test: atest CtsBiometricsTestCases
Test: m vts -j && vts-tradefed run commandAndExit vts -m VtsHalBiometricsFingerprintV2_1Target
Test: m vts -j && vts-tradefed run commandAndExit vts -m VtsHalBiometricsFingerprintV2_2Target
Change-Id: I4d87028d70fdb5c03759080e53e69751cf5e4307
2020-12-03 19:53:16 -08:00
Kevin Chyn
09fc704624 Update fingerprint AIDL for CTS
Bug: 173453845
Test: atest CtsBiometricsTestCases
Change-Id: I9132d366e862b38ccb7fe72082f7a4cb9c7e160f
2020-11-19 18:48:01 -08:00
Kevin Chyn
4d0df26150 Remove HAT from invalidateAuthenticatorId and correct documentation
1) Removes HAT param from fingerprint AIDL
2) Update documentation for fingerprint and face AIDL

Fixes: 173432893
Test: m android.hardware.biometrics.face-update-api
Test: m android.hardware.biometrics.fingerprint-service.example

Change-Id: I9c5e219c6f7a59609b6ff9d692f5a931f4bcea24
2020-11-16 12:42:40 -08:00
Kevin Chyn
4239f892ee Merge "Add default implementation for several methods" 2020-10-26 17:41:59 +00:00
Kevin Chyn
de2610f075 Add default implementation for several methods
Test: atest FingerprintServiceTest
Bug: 170518383

Change-Id: If724d26e85967a4b3ec07c22c706efca5cfc3f86
2020-10-20 18:27:45 -07:00
Ilya Matyukhin
aff41d866c Merge "Create OWNERS files for biometric AIDLs" 2020-10-19 22:53:17 +00:00
Ilya Matyukhin
3d54f4576c Move [generate|revoke]Challenge under ISession.aidl
Bug: 171002801
Test: m android.hardware.biometrics.fingerprint-update-api
Test: atest VtsHalBiometricsFingerprintTargetTest
Change-Id: I2aa266b7b81003b7fd0ab0328833e5500de99908
2020-10-16 04:53:27 +00:00
Ilya Matyukhin
53af9512bd Create OWNERS files for biometric AIDLs
Bug: none
Test: none
Change-Id: Idbe85483a66365095e0afab9bb64d4ea6068ddf7
2020-10-15 11:46:14 -07:00
Kevin Chyn
749799387e Tweaks to fingerprint AIDL
1) Explicit numbering for Error enum, which contains intentionally
   skipped entries for backwards compatibility
2) Documentation for vendorCode. The vendorCodes must have a well
   defined behavior with the array API for things like GSI to work,
   e.g. generic system image with non-generic HAL implementation -
   with this explicit requirement, both components, as long as the
   contract is followed, would allow proper string feedback to be
   loaded/shown.

Bug: 168843220
Test: Builds
Change-Id: Ie78e42b926351a03162a4a6e40f3325641c34609
2020-09-23 15:48:42 -07:00
Kevin Chyn
3388eebde5 Reformat biometric interface documentation to 100 cols
Bug: 168843220
Test: Builds
Change-Id: Ibf2baa14f8c8bd47250dd964eab68307e3885b4c
2020-09-23 14:29:38 -07:00
Kevin Chyn
ef79d661ba Move lockout callbacks to ISessionCallback
Also fixes backward compatibility for AcquiredInfo and Error
constants.

For lockout-related changes:
1) If a session doesn't exist, it means the framework (or higher)
   doesn't care about its lockout state.
2) This allows the ISession#authenticate lifecycle to be clearer,
   e.g. no need for ILockoutCallback#onLockoutTimed followed by
   ISessionCallback#onError(LOCKOUT)

Bug: 168842956
Bug: 168843220

Test: make -j android.hardware.biometrics.fingerprint-update-api
Test: make -j
Test: make -j VtsHalBiometricsFingerprintTargetTest
Change-Id: I0b7e7ab3b89d0d1d7647535af07766c493a2067b
2020-09-23 11:40:13 -07:00
Kevin Chyn
8b3cd5db21 Finish remainder of documentation.
Note that this doesn't mean documentation is done, it just means that
previously undocumented areas now at least have some documentation.

Bug: 168843220
Test: Builds

Change-Id: I92db9b228d46b3925d3f7ae56698f7c52a0ae1bf
2020-09-23 11:27:01 -07:00
Kevin Chyn
1288c105a7 Minor API changes and additional documentation for IFingerprint
1) Removes vendorCode from onEnrollmentProgress. This is already
   being sent in ISessionCallback#onAcquired
2) Adds missing SessionState::INVALIDATING_AUTHENTICATOR_ID state

Test: make -j56 android.hardware.biometrics.fingerprint-update-api
Test: make -j56 VtsHalBiometricsFingerprintTargetTest
Test: make -j56

Change-Id: I246153339b336c029c9f156868127456aecf1a04
2020-09-23 11:07:59 -07:00
Kevin Chyn
64c13a083a Update fingerprint #authenticate interfaces & documentation
1) Split into onAuthenticationSucceeded and onAuthenticaitonFailed.
   No longer need to use "weird behavior" below:
   A) authenticated(id=0) == reject
   B) onEnrolled(id=0) --> previously forbidden
   C) remove(id=0) --> previously magic number to remove all
      enrollments. The new interface has remove(int[] ids).
2) Renames keystoreOperationId to operationId, since keystore
   is only one example of a valid use case. operationId and HATs
   can be used as attestation for any opaque operation.

Bug: 168842956
Bug: 168843220

Test: make -j56 android.hardware.biometrics.fingerprint-update-api
Test: make -j56 VtsHalBiometricsFingerprintTargetTest
Change-Id: I7ca0365be9cf82539d6cabc6d9fcec916badc323
2020-09-23 00:18:55 -07:00
Kevin Chyn
571caa6a45 Start adding documentation for IFingerprint
Minor changes to interface:
1) IResetLockoutCallback renamed to ILockoutCallback
2) Removes unnecessary parameter from onChallengeGenerated
3) Adds "challenge" param to revokeChallenge to support multiple
   in-flight challenges

Bug: 168842956
Bug: 168843220

Test: make -j56 android.hardware.biometrics.fingerprint-update-api
Test: make -j
Test: make -j56 VtsHalBiometricsFingerprintTargetTest

Change-Id: If1f63a6d0c135d7b59690a31728b4d3fc8c2d2c4
2020-09-21 17:06:32 -07:00
Kevin Chyn
e33abd6456 Move ICancellationSignal to common, add supportsNavigationGestures
Bug: 168842956
Test: Builds
Test: make -j56 android.hardware.biometrics.common-update-api
Test: make -j56 android.hardware.biometrics.fingerprint-update-api
Test: make -j56 VtsHalBiometricsFingerprintTargetTest

Change-Id: Ie35ccc2ea8b7ef710914e9a18fc28f49c2d6f0be
2020-09-18 12:07:34 -07:00
Kevin Chyn
c306b76f7f Add HardwareInfo to CommonProps
Bug: 168541000
Test: make -j android.hardware.biometrics.common-update-api
Test: make -j
Change-Id: I2a96a46dc768b4cdb500ca8ea6bfd23c9f724866
2020-09-17 14:27:48 -07:00
Kevin Chyn
94a82210c9 Add sensorLocation, sensorRadius, displayId to SensorProps
Bug: 168541000
Test: make -j56 android.hardware.biometrics.fingerprint-update-api

Change-Id: Ia8323a114c74ec9c6680333c868881ac51e6363f
2020-09-17 13:29:45 -07:00
Kevin Chyn
6e862c31a1 Add authenticatorId changes to Fingerprint aidl
Also adds a top-level README for the biometric package

Bug: 159667191
Bug: 168541000

Test: make -j56 android.hardware.biometrics.fingerprint-update-api
Test: make -j56 VtsHalBiometricsFingerprintTargetTest

Change-Id: I3dba8e7ee16700865662c1a00b75576d2513f930
2020-09-17 13:16:58 -07:00
Kevin Chyn
7d3fdf5ef6 Add android.hardware.biometrics.common
Bug: 168541000

Test: make -j56 android.hardware.biometrics.common-update-api
Test: make -j56 android.hardware.biometrics.fingerprint-update-api
Test: make -j56 android.hardware.biometrics.fingerprint-service.example

Change-Id: Icaa1c2a0363a7fa446747ef89b5e50ca44dcd42e
2020-09-16 13:59:33 -07:00
Ilya Matyukhin
a9a3c850bc Default implementation for IFingerprint
Bug: 152416783
Test: atest VtsHalBiometricsFingerprintTargetTest
Test: atest vts_treble_vintf_vendor_test
Test: atest hal_implementation_test
Change-Id: I67efda2d5418147a7cac9cc54920005a199fcbe3
2020-09-10 19:38:49 -07:00
Ilya Matyukhin
14412df89f Add VTS tests for IFingerprint
Bug: 152416783
Test: atest VtsHalBiometricsFingerprintTargetTest
Change-Id: I6aec70e8f9f4342cab2f7ce367698841e22f57f1
2020-09-10 19:38:49 -07:00
Ilya Matyukhin
ed361970c6 Define IFingerprint
Bug: 152416783
Test: m android.hardware.biometrics.fingerprint-update-api
Change-Id: Iba1fae1739366955b6aaed55b59eed0a3fed5a57
2020-09-10 19:38:49 -07:00
Dan Shi
ff985a85a8 Suppress gtest error for tests without any instance
Bug: 162052785
Test: m -j vts
Change-Id: I58bc808a82b2128bb8774f762f9b9fcecd2614fb
2020-07-29 09:46:36 -07:00
Dan Shi
9eaab747fe Suppress gtest error for tests without any instance am: ba4d532fee am: 73122cd284 am: e5c9b5e722 am: 1a52c0eb25 am: 1a3e0f86eb
Original change: https://android-review.googlesource.com/c/platform/hardware/interfaces/+/1374050

Change-Id: I6ddea2dcb636e3ba67ad11d53b9fe12c51314c7a
2020-07-29 06:36:31 +00:00
Dan Shi
e5c9b5e722 Suppress gtest error for tests without any instance am: ba4d532fee am: 73122cd284
Original change: https://android-review.googlesource.com/c/platform/hardware/interfaces/+/1374050

Change-Id: Ie5e956d4613f5e947c36ba4f1048f0c3aa8944ba
2020-07-29 05:45:58 +00:00
Dan Shi
ba4d532fee Suppress gtest error for tests without any instance
Bug: 162052785
Test: m -j vts
Change-Id: I8c1a48e6fbd7c8161137902b5332911fa0d7b8b3
2020-07-28 15:12:32 -07:00
Jooyung Han
d610435ac4 update hidl .bp
HIDL libs are not necessarily part of VNDK now. Because some are
used by VNDK libs, they are still VNDK. But rest are now just
vendor-available.

.hidl_for_test files are also removed because they are used to exclude
test-purpose hidl libs from VNDK libs.

Instead, .hidl_for_system_ext files are added to tests/lazy to
distinguish them from others which are installed /system.

Bug: 143933769
Test: update-makefiles.sh && m com.android.vndk.current
Merged-In: Ia81312dda340b6b5cbdd7a3c21e1d323bda39a4a
Change-Id: Ia81312dda340b6b5cbdd7a3c21e1d323bda39a4a
(cherry picked from commit b0907a6bb8)
2020-07-07 16:22:36 +09:00
Jooyung Han
d18cba85fe update hidl .bp
HIDL libs are not necessarily part of VNDK now. Because some are
used by VNDK libs, they are still VNDK. But rest are now just
vendor-available.

.hidl_for_test files are also removed because they are used to exclude
test-purpose hidl libs from VNDK libs.

Instead, .hidl_for_system_ext files are added to tests/lazy to
distinguish them from others which are installed /system.

Bug: 143933769
Test: update-makefiles.sh && m com.android.vndk.current
Merged-In: Ia81312dda340b6b5cbdd7a3c21e1d323bda39a4a
Change-Id: Ia81312dda340b6b5cbdd7a3c21e1d323bda39a4a
(cherry picked from commit b0907a6bb8)
2020-07-02 12:26:37 +09:00
Jooyung Han
b0907a6bb8 update hidl .bp
HIDL libs are not necessarily part of VNDK now. Because some are
used by VNDK libs, they are still VNDK. But rest are now just
vendor-available.

.hidl_for_test files are also removed because they are used to exclude
test-purpose hidl libs from VNDK libs.

Instead, .hidl_for_system_ext files are added to tests/lazy to
distinguish them from others which are installed /system.

Bug: 143933769
Test: update-makefiles.sh && m com.android.vndk.current
Change-Id: Ia81312dda340b6b5cbdd7a3c21e1d323bda39a4a
2020-07-02 09:18:17 +09:00
Ilya Matyukhin
134ace098a Add isUdfps method to biometrics.fingerprint@2.3
Bug: 158135499
Test: atest VtsHalBiometricsFingerprintV2_3TargetTest
Change-Id: I10a75f8362f2596709399a45555bf9f09451f962
2020-06-29 15:25:42 -07:00
Ilya Matyukhin
4585601fb3 Define biometrics.fingerprint@2.3
This HIDL introduces onFingerDown and onFingerUp methods.

Bug: 158135499
Test: build
Change-Id: If2bfd70ee518b3f980ed2dc36a2df2a1ccf3afce
2020-06-23 14:26:39 -07:00
Ilya Matyukhin
227e0ae083 Reduce the number of iterations in PreEnrollTest am: 744b028807 am: f80eb3cb9e am: 6ada775429 am: c72840c88a
Original change: https://googleplex-android-review.googlesource.com/c/platform/hardware/interfaces/+/11712201

Change-Id: I5f65cfcfb9d5a0cb9c6f228ff4a337242f109e29
2020-06-04 21:40:15 +00:00
Ilya Matyukhin
6ada775429 Reduce the number of iterations in PreEnrollTest am: 744b028807 am: f80eb3cb9e
Original change: https://googleplex-android-review.googlesource.com/c/platform/hardware/interfaces/+/11712201

Change-Id: Iec4c3608f11fcf3244c7902775cbda48c6051294
2020-06-04 21:10:03 +00:00
Ilya Matyukhin
798629af9e Reduce the number of iterations in PreEnrollTest am: 744b028807
Original change: https://googleplex-android-review.googlesource.com/c/platform/hardware/interfaces/+/11712201

Change-Id: I83175791dd8538ff1e4c7846835a01ebfb0c9a75
2020-06-04 20:56:25 +00:00
Ilya Matyukhin
744b028807 Reduce the number of iterations in PreEnrollTest
The current number of iterations is too high and results in a timeout
from the testing framework.

The goal of the test is to make sure that the generated challenges are
different on every run. It's impossible to test whether any two
challenges will ever be the same for any number of iterations. Hence,
since a 1000 iterations doesn't provide much more value over 10
iterations, 10 was chosen because of its better performance.

Bug: 155844206
Test: "atest VtsHalBiometricsFingerprintV2_1TargetTest" on a blueline
Change-Id: I5db887bdcfed8fb0e44fcedcf9e99dd185d395c3
2020-06-03 01:09:22 +00:00
Roman Kiryanov
761c93e3b9 Add vintf_fragments to android.hardware.biometrics.fingerprint@2.1-service
Bug: 144386336
Test: boot emulator, lshal | grep fingerprint
Signed-off-by: Roman Kiryanov <rkir@google.com>
Merged-In: I97ad0451bb3edfe85d33300baaa41c3fbc5c3cc6
Change-Id: I11c8ebea731f5e7b24ee483d20a8cd25fd01be38
2020-04-13 21:12:53 -07:00
Treehugger Robot
21a0954575 Merge "Add vintf_fragments to android.hardware.biometrics.fingerprint@2.1-service" am: 542841648c am: 0433361fd5 am: 9e1e29b25c am: 8c3259e507 am: e487011b4a
Change-Id: Ie1c96eeb3a5d8d941cec5b1a82d7df50b0aa0f18
2020-04-10 19:35:30 +00:00
Treehugger Robot
9e1e29b25c Merge "Add vintf_fragments to android.hardware.biometrics.fingerprint@2.1-service" am: 542841648c am: 0433361fd5
Change-Id: Id9b1e200f54d18c585331009f978edba91e3df05
2020-04-10 18:05:48 +00:00
Roman Kiryanov
407776edee Add vintf_fragments to android.hardware.biometrics.fingerprint@2.1-service
Bug: 144386336
Test: boot emulator, lshal | grep fingerprint
Signed-off-by: Roman Kiryanov <rkir@google.com>
Change-Id: I97ad0451bb3edfe85d33300baaa41c3fbc5c3cc6
2020-04-09 14:17:54 -07:00
Dan Shi
eb5f33e0ef Rename vts-core to vts am: ba894f81db am: 55d110bcd0
Change-Id: Ifc137320af42febc24937f09e5baa4c5a95ac1c4
2020-04-07 23:56:42 +00:00
Dan Shi
aad51fa000 Rename vts-core to vts
Bug: 151896491
Test: local build
Exempt-From-Owner-Approval: This CL update suite name vts-core to vts as
the suite name is updated. This CL won't change test logic or behavior.

Change-Id: I562b4dc50765e953800a814a8fd84a01c1b9352b
Merged-In: I562b4dc50765e953800a814a8fd84a01c1b9352b
2020-04-07 16:37:40 -07:00
Dan Shi
ba894f81db Rename vts-core to vts
Bug: 151896491
Test: local build
Exempt-From-Owner-Approval: This CL update suite name vts-core to vts as
the suite name is updated. This CL won't change test logic or behavior.

Change-Id: I562b4dc50765e953800a814a8fd84a01c1b9352b
Merged-In: I562b4dc50765e953800a814a8fd84a01c1b9352b
2020-04-07 15:17:02 -07:00
Dan Shi
3a8a650c61 Rename vts-core to vts
Bug: 151896491
Test: local build
Exempt-From-Owner-Approval: This CL update suite name vts-core to vts as
the suite name is updated. This CL won't change test logic or behavior.

Change-Id: I562b4dc50765e953800a814a8fd84a01c1b9352b
2020-04-07 18:03:49 +00:00
Ilya Matyukhin
49120d936c Remove enroll_2_2 and authenticate_2_2
Bug: 139317981
Bug: 149502271
Test: m vts -j
Test: vts-tradefed run commandAndExit vts -m VtsHalBiometricsFingerprintV2_2Target
Change-Id: I80492f324753291be4118de95e16ec370004afc8
2020-03-24 14:09:16 -07:00
Ilya Matyukhin
b05fa96baa Add VTS tests for biometrics.fingerprint@2.2
Bug: 139317981
Test: m vts -j
Test: vts-tradefed run commandAndExit vts -m VtsHalBiometricsFingerprintV2_2Target
Change-Id: I9119de5e690163fbb9ddbb38b117206e8c95a279
2020-01-22 17:55:47 -08:00
Ilya Matyukhin
671c59917d Define biometrics.fingerprint@2.2
This interface allows to pass a hardware window ID to the enroll and
authenticate methods. Also, FingerprintAcquiredInfo::START is
introduced to make latency measurements possible.

Bug: 139317981
Test: hidl-gen -L check android.hardware.biometrics.fingerprint@2.2

Change-Id: Ie044764984776d32ab52ca941cfa008202eca2c6
2020-01-22 17:55:42 -08:00
nelsonli
6bc848ea73 [vts-core] add VtsHalBiometricsFingerprintV2_1TargetTest to vts-core
Bug: 142397658
Test: $ atest VtsHalBiometricsFingerprintV2_1TargetTest
Change-Id: I04baa4f4dbc07f927d1a8c05f691dd63bb098a97
2019-10-24 14:57:11 +08:00
nelsonli
6fe484ca11 [vts-core] add VtsHalBiometricsFingerprintV2_1TargetTest to vts-core
Convert VtsHalBiometricsFingerprintV2_1TargetTest to be parameterized test
and add it to vts-core

Bug: 142397658
Test: $ atest VtsHalBiometricsFingerprintV2_1TargetTest
Change-Id: I076d3de4398e071370f3386817b8248a13eb9352
2019-10-18 01:30:09 +08:00
Steven Moreland
b3a4d3832e Remove libhwbinder/libhidltransport deps
Since these were combined into libhidlbase.

Bug: 135686713
Test: build only (libhwbinder/libhidltransport are empty)
Change-Id: I075670b64eebbbbd6a6ae0e84ad51bf1c6f5ba36
2019-09-06 01:07:02 +00:00