Commit graph

619 commits

Author SHA1 Message Date
Shuo Qian
185e46a234 Revert "Fixed VTS failure in no SIM case"
am: 9d0f0635b9

Change-Id: I2c85ff48e47094810bc4350197611969f94954e7
2018-08-02 12:17:38 -07:00
Shuo Qian
9d0f0635b9 Revert "Fixed VTS failure in no SIM case"
Since the EMERGENCY-type APN is a must set in the radio
setupDataCall request for modem to perform Emergency call,
and the given VTS test case does not set that emergency bit,
I think modem should treat the request as a normal call
request, and should not return "NONE" for no-sim.

This reverts commit 431eb118f8.

Reason for revert: after further discussion, NONE
is not acceptable given the test case.

Bug: 109767888
Change-Id: I3d1cc96120d53a9be0ae5059c26b091bf82dc352
Merged-In: I3d1cc96120d53a9be0ae5059c26b091bf82dc352
(cherry picked from commit 17fec3625d)
2018-08-02 17:16:36 +00:00
Amit Mahajan
7151988f62 Allow NOT_SUPPORTED for setLinkCapacityReportingCriteria on GERAN.
am: 8b833740b2

Change-Id: I6389dcaa6a48338cddb9d6e45519941f8e1cd9f8
2018-07-16 17:14:06 -07:00
Amit Mahajan
8b833740b2 Allow NOT_SUPPORTED for setLinkCapacityReportingCriteria on GERAN.
Test: run vts -m VtsHalRadioV1_2Target
Bug: 110716988
Change-Id: I9a5f014d498db00d818870cbd73e119f66562ef1
(cherry picked from commit c7896501db)
2018-07-16 12:29:47 -07:00
sqian
abf6bdfa55 Fix missed refactor of serial
am: 0c3572e2f3

Change-Id: I308c5279fd50402efe6a2c06feaaf034cea4541d
2018-06-27 18:31:08 -07:00
sqian
0c3572e2f3 Fix missed refactor of serial
Bug: 109822806
Test: run vts
Change-Id: If88384699dbb4c2ddd1c580d2b35be38afd0f8e8
Merged-In: If88384699dbb4c2ddd1c580d2b35be38afd0f8e8
(cherry picked from commit c0e2e2b071)
2018-06-27 15:26:38 -07:00
Jack Yu
e79895b34f Fixed VTS failure in no SIM case
am: ac4e6051f9

Change-Id: I96717b5640c85223c5226e4b911e07d504623429
2018-06-27 13:14:54 -07:00
Jack Yu
ac4e6051f9 Fixed VTS failure in no SIM case
Added RadioError::NONE as a possible return value for data call
setup API. The data call could be setup for emergency purposes
when no SIM inserted.

Test: VTS
Bug: 109767888
Merged-In: I4469c371f999b99d35f4078df000f05ee1f3c84d
Change-Id: I4469c371f999b99d35f4078df000f05ee1f3c84d
(cherry picked from commit 431eb118f8)
2018-06-27 18:10:08 +00:00
Nathan Harold
a6b0fe7fdd Merge "Add docs for setSignalStrengthReportingCriteria" into stage-aosp-master 2018-06-27 17:13:05 +00:00
Nathan Harold
563a057bd2 Add docs for setSignalStrengthReportingCriteria
Because setSignalStrengthReportingCriteria only
supports a single measurement quantity, provide
further clarification on the applicability of the
API and how it may be used in various situations.

Bug: 110121199
Test: compilation - docstring-only change
Change-Id: If4236070fbc03368e5a78b0cf502cdc4a529a6ed
2018-06-27 01:22:20 +00:00
Eric Schwarzenbach
a13b29017c Call notify for voiceReg and dataReg VTS tests
am: 9589ee1c36

Change-Id: Ie20c0329cd19da7ca2f86c7769ba6f7d3a3ca32b
2018-06-26 10:50:35 -07:00
Eric Schwarzenbach
9589ee1c36 Call notify for voiceReg and dataReg VTS tests
Bug: 80554443
Test: vts
Change-Id: I19f7131f7b65323065f3c283a89668ff761815e3
Merged-In: I19f7131f7b65323065f3c283a89668ff761815e3
(cherry picked from commit 2bb626a297)
2018-06-26 10:39:37 -07:00
sqian
fc203c1bc3 Merge "Add setIndicationFilter response notification in 1.2 VTS"
am: a086c5c3a9

Change-Id: I4b869026a0dad435a5ffdc752a1be0ad4ce87dfc
2018-06-25 15:50:52 -07:00
Treehugger Robot
a086c5c3a9 Merge "Add setIndicationFilter response notification in 1.2 VTS" 2018-06-25 22:46:51 +00:00
Amit Mahajan
c847ec0021 Allow REQUEST_NOT_SUPPORTED as an error for startNetworkScan
am: 6a5c36d73f

Change-Id: I6c5daa8b8cd440951e33f094a605a1073b3f64de
2018-06-25 14:17:24 -07:00
sqian
99260ce747 Add setIndicationFilter response notification in 1.2 VTS
Test: run vts
Bug: 109822806
Change-Id: I95102a148a26cab80235cc68ad83143a9bb6eb39
Merged-In: I95102a148a26cab80235cc68ad83143a9bb6eb39
(cherry picked from commit 0ff41b94b3)
2018-06-25 13:08:11 -07:00
Amit Mahajan
6a5c36d73f Allow REQUEST_NOT_SUPPORTED as an error for startNetworkScan
We are trying to tighten the APIs. However for this case since the
documentation was not updated, we are allowing NOT_SUPPORTED for
now and will be cleaned up in a later release.

Test: run vts -m VtsHalRadioV1_2Target
Bug: 110118713
Change-Id: Id9dd3d7bac99bed36ceb9c906189f1fea78d5a2c
(cherry picked from commit a7587b5a7f)
2018-06-25 11:39:04 -07:00
sqian
43f2c3e588 Add REQUEST_NOT_SUPPORTED for changeIccPinForApp and changeIccPin2ForApp
am: 617c98b537

Change-Id: I97e2ac6534ae7354fc66a5bcd6f1833fe0b20498
2018-06-22 19:43:22 -07:00
sqian
617c98b537 Add REQUEST_NOT_SUPPORTED for changeIccPinForApp and changeIccPin2ForApp
Bug: 110037298
Test: run vts -m VtsHalRadioV1_0Target
Change-Id: Iaba800814c5a6950d086a2f105714d01fdaa14a4
Merged-In: Iaba800814c5a6950d086a2f105714d01fdaa14a4
(cherry picked from commit 7470cbd04d)
2018-06-22 16:32:07 -07:00
Amit Mahajan
47de621776 Allow general errors for getImsiForApp().
am: 2c36d90716

Change-Id: Id8832fa06f2e1b67210deeea06890a88b3bc45e2
2018-06-14 13:06:28 -07:00
Amit Mahajan
2c36d90716 Allow general errors for getImsiForApp().
This is to match it with other 1.0 tests where general errors are
allowed. For newer tests we have decided to not allow these errors,
but a failure for this old test is reported when run with SIM
present.

Test: run vts -m VtsHalRadioV1_0Target
Bug: 109889468
Change-Id: If36083b7832706a50805932e8ba08e4eb397f3fe
2018-06-14 17:18:38 +00:00
Steven Moreland
913c071391 Update comments for doc comments.
Doc comments look like "/** ... */" and they
can only be in certain places.

Bug: 79865343
Test: m
Change-Id: Ic15c08ff7dc6e4f9827c1dbe7f7236c11a572ec1
Merged-In: Ic15c08ff7dc6e4f9827c1dbe7f7236c11a572ec1
2018-05-21 14:36:29 -07:00
Steven Moreland
4ee4582230 Update comments for doc comments.
Doc comments look like "/** ... */" and they
can only be in certain places.

Bug: 79865343
Test: m
Change-Id: Ic15c08ff7dc6e4f9827c1dbe7f7236c11a572ec1
2018-05-18 10:10:32 -07:00
sqian
2a60b89b9c Sim Status Present VTS
Fix and enhance sim-present tests,
Save VTS running time,
Fix serial number inconsistancy issue

Fix and enhance sim-present tests:
In 1.0:
- setupDataCall timeout, need more waiting time
- requestIccSimAuthentication returns REQUEST_NOT_SUPPORTED,
need to check it
- sendSms timeout, would need more waiting time
- sendSMSExpectMore timeout, would need more waiting time
- getAllowedCarriers, getting CardState::RESTRICTED, the previous test
of setAllowedCarriers is doing resetting back to no carrier restriction,
but that needs some time to populate.
In 1.1:
- setSimCardPower_1_1 set sim card power down that makes other tests
fail, reset it back with sim card power on.

Save VTS running time,
- Use waiting loop and prevent unnecessary waiting to save the whole
running time.

Fix serial number inconsistancy issue
- During the enforcement running, it is liked the serial number is
not consistent. And it happens in b/78249227. Suspect that when sim
card is inserted, during the testing running time, the radio may
request some response that is not triggered from the test, but the
test may receive it and think it is what is triggered by the test. The
fix is to check serial number before notifying of unlock the test
lock.

Bug: 76125134
Bug: 78248071
Bug: 78139665
Bug: 78249227
Test: run vts -m VtsHalRadioV1_0Target; run vts -m VtsHalRadioV1_1Target
Change-Id: I08fe9d7ac16283c7ce1a5aeb6b3b372786a8d5c3
Merged-In: I08fe9d7ac16283c7ce1a5aeb6b3b372786a8d5c3
(cherry picked from commit 788eb80830)
2018-04-20 14:54:12 -07:00
sqian
788eb80830 Sim Status Present VTS
Fix and enhance sim-present tests,
Save VTS running time,
Fix serial number inconsistancy issue

Fix and enhance sim-present tests:
In 1.0:
- setupDataCall timeout, need more waiting time
- requestIccSimAuthentication returns REQUEST_NOT_SUPPORTED,
need to check it
- sendSms timeout, would need more waiting time
- sendSMSExpectMore timeout, would need more waiting time
- getAllowedCarriers, getting CardState::RESTRICTED, the previous test
of setAllowedCarriers is doing resetting back to no carrier restriction,
but that needs some time to populate.
In 1.1:
- setSimCardPower_1_1 set sim card power down that makes other tests
fail, reset it back with sim card power on.

Save VTS running time,
- Use waiting loop and prevent unnecessary waiting to save the whole
running time.

Fix serial number inconsistancy issue
- During the enforcement running, it is liked the serial number is
not consistent. And it happens in b/78249227. Suspect that when sim
card is inserted, during the testing running time, the radio may
request some response that is not triggered from the test, but the
test may receive it and think it is what is triggered by the test. The
fix is to check serial number before notifying of unlock the test
lock.

Bug: 76125134
Bug: 78248071
Bug: 78139665
Bug: 78249227
Test: run vts -m VtsHalRadioV1_0Target; run vts -m VtsHalRadioV1_1Target
Change-Id: I08fe9d7ac16283c7ce1a5aeb6b3b372786a8d5c3
2018-04-20 00:21:14 +00:00
sqian
031a6a87c9 Radio Sap 1.2 default implementation
Checked points:
- service is on
- vts can run on it
- provided a dummy implementation that a VTS test can pass it
- applied with recent update in radio 1.2 hal
- format repaired
- pass on a 1.0 VTS test, a 1.1 VTS test, and a 1.2 VTS test

Bug: 74114758
Test: run vts

Change-Id: I8a052e3cedb41db9028552ab88f1e26492718497
Merged-In: I8a052e3cedb41db9028552ab88f1e26492718497
(cherry picked from commit 0de4d31569)
2018-04-16 12:01:50 -07:00
Shuo Qian
f06ac68796 Merge "Radio Sap 1.2 default implementation" into pi-dev 2018-04-16 18:44:39 +00:00
sqian
7f3b78408c Fix Radio response/indication 1.2
Radio VTS client 1.2 radio response cannot be cast from radio response
in the service. To fix it, the client radio response and indication
should extend 1.2 IRadioResponse and IRadioIndication

Bug: 77815815
Test: ran it on the default service
Change-Id: Ib014af98d52d9f208d2139f4a239e9d61ea4d569
Merged-In: Ib014af98d52d9f208d2139f4a239e9d61ea4d569
(cherry picked from commit 79bafb943b)
2018-04-12 18:15:36 -07:00
Nathan Harold
8e7fc9f4f5 Add a Test for RadioBandMode to Ensure Auto Mode
The radio band mode is perilous because depending
on the setting and the detected locale, other
settings may be disabled. That can leave the modem
in a soft-brick state. Thus, BandMode = 0 = AUTOMATIC
should always be supported so that the modem can
update and select a band mode of its choosing.

Bug: 28124606
Test: vts radio - getAvailableBandModes
Change-Id: I1f25d9125ef06d290e3a89b5d2162c6bfe939eba
2018-04-11 17:16:24 -07:00
sqian
0de4d31569 Radio Sap 1.2 default implementation
Checked points:
- service is on
- vts can run on it
- provided a dummy implementation that a VTS test can pass it
- applied with recent update in radio 1.2 hal
- format repaired
- pass on a 1.0 VTS test, a 1.1 VTS test, and a 1.2 VTS test

Bug: 74114758
Test: run vts

Change-Id: I8a052e3cedb41db9028552ab88f1e26492718497
2018-04-11 21:33:02 +00:00
Nathan Harold
d07b5895e0 Add a Test for RadioBandMode to Ensure Auto Mode
The radio band mode is perilous because depending
on the setting and the detected locale, other
settings may be disabled. That can leave the modem
in a soft-brick state. Thus, BandMode = 0 = AUTOMATIC
should always be supported so that the modem can
update and select a band mode of its choosing.

Bug: 28124606
Test: vts radio - getAvailableBandModes
Merged-In: I1f25d9125ef06d290e3a89b5d2162c6bfe939eba
Change-Id: I1f25d9125ef06d290e3a89b5d2162c6bfe939eba
(cherry picked from commit c9e391801ba5ccd24b41481b26c2861b71ef03d0)
2018-04-11 13:00:05 -07:00
sqian
79bafb943b Fix Radio response/indication 1.2
Radio VTS client 1.2 radio response cannot be cast from radio response
in the service. To fix it, the client radio response and indication 
should extend 1.2 IRadioResponse and IRadioIndication

Bug: 77815815
Test: ran it on the default service
Change-Id: Ib014af98d52d9f208d2139f4a239e9d61ea4d569
2018-04-11 19:15:17 +00:00
Eric Schwarzenbach
b004dbc19f Update RegState for new CellIdentity types
Bug: 74826109
Test: make, make vts
Change-Id: I6350e5da5bc064e665e54d161ee589c3eadf901a
Merged-In: I6350e5da5bc064e665e54d161ee589c3eadf901a
(cherry picked from commit 74befb69b9)
2018-03-30 15:57:24 -07:00
Eric Schwarzenbach
74befb69b9 Update RegState for new CellIdentity types
Bug: 74826109
Test: make, make vts
Change-Id: I6350e5da5bc064e665e54d161ee589c3eadf901a
2018-03-29 12:37:42 -07:00
Nathan Harold
c2b7f42d7d Merge "Fix Copy+Paste Errors in TdscdmaSignalStrength" into pi-dev 2018-03-06 17:59:10 +00:00
Nathan Harold
6df3d8eb63 Fix Copy+Paste Errors in TdscdmaSignalStrength
When copying over from WcdmaSignalStrength, the
ranges and references were wrong. Sadly they
were carried over. Fixing before this gets
out of hand.

Bug: 18628145
Test: compilation - documentation-only change
Change-Id: I08a247674cf42ebeed26c721ff99a71db4152bbf
2018-03-05 14:48:20 -08:00
Jordan Liu
6f8e4d5593 Fix wcdma signal strength comments
As per the spec, the range should be 0-31, 99, and the section
should be 8.5.

Test: builds - No change to behavior
Bug: 71329173
Change-Id: Ib1ea54b19a7bcb33a0235b3ddb3fa09c4872890f
2018-03-05 20:30:18 +00:00
Cassie
72f409ce49 Merge "Add VTS test for getCellInfoList_1_2" am: 6a83645f64 am: a56b4090f8
am: af1fd9d4d7

Change-Id: I753d13a4505c661071ae88aea0e6450d69a71aea
2018-03-02 08:03:27 +00:00
Cassie
af1fd9d4d7 Merge "Add VTS test for getCellInfoList_1_2" am: 6a83645f64
am: a56b4090f8

Change-Id: Ic6841e7d46b02c271e56db91cf9be6a4bc0c69fe
2018-03-02 07:57:26 +00:00
Treehugger Robot
6a83645f64 Merge "Add VTS test for getCellInfoList_1_2" 2018-03-02 07:42:33 +00:00
yinxu
69177feacf Add vts response functions for Radio Response 1.2 am: 2e6ed18055 am: 1ef5301ca3
am: 8e14e19ef5

Change-Id: I3f9ca84d3db0399e319f8ff36aac12aee0eb1cde
2018-03-02 01:38:07 +00:00
yinxu
8e14e19ef5 Add vts response functions for Radio Response 1.2 am: 2e6ed18055
am: 1ef5301ca3

Change-Id: Iae1bf6feb0bd092cdce9b0e2a39aeecb5720a60e
2018-03-02 01:33:03 +00:00
Cassie
65a3ad31b8 Add VTS test for getCellInfoList_1_2
Bug: 63984327
Test: VTS test
Change-Id: Ie6987f885dfe34c94b30370e1d4853084ee4030b
2018-03-01 15:49:51 -08:00
yinxu
2e6ed18055 Add vts response functions for Radio Response 1.2
Bug: 67750232
Test: Compile and Run VTS
Change-Id: I866cea94b1505b05dee336a53ab72ab685c8f441
2018-03-01 14:15:32 -08:00
Jack Yu
668583d529 Added new VTS test cases for v1.2 data call APIs am: ac1844fac4 am: 67e9c401ec
am: 20d65fe38f

Change-Id: Ic4e1a3aa90769ab3568706f303a12acf5b6f6298
2018-03-01 07:13:53 +00:00
Jack Yu
20d65fe38f Added new VTS test cases for v1.2 data call APIs am: ac1844fac4
am: 67e9c401ec

Change-Id: If3627351c92fcf781c2f7c3b87255197e980d824
2018-03-01 07:08:16 +00:00
Jack Yu
ac1844fac4 Added new VTS test cases for v1.2 data call APIs
Test: VtsHalRadioV1_2Target
Bug: 64132030
Change-Id: I3b9d94985f42a5dd9b9a24e0592cf1657da237d5
2018-03-01 04:31:11 +00:00
Eric Schwarzenbach
10a76aa6ea Add VTS tests for 1.2 reporting criteria am: 8bdc4e04e2 am: 1c9406eb01
am: 35882a28ed

Change-Id: I1c92998d3356446598877f9b1858183f6997ad2c
2018-02-28 18:53:45 +00:00
Eric Schwarzenbach
35882a28ed Add VTS tests for 1.2 reporting criteria am: 8bdc4e04e2
am: 1c9406eb01

Change-Id: I08e4ca8ab25e41e6600f14c8ca04b4cfcb772693
2018-02-28 18:41:01 +00:00
Eric Schwarzenbach
8bdc4e04e2 Add VTS tests for 1.2 reporting criteria
Bug: 72115876
Test: make
Change-Id: I7a7633994888d2f1781ac7d5730727112eb0c86d
2018-02-27 17:29:40 -08:00