Commit graph

1292 commits

Author SHA1 Message Date
Alec Mouri
78d76ea43f Check the correct sysprop for P010 support for gralloc 3 and 4.
We need to check the first api level that the vendor shipped with.

Also check P010 support in the preamble of the relevant test rather than in allocate(), since otherwise either allocate() may incorrectly skip some tests or allocate() may succeed but with the wrong layout information.

Bug: 257442231
Test: VtsHalGraphicsMapperV4_0TargetTest
Change-Id: I00ae5aa01117704158c38f0689e91df99473e208
2023-02-15 02:37:49 +00:00
Ram Indani
f08f437e51 Merge changes from topic "hwc-rri"
* changes:
  [HWC3] VTS client updates for onRefreshRateChangedDebug callback And for setRefreshRateChangedCallbackDebugEnabled
  [HWC3] AIDL implementation for Refresh Rate Overlay indicator
2023-02-13 23:00:03 +00:00
ramindani
8345034b53 [HWC3] VTS client updates for onRefreshRateChangedDebug callback
And for setRefreshRateChangedCallbackDebugEnabled

This does not add any implementation for the VTS code.
Implementation will be added with the VTS tests as a followup.

Test: Device boots
BUG: 202734676
Change-Id: If47bbcf87698b346907b3bc1903908ff0a63203f
2023-02-10 14:27:09 -08:00
ramindani
ff0da0bb24 [HWC3] AIDL implementation for Refresh Rate Overlay indicator
Adds IComposerClient method to inform that the Refresh Rate callback is enabled.
Adds IComposerCallback to get the display vsyncPeriod for the Overlay.
Adds Composition type REFRESH_RATE_INDICATOR

Test: Device boots
BUG: 202734676
Change-Id: I48b0c05f49095b15cea444dc5c3ad8f78a043cb0
2023-02-10 09:25:47 -08:00
Sally Qi
2b4ceb6365 Add exception annotation to getOverlaySupport api.
Bug: 268246323
Test: builds
Change-Id: I1979fed444a9fd3d94af729112fff070beb01439
2023-02-08 12:59:54 -08:00
Yi Kong
0214404f6e Fix compiler warning discovered by clang-r484482 am: 07448c2929 am: ba993e51e8 am: 661d9018c7
Original change: https://android-review.googlesource.com/c/platform/hardware/interfaces/+/2402792

Change-Id: I195de8f952c0b9091e4e57d64535e4e2014f3fb5
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-01-25 20:10:23 +00:00
Yi Kong
07448c2929 Fix compiler warning discovered by clang-r484482
external/googletest/googletest/include/gtest/gtest.h:1545:11: error: invalid operands to binary expression ('const std::vector<unsigned char>' and 'const android::hardware::hidl_vec<unsigned char>') [clang-diagnostic-error]
  if (lhs == rhs) {
      ~~~ ^  ~~~

Test: presubmit
Change-Id: Iabe98a58d5dc5b9943c38240da2d8df6ac61fb7f
2023-01-26 01:23:03 +09:00
Sally Qi
a0545e3057 Merge "[Aidl graphics API] split dataspace array into tuples." 2023-01-24 16:34:02 +00:00
Devika Krishnadas
e794f8f5e4 Merge "gralloc4-vts: Remove assert for sizeInBits for RAW formats" 2023-01-20 20:57:09 +00:00
Treehugger Robot
7603d62a20 Merge "Drop <name>I</name> from mapper HAL." am: d2bbda8b32 am: 116ddaf033 am: 81f4ddd0c5
Original change: https://android-review.googlesource.com/c/platform/hardware/interfaces/+/2392038

Change-Id: Ieb1ffe7a2a24c93b6696acd9d9c178475b826aef
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-01-20 18:54:25 +00:00
Treehugger Robot
d2bbda8b32 Merge "Drop <name>I</name> from mapper HAL." 2023-01-20 17:10:47 +00:00
Sally Qi
c2c392fbea [Aidl graphics API] split dataspace array into tuples.
- update VTS test to make sure primaries/transfers/ranges bits are
  correct.

Bug: 242588489
Test: build and flash; atest VtsHalGraphicsComposer3_TargetTest

Change-Id: I77536d97b98e4dead208b7c8aeed9cfbb0d82316
2023-01-19 15:50:17 -08:00
Brian Lindahl
348bc9d779 Merge changes from topic "revert-uncache-hal-buffers-vts"
* changes:
  Revert "Add VTS test for clearing buffer slots to Composer HIDL and AIDL"
  Revert "Add VTS readback tests for buffer slot clearing"
  Revert "Add VTS for new API for clearing buffer slots"
2023-01-19 20:53:54 +00:00
Brian Lindahl
14bd07b195 Revert "Add VTS test for clearing buffer slots to Composer HIDL and AIDL"
This reverts commit ca3eef29b0.

NOTE: This is not a full revert, it leaves the production code in place and only reverts the VTS test changes.

Reason for revert: b/262370410

Test: atest VtsHalGraphicsComposerV2_1TargetTest on Oriole
Test: atest VtsHalGraphicsComposerV2_2TargetTest on Oriole
Test: atest VtsHalGraphicsComposerV2_3TargetTest on Oriole
Test: atest VtsHalGraphicsComposerV2_4TargetTest on Oriole
Bug: 262370410
Change-Id: Ie5ba7402cda2828ba33131d527ab0c3a66937648
2023-01-18 21:18:55 +00:00
Brian Lindahl
e887a25203 Revert "Add VTS readback tests for buffer slot clearing"
This reverts commit d103cd6828.

NOTE: This is not a full revert, it leaves the production code in place and only reverts the VTS test changes.

Reason for revert: b/262370410

Test: atest VtsHalGraphicsComposerV2_1TargetTest on Oriole
Test: atest VtsHalGraphicsComposerV2_2TargetTest on Oriole
Test: atest VtsHalGraphicsComposerV2_3TargetTest on Oriole
Test: atest VtsHalGraphicsComposerV2_4TargetTest on Oriole
Bug: 262370410
Change-Id: I336beb9f0ed81b305b26c6d8e9da70cfabe04bbd
2023-01-18 21:18:21 +00:00
Brian Lindahl
952057044b Revert "Add VTS for new API for clearing buffer slots"
This reverts commit 78ff2d6491.

NOTE: This is not a full revert, it leaves the production code in place and only reverts the VTS test changes.

Reason for revert: b/262370410

Test: atest VtsHalGraphicsComposerV2_1TargetTest on Oriole
Test: atest VtsHalGraphicsComposerV2_2TargetTest on Oriole
Test: atest VtsHalGraphicsComposerV2_3TargetTest on Oriole
Test: atest VtsHalGraphicsComposerV2_4TargetTest on Oriole
Bug: 262370410
Change-Id: Ica725cfaae6e2a08ed9c53eb9f17d6db1656bc93
2023-01-18 21:16:20 +00:00
Carlos Martinez Romero
7a6d907b99 Merge "Deprecate SKIP_VALIDATE." 2023-01-18 19:04:38 +00:00
Yifan Hong
ccb250d550 Drop <name>I</name> from mapper HAL.
libvintf now supports empty interface names for native HALs.

Test: TH
Bug: 264267049
Change-Id: Ie525478631e785ce8b9d813d08b0a92331047ced
2023-01-17 15:23:32 -08:00
Kriti Dang
5422df8f30 Merge "ComposerHAL APIs for HDR output control" 2023-01-17 17:37:35 +00:00
Sally Qi
c0f28978fa Merge "Remove length check to allow empty HDR10+ blobs to HWC" am: 2b42a74573 am: a7f01798f5 am: a0442dda02
Original change: https://android-review.googlesource.com/c/platform/hardware/interfaces/+/2374997

Change-Id: I7907436ae2e0460db31ec033e603442bc1120ab2
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-01-13 22:07:13 +00:00
Sally Qi
2b42a74573 Merge "Remove length check to allow empty HDR10+ blobs to HWC" 2023-01-13 18:24:15 +00:00
Kriti Dang
3793ebdaea ComposerHAL APIs for HDR output control
Bug: 251168514
Test: atest VtsHalGraphicsComposer3_TargetTest
Change-Id: Icf5437c6dab2c8ce9247617f6e6006051fc206fb
2023-01-13 17:58:30 +01:00
Devika Krishnadas
7f3f32177b gralloc4-vts: Remove assert for sizeInBits for RAW formats
sizeInBits for components in RAW formats do not have to be invalid even if the bits are not contiguous.

Bug: 265348037
Test: atest VtsHalGraphicsMapperV4_0TargetTest

Change-Id: I69f58226e988c20b8ba5499ffec4fa0e2b2a68df
Signed-off-by: Devika Krishnadas <kdevika@google.com>
2023-01-13 00:28:04 +00:00
Treehugger Robot
ad6f10ae9f Merge "Clarify format BLOB locking" am: 66cf51232c am: c764d58ed8 am: 36c65361a0
Original change: https://android-review.googlesource.com/c/platform/hardware/interfaces/+/2381019

Change-Id: I475aa5d0f415480aa1d9d8c599c55c4c8c0dceaf
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-01-12 07:32:53 +00:00
Carlos Martinez Romero
cd04361bb3 Deprecate SKIP_VALIDATE.
Bug: 258549211
Test: Built it and flashed it + added a test.
Change-Id: I7a0dbea4dc0e6687f65d2136a8d21867d7232626
2023-01-11 23:49:21 +00:00
John Reck
5f86e5de89 Merge "Clarify deprecation message" am: fb373b0613 am: 394cdfbbac am: d62f8aa809
Original change: https://android-review.googlesource.com/c/platform/hardware/interfaces/+/2381012

Change-Id: I6dca82a54dbb55b2c8f80fd4b11efcc89c11fe36
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-01-11 01:01:41 +00:00
Sally Qi
1ae586175d Merge "[Graphics AIDL interface] add supportMixedColorSpaces boolean variable." 2023-01-10 21:32:01 +00:00
Sally Qi
2060a4e647 Remove length check to allow empty HDR10+ blobs to HWC
Bug: 212496177
Test: builds
Change-Id: Iad121cd6515e826c4b57976b14e7a5eb947b1728
2023-01-10 11:11:54 -08:00
John Reck
0c1a059f01 Clarify format BLOB locking
Bug: 162571907
Test: n/a doc only change
Change-Id: I3ab26cee8a790067447781e13062c62fc3b7c01c
2023-01-10 11:25:56 -05:00
John Reck
a190be3f86 Clarify deprecation message
Note that it's still used if mapper@4 is still used

Test: n/a doc only change
Change-Id: I21d3070684592f2931842acb43466ae4236856e6
2023-01-10 10:56:00 -05:00
John Reck
741ffc2fd8 Merge "Add a README and a standardizable VERSION" am: a74147236c am: 313e0cec86 am: f42300352e
Original change: https://android-review.googlesource.com/c/platform/hardware/interfaces/+/2375176

Change-Id: I68e182beadfeaa8cb932a8fab501812cca694294
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-01-09 20:36:39 +00:00
John Reck
a74147236c Merge "Add a README and a standardizable VERSION" 2023-01-09 18:38:26 +00:00
Treehugger Robot
9cd21bb582 Merge "Add ExtendableType to allocate" am: 0a9430add2 am: efa98b101f am: 926b4d8b2d
Original change: https://android-review.googlesource.com/c/platform/hardware/interfaces/+/2364519

Change-Id: I21a7c5c74a94f434d9f1237f742cb3f261b4f0be
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-01-09 09:37:10 +00:00
Treehugger Robot
0a9430add2 Merge "Add ExtendableType to allocate" 2023-01-09 08:05:54 +00:00
Treehugger Robot
bca716810c Merge "composer: vts: Init display dimension using active config" am: 12c9d664aa am: 177e0aeaaa am: df623aa638
Original change: https://android-review.googlesource.com/c/platform/hardware/interfaces/+/2302957

Change-Id: Ib27af495e361717e6c4466e8568d803110e6e0f8
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-01-09 06:29:20 +00:00
Treehugger Robot
12c9d664aa Merge "composer: vts: Init display dimension using active config" 2023-01-09 04:51:54 +00:00
John Reck
0124abc1e9 Add a README and a standardizable VERSION
* Changes the compatbility matrix version to 5.0 & marks optional
* Tweaks the interface name in case it doesn't get removed soon
  (otherwise readme looks silly)
* Adds a README.md to mapper/stable-c
* Adds VTS test to validate versions match

Test: build + mapper VTS

Change-Id: I9b1256e07aaf2876d579a5487d2051c60097fb70
2023-01-06 17:40:16 -05:00
John Reck
2b3eccb904 Merge "Add stride query" am: 0797e36036 am: 04d190b3c8 am: 2e7c541ebe
Original change: https://android-review.googlesource.com/c/platform/hardware/interfaces/+/2360899

Change-Id: I58bfee442be24701d7ae2e98cacb4e34b1b1b219
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-01-06 20:57:54 +00:00
John Reck
cf8d8bc769 Add ExtendableType to allocate
Allows for passing arbitrary additional options to IAllocator
Can be used to control things such as compression level without
exhausting usage bits

Currently there are no standard options defined so this only allows
for vendor-internal extensions currently.

Fixes: 257075040
Test: VtsHalGraphicsAllocatorAidl_TargetTest
Change-Id: I37b730f5ba141b08d458866c6d03a39b27124e02
2023-01-06 15:43:27 -05:00
John Reck
0797e36036 Merge "Add stride query" 2023-01-06 19:38:30 +00:00
John Reck
eeedffd5cc Merge "Add libui requirements" 2023-01-05 17:25:17 +00:00
HyunKyoung
4775bdce26 composer: vts: Init display dimension using active config
Dimension was initialized to the size of the last config that is in the config list.
VTS didn't change the dimension in the readback test and allocated buffer
for the readback with the dimension size.
However it was different with actual display size.
This change initializes display dimension to the actual display size.

Bug: 259155172
Change-Id: I64fec02f5386eb6ca1f41ab376be193231810b93
Signed-off-by: HyunKyoung <hk310.kim@samsung.com>
2023-01-05 10:17:34 +09:00
John Reck
2c2cfc9341 Add stride query
Fixes: 261856851
Test: VtsHalGraphicsMapperStableC_TargetTest

Change-Id: Ib49df2d46dd55848c4854179bd6205c86c232a6d
2023-01-04 16:41:26 -05:00
Trevor Black
b0170e08de Merge "The aidl changes necessary to add requested AHB format enums" am: 3e01679bb5 am: a8fbf496f8 am: af57555cbf
Original change: https://android-review.googlesource.com/c/platform/hardware/interfaces/+/2328513

Change-Id: I6ef9729b24defe2acad14c332455d8542a325eb5
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-12-21 01:32:07 +00:00
Trevor Black
3e01679bb5 Merge "The aidl changes necessary to add requested AHB format enums" 2022-12-21 00:24:27 +00:00
Sally Qi
7aaacf6068 [Graphics AIDL interface] add supportMixedColorSpaces boolean variable.
- To determine if the device can hendle mixed colorspaces without
  falling back to client composition.

Bug: 242588489
Test: build and flash
Change-Id: Ied346e1fe9c0b260c37aee458eddac689e711336
2022-12-19 23:22:31 -08:00
Brian Lindahl
78ff2d6491 Add VTS for new API for clearing buffer slots
Bug: 262041682
Bug: 258196272
Test: VtsHalGraphicsComposer3_TargetTest
Change-Id: If7e5fea56734f3ae7b4aae7378f4aea0eacc8e32
2022-12-19 16:52:33 -07:00
Brian Lindahl
24de83be34 Add to AIDL field to LayerCommand to clear buffer slots
Bug: 262041682
Bug: 258196272
Test: presubmit
Change-Id: Ib1819ccc2b53036b8d47cfd4d3d87d6ec07af7c5
2022-12-19 15:02:05 -07:00
Emilian Peev
3aea54393c graphics/common: Add Jpeg/R dataspace
Bug: 241284696
Test: atest -c -d
cts/tests/camera/src/android/hardware/camera2/cts/ImageReaderTest.java#testJpegR

Change-Id: I218b9abe048ac07b3e54edad06b452301df48726
2022-12-16 11:09:17 -08:00
Trevor David Black
060a59992d The aidl changes necessary to add requested AHB format enums
PIXEL_FORMAT_R_16_UINT
- AHARDWAREBUFFER_FORMAT_R16_UINT
PIXEL_FORMAT_RG_1616_UINT
- AHARDWAREBUFFER_FORMAT_R16G16_UINT
PIXEL_FORMAT_RGBA_10101010
- AHARDWAREBUFFER_FORMAT_R10G10B10A10_UNORM

Bug: 233033456
Test: Build
Change-Id: I7b9829f549dd6d931531f14fef458d1fecc82ac9
2022-12-15 19:18:11 +00:00