Commit graph

267 commits

Author SHA1 Message Date
Jooyung Han
580e81b0be Add virtual fingerprint HAL APEX
This moves the virtual fingerprint HAL into a vendor apex:
  com.android.hardware.biometrics.fingerprint.virtual.

Bug: 279674662
Test: follow README.md to test the virtual FP HAL
(cherry picked from https://googleplex-android-review.googlesource.com/q/commit:7af7ad0c8770e13c3b77abe81c2ba48a2927b531)
Merged-In: I4664a3805b9444c87b0ac31a84ec10fb47d9580e
Change-Id: I4664a3805b9444c87b0ac31a84ec10fb47d9580e
2023-06-02 03:46:25 +00:00
Jeff Pu
87e9f2bebe Close the session if Fingerprint servers die
by registering the death notification of the associated binder.
Bug: 273807765
Test: adb shell stop;adb shell start

Change-Id: Ifc60e68fdbf986a355f828a7fc11f2aecee4cbea
2023-05-05 14:14:57 +00:00
Alex Buynytskyy
ec1198d941 UpsideDownCake is now 34
Ignore-AOSP-First: UpsideDownCake Finalization
Bug: 275409981
Test: build
Change-Id: I832ab7a8b5445ba85e27bbcf5be64906bfa0e5be
2023-04-07 23:41:20 +00:00
Diya Bera
34dc8bfe51 Adding POWER_PRESS to AcquiredInfo.aidl and Error.aidl
Test: N/A
Bug: 269293986
Change-Id: If2e2a1c0f48d86c427a0c8f93f077c940c3eb8d8
2023-02-21 22:44:33 +00:00
Austin Delgado
88ded642f2 Update fingerprint AIDL for Android U
1. Adds sensor shape and touch detection configuration.
2. Adds onPointerCancelWithContext and setIgnoreDisplayTouches.
3. Adds LIFT_TOO_SOON constant to AcquiredInfo.
4. Deprecates SensorLocation displayId, onPointerDown, and onPointerUp.

Bug: 266476972
Test: m android.hardware.biometrics.fingerprint-update-api
Test: built locally
Change-Id: I3aae3c7f8a65d5805f3dd583330407c255ca1369
2023-02-17 21:30:26 +00:00
Jeff Pu
ebb2b746ce Make virtual fingerprint HAL as lazy HAL
Bug: 262630839
Test: atest VtsHalBiometricsFingerprintTargetTest
Change-Id: I8f17f00d3e91554fcfb99c8b478ed8b6131b4530
2023-02-13 18:00:25 +00:00
Jeffrey Vander Stoep
c5d5b7d4ea Revert "Make virtual fingerprint Hal as a lazy Hal"
This reverts commit 93e97f94b6.

Reason for revert: b/263519851

Change-Id: I24a9921c806013c5a50bb0674690b67beca172f0
2022-12-23 11:28:28 +00:00
Jeff Pu
93e97f94b6 Make virtual fingerprint Hal as a lazy Hal
so that the Hal service can start dynamically as needed
by vts test and others

Bug: 262630839
Test: atest VtsHalBiometricsFingerprintTargetTest:IFingerprint/Fingerprint
Change-Id: I58dfa3b49bade3bbd89c3a8f6cd884c632e9eae4
2022-12-20 21:04:54 +00:00
Jeff Pu
9c1be5a0e1 Add virtual fingerprint HAL child process based on demand
Bug: 244854670
Test: Manual
Change-Id: I403de4cc334aae8e888da064d9064ebe283bf572
2022-12-07 14:52:47 +00:00
Jeff Pu
b27153df09 Streamline OWNERS file under hardware/interfaces/biometrics
Bug: 259997419
Test: N/A
Change-Id: Ie435c70566267f9ff4a4b9474d41c5b625fc6b74
2022-11-28 14:12:28 +00:00
Ilya Matyukhin
8453178f18 Add @hide to the biometric interfaces
This change allows the framework to depend on biometric AIDL types, for
example: `android.hardware.biometrics.fingerprint.PointerContext`.

The dependency can be introduced with a `-java-source` target, for
example: `:android.hardware.biometrics.common-V3-java-source`.

The "@hide" annotation informs Metalava that these types are not a
public API (not part of the SDK).

Bug: 218388821
Test: m android.hardware.biometrics.common-update-api
Test: m android.hardware.biometrics.face-update-api
Test: m android.hardware.biometrics.fingerprint-update-api
Change-Id: Ib3327594c64dbb800b9d1744869ceb490d63e553
2022-11-18 06:37:09 +00:00
Jeff Pu
5265318938 Fingerprint virtual HAL checkin (part 3)
- support randomization
- display touch events
- lockout
- cmd and dumpsys

Bug: 230515082
Bug: 230515086
Test: atest FakeFingerprintEngineTest
      atest FakeFingerprintEngineUdfpsTest
      atest --no-bazel-mode VtsHalBiometricsFingerprintTargetTest

Change-Id: Ia5399c86b7fec90b41d426c2f82cb257f4dc9a8a
2022-11-11 13:06:32 +00:00
Jeff Pu
343ca94b13 Fingerprint virtual HAL checkin (part 2)
- acquiredInfo support for HAL operations
- error insertions
- FPS configurations

Bug: 230515082
Bug: 230515086
Test: atest FakeFingerprintEngineTest
      atest FakeFingerprintEngineUdfpsTest
      atest --no-bazel-mode VtsHalBiometricsFingerprintTargetTest

Change-Id: Iedd1056e516358c3c0a99bd4a720016cc0f880e4
2022-10-06 23:03:11 -04:00
Jeff Pu
63f33c79a2 Fingerprint virtual HAL checkin (part 1)
- udfps and side fingerprint sensor instance
- sensor location configuration
- misc. fixes/workarounds

Bug: 230515082, 230515086
Test: atest FakeFingerprintEngineTesT
      atest FakeFingerprintEngineUdfpsTest
      atest --no-bazel-mode VtsHalBiometricsFingerprintTargetTest
Change-Id: I9bec76496b35029cab4561d0d4ea85a78bec589a
2022-08-19 10:46:32 -04:00
Trevor Radcliffe
c088612eb2 Point directly to generated c sysprop_library
Supports aosp/2119952

Bug: 226199990
Test: m
Change-Id: Ifa5725abda911f2ea4d4951d41ac54fe703ae31b
2022-06-14 20:02:44 +00:00
Jeff Pu
0fe3730e7b Add team members to OWNER file
Bug: N/A
Test: N/A
Change-Id: I3e16a978624672515699eb2c99942ab7ed78a6e8
2022-05-24 23:35:18 +00:00
Joshua McCloskey
db009a58cb Add virtual Face HAL
Fixes: 230514750
Test: atest VtsHalBiometricsFaceTargetTest
Test: atest VtsHalBiometricsFingerprintTargetTest
Test: atest android.hardware.biometrics.face.FakeFaceEngineTest
Test: atest android.hardware.biometrics.face.FakeFingerprintEngineTest
Test: See README.md
Test: Verified that face and fingerprint get reset upon authenticating.

Change-Id: I57c1a61bec960e3be28736e6050be662ef412d8c
2022-05-16 19:34:12 +00:00
Joshua McCloskey
c8c0bad864 Refactored biometric libraries into common
Test: atest
Bug: 230514750
Change-Id: I47ad020004ffef9646281611a637e1a5208f5573
2022-05-13 21:18:10 +00:00
Keith Mok
85aebe3ee2 Fix fingerprint aidl race condition then thread is join
Even if the shared variable is atomic, it must be modified under the
mutex in order to correctly publish the modification to the waiting
thread.

There is a chance that mThread will miss both mIsDestructing
and notify event without a mutex.

Bug: 231737939
Test: manual
Change-Id: If83a94b766c816b9e4897acb1e89eacdce880c15
2022-05-07 01:28:57 +00:00
Joe Bolinger
938c07ce5a Merge "Declare example HAL as virtual instance." 2022-04-29 00:03:46 +00:00
Joe Bolinger
3041e526de Declare example HAL as virtual instance.
Bug: 228638448
Test: manual (see README.md)
Change-Id: I4c00b9e394eb7863416b61662528869f7e70c09d
2022-04-28 11:24:30 -07:00
Tim Murray
f6e30c4a2b Fix WorkerThreadTest am: 712f48c217 am: 310257bdc6
Original change: https://googleplex-android-review.googlesource.com/c/platform/hardware/interfaces/+/17845136

Change-Id: I033df4b08a316196259dcd5567cbe59131e88e6e
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-04-20 06:04:13 +00:00
Tim Murray
712f48c217 Fix WorkerThreadTest
Queue capacity needs to be NUM_TASKS + 1 for the extra final cv.notify
at the end.

Test: atest --host --rerun-until-failure 1000 WorkerThreadTest
Bug: b/229801892
Change-Id: I95eb07680fe80cfc3bfafaa2de81c48d61d14b4b
2022-04-20 03:33:16 +00:00
Joe Bolinger
de94aa0354 Add rear fps virtual HAL.
Bug: 228638448
Test: atest FakeFingerprintEngineTest
Test: manual (see README.md)

Change-Id: Ifecf6b5667352eb2127f820bfde47c7d325ab1b2
2022-04-12 17:13:24 -07:00
Jiyong Park
703e97920e Freeze AIDL APIs for TM
Bug: 225941299
Test: m
Change-Id: Ie41cc0797710f813f92c65c387f247c7806d8394
2022-03-31 12:01:39 +09:00
Chih-hung Hsieh
34593d4e2a Merge "Add timed out test files to tidy_timeout_srcs" am: ff54f73b4f am: fa83970b3a am: 581616e658
Original change: https://android-review.googlesource.com/c/platform/hardware/interfaces/+/1992232

Change-Id: I2eac13fe3b5ab0b4f15d6ceadf376e5e74124a81
2022-02-24 01:32:09 +00:00
Chih-Hung Hsieh
ad1bf31b78 Add timed out test files to tidy_timeout_srcs
* Timed out runs do not show any warning messages.
* These test files cannot finish clang-tidy runs with
  the following settings:
    TIDY_TIMEOUT=90
    WITH_TIDY=1
    CLANG_ANALYZER_CHECKS=1
* When TIDY_TIMEOUT is set, in Android continuous builds,
  tidy_timeout_srcs files will not be compiled by clang-tidy.
  When developers build locally without TIDY_TIMEOUT,
  tidy_timeout_srcs files will be compiled.
* Some of these test modules may be split into smaller ones,
  or disable some time consuming checks, and then
  enable clang-tidy to run within limited time.

Bug: 201099167
Test: make droid tidy-hardware-interfaces_subset
Change-Id: I1de28f1572fff368f67eab512fffec9f2e5c2a9b
2022-02-18 17:25:41 -08:00
Ilya Matyukhin
f6e0f39cde Add new fields to fingerprint PointerContext
The new fields provide additional information to the HAL about the touch
events originating from the framework.

Bug: 205915651
Test: m android.hardware.biometrics.common-update-api
Test: m android.hardware.biometrics.fingerprint-update-api
Test: lunch cf_x86_phone-userdebug && m
Change-Id: I987e26ac03e3268eea30feb9bbddffe6ca8d0035
2022-02-07 16:05:32 -08:00
Joe Bolinger
25e9823f63 Add update context method to face and fingerprint HAL.
This is needed for changes that occur mid-operation and was lost
from the previous changes when switching from the single context
method to the overloaded approach.

Bug: 204584403
Test: atest VtsHalBiometricsFingerprintTargetTest VtsHalBiometricsFaceTargetTest

Change-Id: Ie917bce9de910a421e19130b6e518bd6fc85298e
2022-01-25 01:19:56 +00:00
Joe Bolinger
13cb0fb235 Update common and fingerprint AIDL for session logging.
This also partially reverts commit 1988b3825bc95a0e7e3bb86bfa5bf70ea5323a61 which unnecessarily froze the interface during a prior interface addition.

Bug: 204585936
Bug: 204584403
Test: atest VtsHalBiometricsFingerprintTargetTest
Change-Id: Ibc9934390a487f5bfb9d3678ad65e7b1c3740ae7
2022-01-12 12:31:19 -08:00
Steven Moreland
77b74ffc0a Merge "CHECK -> CHECK_EQ copy pasta" am: a8138bfbf6 am: dd39b5c9d0 am: f711c9d406 am: 53c7517b02
Original change: https://android-review.googlesource.com/c/platform/hardware/interfaces/+/1921302

Change-Id: I3f32bf37c1c025e82e14ee6c9f0ffde87f6bcbd6
2021-12-14 18:40:32 +00:00
Steven Moreland
ffb03995e6 CHECK -> CHECK_EQ copy pasta
Hey did I start this? We can take a little bit better errors. :)

Bug: N/A
Test: N/A
Change-Id: I0e96f7f49dae9968904333da9b8269694058c11c
2021-12-14 01:45:47 +00:00
Joe Bolinger
ce02213c6a Update fingerprint AIDL with additional display id field.
This enables the HAL to use stable display ids (i.e. config_displayUniqueIdArray).

Bug: 174868353
Test: builds
Change-Id: Ib02e9d026d116df3f9acadf6c083f44b37b4169c
2021-10-25 20:48:04 +00:00
Yiming Pan
b692d61e3d Merge "Add OWNERS for VTS module VtsHalBiometricsFingerprintV2_1TargetTest" am: 9f62451015 am: 29828bc55a am: ad7f738d63 am: 8165cd5d57 am: dfe32de916
Original change: https://android-review.googlesource.com/c/platform/hardware/interfaces/+/1793837

Change-Id: Ib74eaf8e191a45e3a1dab4fcc01227231986fc7b
2021-10-01 01:30:57 +00:00
Yiming Pan
29828bc55a Merge "Add OWNERS for VTS module VtsHalBiometricsFingerprintV2_1TargetTest" am: 9f62451015
Original change: https://android-review.googlesource.com/c/platform/hardware/interfaces/+/1793837

Change-Id: I928b4b4c013f9109190538871b67dade51547fae
2021-10-01 00:36:41 +00:00
Yiming Pan
9f62451015 Merge "Add OWNERS for VTS module VtsHalBiometricsFingerprintV2_1TargetTest" 2021-10-01 00:34:46 +00:00
Treehugger Robot
9bd4c2fa54 Merge "Backfill owner information for VTS module VtsHalBiometricsFingerprintV2_2TargetTest." am: 80d2664e96 am: 1ade669804 am: b71f0a7c41 am: 232efecddc am: f6c290fc31
Original change: https://android-review.googlesource.com/c/platform/hardware/interfaces/+/1814069

Change-Id: I899b0584883d7fd44969db1ca3173df276479803
2021-09-10 18:19:45 +00:00
Treehugger Robot
1ade669804 Merge "Backfill owner information for VTS module VtsHalBiometricsFingerprintV2_2TargetTest." am: 80d2664e96
Original change: https://android-review.googlesource.com/c/platform/hardware/interfaces/+/1814069

Change-Id: I3c6bd792c8c7a85ef4f31921d997f13d7d18fc9a
2021-09-10 17:22:21 +00:00
Yiming Pan
e06fdd73c0 Backfill owner information for VTS module VtsHalBiometricsFingerprintV2_2TargetTest.
Each VTS module is required to have OWNERS file. The ownership is based on
go/vts-owners. For more information about ownership policy, please visit
go/xts-owners-policy.

Test: Tree Hugger
Bug: 143903671
Change-Id: Id9f854295ab38c07a65d87ec32251dd5c2d687cf
2021-08-30 12:58:13 -07:00
Yiming Pan
538c89c06d Add OWNERS for VTS module VtsHalBiometricsFingerprintV2_1TargetTest
Each VTS module is required to have OWNERS file. The ownership is based on
go/vts-owners. For more information about ownership policy, please visit
go/xts-owners-policy.

Test: Tree Hugger
Bug: 143903671
Change-Id: Idebf408aad47b57901336baecbc2cbfc1cd501b0
2021-08-11 16:38:22 -07:00
Jiyong Park
d55d28a1d0 Remove ndk_platform backend. Use the ndk backend.
The ndk_platform backend will soon be deprecated because the ndk backend
can serve the same purpose. This is to eliminate the confusion about
having two variants (ndk and ndk_platform) for the same ndk backend.

Bug: 161456198
Test: m
Merged-In: I0652f1efe920111d79dd8c2ecd52e55dda54538f
Change-Id: Ib58c9f1cb80d083a3c62d03415610be855b80f03
(cherry picked from commit c426c6dbdc)
2021-08-09 11:20:04 +09:00
Jiyong Park
c426c6dbdc Remove ndk_platform backend. Use the ndk backend.
The ndk_platform backend will soon be deprecated because the ndk backend
can serve the same purpose. This is to eliminate the confusion about
having two variants (ndk and ndk_platform) for the same ndk backend.

Bug: 161456198
Test: m
Change-Id: I0652f1efe920111d79dd8c2ecd52e55dda54538f
2021-08-04 12:48:07 +09:00
Ilya Matyukhin
f073d4a64c Merge "Update comments for IBiometricsFingerprint@2.3" into sc-dev am: 70b9c17191 am: 0a97ea1364
Original change: https://googleplex-android-review.googlesource.com/c/platform/hardware/interfaces/+/15364786

Change-Id: I8912831a1dae9841b3d37c582bcd5e2a2db53385
2021-07-24 03:21:01 +00:00
Ilya Matyukhin
ca3f4c0ac1 Merge "Update comments for IBiometricsFingerprint@2.3" into sc-dev am: 70b9c17191
Original change: https://googleplex-android-review.googlesource.com/c/platform/hardware/interfaces/+/15364786

Change-Id: If1aae2740b54c5539d7bced35a47bda6e5022358
2021-07-24 03:08:17 +00:00
Ilya Matyukhin
ac11a2e824 Update comments for IBiometricsFingerprint@2.3
This CL adds a comment that discourages use of this interface. The AIDL
interface, IFingerprint, should be used instead.

Bug: 160189286
Test: hidl-gen -L check android.hardware.biometrics.fingerprint@2.3::IBiometricsFingerprint
Change-Id: Ifafb191ac16e03e60d677fce6dc9e41e87bad0c0
2021-07-22 19:39:21 -07:00
Ilya Matyukhin
22e5ec680c IFingerprint: update VTS tests am: 04247248ce am: 6bf1146fb6
Original change: https://googleplex-android-review.googlesource.com/c/platform/hardware/interfaces/+/15192112

Change-Id: I3a20e045e8a1913408f854c2001643e42fd8666c
2021-07-03 02:04:25 +00:00
Ilya Matyukhin
76b8048610 IFingerprint: update VTS tests am: 04247248ce
Original change: https://googleplex-android-review.googlesource.com/c/platform/hardware/interfaces/+/15192112

Change-Id: I7b00ebb888973faf2a06af1b2e8a8f95ef626654
2021-07-03 01:49:54 +00:00
Ilya Matyukhin
af6a74151e IFingerprint: update default implementation am: 1d52438592 am: 37ff41de0b
Original change: https://googleplex-android-review.googlesource.com/c/platform/hardware/interfaces/+/15192111

Change-Id: I51f9b8f9a5edc92dfb1e260dbf92e957c8aa61f8
2021-07-03 00:26:49 +00:00
Ilya Matyukhin
f3c53e9c55 IFingerprint: update default implementation am: 1d52438592
Original change: https://googleplex-android-review.googlesource.com/c/platform/hardware/interfaces/+/15192111

Change-Id: I9072ef742649bb4258071c43f1fda7cc6d75db0d
2021-07-03 00:11:41 +00:00
Ilya Matyukhin
04247248ce IFingerprint: update VTS tests
Bug: 166799066
Test: VtsHalBiometricsFingerprintTargetTest
Change-Id: I2bf765890203a4edc016d1b7f0abd1d205b2a0ba
2021-07-02 23:58:58 +00:00