Commit graph

486 commits

Author SHA1 Message Date
Etan Cohen
c11ec2f5b0 Merge "[WIFI][TREBLE] Uprev Wi-Fi HAL 1.2" 2017-09-15 13:58:43 +00:00
Etan Cohen
59e255b599 Merge "[AWARE] Developer documentation on HAL usage" into oc-mr1-dev am: ccf6ab6e05
am: 5af3ca8853

Change-Id: If438153118c3f4521dec85a83faa94a04cbf6425
2017-09-15 09:23:10 +00:00
Etan Cohen
5af3ca8853 Merge "[AWARE] Developer documentation on HAL usage" into oc-mr1-dev
am: ccf6ab6e05

Change-Id: I6e768ad167d8e1f07ed59d9301eabdbc777e78b3
2017-09-15 02:55:04 +00:00
Etan Cohen
1b60b120de [AWARE] Developer documentation on HAL usage
Add documentation specifying which HAL APIs are used by the
framework.

Bug: 65646388
Test: N/A
Change-Id: Id1407a2d206b8eab47f5753a7cc6713b9581aeff
2017-09-14 15:19:26 -07:00
Etan Cohen
6ce5090854 [WIFI][TREBLE] Uprev Wi-Fi HAL 1.2
In preparation for new feature development - uprev the Wi-Fi Treble HAL
revision from 1.1 to 1.2.

This CL does not contain any functional changes to the HAL itself. Only
updating the revision.

Bug: 65647646
Test: builds and Wi-Fi runs
Change-Id: I8e80e866562a508bf481104a3dbcf2bd8f8015b4
2017-09-14 13:00:39 -07:00
Jaekyun Seok
81104ae5ef Add 'vendor.' prefix to a vendor HAL service name
To prevent property name collisions between properties of system and
vendor, 'vendor.' prefix must be added to a vendor HAL service name.
You can see the details in http://go/treble-sysprop-compatibility.

Test: succeeded building and tested on a walleye device
Bug: 36796459
Change-Id: I4e8fbee791ec917a8f627a1366f4d44ec7e6febc
2017-09-12 08:01:42 +09:00
Roshan Pius
d956fb10e5 Merge "wifi(implementation): Remove unnecessary local variable" into oc-mr1-dev
am: 12d6df4a2a

Change-Id: Id89af05cf256af7b4a6958c502a7f8a683901084
2017-09-05 22:53:56 +00:00
Roshan Pius
e94d036f4f Merge "wifi(implementation): Make WifiLegacyHal.stop() blocking" into oc-mr1-dev
am: ac2cd9e8ea

Change-Id: Ic20beb0fe4cd08c8e631ea170d8e6a85dbaac5ce
2017-09-05 22:53:26 +00:00
Roshan Pius
3078a4cb67 wifi(implementation): Remove unnecessary local variable
Bug: 65058323
Test: Compiles
Change-Id: Ib268234837f5b381572c8038e7900a145fb32249
2017-08-28 16:14:22 -07:00
Roshan Pius
155344b866 wifi(implementation): Make WifiLegacyHal.stop() blocking
IWifi::stop() is currently non-blocking which makes it hard for the
client to determing when the stop is fully complete. This for example
causes wificond to disable the wlan0 interface while the legacy HAL
stop is being processed. So, add a timed wait to let the legacy HAL
complete processing of the stop before we unblock the IWifi::stop()
HIDL call.

Bug: 64611487
Test: Manual tests by wifi state toggling and verifying the order of
events in logs:
08-15 19:17:53.302   796   796 I android.hardware.wifi@1.0-service:
Stopping legacy HAL
08-15 19:17:53.302   796   796 I WifiHAL : Sent msg on exit sock to
unblock poll()
08-15 19:17:53.302   796  4793 E CLD80211:
/vendor/bin/hw/android.hardware.wifi@1.0-service: Could not find group
host_logs, errno: 0 id: -2
08-15 19:17:53.302   796  4793 E CLD80211:
/vendor/bin/hw/android.hardware.wifi@1.0-service: Could not find group
fw_logs, errno: 0 id: -2
08-15 19:17:53.302   796  4793 E CLD80211:
/vendor/bin/hw/android.hardware.wifi@1.0-service: Could not find group
per_pkt_stats, errno: 0 id: -2
08-15 19:17:53.302   796  4793 E CLD80211:
/vendor/bin/hw/android.hardware.wifi@1.0-service: Could not find group
diag_events, errno: 0 id: -2
08-15 19:17:53.302   796  4793 E CLD80211:
/vendor/bin/hw/android.hardware.wifi@1.0-service: Could not find group
fatal_events, errno: 0 id: -2
08-15 19:17:53.302   796  4793 I CLD80211:
/vendor/bin/hw/android.hardware.wifi@1.0-service: Sent msg on exit sock
to unblock poll()
08-15 19:17:53.302   796  4793 I android.hardware.wifi@1.0-service:
Legacy HAL stop complete callback received
08-15 19:17:53.304   802   838 D CHRE    : @ 151.328: [Platform] wifi:
has 0, enabled 0
08-15 19:17:53.321   796  4793 I android.hardware.wifi@1.0-service:
Legacy HAL event loop terminated
08-15 19:17:53.321   796   796 I android.hardware.wifi@1.0-service:
Legacy HAL stop complete
08-15 19:17:53.522   796   796 I android.hardware.wifi@1.0-service: Wifi
HAL stopped

Test: Will send for regression tests.
Change-Id: I394c11724e9459a4b9a6b970e2bcb4e0ad65fefc
2017-08-28 12:55:07 -07:00
Etan Cohen
3718363c50 Merge "[AWARE] Fix maxNdpSessions documentation" into oc-mr1-dev
am: 5920714752

Change-Id: I891efa8137b3a69b320d65c34832d4e64530cb20
2017-08-15 23:05:09 +00:00
TreeHugger Robot
5920714752 Merge "[AWARE] Fix maxNdpSessions documentation" into oc-mr1-dev 2017-08-15 22:53:06 +00:00
Roshan Pius
0369531e0f Merge "wifi(implementation): Reduce logging severity" into oc-mr1-dev
am: c0e5e08634

Change-Id: I1603f227ab8a10268a41da51c59f0dc3cbec5634
2017-08-15 22:33:07 +00:00
Roshan Pius
d6ce826894 wifi(implementation): Reduce logging severity
IE elements should not be present in the batched scan results, but it
being there doesn't cause any problems. The IE elements will be ignored
when we send it over the HIDL interface, so reduce the log level to
prevent log spamming.

Bug: 64448186
Test: None
Change-Id: Ia0d0312a113c907bb0992bb8f41e734fe9d05114
2017-08-15 08:42:50 -07:00
Etan Cohen
36591cb5f5 [AWARE] Fix maxNdpSessions documentation
Clarify meaning of maxNdpSessions capability. Total, not per interface.

Bug: 64685830
Test: builds
Change-Id: I24fc0a97172a4ca161f432b6c5c1dc55a44dfb12
2017-08-14 14:12:11 -07:00
Steven Moreland
4f25c2a143 Revert "Revert "Updating all makefiles.""
Relanding without automotive/vehicle/2.0+2.1 changes.

This reverts commit 1020ebedfb.

Merged-In: I8608c8f636c35f21e4246a805a9eff6d14124e0a
Change-Id: Icc49df42c2bedf443d878d5d8fbaa53441ea65db
2017-08-11 23:02:01 +00:00
Steven Moreland
1020ebedfb Revert "Updating all makefiles."
This reverts commit 8ac1971678.

Reason for revert: Didn't remove automotive changes from this CL.

Merged-In: I8608c8f636c35f21e4246a805a9eff6d14124e0a
Change-Id: I1c660cffc8817ad0b33da9f6eceb3d88e7c48416
2017-08-11 22:56:56 +00:00
Steven Moreland
8ac1971678 Updating all makefiles.
Bug: 64487114
Test: none
Merged-In: I8608c8f636c35f21e4246a805a9eff6d14124e0a
Change-Id: I2fa89b6661c39859ec4fb62c4bb0a05a35e645f0
2017-08-10 22:40:04 +00:00
Tri Vo
a6969cdd68 Merge "VTS tests now static link to HAL def libs. #2" into oc-mr1-dev
am: 2883486706

Change-Id: I763622ff5280ade458da82e95df50a1b6d104f93
2017-08-10 18:08:27 +00:00
Tri Vo
2883486706 Merge "VTS tests now static link to HAL def libs. #2" into oc-mr1-dev 2017-08-10 17:45:07 +00:00
Tri Vo
0c2ce357b1 VTS tests now static link to HAL def libs. #2
And use VtsHalTargetTestDefaults.

Bug: 64040096
Test: crop out all non-affected tests from vts-hal-hidl.xml and run
vts-tradefed run commandAndExit vts-hal-hidl --skip-all-system-status-check 
--skip-preconditions
2 failures, same as without this change:
GatekeeperHidlTest.DeleteAllUsersTest
GatekeeperHidlTest.DeleteUserTest

Change-Id: I8f6995e9536a9aefe283ee3effec9f5a7f03b620
2017-08-10 17:44:57 +00:00
Roshan Pius
a0c51fcb66 wifi(vts): Remove a tight loop of toggling wifi state am: 0d1bb97447
am: c2fe644833

Change-Id: Ia85c1d368d1730fbbf76c37607ca01a367f101e5
2017-08-09 05:15:18 +00:00
Roshan Pius
0f2946eb46 wifi(vts): Remove a tight loop of toggling wifi state
am: 0d1bb97447

Change-Id: Icec63b9ffd5d12003da44bdde73edde04e55f11a
2017-08-09 05:09:17 +00:00
Roshan Pius
c2fe644833 wifi(vts): Remove a tight loop of toggling wifi state
am: 0d1bb97447

Change-Id: Ib6f4e21ab0a8cf7970ea8da0990d403629d566c5
2017-08-09 05:09:17 +00:00
Roshan Pius
0d1bb97447 wifi(vts): Remove a tight loop of toggling wifi state
The tight loop of HAL start/stop exposes a race condition within the HAL.
Adding a fix for preventing this race would need a fix which would be
pretty risky at this point of the release. The issue itself is unlikely
to happen in real use cases because wifi toggles (user initiated or test
scripts initiated) via framework goes through a series of processing
before it invokes the HAL start/stop.

Bug: 64195190
Test: `make vts -j30 BUILD_GOOGLE_VTS=true TARGET_PRODUCT=aosp_arm64 &&
vts-tradefed run commandAndExit vts --skip-all-system-status-check
--primary-abi-only --skip-preconditions --module VtsHalWifiV1_0Target -l
INFO`

Change-Id: I4e4d65f8b6e2e423a3a5f26e5a97a78b7e99c3e8
2017-08-09 04:58:29 +00:00
Roshan Pius
cf8a53de3e wifi(vts): Ignore IWifi.stop() returning ERROR_NOT_AVAILABLE am: 8c216524a3
am: aee43a0913

Change-Id: I950d0d4f934ed1ac577fcf750c1fbc7e1d6e0030
2017-08-08 17:13:24 +00:00
Roshan Pius
aee43a0913 wifi(vts): Ignore IWifi.stop() returning ERROR_NOT_AVAILABLE
am: 8c216524a3

Change-Id: I230da94a69e29be2e8b32ca2b0f28d10b068e2da
2017-08-08 17:10:25 +00:00
Roshan Pius
07bac60f31 wifi(vts): Ignore IWifi.stop() returning ERROR_NOT_AVAILABLE
am: 8c216524a3

Change-Id: I1bf9be99d4e673209edb893040483bf772ee3ca0
2017-08-08 17:10:25 +00:00
Roshan Pius
8c216524a3 wifi(vts): Ignore IWifi.stop() returning ERROR_NOT_AVAILABLE
When IWifi.stop() is invoked back to back (happens in the ConfigureChip
vts test), the HAL would return ERROR_NOT_AVAILABLE if the previous stop
is still being processed. This is not an error that needs to fail the test,
but a legitimate status for stop. We have a retry mechanism to handle
this in both the VTS test and framework for the case where IWifi.start()
is invoked while the previous stop is being processed.

While there, corrected a few log messages emitted by the HAL to debug
such startup/stop issues better.

Bug: 63971806
Test: `vts-tradefed run commandAndExit vts --skip-all-system-status-check
--primary-abi-only --skip-preconditions --module VtsHalWifiV1_0Target -l
INFO`

Change-Id: I5e3470ac97541a6ea10aceec9b737e5d03ed5206
2017-08-08 17:02:19 +00:00
Justin Yun
d66371512c Update make file for vndk enabled.
am: 608d773ef8

Change-Id: I6ea2891c61edaa2f8e1657544e3d2fb5011626c8
2017-08-05 02:10:40 +00:00
TreeHugger Robot
0a21415efa Merge changes from topic 'hidl-vndk-enabled-oc-mr1' into oc-mr1-dev
* changes:
  Mark hidl utils as vndk
  Manually update makefile for vndk-sp hidl libs.
  Update make file for vndk enabled.
2017-08-05 02:01:37 +00:00
Tri Vo
4fdb18759b Merge "Wifi supplicant test statically links to dependencies." into oc-mr1-dev
am: c0d5b9bbb8

Change-Id: I1c2a9dfe36fdd47c81b7e405adb60383e6257a1c
2017-08-04 23:15:43 +00:00
Tri Vo
c0d5b9bbb8 Merge "Wifi supplicant test statically links to dependencies." into oc-mr1-dev 2017-08-04 23:07:26 +00:00
Tri Vo
48f8e5d6be Wifi supplicant test statically links to dependencies.
This test now statically links to libs not guaranteed to be on the
device.

Bug: 64040096
Test: compiles
Change-Id: I986e61835e641e15bdad0ff9571ee8ffa59b2a46
2017-08-04 10:36:10 -07:00
Justin Yun
608d773ef8 Update make file for vndk enabled.
Update the Android.bp generated with hidl-gen.

Test: build with and without BOARD_VNDK_VERSION=current
Bug: 63866913
Change-Id: I1a9db1df49e0f13c5790da2b118ae9ec63ba34a7
2017-08-04 14:12:23 +09:00
Steven Moreland
a7a300a13b Merge "Update makefiles for vndk enabled." into oc-mr1-dev
am: d9b12c13e5

Change-Id: Id70e58e6b4d20dada4aab107b2aa98c58cf167ca
2017-08-04 01:04:40 +00:00
TreeHugger Robot
d9b12c13e5 Merge "Update makefiles for vndk enabled." into oc-mr1-dev 2017-08-04 00:52:06 +00:00
Tri Vo
c7d816b680 Merge changes from topic 'vts_deps' am: 7d149a564f am: 7f8774ef80 am: 3b84dc5c78
am: 84d1627979

Change-Id: I809807a17187a401c396cd73721ca9fdccc60f1c
2017-08-03 20:34:21 +00:00
Tri Vo
35c7bd2e2b VTS tests now static link to HAL def libs.
And use VtsHalTargetTestDefaults.

Bug: 64040096
Test: compiles
Merged-In: I3cfb1a64f6abcf3145337a736800b72d92a0b152
Change-Id: I3cfb1a64f6abcf3145337a736800b72d92a0b152
(cherry picked from commit 6c2bd86f70)
2017-08-03 13:28:08 -07:00
Tri Vo
84d1627979 Merge changes from topic 'vts_deps' am: 7d149a564f am: 7f8774ef80
am: 3b84dc5c78

Change-Id: I00c00e9e48d0275a78fb8914fdbc85de10b0d060
2017-08-03 20:27:47 +00:00
Tri Vo
3b84dc5c78 Merge changes from topic 'vts_deps' am: 7d149a564f
am: 7f8774ef80

Change-Id: Ieb521a2e25f9483d68d33a8c9d4b2d957da978c7
2017-08-03 20:21:47 +00:00
Tri Vo
7f8774ef80 Merge changes from topic 'vts_deps'
am: 7d149a564f

Change-Id: Idf236b741d7ff2cc529002218c34a3b4f0cf625c
2017-08-03 20:15:19 +00:00
Treehugger Robot
7d149a564f Merge changes from topic 'vts_deps'
* changes:
  VTS tests now static link to HAL def libs.
  Add cc_defaults VtsHalTargetTestDefaults
2017-08-03 20:06:15 +00:00
Tri Vo
6c2bd86f70 VTS tests now static link to HAL def libs.
And use VtsHalTargetTestDefaults.

Bug: 64040096
Test: compiles
Change-Id: I3cfb1a64f6abcf3145337a736800b72d92a0b152
2017-08-03 18:04:00 +00:00
Tri Vo
7694738e26 Update Android.bp HIDL makefiles
am: f5d136c231

Change-Id: Iaabf86403c85f7cbf57d78de5abbfaff0c53fec5
2017-08-03 15:20:54 +00:00
Steven Moreland
c716b8c307 Update makefiles for vndk enabled.
Test: none
Bug: 63866913
Change-Id: I29174fdadca2828455ef49f14e53bc95c5238dbb
2017-08-02 18:00:14 -07:00
Tri Vo
f5d136c231 Update Android.bp HIDL makefiles
Allow HAL definition libs to be static.

Bug: 32920003
Bug: 64040096
Test: update-all-google-makefiles.sh
Change-Id: I1483d572bea6799717d1614fb7d52fe225e31104
2017-08-03 00:30:01 +00:00
Steven Moreland
208a586cf8 Update HIDL makefiles.
Allow them to be static.

This is required for a couple of reasons:
- enabling HIDL passthrough in recovery
- enabling VTS tests to be static blobs

Bug: 32920003
Bug: 64040096
Test: update-all-google-makefiles.sh
Merged-In: I1b2401fb273ab80819e3870aa71fe742269674ba
Change-Id: I1b2401fb273ab80819e3870aa71fe742269674ba
(cherry picked from commit 7206708528)
2017-08-02 12:52:41 -07:00
Sundong Ahn
3bee656e84 Change dependency library am: 94293086f8 am: 79e801cb18 am: aad41e85d4
am: 8ca20771e7

Change-Id: I1b2b68a760751ec6dcb05db1ee6fdead0f00db33
2017-08-02 17:23:11 +00:00
Sundong Ahn
8ca20771e7 Change dependency library am: 94293086f8 am: 79e801cb18
am: aad41e85d4

Change-Id: I079faa1a1438b0d2b0d8e5ed7929c77e73519ca1
2017-08-02 17:14:59 +00:00