When a camera is removed, |hidlMetadata| takes over ownership of
|metadata|. Therefore, we should not free |metadata| again.
Bug: 180014486
Test: Remove an external camera, and no crashes were observed.
Marged-In: I85246067f8753911cbcb58af24a46f12962226f3
Change-Id: I85246067f8753911cbcb58af24a46f12962226f3
(cherry picked from commit f36a439e3a97315a9f0a8661ea77aff61fb79c82)
(cherry picked from commit 682abf4039)
Use 'arbitrary' dataspace when trying to configure RAW streams.
Bug: 179158925
Test: pass vts with VtsHalCameraProviderV2_4TargetTest
Change-Id: I6360e4a459ae51af4898a7329fe31ded152efe8f
Earlier, for processCaptureRequestInternal, we took into account
producer and consumer usage flags returned by configureSingleStream.
Instead we should be taking into account the producer flag returned by
configureSingleStream and the consumer flag passed into
processCaptureRequestInternal (for output streams).
Bug: 162344072
Test: Use secure camera as secure only camera and run vts
Test: Run camera vts
Test: Vendor testing
Change-Id: I9fbd4db4cff48c25684f097907e7ba995c3edf41
Signed-off-by: Jayant Chowdhary <jchowdhary@google.com>
The new framework implementation derives capture buffer loss
notification from other information, and treats HAL notify() with
ERROR_BUFFER as no-op.
Test: Build
Bug: 155353799
Change-Id: Ia7ea52ee2750c7404b657467e1cfda4c05e6cc78
- Add documentation about giving hints to camera HAL about concurrent
operation before configuring sessions
- Limitations on ZOOM_RATIO_RANGE during concurrent operation.
Bug: 151891611
Test: builds
Change-Id: I79d0bd8be1ed9aa29a1ba080d01833f16eff580c
Signed-off-by: Jayant Chowdhary <jchowdhary@google.com>
The old config file is no longer being used. Adding new config
file that has the proper 30 minutes timeout.
Test: atest VtsHalCameraProviderV2_4TargetTest on Pixel 4
Bug: 156007290
Change-Id: I97b0fff967f87712f8f96ed06b628c70ad30dde4
Bug: 156749607
Test: fake mark a camera id as a secure only, see that it doesn't get
tested unless a test calls getCameraDeviceNames with addSecure = true
Test: VtsHalCameraProviderV2_4TargetTest passes on device without any secure only
cameras
Change-Id: Ibe428b663bd8024f46f0273ed5dfaa108a90dd43
Signed-off-by: Jayant Chowdhary <jchowdhary@google.com>
For concurrent camera, we allow the maximum digital zoom to be smaller
than the maximum zoom ratio. Adjust VTS test accordingly.
Test: camera VTS test
Bug: 151891611
Change-Id: I1d3813ed93faa83689dcb6a83490fae5581c602f
Existing definition was inconsistent, so update it to be consistent
and match what implementations have actually done.
Test: Builds
Bug: 150331548
Change-Id: I5dfbe7c802bf4ac98f0c5556d5ac3af5d79cff7a
For easy transition from SchedTune to UtilClamp, direct access to these
cgroups should be abstracted by using task profiles. Replace writepid
commands with new task_profiles command.
Bug: 155419956
Test: change .rc file and confirm task profile is applied
Signed-off-by: Suren Baghdasaryan <surenb@google.com>
Change-Id: I2732f7365351f132dbf0566319e3969c2a25b3e4
Merged-In: I2732f7365351f132dbf0566319e3969c2a25b3e4
This is to handle the case where HAL isn't using the hidl shim.
Test: dumpsys on Pixel 2
Bug: 145300768
Change-Id: I74874a025904887cc27ec00518f4261dd24e291a
The system camera kind of physical cameras which are public, should be the same as the
system camera kind of the logical cameras they back.
The system camera kinds of all logical cameras that share the same
hidden physical cameras must be the same.
Bug: 152053830
Test: VtsHalCameraProviderV2_4TargetTest
--gtest_filter=PerInstance/CameraHidlTest.getCameraCharacter*
Test: VtsHalCameraProviderV2_4TargetTest
--gtest_filter=PerInstance/CameraHidlTest.systemCamera*
Change-Id: Iba07a6aa4a5fb465e9e0c4d0adedf6becaba7d14
Signed-off-by: Jayant Chowdhary <jchowdhary@google.com>
Bug: 151896491
Test: local build
Exempt-From-Owner-Approval: This CL update suite name vts-core to vts as
the suite name is updated. This CL won't change test logic or behavior.
Change-Id: I562b4dc50765e953800a814a8fd84a01c1b9352b
Merged-In: I562b4dc50765e953800a814a8fd84a01c1b9352b
Migrate BOKEH_MODE_STILL_CAPTURE and BOKEH_MODE_CONTINUOUS to be 2 enums
of CONTROL_EXTENDED_SCENE_MODE.
Test: VtsHalCameraProviderV2_4TargetTest
Bug: 151759402
Change-Id: I4ee88ab550902edadbd8dc446677c5a02ea582cb
With current implementation cameraId is part of something like:
device@3.5/external//dev/video0
This doesn't work well with Camera2 API based apps.
Adding CameraIdOffset tag to Provider as a base offset.
Test: presubmit builds
Bug: 151350336
Merged-In: I6309d16be565616f048fb24a70e9be5b2f5ed480
Change-Id: I6309d16be565616f048fb24a70e9be5b2f5ed480
(cherry picked from commit 4f6022ae5d)
The offline requests deque is constructed with
specific amount of entries. Initialize the
the already allocated entries before pushing
new ones.
Bug: 149346795
Test: Camera CTS
Change-Id: I6db8d48949caf753429702b60c48698c95ecf4ad
Both EXIF_TAG_IMAGE_WIDTH and EXIF_TAG_IMAGE_LENGTH
expect short values as per EXIF spec. Call appropriate
libexif function to avoid possible heap corruption.
Bug: 148223871
Test: Successful build
Change-Id: Ib16bf1ae8ab2093da529efe6ff0778331c3e9eb3
Camera device subinterface version 3.6 must inherit
from the previous version 3.5 and continue to support
device sessions with versions 3.2, 3.5 as well as the
most recent 3.6.
Bug: 148235329
Test: VtsHalCameraProviderV2_4TargetTest
--gtest_filter=PerInstance/CameraHidlTest.switchToOffline/0_external_0
Change-Id: Ia46cbd771eb1d2624cc0cee808a3eb074fc775b6
