Commit graph

130 commits

Author SHA1 Message Date
Tomasz Wasilczyk
848f29c2d1 Merge "Widen dummy band range to cover all regions." into oc-mr1-dev 2017-08-12 00:15:55 +00:00
TreeHugger Robot
b0e7821fcb Merge "Update broadcastradio HAL 1.0 VTS tests." into oc-mr1-dev 2017-08-11 18:56:16 +00:00
Tomasz Wasilczyk
394b343ae5 Update broadcastradio HAL 1.0 VTS tests.
This is a cherry-pick of the following VTS changes from O MR1 to O:
 - ag/2462390: Fix Broadcast radio 1.0 VTS to not fail on
   other radio types than AM/FM.
 - ag/2477726: Make tuned field description more precise and
   fix VTS tests to obey it.
 - ag/2549733: Implement out-of-band metadata images (a test for in-band).

Additionally, it fixes config callback handling in OpenTunerTwice test.

Bug: b/64324703
Test: VTS
Change-Id: I590b9b4d927fb0cd41f92e919343b5b94ad0e246
2017-08-10 20:28:18 -07:00
Tomasz Wasilczyk
701a5bdda5 Widen dummy band range to cover all regions.
Bug: b/64115131
Test: VTS, instrumentation
Change-Id: I34e9aac440a003226200243c835e6116ba7eae90
2017-08-10 16:07:20 -07:00
Tri Vo
2883486706 Merge "VTS tests now static link to HAL def libs. #2" into oc-mr1-dev 2017-08-10 17:45:07 +00:00
Tri Vo
0c2ce357b1 VTS tests now static link to HAL def libs. #2
And use VtsHalTargetTestDefaults.

Bug: 64040096
Test: crop out all non-affected tests from vts-hal-hidl.xml and run
vts-tradefed run commandAndExit vts-hal-hidl --skip-all-system-status-check 
--skip-preconditions
2 failures, same as without this change:
GatekeeperHidlTest.DeleteAllUsersTest
GatekeeperHidlTest.DeleteUserTest

Change-Id: I8f6995e9536a9aefe283ee3effec9f5a7f03b620
2017-08-10 17:44:57 +00:00
TreeHugger Robot
2187f58fad Merge "Add OWNERS for broadcast radio HAL 1.1." into oc-mr1-dev 2017-08-08 19:26:42 +00:00
Tomasz Wasilczyk
75c2bd8d1c Add OWNERS for broadcast radio HAL 1.1.
Test: not necessary
Change-Id: I73881db46382276f56963c9d3a40cb0bdc1a2070
2017-08-07 17:46:31 -07:00
Tomasz Wasilczyk
da97a6dd42 Change VENDOR program types to range.
Bug: b/64331420
Test: VTS, instrumentation
Change-Id: If91d8e6835ed3acaf429bb05b96f3d3a7985d19b
2017-08-07 10:27:28 -07:00
Tomasz Wasilczyk
eabdc13839 Merge "Pass ProgramInfo over currentProgramInfoChanged and drop afSwitch_1_1." into oc-mr1-dev 2017-08-05 20:47:14 +00:00
TreeHugger Robot
0a21415efa Merge changes from topic 'hidl-vndk-enabled-oc-mr1' into oc-mr1-dev
* changes:
  Mark hidl utils as vndk
  Manually update makefile for vndk-sp hidl libs.
  Update make file for vndk enabled.
2017-08-05 02:01:37 +00:00
Tomasz Wasilczyk
dd130660d3 Pass ProgramInfo over currentProgramInfoChanged and drop afSwitch_1_1.
Bug: b/64229617
Test: VTS, instrumentation
Change-Id: Id2d209a31d801f85e197312673eb6b7ee63ada46
2017-08-04 12:14:53 -07:00
Justin Yun
608d773ef8 Update make file for vndk enabled.
Update the Android.bp generated with hidl-gen.

Test: build with and without BOARD_VNDK_VERSION=current
Bug: 63866913
Change-Id: I1a9db1df49e0f13c5790da2b118ae9ec63ba34a7
2017-08-04 14:12:23 +09:00
Tomasz Wasilczyk
fa3a559d86 Pass vendor-specific info as map.
This solves a problem of identifying, if a given application is talking
to a hardware that can handle format of these strings.

Bug: b/64229617
Test: VTS, instrumentation
Change-Id: If1a5f9900800b8537ef158beefcbaf3c1008c3da
2017-08-03 18:21:47 -07:00
Tomasz Wasilczyk
dd58770c39 Implement missing broadcastradio 1.1 VTS tests.
Bug: b/36864490
Test: VTS
Change-Id: Iff25fdd65624db09e6667d32108e479d5eee6964
2017-08-03 12:59:12 -07:00
Tomasz Wasilczyk
e16fb74b05 Merge "Linguistic fixes for broadcastradio 1.1 HAL." into oc-mr1-dev 2017-08-03 16:54:54 +00:00
Tomasz Wasilczyk
b75bb41575 Merge "Address Broadcast Radio HAL review notes." into oc-mr1-dev 2017-08-03 16:52:31 +00:00
Tri Vo
f5d136c231 Update Android.bp HIDL makefiles
Allow HAL definition libs to be static.

Bug: 32920003
Bug: 64040096
Test: update-all-google-makefiles.sh
Change-Id: I1483d572bea6799717d1614fb7d52fe225e31104
2017-08-03 00:30:01 +00:00
Tomasz Wasilczyk
9214894ebc Linguistic fixes for broadcastradio 1.1 HAL.
Bug: b/64113304
Test: it builds
Change-Id: I5d5d090a44146e327d7b0f69cc2ba97060f3b515
2017-08-02 13:35:09 -07:00
Tomasz Wasilczyk
b8a2afe446 Address Broadcast Radio HAL review notes.
Bug: b/64229617
Test: instrumentation, VTS
Change-Id: I4009b33eaea6df585f514711f22dfb7fec5ad379
2017-08-01 14:53:43 -07:00
Tomasz Wasilczyk
614ffc163a Refine broadcastradio HAL comments.
Bug: b/64113304
Test: it builds
Change-Id: I42c1d32dbe436c97f0a05b4fdb88f60f11ceb0a1
2017-07-29 17:31:56 -07:00
Tomasz Wasilczyk
efadc19b6b Make virtual radio space generic, not only FM-exclusive.
Bug: b/36864090
Test: VTS, instrumentalization
Change-Id: I2764d09f56a397a1b80914a2634d6bad4b3bd3d2
2017-07-29 11:29:46 -07:00
Tomasz Wasilczyk
5be4c2b6e3 Remove a hack for 1.0/1.1 bitmap compatibility.
Instead, implement it correctly.
This hack was a quick jury-rigging before O MR1 FC.

Bug: b/36864090
Test: VTS
Change-Id: Ia9caff9228518ec573a85437e9070db777057359
2017-07-29 11:29:46 -07:00
Tomasz Wasilczyk
753c1d1ef2 Implement closing default radio implementation by invalidating all future calls.
Also, use the new hidl_vec range constructor.

Bug: b/36864090
Test: VTS
Change-Id: I92a22ab7f263edd39e42abb65bc25b3d3dc33a1e
2017-07-29 11:29:46 -07:00
Tomasz Wasilczyk
6e93c9c8ba Broadcast Radio default implementation: analog forced switch.
Bug: b/36864090
Test: VTS
Change-Id: I2b7bcf2bb3ad7075f39280ab72b32bff5bf166a3
2017-07-28 08:58:08 -07:00
Tomasz Wasilczyk
c1763a6796 Fix remaining broadcastradio 1.1 VTS TODOs.
This includes:
- cover all AM/FM bands, not just first one
- fix flakiness on late callback dereference
- fix 1.0 tuneComplete check
- move utils includes into separate subdirectories

Bug: b/36864490
Test: VTS
Change-Id: I6e2427ac29abd6278c9783cf83b4df05195ac7ea
2017-07-26 14:41:35 -07:00
Tomasz Wasilczyk
5ca56431d4 Rename vendorExtension fields to vendorInfo.
Bug: b/63634552
Test: instrumentation
Change-Id: Ifeb41ace8d4f4df093c925883c07ea86f0d9b5d7
2017-07-19 16:26:56 -07:00
Tomasz Wasilczyk
ba3e254483 Implement out-of-band metadata images.
This saves a lot of HIDL bandwidth, by not including raw image data in
metadata vector.

Bug: b/63702941
Test: VTS
Change-Id: I73d5218095e4af34c58da8dcfc520abd4cb46c26
2017-07-19 13:38:26 -07:00
Tomasz Wasilczyk
9400122ce8 Merge "Add DRMO_MODULATION program identifier type." 2017-07-19 13:55:56 +00:00
Tomasz Wasilczyk
5a76ec53c2 Add DRMO_MODULATION program identifier type.
Bug: b/63702941
Test: it builds
Change-Id: I3353b232c2e24f7e3c816d4089b2cbf40c4b79ae
2017-07-19 06:53:39 -07:00
Yifan Hong
c67f7b09fd Mark a.h.broadcastradio@1.1-utils-lib as vendor_available
It is used by libandroid_servers, a platform module.

Test: BOARD_VNDK_VERSION=current m libandroid_servers -j

Bug: 33241851
Change-Id: Iac260092d488133033b9a5f0238f7993ab5ef7f0
2017-07-18 15:37:28 -07:00
Tomasz Wasilczyk
85a60baea1 Merge "Make it possible to check if a given program/identifier type is supported." 2017-07-18 17:00:55 +00:00
Tomasz Wasilczyk
bb47714f8d Merge "Fill announcement-related gaps in Broadcast Radio APIs." 2017-07-18 16:49:17 +00:00
Tomasz Wasilczyk
8ca043b286 Merge "Added programInfoChanged callback." 2017-07-18 16:15:17 +00:00
Tomasz Wasilczyk
dc5291d63c Merge changes from topic 'radio-sprint-selector'
* changes:
  Split VENDOR program type to four distinct types.
  Move utils lib out from implementation namespace.
2017-07-18 15:36:23 +00:00
Tomasz Wasilczyk
e192c39c51 Make it possible to check if a given program/identifier type is supported.
Test: VTS
Bug: b/63702941
Change-Id: I8bf162646971188d3bed006c66eb25f1f5dc8df9
2017-07-17 16:56:02 -07:00
Tomasz Wasilczyk
24180098d7 Fill announcement-related gaps in Broadcast Radio APIs.
- adds TA and TP flags to ProgramInfo struct
- adds a callback to cancel announcement

Bug: b/63702941
Test: Instrumentalization, VTS
Change-Id: I03a0781d37429d4a84aab2dce3e5bb7794a20c57
2017-07-17 16:56:02 -07:00
Tomasz Wasilczyk
f8866e79d7 Added programInfoChanged callback.
Also, updated tuneComplete_1_1 and afSwitch_1_1 to match the new behavior
(not passing the whole ProgramInfo struct).

Bug: b/32621193
Test: VTS (none added)
Change-Id: Ic8aee15b05cb982d97e550fc0806f34fbe112e22
2017-07-17 16:56:02 -07:00
Tomasz Wasilczyk
d167caff30 Split VENDOR program type to four distinct types.
Bug: b/32621193
Test: VTS, none added
Change-Id: Ia3b793faeed1129932cf312d231c7d661542fda9
2017-07-17 16:55:56 -07:00
Mikhail Naganov
afae464376 Add OWNERS for audio-related HAL default implementations
Test: not needed
Change-Id: Idefe7be10bde22866be82f87118b9b54e74c3f40
2017-07-14 17:14:53 +00:00
Tomasz Wasilczyk
2834b95b12 Move utils lib out from implementation namespace.
RadioService may benefit from it too.

Also, fix subchannel base, as I found a tiny comment about it in the 1.0 HAL.

Bug: b/32621193
Test: instrumentalization
Change-Id: I11939025b72bdeab4cc6393e25159f53164e22ed
2017-07-13 14:14:11 -07:00
Tomasz Wasilczyk
bb5f29c9fb Use broadcastradio 1.1 default implementation by default.
Also, remove a warning for 1.1 interface, as the hidl freeze mechanism
is now in place.

Bug: b/34348946
Test: VTS, instrumentalization
Change-Id: I82025a7de8abd0758ba8b196bbbfc48b9322ac3b
2017-07-12 12:23:41 -07:00
Tomasz Wasilczyk
c9ba646a72 Refactor Broadcast Radio 1.1 VTS test.
Also apply some minor fixes and log tweaks to the default implementation.

Bug: b/36864490
Test: VTS
Change-Id: I16558d71c6cdee71854ecae9106b8a1c78032439
2017-07-10 15:32:29 -07:00
Tomasz Wasilczyk
a02b6ef23c Implement ProgramSelector at HIDL layer.
No front-end implementation yet.

Bug: b/32621193
Test: VTS
Change-Id: I48f034e709254836cad35bbeb4285c3c42a9e1cd
2017-07-06 17:45:26 -07:00
Tomasz Wasilczyk
2af8c52a6a Merge "Add RDS info to virtual stations, convert to ProgramInfo." 2017-07-05 21:22:46 +00:00
Tomasz Wasilczyk
100f2ed58a Add RDS info to virtual stations, convert to ProgramInfo.
Bug: b/36864090
Test: manual, VTS (none added)
Change-Id: Iad54f5abee4c722030ae118cb3c4d8ad64225b34
2017-06-30 09:06:30 -07:00
Tomasz Wasilczyk
7f7c8c9bc7 RDS PI is a number, not a string.
Makes an ABI-stable change to a hal definition file.

Bug: b/63147256
Test: manual, VTS, instumentalization
Change-Id: I7f1d88dea77fcfd7c203427c094553a6ae89d43b
2017-06-29 18:55:54 -07:00
TreeHugger Robot
ad48396212 Merge "Move broadcastradio test to vendor." 2017-06-29 20:00:34 +00:00
Steven Moreland
cfc836a326 Move broadcastradio test to vendor.
This is a vendor test and is causing builds with BOARD_VNDK_VERSION
to fail during soong processing.

Bug: 37342627
Test: BOARD_VNDK_VERSION=current builds fail later
Change-Id: Icc465b36ff0ecb0ac6c13ba99271eb9b86db6948
2017-06-29 11:09:33 -07:00
Tomasz Wasilczyk
0202b3e7b3 Make tuned field description more precise and fix VTS tests to obey it.
Also makes an ABI-stable change to a hal definition file.

Bug: b/36864490
Test: VTS
Change-Id: Ibf3513722144a559c31d0f61eb84bc718cd9dbdc
2017-06-29 16:21:54 +00:00