Commit graph

1817 commits

Author SHA1 Message Date
Sarah Chin
bb35a4371e Clean up VtsHalRadioTargetTest
Refactor class design so RadioServiceTest extends TestWithParam and
each individual radio service test extends RadioServiceTest.
Move setup and teardown logic common to all classes to RadioServiceTest.
Add logs to print when each test starts/finishes to help debug issues.
Remove unused imports and fix some typos.
Change unique_lock to lock_guard in notify to prevent MTE errors.

Test: atest VtsHalRadioTargetTest on fullmte build
Bug: 263940636
Change-Id: I2f6844f07d4518c00d47f98e5e15bea0a809fa84
Merged-In: I2f6844f07d4518c00d47f98e5e15bea0a809fa84
2023-05-04 22:35:47 +00:00
Treehugger Robot
3d35c2e75c Merge "Backport VTS fixes to previous test versions" into udc-dev 2023-04-28 23:12:07 +00:00
Jayachandran C
98b15ce956 Merge "Fix fail on RadioConfigTest#checkPortInfoExistsAndPortActive for dual-SIM detection" into android13-tests-dev am: 2b072c63c9 am: caf536d72a am: eaeb13c583
Original change: https://android-review.googlesource.com/c/platform/hardware/interfaces/+/2530680

Change-Id: I70a3f5264884508d3ae4da6f27a539d388bb1495
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-04-28 21:58:59 +00:00
Sarah Chin
fc35c0797e Backport VTS fixes to previous test versions
Network scan check periodicity only if scan type is PERIODIC.
Fix MCC/MNC checks to handle null strings.

Test: atest VTS
Bug: 259674407
Change-Id: I77e0706f413ce9defb174f00ee145dcc01f5d780
2023-04-28 11:12:01 -07:00
Zhang Yuan
276189b7df Fix fail on RadioConfigTest#checkPortInfoExistsAndPortActive for dual-SIM detection
The code currently uses 'dsds' to detect dual-SIM configurations,
but it misses 'dsda' configurations, resulting in test failures.
Should use the detection mechanism by adding handling for 'dsda',
ensuring accurate detection of all dual-SIM configurations.

Bug: 277705768
Test: vts -m VtsHalRadioTargetTest -t PerInstance/RadioConfigTest#checkPortInfoExistsAndPortActive/0_android_hardware_radio_config_IRadioConfig_default

Change-Id: Ie73a958ff14e86f440831e18291b6599b6eac30b
Signed-off-by: Jia Jia <jia.jia@zte.com.cn>
2023-04-25 21:16:42 +00:00
Sarah Chin
757a75879f Fix broken and flaky VTS tests
1. nvResetConfig takes some time to reset the modem, causing subsequent
   tests to fail with a timeout since the modem is unavailabe.
   Add a timeout after nvResetConfig to allow the modem to be up again
   before running the next test.
2. Remove invalid errors for start/stopKeepalive. These tests should
   fail due to invalid arguments, so remove NONE as a possible error.
   RADIO_NOT_AVAILABLE should also be removed.
3. Fix incorrect startNetworkScan_InvalidInterval tests, since we only
   check the interval when the scan type is PERIODIC.
4. Save and reset the previous allowed network type bitmap after the
   test. Combine get/set into one test that tests both behaviors.
5. Fix checks for MCC/MNC in getDataRegistrationState

Bug: 277626718
Bug: 240953393
Bug: 264913330
Bug: 259674407
Bug: 242801688
Test: atest VtsHalRadioTargetTest
Change-Id: Ic7188f9d8ccfcd90d844b45e3b370a3be3c515d6
2023-04-20 16:37:10 -07:00
Muralidhar Reddy Mule
be44d36ed7 Merge "Add cuttlefish support for iccCloseLogicalChannelWithSessionInfo HAl 2.1 API" into udc-dev 2023-04-18 13:30:25 +00:00
Sarah Kim
1feae91137 Merge "Require SIM card for all VTS tests" into udc-dev 2023-04-18 04:49:00 +00:00
Muralidhar Reddy
b27377ceb4 Add cuttlefish support for iccCloseLogicalChannelWithSessionInfo HAl 2.1 API
Bug: 268496310
Test: atest VtsHalRadioTargetTest:PerInstance/RadioSimTest, atest CtsCarrierApiTestCases:android.carrierapi.cts.CarrierApiTest#testIccCloseLogicalChannel
Change-Id: I3ce5fcb066e10fd65a605d1700721da37d97febb
2023-04-18 02:32:50 +00:00
Sarah Chin
899b03c945 Require SIM card for all VTS tests
We check SIM card status is PRESENT before running any VTS tests, so
ensure that it's enforced in the configs as well.

Test: atest VtsHalRadioTargetTest
Bug: 237504027
Change-Id: I1b2c317e21db118e4b957804feb76f266d887b20
2023-04-17 16:55:33 -07:00
Muralidhar Reddy
eb1c617446 Ignore new tests of IRadioSim, IRadioModem V2 in devices with V1
Bug: 270513760
Test: atest VtsHalRadioTargetTest:PerInstance/RadioSimTest, atest VtsHalRadioTargetTest:PerInstance/RadioModemTest
Change-Id: Ia981f1f341c6d2ebe3c7ff768505057140c9d718
2023-04-12 12:57:17 +00:00
Treehugger Robot
42df448bed Merge "Update Vts for getSlicingConfig" am: 2d79edf1d8 am: 913f780979 am: 20e72e98bc
Original change: https://android-review.googlesource.com/c/platform/hardware/interfaces/+/2430052

Change-Id: Id24d00b7d308a54e46231c975061390fc7114b11
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-04-11 06:21:24 +00:00
Hunsuk Choi
2c0b8e55c9 Merge "Ignore new tests for IRadioNetwork V2 in devices with V1" into udc-dev 2023-04-11 02:14:17 +00:00
Hunsuk Choi
ee588b2cd3 Ignore new tests for IRadioNetwork V2 in devices with V1
Bug: 277537061
Test: atest VtsHalRadioTargetTest:PerInstance/RadioNetworkTest
Change-Id: I902c736017bf0f2aad0bd9077ca29f4480293369
2023-04-11 00:17:24 +00:00
Alex Buynytskyy
ec1198d941 UpsideDownCake is now 34
Ignore-AOSP-First: UpsideDownCake Finalization
Bug: 275409981
Test: build
Change-Id: I832ab7a8b5445ba85e27bbcf5be64906bfa0e5be
2023-04-07 23:41:20 +00:00
Pavan Kumar M
8b5cf0ca14 Update Vts for getSlicingConfig
Currently getSlicingConfigAPI always returns NOT_SUPPORTED.
But GetSlicingConfig is supported in Android U. and VTS will fail.

This change updates the expected errorcodes for getSlicingConfig API.

Tests: Builds, Boots, RadioDataTest
Bug: 228996685
Change-Id: I10cf7b0b9ba09e56605d5a498ec48c4b8972f00b
2023-04-05 16:44:49 +05:30
Chen Baoyu
5a9285f1a0 Fix crash issue on test case RadioHidlTest_v1_5#startNetworkScan. am: a2881ffbd0 am: 4dc8eaba99 am: 0e10316efa
Original change: https://android-review.googlesource.com/c/platform/hardware/interfaces/+/2496776

Change-Id: I8cad7dab8887cf979e25f4fe689218800d5950f4
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-03-24 19:25:41 +00:00
Chen Baoyu
2154b45320 Fix crash issue on test case RadioHidlTest_v1_5#startNetworkScan. am: a2881ffbd0
Original change: https://android-review.googlesource.com/c/platform/hardware/interfaces/+/2496776

Change-Id: I59fa870664976566743a608e857cb91d7907efa4
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-03-24 18:27:43 +00:00
Chen Baoyu
a2881ffbd0 Fix crash issue on test case RadioHidlTest_v1_5#startNetworkScan.
Bad safe_union access is raised by calling the GET method of
eutranBands(), because in default ctor of safe_union RadioAccessSpecifier::Bands
hidl_d is assigned with hidl_discriminator::geranBands, which conflicts
with hidl_discriminator::eutranBands, and leads to crash.

Should use the SET method of eutranBands(&) for assignment purpose.

Fix: 275077563
Bug: 271642958
Change-Id: Ie241e8968eb7f9a1297203be2ab4e0a1bf738dea
Signed-off-by: Jia Jia <jia.jia@zte.com.cn>
2023-03-24 17:56:53 +00:00
Jack Yu
ecd6c2c33d Used LTE bands for network scan am: 87abf6a366 am: 708539cec7 am: d4b2a2b91d
Original change: https://android-review.googlesource.com/c/platform/hardware/interfaces/+/2493495

Change-Id: Ic16fb270c302758dd11f2636a15d6df9b49fdee0
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-03-17 04:45:45 +00:00
Jack Yu
ba41b92e54 Used LTE bands for network scan am: 87abf6a366
Original change: https://android-review.googlesource.com/c/platform/hardware/interfaces/+/2493495

Change-Id: I437d499c79368cbc6a35c9a730bbcc94adde8060
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-03-17 03:16:19 +00:00
Jack Yu
87abf6a366 Used LTE bands for network scan
Test with LTE bands, which are supported by every device
in the world.

Bug: 271642958
Test: atest VtsHalRadioTargetTest
Change-Id: Ibc71a69b1a9aeec506a35fac9f64ecad80371155
2023-03-17 00:05:34 +00:00
Jack Yu
a80f6f7c96 Merge "Add REQUEST_NOT_SUPPORTED and INVALID_ARGUMENTS to be allowed." am: 86bc150058 am: bc00ee0af0 am: 52e70ec981
Original change: https://android-review.googlesource.com/c/platform/hardware/interfaces/+/2471285

Change-Id: Ic31fd5f850ab50847e896f30952bc6de45db1edd
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-03-14 21:25:05 +00:00
Zhang Yuan
399c257ece Add REQUEST_NOT_SUPPORTED and INVALID_ARGUMENTS to be allowed.
For those devices which does not support GSM, returning is not
supported or invalid arguments are the expected behavior.

Bug: 271642958
Test: atest VtsHalRadioTargetTest
Merged-In: I3ac7407fdee82348411db99d340613e62f36a277
Change-Id: I3ac7407fdee82348411db99d340613e62f36a277
Signed-off-by: Jia Jia <jia.jia@zte.com.cn>
(cherry picked from commit 5bf6d5777a)
2023-03-14 19:08:46 +00:00
Zhang Yuan
5bf6d5777a Add REQUEST_NOT_SUPPORTED and INVALID_ARGUMENTS to be allowed.
For those devices which does not support GSM, returning is not
supported or invalid arguments are the expected behavior.

Bug: 271642958
Test: atest VtsHalRadioTargetTest
Change-Id: I3ac7407fdee82348411db99d340613e62f36a277
Signed-off-by: Jia Jia <jia.jia@zte.com.cn>
2023-03-13 19:01:10 -07:00
Thomas Nguyen
82d90d086f Merge "DO NOT MERGE Revert "Add Satellite HAL APIs"" into udc-dev 2023-03-11 01:37:02 +00:00
Thomas Nguyen
89e5fc4f5d DO NOT MERGE Revert "Add Satellite HAL APIs"
Revert submission 20583557-Satellite APIs

Reason for revert: We need to revert these changes for U

Reverted changes: /q/submissionid:20583557-Satellite+APIs

Bug: 271297374
Test: Call and SMS/MMS with live network.
atest TelephonyManagerTestOnMockModem
atest VtsHalRadioTargetTest
atest com.android.cellbroadcastreceiver.compliancetests.CellBroadcastConfigTest
atest android.telephony.cts.TelephonyManagerTest
atest android.telephony.cts.SatelliteManagerTest

Change-Id: I7ada8e72d77543f1ac03b267d61e8fd037ec3708
2023-03-05 14:48:08 -08:00
Avinash Malipatil
cc072f6859 Modified MediaDirection to provide more granular control over RTP and RTCP flow.
Bug: 270657968
Test: Build
Change-Id: Ic0a75dce6aaf7f9a25216d01243c69bbb44f1407
2023-03-03 02:42:18 +00:00
Sarah Chin
f9a4d9f7e5 Add backwards compatible default value for NR timing advance
Test: atest SignalStrengthTest
Bug: 141097448
Bug: 266825334
Change-Id: I97413b651fa99d4a0e119d4af670fb7216fca704
2023-02-18 02:49:39 -08:00
Muralidhar Reddy Mule
0dd7277c36 Merge "Add new API for iccCloseLogicalChannel to pass isEs10 information." 2023-02-10 04:06:47 +00:00
Muralidhar Reddy
c13d0d61e1 Add new API for iccCloseLogicalChannel to pass isEs10 information.
When a common logical channel ID is opened over 2 or more LSIs(including command port LSI), there is an ambiguity in closing the logical channel.
To resolve the ambiguity, pass isEs10 information about whether the logical channel was opened to send ES10 commands or not.

Test: Build
Bug: 268496310
Change-Id: I3e4f386b2a4f88d6e8bcc552d5ef1f404a8f9127
2023-02-09 17:35:22 +00:00
Treehugger Robot
ff3de20b90 Merge "Fix setupDataCall tests for osAppid" into android13-tests-dev 2023-02-09 16:25:05 +00:00
Sarah Chin
91e2e5196f Fix setupDataCall tests for osAppid
Test: atest VtsHalRadioTargetTest
Bug: 265830733
Change-Id: I1b342bb7a829585607db4518bf4017e28b6db84f
Merged-In: I1b342bb7a829585607db4518bf4017e28b6db84f
2023-02-09 09:22:56 +00:00
Treehugger Robot
d70545bfd5 Merge "VtsHalRadioV1_4Target.setPreferredNetworkTypeBitmap" into android12L-tests-dev am: 78cdf668a8 am: 221de90c16 am: 8900a1e345 am: 62abe67883
Original change: https://android-review.googlesource.com/c/platform/hardware/interfaces/+/2375494

Change-Id: I33f96bfbb20296cea172a742e208b7dd5869bf3e
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-02-04 03:07:00 +00:00
Treehugger Robot
62d87cb2da Merge "VtsHalRadioV1_4Target.setPreferredNetworkTypeBitmap" into android12L-tests-dev am: 78cdf668a8 am: 221de90c16
Original change: https://android-review.googlesource.com/c/platform/hardware/interfaces/+/2375494

Change-Id: Ifdf2a54524931654a4668b3a2e482541afb7e1a3
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-02-04 02:07:30 +00:00
Treehugger Robot
221de90c16 Merge "VtsHalRadioV1_4Target.setPreferredNetworkTypeBitmap" into android12L-tests-dev am: 78cdf668a8
Original change: https://android-review.googlesource.com/c/platform/hardware/interfaces/+/2375494

Change-Id: I9a4715bfea07ec34c9cb0fe8f31360c778e172c8
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-02-04 01:35:00 +00:00
Helen
e4af3c6ddf VTS implementation for ImsMediaHal
Bug: 263201546
Test: atest VtsHalRadioTargetTest (using cuttlefish)

Change-Id: I38eacded9a4523b7c5121f2d759d9b118923bcc7
2023-02-03 03:24:10 +00:00
Rakesh Raghava
93410d8dc5 Merge "[ImsMedia] Add notifyMediaQualityStatus api as per updated imsmedia design" 2023-01-31 21:08:25 +00:00
Rakesh Raghava
93bb36fe79 [ImsMedia] Add notifyMediaQualityStatus api as per updated imsmedia design
- removed notifyMediaInactivity(), notifyPacketLoss()
  notifyJitter() apis
- updated MediaQualityThreshold

Bug: 266514335
Test: build (m android.hardware.radio.ims.media-update-api && m -j64)
Change-Id: I328a437018d1ddd9e3d7be353d0c2551b850747c
2023-01-31 10:08:23 +00:00
Hwayoung Helen Kim
bf2ff60264 Merge "[ImsMedia] Add the duration value for the received DTMF api as per updated imsmedia design" 2023-01-31 02:11:41 +00:00
Helen
5e873e7d68 [ImsMedia] Add the duration value for the received DTMF api as per updated imsmedia design
Bug: 265610926
Test: build (mm && m -j64)
Change-Id: I6806f5fcb5c78271b7b8a8f56b44e32272de990f
2023-01-27 18:22:48 +00:00
Sarah Chin
00b64abb04 Merge "Fix enum typo in DataCallFailCause" 2023-01-25 19:08:58 +00:00
Sarah Chin
f233448ee9 Fix enum typo in DataCallFailCause
Test: build
Change-Id: I19b96ad9c18445837a1b89e2d202235cc72416aa
2023-01-25 03:56:46 -08:00
Arun kumar Voddu
37d9a40141 Merge "HAL changes to remove the carrierId" 2023-01-25 04:32:56 +00:00
Hwayoung Helen Kim
5dbcc47e97 Merge "[AOSP IMS] Change anbrBitrate to anbrMode" 2023-01-23 16:04:20 +00:00
Helen
f69fbd9616 [AOSP IMS] Change anbrBitrate to anbrMode
Bug: 250506481
Test: Build
Change-Id: I448e601c1fa5db4b9d0e04a8419e6dd0a2a11b1e
2023-01-20 01:17:02 +00:00
Sarah Chin
47213a189c Fix setupDataCall tests for osAppid
Test: atest VtsHalRadioTargetTest
Bug: 265830733
Change-Id: I1b342bb7a829585607db4518bf4017e28b6db84f
Merged-In: I1b342bb7a829585607db4518bf4017e28b6db84f
2023-01-19 13:07:04 -08:00
Sarah Chin
931487326c Merge "Fix setupDataCall tests for osAppid" 2023-01-19 19:18:15 +00:00
Sarah Chin
537f17a3a2 Merge "Change averagingWindowMs to int" 2023-01-19 19:09:21 +00:00
Thomas Nguyen
991a89d922 Merge "Add Satellite HAL APIs" 2023-01-19 02:37:20 +00:00