Commit graph

790 commits

Author SHA1 Message Date
Xin Li
879960bdce Merge Android U (ab/10368041)
Bug: 291102124
Merged-In: I7b6fffac2ada0e039f79bad8cc9b4d954e9c3460
Change-Id: I9466127d8d0fa38df36ca99f704853b2db871e67
2023-08-25 13:29:30 -07:00
Alec Mouri
cdcfd05736 Fix a DimmingStage documentation typo by rewording the doc.
Change-Id: I5a1b3a99630cfded4b34c74b020bb4df2ce12084
2023-07-20 23:07:17 +00:00
Edward Liaw
c01432b259 Merge "TEST_MAPPING: enable vts hal tests in kernel-presubmit" am: 24a8a39219 am: 69771123ba am: ac75f2d41c
Original change: https://android-review.googlesource.com/c/platform/hardware/interfaces/+/2610093

Change-Id: Id502dbe01f18f68a140290f5f0bf8b709d35bf0e
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-06-01 22:00:27 +00:00
Edward Liaw
69771123ba Merge "TEST_MAPPING: enable vts hal tests in kernel-presubmit" am: 24a8a39219
Original change: https://android-review.googlesource.com/c/platform/hardware/interfaces/+/2610093

Change-Id: Ifb1fe3792f481cfe57d3b4e9e0f7995ced887a7c
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-06-01 21:11:34 +00:00
Edward Liaw
24696b3e32 TEST_MAPPING: enable vts hal tests in kernel-presubmit
Enable the following tests:
VtsHalBluetoothAudioTargetTest
VtsHalGraphicsComposerV2_4TargetTest

Bug: 284307085
Bug: 258819618
Test: atest :kernel-presubmit
Change-Id: I8667eaee120777a776339481f72558566e6c94b3
Signed-off-by: Edward Liaw <edliaw@google.com>
2023-06-01 16:08:42 +00:00
ramindani
caee7cd3f6 [VTS 2.3] Add length check before reading blob
Adding a length check prevents the read() from
reading outside the bounds and prevents OOB crash.

Test: atest VtsHalGraphicsComposerV2_3TargetTest && atest VtsHalGraphicsComposerV2_4TargetTest
BUG: 252764300
Change-Id: I6231e340a925127f9c32ccb76768286f7292df58
Merged-In: I6231e340a925127f9c32ccb76768286f7292df58
2023-05-25 22:12:24 +00:00
Kriti Dang
79bbec97c4 Change the HDR conversion VTS test to take into account sink device
capabilities

Bug: 278467239
Test: atest VtsHalGraphicsComposer3_TargetTest
Change-Id: I69c21b6d8b9753500a7b7a1692448b7151009ba3
2023-05-08 08:28:09 +00:00
Huihong Luo
651806f263 Reset pending commands
Allow takePendingCommands to have ownership for mComamnds so commands
are reset on each call. Make reset method to be private.

Bug: 273525126
Test: manual
Change-Id: Ifecad733e5e85d475825969296ddf68081ce9e60
2023-04-22 04:09:10 +00:00
Alex Buynytskyy
ec1198d941 UpsideDownCake is now 34
Ignore-AOSP-First: UpsideDownCake Finalization
Bug: 275409981
Test: build
Change-Id: I832ab7a8b5445ba85e27bbcf5be64906bfa0e5be
2023-04-07 23:41:20 +00:00
ramindani
ea9ab1c01e VTS add length is not zero check for executeSetClientTarget am: d00b8598bb
Original change: https://googleplex-android-review.googlesource.com/c/platform/hardware/interfaces/+/22434697

Change-Id: I711607fc79f2ea513daba2b5017b9b5222a13d08
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-04-05 00:49:57 +00:00
ramindani
d00b8598bb VTS add length is not zero check for executeSetClientTarget
Test: atest VtsHalGraphicsComposerV2_1TargetTest
BUG: 252764410
Change-Id: Icd15f6e7bfdd7b3e3d0d4b407195258d4171c560
(cherry picked from commit 708d49cfce)
Merged-In: Icd15f6e7bfdd7b3e3d0d4b407195258d4171c560
2023-04-03 20:55:08 +00:00
Ram Indani
946e04580b Merge "VTS add length is not zero check for executeSetClientTarget" into udc-dev 2023-04-03 20:54:03 +00:00
Sally Qi
3972fcdb1f Merge "Fix HDR sluggish issue." into udc-dev 2023-04-03 17:21:26 +00:00
ramindani
708d49cfce VTS add length is not zero check for executeSetClientTarget
Test: atest VtsHalGraphicsComposerV2_1TargetTest
BUG: 252764410
Change-Id: Icd15f6e7bfdd7b3e3d0d4b407195258d4171c560
2023-04-03 09:12:02 -07:00
Brian Lindahl
5d9aedf558 Merge "Fix bug where buffer slots to clear were not set correctly" into udc-dev 2023-04-03 13:29:49 +00:00
TreeHugger Robot
ac28d06464 Merge "Add VTS test for clearing buffer slots to Composer HIDL and AIDL" into udc-dev 2023-03-31 22:34:15 +00:00
Brian Lindahl
c85693d02d Fix bug where buffer slots to clear were not set correctly
Bug: 276417624
Bug: 258196272
Test: VtsHalGraphicsComposer3_TargetTest
Change-Id: Ie077f14140d71f88a497c4a8995d73dd07c31598
2023-03-31 07:45:18 -06:00
Brian Lindahl
25e0d09c76 Add VTS test for clearing buffer slots to Composer HIDL and AIDL
This feature allows SurfaceFlinger to clear buffer slots when buffers
are discarded by SurfaceFlinger clients and will no longer be used,
allowing the graphics memory to be freed immediately.

Bug: 258196272
Test: atest VtsHalGraphicsComposerV2_4TargetTest
Test: atest VtsHalGraphicsComposer3_TargetTest
Change-Id: Ibfbe2078ac419bb8f3880ee3f0512acaad2f5012
2023-03-31 07:26:27 -06:00
Sally Qi
6814c443eb Fix HDR sluggish issue.
- skip writing blobs if empty packet is sent for per-frame metadata.

Bug: 274050717
Test: play HDR video on YouTube
Change-Id: If8716613136c70a5adee29074cc2e9d35a500264
2023-03-30 23:41:29 -07:00
Brian Johnson
9f370be5bb Merge "Revert "Add a DisplayCapability for multi-threaded present"" into udc-dev 2023-03-31 01:55:24 +00:00
Leon Scroggins III
4509505ce0 Revert "Add a DisplayCapability for multi-threaded present"
This reverts commit b3e336edd1.

Bug: 274954820
Test: build
Change-Id: I6265f8de3db31f07506906cee82a91fe3baac0bc
2023-03-23 18:23:15 -04:00
ramindani
17c7110b70 [VTS] Add interface version check function
Use the interface version check function in
SetRefreshRateChangedCallbackDebug tests

Update the GetOverlaySupport and SkipValidateDeprecatedTest
To use the interface vesion function

Test: atest VtsHalGraphicsComposer3_TargetTest
BUG: 267565265
Change-Id: I3f37f4ff5610f8e9e3dec299ed7c3f0c41a630d7
2023-03-20 18:16:57 +00:00
Kriti Dang
5fcddd74f6 Fixing the HDR conversion aidls
Bug: 251168514
Test: atest VtsHalGraphicsComposer3_TargetTest
Change-Id: I10310dd26809bd546c41d3d16bebcba711e43a50
2023-03-07 14:36:03 +00:00
ramindani
9151889d57 [VTS] change the bool to lambda
BUG: 202734676
Test: atest VtsHalGraphicsComposer3_TargetTest
Change-Id: I5611cd8a6cc23491621470d6457e2bfc859fde4e
2023-03-03 18:51:09 +00:00
ramindani
9dd8c4882b VTS for the Refresh rate callback debug enabled
BUG: 202734676
Test: atest VtsHalGraphicsComposer3_TargetTest
with the patch of
Ibc80d66eae6b21c3cf84d35fa819e97ccc509ede

Change-Id: I02bdf061420fe12ef4548008d66bb73e8cd416e8
2023-03-03 03:29:02 +00:00
Dorin Drimus
08212492f8 Fix VtsHalGraphicsComposer3_TargetTest / GetOverlaySupport
Test case is for composer starting with version 2 API, but the test case doesn't check version, so it fails for version 1 API.

Bug: 267565265
Test: 1. Push VtsHalGraphicsComposer3_TargetTest to device
2. Run VtsHalGraphicsComposer3_TargetTest
Test Command:
chmod 777 data/VtsHalGraphicsComposer3_TargetTest
./data/VtsHalGraphicsComposer3_TargetTest

Change-Id: I7bf37061aba84dfdfea5fc9dda5a300a1e5ec680
(cherry picked from commit 7493bbc999)
Merged-In: I7bf37061aba84dfdfea5fc9dda5a300a1e5ec680
2023-02-24 09:24:16 +00:00
Kriti Dang
376227694f Update setHdrConversionStrategy to return the preferredHdrOutput type
Bug: 268336382
Test: atest VtsHalGraphicsComposer3_TargetTest
Change-Id: I6ac912ac8a0329f4ea32acad657e44b473660c42
2023-02-14 18:10:16 +00:00
Ram Indani
f08f437e51 Merge changes from topic "hwc-rri"
* changes:
  [HWC3] VTS client updates for onRefreshRateChangedDebug callback And for setRefreshRateChangedCallbackDebugEnabled
  [HWC3] AIDL implementation for Refresh Rate Overlay indicator
2023-02-13 23:00:03 +00:00
ramindani
8345034b53 [HWC3] VTS client updates for onRefreshRateChangedDebug callback
And for setRefreshRateChangedCallbackDebugEnabled

This does not add any implementation for the VTS code.
Implementation will be added with the VTS tests as a followup.

Test: Device boots
BUG: 202734676
Change-Id: If47bbcf87698b346907b3bc1903908ff0a63203f
2023-02-10 14:27:09 -08:00
ramindani
ff0da0bb24 [HWC3] AIDL implementation for Refresh Rate Overlay indicator
Adds IComposerClient method to inform that the Refresh Rate callback is enabled.
Adds IComposerCallback to get the display vsyncPeriod for the Overlay.
Adds Composition type REFRESH_RATE_INDICATOR

Test: Device boots
BUG: 202734676
Change-Id: I48b0c05f49095b15cea444dc5c3ad8f78a043cb0
2023-02-10 09:25:47 -08:00
Sally Qi
2b4ceb6365 Add exception annotation to getOverlaySupport api.
Bug: 268246323
Test: builds
Change-Id: I1979fed444a9fd3d94af729112fff070beb01439
2023-02-08 12:59:54 -08:00
Sally Qi
a0545e3057 Merge "[Aidl graphics API] split dataspace array into tuples." 2023-01-24 16:34:02 +00:00
Sally Qi
c2c392fbea [Aidl graphics API] split dataspace array into tuples.
- update VTS test to make sure primaries/transfers/ranges bits are
  correct.

Bug: 242588489
Test: build and flash; atest VtsHalGraphicsComposer3_TargetTest

Change-Id: I77536d97b98e4dead208b7c8aeed9cfbb0d82316
2023-01-19 15:50:17 -08:00
Brian Lindahl
348bc9d779 Merge changes from topic "revert-uncache-hal-buffers-vts"
* changes:
  Revert "Add VTS test for clearing buffer slots to Composer HIDL and AIDL"
  Revert "Add VTS readback tests for buffer slot clearing"
  Revert "Add VTS for new API for clearing buffer slots"
2023-01-19 20:53:54 +00:00
Brian Lindahl
14bd07b195 Revert "Add VTS test for clearing buffer slots to Composer HIDL and AIDL"
This reverts commit ca3eef29b0.

NOTE: This is not a full revert, it leaves the production code in place and only reverts the VTS test changes.

Reason for revert: b/262370410

Test: atest VtsHalGraphicsComposerV2_1TargetTest on Oriole
Test: atest VtsHalGraphicsComposerV2_2TargetTest on Oriole
Test: atest VtsHalGraphicsComposerV2_3TargetTest on Oriole
Test: atest VtsHalGraphicsComposerV2_4TargetTest on Oriole
Bug: 262370410
Change-Id: Ie5ba7402cda2828ba33131d527ab0c3a66937648
2023-01-18 21:18:55 +00:00
Brian Lindahl
e887a25203 Revert "Add VTS readback tests for buffer slot clearing"
This reverts commit d103cd6828.

NOTE: This is not a full revert, it leaves the production code in place and only reverts the VTS test changes.

Reason for revert: b/262370410

Test: atest VtsHalGraphicsComposerV2_1TargetTest on Oriole
Test: atest VtsHalGraphicsComposerV2_2TargetTest on Oriole
Test: atest VtsHalGraphicsComposerV2_3TargetTest on Oriole
Test: atest VtsHalGraphicsComposerV2_4TargetTest on Oriole
Bug: 262370410
Change-Id: I336beb9f0ed81b305b26c6d8e9da70cfabe04bbd
2023-01-18 21:18:21 +00:00
Brian Lindahl
952057044b Revert "Add VTS for new API for clearing buffer slots"
This reverts commit 78ff2d6491.

NOTE: This is not a full revert, it leaves the production code in place and only reverts the VTS test changes.

Reason for revert: b/262370410

Test: atest VtsHalGraphicsComposerV2_1TargetTest on Oriole
Test: atest VtsHalGraphicsComposerV2_2TargetTest on Oriole
Test: atest VtsHalGraphicsComposerV2_3TargetTest on Oriole
Test: atest VtsHalGraphicsComposerV2_4TargetTest on Oriole
Bug: 262370410
Change-Id: Ica725cfaae6e2a08ed9c53eb9f17d6db1656bc93
2023-01-18 21:16:20 +00:00
Carlos Martinez Romero
7a6d907b99 Merge "Deprecate SKIP_VALIDATE." 2023-01-18 19:04:38 +00:00
Kriti Dang
5422df8f30 Merge "ComposerHAL APIs for HDR output control" 2023-01-17 17:37:35 +00:00
Sally Qi
c0f28978fa Merge "Remove length check to allow empty HDR10+ blobs to HWC" am: 2b42a74573 am: a7f01798f5 am: a0442dda02
Original change: https://android-review.googlesource.com/c/platform/hardware/interfaces/+/2374997

Change-Id: I7907436ae2e0460db31ec033e603442bc1120ab2
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-01-13 22:07:13 +00:00
Kriti Dang
3793ebdaea ComposerHAL APIs for HDR output control
Bug: 251168514
Test: atest VtsHalGraphicsComposer3_TargetTest
Change-Id: Icf5437c6dab2c8ce9247617f6e6006051fc206fb
2023-01-13 17:58:30 +01:00
Carlos Martinez Romero
cd04361bb3 Deprecate SKIP_VALIDATE.
Bug: 258549211
Test: Built it and flashed it + added a test.
Change-Id: I7a0dbea4dc0e6687f65d2136a8d21867d7232626
2023-01-11 23:49:21 +00:00
Sally Qi
1ae586175d Merge "[Graphics AIDL interface] add supportMixedColorSpaces boolean variable." 2023-01-10 21:32:01 +00:00
Sally Qi
2060a4e647 Remove length check to allow empty HDR10+ blobs to HWC
Bug: 212496177
Test: builds
Change-Id: Iad121cd6515e826c4b57976b14e7a5eb947b1728
2023-01-10 11:11:54 -08:00
Shubhangi Pawar
3e1907ae4a Merge "composer: vts: Init display dimension using active config" into android13-tests-dev 2023-01-09 18:59:00 +00:00
Treehugger Robot
bca716810c Merge "composer: vts: Init display dimension using active config" am: 12c9d664aa am: 177e0aeaaa am: df623aa638
Original change: https://android-review.googlesource.com/c/platform/hardware/interfaces/+/2302957

Change-Id: Ib27af495e361717e6c4466e8568d803110e6e0f8
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-01-09 06:29:20 +00:00
HyunKyoung
37b3413684 composer: vts: Init display dimension using active config
Dimension was initialized to the size of the last config that is in the config list.
VTS didn't change the dimension in the readback test and allocated buffer
for the readback with the dimension size.
However it was different with actual display size.
This change initializes display dimension to the actual display size.

Bug: 259155172
Change-Id: I64fec02f5386eb6ca1f41ab376be193231810b93
Merged-In: I64fec02f5386eb6ca1f41ab376be193231810b93
Signed-off-by: HyunKyoung <hk310.kim@samsung.com>
2023-01-09 04:56:06 +00:00
Treehugger Robot
12c9d664aa Merge "composer: vts: Init display dimension using active config" 2023-01-09 04:51:54 +00:00
HyunKyoung
4775bdce26 composer: vts: Init display dimension using active config
Dimension was initialized to the size of the last config that is in the config list.
VTS didn't change the dimension in the readback test and allocated buffer
for the readback with the dimension size.
However it was different with actual display size.
This change initializes display dimension to the actual display size.

Bug: 259155172
Change-Id: I64fec02f5386eb6ca1f41ab376be193231810b93
Signed-off-by: HyunKyoung <hk310.kim@samsung.com>
2023-01-05 10:17:34 +09:00
Sally Qi
7aaacf6068 [Graphics AIDL interface] add supportMixedColorSpaces boolean variable.
- To determine if the device can hendle mixed colorspaces without
  falling back to client composition.

Bug: 242588489
Test: build and flash
Change-Id: Ied346e1fe9c0b260c37aee458eddac689e711336
2022-12-19 23:22:31 -08:00