Commit graph

1729 commits

Author SHA1 Message Date
Gabriel Biren
4c3eeb417e Use a 64-bit instance of 0x1 when creating
the event bitmask.

Comments on ag/24025770 suggest that the bit
shift will lead to undefined behavior for
event codes greater than 31.

Bug: 290318208
Test: atest VtsHalWifiNanIfaceTargetTest
       # manually set some of the expected
       # events codes to > 31 to verify that
       # the bit shift works as expected
Change-Id: I09e11dac8acf90baf047e24cebe1d01970b1dc8a
2023-07-13 19:46:59 +00:00
Gabriel Biren
3f7bfd2dc5 Represent NAN callback events as a bitmap
to better handle overlapping events.

Reimplementation of aosp/2473685 for
the AIDL VTS tests.

Bug: 290318208
Test: atest VtsHalWifiNanIfaceTargetTest
Change-Id: I1a0e6ab8dd529c10fcec8f26424a7181e7d91568
2023-07-11 22:23:34 +00:00
Yuyang Huang
54bbf07e06 Add TV devices that have MdnsOffloadManagerService to APF exempt list
For Panel TV devices, the vendor can implemented TV specific mDNS
offload instead of APF in U. If TV specific mDNS offload is implemented.
MdnsOffloadManagerService will exist in the system ext partition. The
APF vts will be skipped if MdnsOffloadManagerService exist.

Bug: 283038712
Test: atest VtsHalWifiStaIfaceTargetTest
Change-Id: If55ec42507460b9a2c6eee683d85b8109f2af236
2023-06-28 02:24:35 +00:00
Gabriel Biren
0f1628e1ac Merge "Set the value of using_dynamic_iface_combination_ in the WifiChip constructor." into udc-dev 2023-06-16 20:58:26 +00:00
Gabriel Biren
01cf38f349 Merge "Improve process to run the Vendor HAL gTest suite." into udc-dev 2023-06-15 00:12:52 +00:00
Gabriel Biren
80f5392763 Improve process to run the Vendor HAL gTest suite.
This includes:
 - Adding a README to help users get started.
 - Improving the test script to avoid issue where
   device is not ready for the next ADB command
   after 'adb root'.

Bug: 271914366
Test: Manual test
       1. Reboot device.
       2. ./runtests.sh
       3. Tests are expected to execute.
Change-Id: I9f452384a7067708f617d1e932f06b2f5c7ab119
2023-06-14 22:53:28 +00:00
Gabriel Biren
989c78a51f Set the value of using_dynamic_iface_combination_
in the WifiChip constructor.

gTest suite currently cannot mock the legacy HAL
call for getSupportedIfaceConcurrencyMatrix.
If we set using_dynamic_iface_combination_ to true
in the unit tests, we can avoid making this call.

Bug: 271914366
Test: ./runtests.sh # gTest
Test: atest VtsHalWifiChipTargetTest # VTS
Change-Id: Ic43daab6ff5fdc5f78af614ad775f436fbbe8726
2023-06-14 22:45:29 +00:00
Gabriel Biren
5df702513f Merge "Add a new utility class wifi_hidl_test_utils_1_6 for the Wifi VTS tests." into udc-dev 2023-06-06 20:01:57 +00:00
Gabriel Biren
cd6da07327 Add a new utility class wifi_hidl_test_utils_1_6
for the Wifi VTS tests.

Main method is getBridgedWifiApIface_1_6, which
allows us to configure the chip based on the
Bridged AP IfaceConcurrencyType, rather than
the AP IfaceType like in getBridgedWifiApIface_1_5.

Implementations were largely copied from
wifi_hidl_test_utils and wifi_hidl_test_utils_1_5.

Bug: 283402709
Test: atest VtsHalHostapdTargetTest
       # tested on a Bluejay device that supports
       # the AddAccessPointWithDualBandConfig test
Change-Id: I2571876149fc14c8de02e1cec9934dd052cada5c
2023-06-05 22:52:52 +00:00
Treehugger Robot
5d806f5adb Merge "wifi: Fix single AP iface isn't deleted" into udc-dev 2023-06-02 03:36:59 +00:00
Sunil Ravi
780bef050a wifi: Fix single AP iface isn't deleted
Bug: 222599182
Bug: 278808480
Test: Manual Test, the AP iface is deleted.
Change-Id: I07faf0afcd1f69af4ef57204ceac02c2572453f2
2023-06-01 21:54:24 +00:00
Yuyang Huang
5c3c6483d3 Update APF VTS to include the vendor API level check
APF is support is mandatory since VSR 14. Before that, the APF
requirement is optional. Vendors can opted into upgrading their
HAL to AIDL, so the VTS need to check if vendor API level on the device
and only mandate the APF capability check if the vendor API level is
greater or equal to 14.

Bug: 283181837
Test: atest VtsHalWifiStaIfaceTargetTest
Change-Id: I21513187d4ca99d721d0e9dc5e243adad77ab8c6
2023-05-18 18:11:56 +09:00
TreeHugger Robot
a60e28c818 Merge "Remove unused wifi offload HAL." into udc-dev 2023-05-13 02:22:28 +00:00
Gabriel Biren
8e9d701b56 Remove unused wifi offload HAL.
Bug: 280901687
Test: m
Change-Id: Iad9a2c470b27fbe5432fd5a88244162f8f73a71c
2023-05-11 01:07:42 +00:00
maheshkkv
0ace7e5f91 Add documentation for Aware suspend & resume
Bug: 281882132
Test: build
Change-Id: Ifea3dd9a0bd635c95e3b80f09427d380b75e0fa9
2023-05-10 17:01:24 -07:00
Gabriel Biren
4f9c93276d Merge "Skip HIDL v1.6 RTT responder VTS tests if the capabilities do not indicate responder support." into udc-dev 2023-05-09 23:28:34 +00:00
Gabriel Biren
6eafc23dcf Skip HIDL v1.6 RTT responder VTS tests if the
capabilities do not indicate responder support.

Bug: 280550766
Test: atest VtsHalWifiRttV1_6TargetTest
Change-Id: I4e76a874837c6199b2bef65b3f0c138260972b4a
2023-05-08 18:29:10 +00:00
Gabriel Biren
6d41484860 Skip RTT responder VTS tests if the capabilities
do not indicate responder support.

Bug: 280550766
Test: atest WifiRttControllerAidlTest
Change-Id: I343dc3f2729274db5628f54501b89a470a512206
2023-05-03 22:11:51 +00:00
Gabriel Biren
8fddf60046 Merge "Fix VtsHalWifiSupplicantP2pIfaceTargetTest failed issue" into udc-dev 2023-04-26 15:56:54 +00:00
zhengyu.zhan
38bff8b0c7 Fix VtsHalWifiSupplicantP2pIfaceTargetTest failed issue
supplicant_test_utils::initializeService() only stop Supplicant,
don't start it. refer Android T code, It should start Supplicant
when initializeService().

Bug: 279572212
Test: VtsHalWifiSupplicantP2pIfaceTargetTest pass

Change-Id: I9f4b3e21ee0865eb95d71f7f832b2eb405de9607
2023-04-25 22:17:28 +00:00
Gabriel Biren
fce371b9b5 Add a lock around any public methods in
the AidlCallbackHandler.

Bug: 278433745
Test: Start wifi.
Change-Id: I2b143b9e8671eaf8c63c5623c09d2a04f914a772
2023-04-21 18:15:16 +00:00
Sunil Ravi
abb157f297 Merge "wifi: Skip SetStrictConversativePeerMode VTS test" into udc-dev 2023-04-17 18:38:55 +00:00
Sunil Ravi
974a74d896 wifi: Skip SetStrictConversativePeerMode VTS test
SetStrictConversativePeerMode HAL API is added in
AIDL version 2. So if the HAL interface version is
less than 2, skip the test.

Bug: 278169264
Bug: 277318919

Test: atest VtsHalWifiSupplicantStaNetworkTargetTest
Change-Id: I7f8ace88b0f37679ecaedd5370b47e220c437d50
2023-04-15 01:10:46 +00:00
Yuyang Huang
b37f9a8a83 Add @VsrTest annotation to Apf test
Bug: 259309511
Test: atest VtsHalWifiStaIfaceTargetTest
Change-Id: I860e7bff6a31ae7871a6041ab76c2c685b7c8c38
2023-04-14 12:26:32 +09:00
Gabriel Biren
72235e8d40 Merge "Use the default SAP interface name in VtsHalWifiHostapdV1_2TargetTest." into udc-dev 2023-04-13 15:15:47 +00:00
Gabriel Biren
282c8312bf Use the default SAP interface name in
VtsHalWifiHostapdV1_2TargetTest.

Test currently sets up a new interface
and uses that interface's name. On Pixel,
the new interface is wlan1, which does not
seem to support the OpenAccessPointWithoutAcs
configuration. However, the default SAP
interface wlan0 does support it.

The method to get the default interface name
is taken from this file before ag/19202002
was merged.

Bug: 270509029
Test: atest VtsHalWifiHostapdV1_2TargetTest
       (on a Bramble device running rvc-qpr3-release)
Change-Id: Ic3c516f452dfb54f155246073a9bca20dbecaa0f
2023-04-12 21:33:50 +00:00
Gabriel Biren
f5c86e53bf Merge "Acquire the global lock when the dump method is called." into udc-dev 2023-04-12 20:06:12 +00:00
Xiao Ma
e238106742 Merge "Update the setDtimMultiplier aidl API documentation." into udc-dev 2023-04-12 00:46:17 +00:00
Xiao Ma
9acf79f7ad Update the setDtimMultiplier aidl API documentation.
Update the aidl API documentation to describe how setDtimMultiplier API
is supposed to work, i.e. we can call this API to set a maximum DTIM
multiplier value to use in driver, any larger value must not be accepted
and meanwhile it allows to set a specific multiplier by OEMs. Try to
make the description clear and avoid the ambiguity.

Bug: 266256943
Test: m
Change-Id: Ic7d2284a25e32d1b0752cf2bc832c069f646fcea
2023-04-11 15:03:51 +09:00
Alex Buynytskyy
1deeb7fabf Merge "UpsideDownCake is now 34" into udc-dev 2023-04-11 01:17:33 +00:00
Gabriel Biren
57896d2a1c Acquire the global lock when the
dump method is called.

This should prevent a race condition
between stop() and dump().

stop() already acquires the global lock
when it calls validateAndCall().

Bug: 274641043
Test: adb shell dumpsys wifi # validates dump()
Change-Id: Ie2df0861308954cd2e399c9604d4ae0dcddf95fb
2023-04-10 23:47:45 +00:00
Gabriel Biren
3af3d5bd13 Merge "Do not check the returned value in the VTS test for IWifiChip#getFeatureSet." into udc-dev 2023-04-10 20:00:09 +00:00
Alex Buynytskyy
ec1198d941 UpsideDownCake is now 34
Ignore-AOSP-First: UpsideDownCake Finalization
Bug: 275409981
Test: build
Change-Id: I832ab7a8b5445ba85e27bbcf5be64906bfa0e5be
2023-04-07 23:41:20 +00:00
Gabriel Biren
90059381f0 Do not check the returned value in the
VTS test for IWifiChip#getFeatureSet.

Some implementations of the legacy HAL,
such as Goldfish, do not have any
supported features.

Bug: 273886122
Test: atest VtsHalWifiChipTargetTest
       (tested on Cuttlefish)
Change-Id: I3ca22187cab0e77d36a28908e57ff4970535e4ae
2023-04-07 23:30:54 +00:00
Gabriel Biren
7b65166e33 Remove HIDL implementation for the WiFi
Vendor HAL.

Bug: 274964641
Test: Treehugger builds.
Change-Id: I0198870790077f1ca03c663d58aac53eb4a64b83
2023-04-06 21:01:59 +00:00
Yuyang Huang
1096ca0ed2 Merge "Add VTS to cover the APF VSR requirement since U" into udc-dev 2023-03-28 03:57:02 +00:00
Yuyang Huang
e6396ba7ba Add VTS to cover the APF VSR requirement since U
Since Android U, VSR 5.3.12 mentioned the Android Packet Filtering must
be supported by CHIPSETs and DEVICEs launching on Android 14 or higher.
This VTS was added to check if APF is supported properly.

Given the limitation of the VTS testing environment, the first version
of the test case only checks: if the APF is supported by WiFi chips with
version 4 and more than 1024 bytes of usable memory.

Bug: 259309511
Test: atest VtsHalWifiStaIfaceTargetTest
Change-Id: I3ee2a980a4440db232738a23c1633aaff3562d95
2023-03-27 10:54:44 +09:00
TreeHugger Robot
8712639df1 Merge "Update comment for the INonStandardCertCallback to indicate how certificates are added." into udc-dev 2023-03-23 18:38:15 +00:00
Gabriel Biren
a3b22e5a72 Update comment for the INonStandardCertCallback to
indicate how certificates are added.

Bug: 267819850
Test: m
Change-Id: I896bf68138b93a97c843699d69bac193e7ee1523
2023-03-23 00:23:20 +00:00
Ye Jiao
2dc47ca925 Add config to skip state toggle off/on for Wi-Fi NAN
If STA and NAN share the same iface wlan0, Wi-Fi vendor HAL service
sends eventDisabled to NAN framework when STA setMacAddress to wlan0.
This disables NAN when STA is turned on.

Since NAN always uses its own random MAC instead of using MAC of STA,
this action is not necessary and gets NAN kicked off for no benefits.

We add a build time configuration to optionally disable this behavior.

Bug: 273426515
Test: manually test

Change-Id: Ifc71b7e8d09eac1b66b9e18c70e0e6d202683ff6
2023-03-21 18:13:18 +00:00
Gabriel Biren
ad659e2829 Merge changes from topic "supplicant-fixed-size-arrays" into udc-dev
* changes:
  Use fixed-size arrays for any arrays added in V2 that expect a pre-set size.
  Disable linter in the Supplicant interface Android.bp file.
2023-03-17 16:11:11 +00:00
Oscar Shu
e07c69786d Merge "Update setAfcChannelAllowance" into udc-dev 2023-03-16 23:40:24 +00:00
Gabriel Biren
da640d66b2 Use fixed-size arrays for any arrays added in
V2 that expect a pre-set size.

Bug: 273964536
Test: m
Change-Id: Iab1239484bfc7fd61834118e5a9e1999cab194ad
2023-03-16 23:33:11 +00:00
Gabriel Biren
fb8b891a36 Disable linter in the Supplicant interface
Android.bp file.

This allows us to use fixed-size arrays
in the interface.

Bug: 273964536
Test: m
Change-Id: Ic1a0c5ce5360e787e1664ed855e2642d22be7148
2023-03-16 23:31:08 +00:00
Oscar Shu
4275c8793c Update setAfcChannelAllowance
Use a new structure to passdown:
- AFC information queried based on frequency
- AFC information queried based on channel number
- expiration time

This change is per chip vendor request. Based on AFC server support,
either frequency based information or channel based information may be
empty. If both are empty, then it indicate the driver should not allow
any standard power transmission on 6Ghz.

Bug: 262791660
Test: compile
Test: Manually verified information is passed down with local framework
change

Change-Id: Id1d014a6113f6863b98ef8239a5a52d3863aa758
2023-03-16 18:55:54 +00:00
Gabriel Biren
0d841ae812 Add comment to the Vendor HAL Android.bp file to
explain why the linter is disabled.

If the linter were enabled, we would run into a
build failure because fixed-size arrays are not
supported on SDK Level < 33. The interface indicates
min_sdk_version 30 due to mainline requirements,
but the interface will only be accessed by devices
running Android U.

Bug: 267819850
Test: m
Change-Id: Ifed2223d1c5f4bf46329ed72fa622b730e99cde1
2023-03-16 17:24:51 +00:00
Gabriel Biren
c939532af1 Merge "Remove deprecated method getValidFrequenciesForBand from IWifiApIface and IWifiStaIface." into udc-dev 2023-03-15 17:24:54 +00:00
Gabriel Biren
04bf5bd30c Merge changes from topic "rename-get-chip-caps" into udc-dev
* changes:
  Rename getCapabilities to getFeatureSet in the Vendor HAL implementation.
  Rename getCapabilities to getFeatureSet in IWifiChip and IWifiStaIface.
2023-03-15 16:51:00 +00:00
Gabriel Biren
a224caede2 Merge "Remove unused method removeAllQosPoliciesForScs from the Supplicant interface." into udc-dev 2023-03-13 16:16:14 +00:00
Cole Faust
e76cbec982 Baseline NewApi issues
NewApi was recently updated to support linting methods in
the system, module_lib, and system_server sdks, and was
demoted to a warning due to the new issues it finds.
Baseline all the new issues that NewApi can be made an error
again.

These cls were generated automatically by a script that
copied the NewApi issues from the reference baselines.

Bug: 268261262
Test: m lint-check
Change-Id: I22f3b3575b6ea00d72d143019d9eed028aa98b56
2023-03-09 14:20:10 -08:00