Commit graph

435 commits

Author SHA1 Message Date
Jeff Pu
c6f2146a2e Added temporary-lockout timer support
Bug: 294096426
Test: Manual
Change-Id: I7d11b28697021ee21abae7c01ff393e4154ee9a4
2023-08-04 15:27:42 +00:00
Jeff Pu
5055e3cb07 HAT validity check should be performed early
in enrollment HAL operation.
Bug: 293206206
Test: atest --no-bazel-mode VtsHalBiometricsFingerprintTargetTest

Change-Id: I223615bbbd86d3f918f976c0d46e9ee93338f2a8
2023-07-27 12:44:02 -04:00
Jeff Pu
8fec556d25 Authentication state stays on enrollment mismatch
Bug: 291778822
Test: atest FakeFingerprintEngineTest
Change-Id: I4566303af982855aa0ebc52652464fb116a23858
2023-07-20 13:51:34 +00:00
Jeff Pu
073af1802e Update fingerprint VHAL operation lifecycle
Bug: 289410175
Test: atest FakeFingerprintEngineTest
Change-Id: I6da68047be9bf5357c1b4c75ba28fc66c2e3bcc0
2023-07-17 13:23:47 +00:00
Jeff Pu
437516ea3a Inform framework of lockout right when the failed attempts reaches threshold
Bug: b/277780293
Test: atest FakeLockoutTrackerTest
Change-Id: Iefe88f3ab492773844b18c525ddbf37218227256
2023-06-28 15:22:44 +00:00
Jeff Pu
fd1e1e58fc Merge "Simulate finger touch with virtual fingerprint hal" into udc-qpr-dev 2023-06-21 17:28:36 +00:00
Jeff Pu
0e4f9eb2aa Remove the workaround of extra enrollment for the fixed b/243129174
Bug: 284475725
Test: atest BiometricsE2eTests
Change-Id: I92a2153d45e01543dcfdccf131905b6fd557fb34
2023-06-15 17:36:58 +00:00
Jeff Pu
def5b04848 Simulate finger touch with virtual fingerprint hal
Bug: 277780272
Test: atest BiometricsE2eTests
Change-Id: I9330b3eeca52321c59d0af63782d38cd3b5f901f
2023-06-14 15:08:57 +00:00
Jeff Pu
30925ee9a4 Merge "Close the session if Fingerprint servers die" into udc-dev 2023-05-08 19:21:19 +00:00
Jeff Pu
87e9f2bebe Close the session if Fingerprint servers die
by registering the death notification of the associated binder.
Bug: 273807765
Test: adb shell stop;adb shell start

Change-Id: Ifc60e68fdbf986a355f828a7fc11f2aecee4cbea
2023-05-05 14:14:57 +00:00
Diya Bera
8200cff2e4 Adding owners
Test: N/A
Bug: 278741020
Change-Id: I586787a31cab0d32d14d43f5f84ceb1e14087aa4
2023-04-18 17:55:17 +00:00
Joshua Mccloskey
4803c70715 Merge "Updated aidl doc w/ regard to lockout." into udc-dev 2023-04-11 23:15:22 +00:00
Alex Buynytskyy
ec1198d941 UpsideDownCake is now 34
Ignore-AOSP-First: UpsideDownCake Finalization
Bug: 275409981
Test: build
Change-Id: I832ab7a8b5445ba85e27bbcf5be64906bfa0e5be
2023-04-07 23:41:20 +00:00
Joshua McCloskey
0716d7d56b Updated aidl doc w/ regard to lockout.
Test: N/A
Bug: 250071647
Change-Id: I774640b6f7a3f6397b6acbdb48c8ab14c6001a12
2023-03-13 22:19:28 +00:00
Diya Bera
4c580ff731 Merge "Adding POWER_PRESS to AcquiredInfo.aidl and Error.aidl" into udc-dev 2023-03-02 02:06:52 +00:00
Joe Bolinger
5698405873 Add display state and authenticate reason to biometric AIDL interface.
Bug: 268295421
Test: N/A
Change-Id: Ifc643457a4e61149721a38938f8e20976b54cf56
2023-02-23 00:27:06 +00:00
Diya Bera
34dc8bfe51 Adding POWER_PRESS to AcquiredInfo.aidl and Error.aidl
Test: N/A
Bug: 269293986
Change-Id: If2e2a1c0f48d86c427a0c8f93f077c940c3eb8d8
2023-02-21 22:44:33 +00:00
Austin Delgado
88ded642f2 Update fingerprint AIDL for Android U
1. Adds sensor shape and touch detection configuration.
2. Adds onPointerCancelWithContext and setIgnoreDisplayTouches.
3. Adds LIFT_TOO_SOON constant to AcquiredInfo.
4. Deprecates SensorLocation displayId, onPointerDown, and onPointerUp.

Bug: 266476972
Test: m android.hardware.biometrics.fingerprint-update-api
Test: built locally
Change-Id: I3aae3c7f8a65d5805f3dd583330407c255ca1369
2023-02-17 21:30:26 +00:00
Jeff Pu
ebb2b746ce Make virtual fingerprint HAL as lazy HAL
Bug: 262630839
Test: atest VtsHalBiometricsFingerprintTargetTest
Change-Id: I8f17f00d3e91554fcfb99c8b478ed8b6131b4530
2023-02-13 18:00:25 +00:00
Joe Bolinger
f3661ff85c Add wake reason to OperationContext.
This additional metadata can optionally be used by the HAL to make optimizations when an operation is started.

Bug: 246363169
Test: N/A (builds)
Change-Id: I493cba04f54d09f976b31a68661a18397af02ce9
2023-02-03 21:58:30 +00:00
Jeffrey Vander Stoep
c5d5b7d4ea Revert "Make virtual fingerprint Hal as a lazy Hal"
This reverts commit 93e97f94b6.

Reason for revert: b/263519851

Change-Id: I24a9921c806013c5a50bb0674690b67beca172f0
2022-12-23 11:28:28 +00:00
Jeff Pu
93e97f94b6 Make virtual fingerprint Hal as a lazy Hal
so that the Hal service can start dynamically as needed
by vts test and others

Bug: 262630839
Test: atest VtsHalBiometricsFingerprintTargetTest:IFingerprint/Fingerprint
Change-Id: I58dfa3b49bade3bbd89c3a8f6cd884c632e9eae4
2022-12-20 21:04:54 +00:00
Steven Moreland
65ee297ef9 Merge "Mark modules frozen explicitly." 2022-12-12 18:27:49 +00:00
Steven Moreland
edff13e314 Mark modules frozen explicitly.
Makes it easier to see which versions are available.

Bug: 188871598
Test: N/A
Change-Id: Ica76a8225fec8dc5267362cbfd43e06e65ad3f1e
2022-12-08 18:02:08 +00:00
Jeff Pu
9c1be5a0e1 Add virtual fingerprint HAL child process based on demand
Bug: 244854670
Test: Manual
Change-Id: I403de4cc334aae8e888da064d9064ebe283bf572
2022-12-07 14:52:47 +00:00
Jeff Pu
b27153df09 Streamline OWNERS file under hardware/interfaces/biometrics
Bug: 259997419
Test: N/A
Change-Id: Ie435c70566267f9ff4a4b9474d41c5b625fc6b74
2022-11-28 14:12:28 +00:00
Ilya Matyukhin
8453178f18 Add @hide to the biometric interfaces
This change allows the framework to depend on biometric AIDL types, for
example: `android.hardware.biometrics.fingerprint.PointerContext`.

The dependency can be introduced with a `-java-source` target, for
example: `:android.hardware.biometrics.common-V3-java-source`.

The "@hide" annotation informs Metalava that these types are not a
public API (not part of the SDK).

Bug: 218388821
Test: m android.hardware.biometrics.common-update-api
Test: m android.hardware.biometrics.face-update-api
Test: m android.hardware.biometrics.fingerprint-update-api
Change-Id: Ib3327594c64dbb800b9d1744869ceb490d63e553
2022-11-18 06:37:09 +00:00
Jeff Pu
5265318938 Fingerprint virtual HAL checkin (part 3)
- support randomization
- display touch events
- lockout
- cmd and dumpsys

Bug: 230515082
Bug: 230515086
Test: atest FakeFingerprintEngineTest
      atest FakeFingerprintEngineUdfpsTest
      atest --no-bazel-mode VtsHalBiometricsFingerprintTargetTest

Change-Id: Ia5399c86b7fec90b41d426c2f82cb257f4dc9a8a
2022-11-11 13:06:32 +00:00
Jeff Pu
343ca94b13 Fingerprint virtual HAL checkin (part 2)
- acquiredInfo support for HAL operations
- error insertions
- FPS configurations

Bug: 230515082
Bug: 230515086
Test: atest FakeFingerprintEngineTest
      atest FakeFingerprintEngineUdfpsTest
      atest --no-bazel-mode VtsHalBiometricsFingerprintTargetTest

Change-Id: Iedd1056e516358c3c0a99bd4a720016cc0f880e4
2022-10-06 23:03:11 -04:00
Jeff Pu
63f33c79a2 Fingerprint virtual HAL checkin (part 1)
- udfps and side fingerprint sensor instance
- sensor location configuration
- misc. fixes/workarounds

Bug: 230515082, 230515086
Test: atest FakeFingerprintEngineTesT
      atest FakeFingerprintEngineUdfpsTest
      atest --no-bazel-mode VtsHalBiometricsFingerprintTargetTest
Change-Id: I9bec76496b35029cab4561d0d4ea85a78bec589a
2022-08-19 10:46:32 -04:00
Trevor Radcliffe
c088612eb2 Point directly to generated c sysprop_library
Supports aosp/2119952

Bug: 226199990
Test: m
Change-Id: Ifa5725abda911f2ea4d4951d41ac54fe703ae31b
2022-06-14 20:02:44 +00:00
Jeff Pu
0fe3730e7b Add team members to OWNER file
Bug: N/A
Test: N/A
Change-Id: I3e16a978624672515699eb2c99942ab7ed78a6e8
2022-05-24 23:35:18 +00:00
Joshua McCloskey
db009a58cb Add virtual Face HAL
Fixes: 230514750
Test: atest VtsHalBiometricsFaceTargetTest
Test: atest VtsHalBiometricsFingerprintTargetTest
Test: atest android.hardware.biometrics.face.FakeFaceEngineTest
Test: atest android.hardware.biometrics.face.FakeFingerprintEngineTest
Test: See README.md
Test: Verified that face and fingerprint get reset upon authenticating.

Change-Id: I57c1a61bec960e3be28736e6050be662ef412d8c
2022-05-16 19:34:12 +00:00
Joshua McCloskey
c8c0bad864 Refactored biometric libraries into common
Test: atest
Bug: 230514750
Change-Id: I47ad020004ffef9646281611a637e1a5208f5573
2022-05-13 21:18:10 +00:00
Keith Mok
85aebe3ee2 Fix fingerprint aidl race condition then thread is join
Even if the shared variable is atomic, it must be modified under the
mutex in order to correctly publish the modification to the waiting
thread.

There is a chance that mThread will miss both mIsDestructing
and notify event without a mutex.

Bug: 231737939
Test: manual
Change-Id: If83a94b766c816b9e4897acb1e89eacdce880c15
2022-05-07 01:28:57 +00:00
Raju Kulkarni
d3f71ca6fb Merge changes from topic "aidl-freeze-tm" into tm-dev am: c13dea1094 am: 289d5bc4e4
Original change: https://googleplex-android-review.googlesource.com/c/platform/hardware/interfaces/+/17983786

Change-Id: I76f293dabffc1e2eddefdf3359373e1d6663e245
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-04-29 19:27:40 +00:00
Joe Bolinger
938c07ce5a Merge "Declare example HAL as virtual instance." 2022-04-29 00:03:46 +00:00
Joe Bolinger
3041e526de Declare example HAL as virtual instance.
Bug: 228638448
Test: manual (see README.md)
Change-Id: I4c00b9e394eb7863416b61662528869f7e70c09d
2022-04-28 11:24:30 -07:00
Jiyong Park
36e00b0741 Finalize V2 of android.hardware.biometrics.common
It was missing in the prior attempt to finzalize all AIDL interfaces.

Bug: 230660133
Test: m nothing
Change-Id: Icc319c84d57639ce083730a8bf15957e3ab7fe1d
2022-04-28 08:48:50 +09:00
Tim Murray
f6e30c4a2b Fix WorkerThreadTest am: 712f48c217 am: 310257bdc6
Original change: https://googleplex-android-review.googlesource.com/c/platform/hardware/interfaces/+/17845136

Change-Id: I033df4b08a316196259dcd5567cbe59131e88e6e
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-04-20 06:04:13 +00:00
Tim Murray
712f48c217 Fix WorkerThreadTest
Queue capacity needs to be NUM_TASKS + 1 for the extra final cv.notify
at the end.

Test: atest --host --rerun-until-failure 1000 WorkerThreadTest
Bug: b/229801892
Change-Id: I95eb07680fe80cfc3bfafaa2de81c48d61d14b4b
2022-04-20 03:33:16 +00:00
Joe Bolinger
de94aa0354 Add rear fps virtual HAL.
Bug: 228638448
Test: atest FakeFingerprintEngineTest
Test: manual (see README.md)

Change-Id: Ifecf6b5667352eb2127f820bfde47c7d325ab1b2
2022-04-12 17:13:24 -07:00
Jiyong Park
703e97920e Freeze AIDL APIs for TM
Bug: 225941299
Test: m
Change-Id: Ie41cc0797710f813f92c65c387f247c7806d8394
2022-03-31 12:01:39 +09:00
Joshua Mccloskey
dba89696b0 Updated Face AIDL createSession docs
Test: N/A
Bug: 219081263
Change-Id: I05af5a64ca9275932a026ed43e2061e7fd51d247
2022-03-14 18:16:22 +00:00
Chih-hung Hsieh
34593d4e2a Merge "Add timed out test files to tidy_timeout_srcs" am: ff54f73b4f am: fa83970b3a am: 581616e658
Original change: https://android-review.googlesource.com/c/platform/hardware/interfaces/+/1992232

Change-Id: I2eac13fe3b5ab0b4f15d6ceadf376e5e74124a81
2022-02-24 01:32:09 +00:00
Chih-Hung Hsieh
ad1bf31b78 Add timed out test files to tidy_timeout_srcs
* Timed out runs do not show any warning messages.
* These test files cannot finish clang-tidy runs with
  the following settings:
    TIDY_TIMEOUT=90
    WITH_TIDY=1
    CLANG_ANALYZER_CHECKS=1
* When TIDY_TIMEOUT is set, in Android continuous builds,
  tidy_timeout_srcs files will not be compiled by clang-tidy.
  When developers build locally without TIDY_TIMEOUT,
  tidy_timeout_srcs files will be compiled.
* Some of these test modules may be split into smaller ones,
  or disable some time consuming checks, and then
  enable clang-tidy to run within limited time.

Bug: 201099167
Test: make droid tidy-hardware-interfaces_subset
Change-Id: I1de28f1572fff368f67eab512fffec9f2e5c2a9b
2022-02-18 17:25:41 -08:00
Ilya Matyukhin
f6e0f39cde Add new fields to fingerprint PointerContext
The new fields provide additional information to the HAL about the touch
events originating from the framework.

Bug: 205915651
Test: m android.hardware.biometrics.common-update-api
Test: m android.hardware.biometrics.fingerprint-update-api
Test: lunch cf_x86_phone-userdebug && m
Change-Id: I987e26ac03e3268eea30feb9bbddffe6ca8d0035
2022-02-07 16:05:32 -08:00
Steven Moreland
22c5b64894 -= src_available (internal)
Default now. To Remove.

Bug: 215754978
Test: N/A
Change-Id: Ie83df828ea2ec892c6586ffa32e9f6c42d83a2fe
2022-01-31 19:52:35 +00:00
Joe Bolinger
25e9823f63 Add update context method to face and fingerprint HAL.
This is needed for changes that occur mid-operation and was lost
from the previous changes when switching from the single context
method to the overloaded approach.

Bug: 204584403
Test: atest VtsHalBiometricsFingerprintTargetTest VtsHalBiometricsFaceTargetTest

Change-Id: Ie917bce9de910a421e19130b6e518bd6fc85298e
2022-01-25 01:19:56 +00:00
Joe Bolinger
7bd42e1b14 Update common and face AIDL for session logging.
Bug: 204585936
Bug: 204584403
Test: atest VtsHalBiometricsFaceTargetTest
Change-Id: Icba064c5c48f808327323ab64b7b63f68737a2f8
2022-01-12 16:29:35 -08:00