Commit graph

130 commits

Author SHA1 Message Date
Steven Moreland
84dd3b7496 Add AIDL Lights HAL to support multiple lights per type
This is a revision of the previous 2.0 HIDL-based light HAL.
It accomplishes 2 goals:
 1) Support more than 1 light for a given type. This allows Assistant to
    use the HAL on TV platforms that have usually 4 indicator lights.
 2) Use AIDL, which is the more modern way of writing HALs.
The previous HAL is in hardware/interfaces/light/2.0 and the new one is
in versioned as aidl, as that supports forward compatibility.

Test: atest VtsHalLightTargetTest
Bug: 142715294, 142230898
Change-Id: I6d8c12b3df88e02f2a0fff8b6aa8543372b510c8
Merged-In: I08d831ca0380d8bb187e43f6d5c214810ff72f50
2020-02-07 01:50:36 +01:00
Dan Shi
0e1efc568c Merge "Add VtsHalLightV2_0TargetTest and VtsHalNeuralnetworksV1_* to vts-core" 2019-10-14 15:35:48 +00:00
Dan Shi
4856370e54 Add VtsHalLightV2_0TargetTest and VtsHalNeuralnetworksV1_* to vts-core
Bug: None
Test: None
Change-Id: I3fbbba0dc283bec2de025f0b743d97ded5874bf9
2019-10-10 13:45:43 -07:00
Dmitry Shmidt
34ed38743e light: Allow blank_screen utiltiy to get color from command line
Bug: 142058809
Test: blank_screen 0xFFFFFFFF

Change-Id: I4efdaaa2397b076e5699a75852bb15bfb1f6c5f8
Signed-off-by: Dmitry Shmidt <dimitrysh@google.com>
2019-10-07 16:33:06 -07:00
Steven Moreland
b3a4d3832e Remove libhwbinder/libhidltransport deps
Since these were combined into libhidlbase.

Bug: 135686713
Test: build only (libhwbinder/libhidltransport are empty)
Change-Id: I075670b64eebbbbd6a6ae0e84ad51bf1c6f5ba36
2019-09-06 01:07:02 +00:00
Steven Moreland
022cda0236 Lights: parameterized VTS tests.
Bug: 139437880
Test: run VtsHalLightV2_0TargetTest as gtest
Change-Id: I43e8f43583e0ad5fc560c3ee2129305396751e29
2019-08-21 15:46:02 -07:00
Steven Moreland
1ae4615d9f Update hidl makefiles for bpfmt
hidl-generated makefiles are now generated such that bpfmt(file) == file.

Bug: 67417008
Test: enable bpfmt hook
Change-Id: I1f69d292bc23a7cc293a66110cb02d597e1019ad
2019-04-17 09:38:50 -07:00
Steven Moreland
a878aee9ab Update makefies: no 'types'
Bug: 123976090
Test: N/A
Change-Id: I30fb04c81889b62775e1b764b965fdb0f893de17
2019-03-04 11:27:17 -08:00
Peter Kalauskas
45c1dd8160 Add lazy service target to the light HAL
This change allows a device to include the lazy service implementation,
which will allow the HAL to exit when it is not in use.

Test: Manually observe brightness slider behavior
Change-Id: I7f8f747ebe6e183e1aaf1406852e6e26a97aee35
2019-01-23 15:29:05 -08:00
Keun Soo YIM
68ae05dd2d pack VTS cc_test binaries as general-tests
Test: make general-tests
Bug: 120093339
Merged-In: I363450d205868f900e4925ccff1430e2a569f2a4
Change-Id: I363450d205868f900e4925ccff1430e2a569f2a4
2018-12-07 10:49:56 -08:00
Steven Moreland
44c01c0883 Revert "blank_screen: always exit with _exit()."
This was a temporary workaround in Android P, but it is fixed
with a relatively more dangerous change in libhwbinder.

This reverts commit 73ba34f1b7.

Bug: 77934844
Test: reboot device and watch for screen to get shutdown, check logs

Change-Id: I970144eea4acd8254f4a67ebe803f3c3eda9aba2
2018-05-25 00:38:14 +00:00
Steven Moreland
73ba34f1b7 blank_screen: always exit with _exit().
Delay starting the threadpool until necessary,
and once started, always exit with _exit().

Bug: 77934844
Test: screen is blanked on reboot
Change-Id: I7715d889a6f78b9ce058fb3841ef7944116d8e82
2018-05-22 15:23:41 -07:00
TreeHugger Robot
ebc5e9a5ea Merge "blank_screen: shut off all lights" into pi-dev 2018-03-16 19:39:05 +00:00
Steven Moreland
04f859a9b9 blank_screen: shut off all lights
This is used to make the phone appear off by init
during late boot (e.x. fsck for disk health), so
it should shut off all lights (not just the screen).

Bug: 74976325
Test: blank_screen
Change-Id: I790cc3dd856c2c2095fa3cf82519fd30834304ca
2018-03-16 10:31:07 -07:00
Steven Moreland
59dbae92ed light service: mark as shutdown critical
Required because the lights need to be turned off late in boot
(e.x. during fsck for disk health), and before, blank_screen
accessing light encountered a race condition where if it didn't
get scheduled before all of the processes which were getting
shutdown were getting killed, the screen wouldn't blank.

Bug: 74976325
Test: adjusting brightness continues to work
Test: screen blanks during shutdown at the correct time
    including when an artificial 5s delay is inserted when
    the phone normally fscks (which can also be quick)

Change-Id: I57ebc11d7ecf57ee327c681455712f4b53de6fd3
2018-03-16 17:26:21 +00:00
Zhuoyao Zhang
d8f7fd48ea Merge "Convert light hal test to use VtsHalHidlTargetTestEnvBase" am: c4c77e570e am: 923bbc8934
am: 6a773b9a7c

Change-Id: I0c4ca12e6de262660a0b47d0098ee3b314c4f8a4
2018-02-13 22:44:51 +00:00
Zhuoyao Zhang
0f6e77caad Convert light hal test to use VtsHalHidlTargetTestEnvBase
Bug: 64203181
Test: make vts
      vts-tradefed run vts -m VtsHalLightV2_0Target

Change-Id: I76eaac300697e25739c7ea0d2fb07b5b005a3040
2018-02-10 12:41:49 -08:00
Steven Moreland
4afb529f4c Merge "Remove unnecessary group from blank_screen." am: 7b9e7c3f4b am: a3dfa8acc3
am: c0404b5a86

Change-Id: I4d6eeb9b1465f3b5b9b902c50f9c050985cb4168
2018-01-24 02:34:41 +00:00
Steven Moreland
efab822141 Remove unnecessary group from blank_screen.
Was accidentally copy-pasted here.

Bug: N/A
Test: setprop ctl.start blank_screen
Change-Id: I0b100b02aecd2649f2528834f431a0bc8b164c46
2018-01-23 15:15:40 -08:00
Steven Moreland
35535bdd39 Add 'blank_screen' util. am: 64a7afb07e am: 30cb8c1b79
am: a2dc32bd29

Change-Id: I4bf96f1c14cea91a504e2f425aa7281afb08b7f1
2018-01-22 20:43:34 +00:00
Steven Moreland
64a7afb07e Add 'blank_screen' util.
This can be transitioned to by init to shutdown the
screen thereby preventing init from either depending
on binder or accessing halified sysnodes directly.

Bug: 70846424
Test: manual + init use
Change-Id: I86893ee5d7118547cd073297c0626e474f366b82
2018-01-19 13:09:32 -08:00
Steven Moreland
5d4dc1b81e Add interface specification for lights hal.
So that init knows how to start it and to provide
an example of how to specify interfaces since there
are no lazy starting services on Pixel yet.

In order to make lights a lazy service, it would also
have to be marked as 'oneshot'.

Test: manually using Light as a lazy service
Bug: 64678982
Change-Id: I846a7e2d9545b42af9b985adb74883bda1b8c355
2018-01-05 10:16:34 -08:00
Steven Moreland
98ca764006 Add interface specification for lights hal.
So that init knows how to start it and to provide
an example of how to specify interfaces since there
are no lazy starting services on Pixel yet.

In order to make lights a lazy service, it would also
have to be marked as 'oneshot'.

Test: manually using Light as a lazy service
Bug: 64678982
Merged-In: I846a7e2d9545b42af9b985adb74883bda1b8c355
Change-Id: I846a7e2d9545b42af9b985adb74883bda1b8c355
2018-01-05 18:15:25 +00:00
Steven Moreland
7de4288e6d Merge "Add debug output for lights." am: 25ccf20c8c am: ba7d14198b
am: 711ea3501a

Change-Id: Ib37c58aeb9aa13542ae730426cc7c4e2ae39e19c
2017-12-22 22:02:12 +00:00
Steven Moreland
b0c20e99a1 Add debug output for lights.
As an example and also to expose which lights are
registered easily. Note, this is all the information
that we can print given the libhardware lights interface.

Bug: 70846424
Test: lshal debug
Change-Id: I5f55e3e64149fc63a45ab9dab94d5fea27bb61da
2017-12-20 14:51:47 -08:00
Steven Moreland
63ad003de6 Cleanup Lights Android.bp am: fabe9e4bef am: 1617ee8132
am: b31e72c574

Change-Id: Ia2bf7eae93ae3252339b55de7b0080a04d808625
2017-12-19 19:28:59 +00:00
Steven Moreland
fabe9e4bef Cleanup Lights Android.bp
Test: none
Change-Id: I3c5156a75a044c67f41878e880dece730ed7158f
2017-12-19 01:57:03 +00:00
Steven Moreland
4025af9e81 Light mk -> bp.
Test: boots
Merged-In: I15c4779a7c9eea39fb20746f69800dcf20670275
Change-Id: I963b957491575edbf68727ad4c97b733dceb0149
2017-12-19 01:56:10 +00:00
Treehugger Robot
adf8208c52 Merge "Remove subdirs" 2017-11-29 17:53:33 +00:00
Steven Moreland
7b9888217e Remove subdirs
Removing whenever I see these in code reviews.

Test: none
Merged-In: I4322f533a837d55618ec2ed2125e8966ace9d61d
Change-Id: I4322f533a837d55618ec2ed2125e8966ace9d61d
2017-11-28 17:19:46 -08:00
Steven Moreland
fcca4e23b7 Remove subdirs
Removing whenever I see these in code reviews.

Test: none
Merged-In: I4322f533a837d55618ec2ed2125e8966ace9d61d
Change-Id: I4322f533a837d55618ec2ed2125e8966ace9d61d
2017-11-28 14:22:43 -08:00
Chih-Hung Hsieh
1b275a2c41 Use -Werror in hardware/interfaces/light/2.0
Bug: 66996870
Test: build with WITH_TIDY=1
Change-Id: If922bef89eba554c37b74a574bb0a042cfad46c7
Merged-In: I15c4779a7c9eea39fb20746f69800dcf20670275
2017-11-28 17:13:03 +00:00
Steven Moreland
8db261bc99 Updating makefiles for hidl_interface.
Bug: 64487114
Test: manual
Merged-In: Ie13d9e014cf2b81c18c67f551b4644fb9f0ba812
Change-Id: Ie13d9e014cf2b81c18c67f551b4644fb9f0ba812
2017-11-13 10:00:18 -08:00
Steven Moreland
a1169dd600 Update makefiles for hidl_interface.
Bug: 35570956
Test: manual
Change-Id: I7a220b78ee081240e1dc30ef5672ba39e3e98375
2017-11-10 09:06:55 -08:00
Steven Moreland
1d7374c5e1 Update for Soong java makefiles. am: c3e80fa01e am: 0fff75dee1 am: 6c811964a1
am: 116161d94e

Change-Id: I33643636e2511de77fdf7de57777eb67edee2e52
2017-10-11 16:39:21 +00:00
Steven Moreland
c3e80fa01e Update for Soong java makefiles.
Test: pass
Bug: 33420795
Change-Id: Id9b1919a19b8ff682738cfb0869a479b4dbb4293
2017-10-10 23:07:20 +00:00
Steven Moreland
9b019ac4fe Merge "Remove useless Android.mk files." am: 75d5cf515a am: f27cfa15d7 am: 33dc30ce49
am: 0653f3b212

Change-Id: I7c2da3cf30da7b4a1eda7e5369e9caa5ebab2462
2017-10-05 21:52:50 +00:00
Treehugger Robot
75d5cf515a Merge "Remove useless Android.mk files." 2017-10-05 21:40:27 +00:00
Steven Moreland
4b60470f1a Remove useless Android.mk files.
These have been c/p'd all over the place.

Test: m -j nothing
Bug: 33420795
Change-Id: I77979866dbb2345a41a873c84ec3fccd7b127510
2017-10-04 15:52:40 -07:00
Steven Moreland
70bfb9d250 Merge "Update for hidl adapter module defaults." am: 988c977079 am: 861651985f am: b53e6ad535
am: 9a17f41f6f

Change-Id: I78d9292068b372238554fd9d35128e69f5b5f9d2
2017-10-04 21:54:11 +00:00
Steven Moreland
527fd76a0e Update for hidl adapter module defaults.
Test: pass
Change-Id: Idc6a943149a279bf17cfcfd0f2571473e53bbbbf
2017-10-04 12:47:03 -07:00
Steven Moreland
91799c6cc7 Merge "Fix typo in update makefiles." am: 9960148420 am: f07e364ce3 am: 71a193a425
am: 9fdd241905

Change-Id: I1c852fa6600fecc44d5afd1a65a5f51c43ecf71c
2017-09-27 00:02:52 +00:00
Steven Moreland
a5299ee739 Fix typo in update makefiles.
Bug: 37518178
Test: pass
Change-Id: Ic401b3a473f15ca4c01e58b3072e19db7c31b653
2017-09-26 21:59:43 +00:00
Steven Moreland
7741c0e17b Update makefiles for hidl adapter. am: 26a0bb2762 am: 73949c1d7e am: b94d0c7290
am: 97228c0b7d

Change-Id: Ic4b459b7c1a4325453945b0b00db8f44e4e77c26
2017-09-26 13:36:09 +00:00
Steven Moreland
26a0bb2762 Update makefiles for hidl adapter.
Bug: 37518178
Test: manual
Change-Id: I50e999907d3c64d2b039272b823971998da64d1b
2017-09-25 18:35:56 +00:00
Jaekyun Seok
81104ae5ef Add 'vendor.' prefix to a vendor HAL service name
To prevent property name collisions between properties of system and
vendor, 'vendor.' prefix must be added to a vendor HAL service name.
You can see the details in http://go/treble-sysprop-compatibility.

Test: succeeded building and tested on a walleye device
Bug: 36796459
Change-Id: I4e8fbee791ec917a8f627a1366f4d44ec7e6febc
2017-09-12 08:01:42 +09:00
Tri Vo
b65c5ceff2 VTS tests now static link to HAL def libs.
And use VtsHalTargetTestDefaults.
This is a partial cherry-pick of ag/2657080.

Bug: 64040096
Test: compiles, works fine in internal master
Merged-In: I8f6995e9536a9aefe283ee3effec9f5a7f03b620
Change-Id: I76d47d8546416b57055841851a9d343026cd3210
2017-08-25 11:48:10 -07:00
Steven Moreland
dfd8287506 Updating all makefiles.
Bug: 64487114
Test: none
Merged-In: I8608c8f636c35f21e4246a805a9eff6d14124e0a
Merged-In: I2fa89b6661c39859ec4fb62c4bb0a05a35e645f0
Merged-In: Ifdc3c17cb2b85c18b37dac2d03bb5c8935c23180
Change-Id: I170fa1c4fe39f8109b1670db58ef99bb11afc0be
2017-08-14 20:25:09 +00:00
Steven Moreland
6da35570df Updating all makefiles.
Bug: 64487114
Test: none
Change-Id: I8608c8f636c35f21e4246a805a9eff6d14124e0a
2017-08-10 23:43:46 +00:00
Tri Vo
2b2ba2fa83 Merge "VTS tests now static link to HAL def libs. #2" into oc-mr1-dev am: 2883486706
am: a6969cdd68

Change-Id: Iecd7cfd4e02aea837647e2f12446e7375744f004
2017-08-10 18:38:53 +00:00