Commit graph

482 commits

Author SHA1 Message Date
Shuo Qian
9d0f0635b9 Revert "Fixed VTS failure in no SIM case"
Since the EMERGENCY-type APN is a must set in the radio
setupDataCall request for modem to perform Emergency call,
and the given VTS test case does not set that emergency bit,
I think modem should treat the request as a normal call
request, and should not return "NONE" for no-sim.

This reverts commit 431eb118f8.

Reason for revert: after further discussion, NONE
is not acceptable given the test case.

Bug: 109767888
Change-Id: I3d1cc96120d53a9be0ae5059c26b091bf82dc352
Merged-In: I3d1cc96120d53a9be0ae5059c26b091bf82dc352
(cherry picked from commit 17fec3625d)
2018-08-02 17:16:36 +00:00
Amit Mahajan
8b833740b2 Allow NOT_SUPPORTED for setLinkCapacityReportingCriteria on GERAN.
Test: run vts -m VtsHalRadioV1_2Target
Bug: 110716988
Change-Id: I9a5f014d498db00d818870cbd73e119f66562ef1
(cherry picked from commit c7896501db)
2018-07-16 12:29:47 -07:00
sqian
0c3572e2f3 Fix missed refactor of serial
Bug: 109822806
Test: run vts
Change-Id: If88384699dbb4c2ddd1c580d2b35be38afd0f8e8
Merged-In: If88384699dbb4c2ddd1c580d2b35be38afd0f8e8
(cherry picked from commit c0e2e2b071)
2018-06-27 15:26:38 -07:00
Jack Yu
ac4e6051f9 Fixed VTS failure in no SIM case
Added RadioError::NONE as a possible return value for data call
setup API. The data call could be setup for emergency purposes
when no SIM inserted.

Test: VTS
Bug: 109767888
Merged-In: I4469c371f999b99d35f4078df000f05ee1f3c84d
Change-Id: I4469c371f999b99d35f4078df000f05ee1f3c84d
(cherry picked from commit 431eb118f8)
2018-06-27 18:10:08 +00:00
Eric Schwarzenbach
9589ee1c36 Call notify for voiceReg and dataReg VTS tests
Bug: 80554443
Test: vts
Change-Id: I19f7131f7b65323065f3c283a89668ff761815e3
Merged-In: I19f7131f7b65323065f3c283a89668ff761815e3
(cherry picked from commit 2bb626a297)
2018-06-26 10:39:37 -07:00
Treehugger Robot
a086c5c3a9 Merge "Add setIndicationFilter response notification in 1.2 VTS" 2018-06-25 22:46:51 +00:00
sqian
99260ce747 Add setIndicationFilter response notification in 1.2 VTS
Test: run vts
Bug: 109822806
Change-Id: I95102a148a26cab80235cc68ad83143a9bb6eb39
Merged-In: I95102a148a26cab80235cc68ad83143a9bb6eb39
(cherry picked from commit 0ff41b94b3)
2018-06-25 13:08:11 -07:00
Amit Mahajan
6a5c36d73f Allow REQUEST_NOT_SUPPORTED as an error for startNetworkScan
We are trying to tighten the APIs. However for this case since the
documentation was not updated, we are allowing NOT_SUPPORTED for
now and will be cleaned up in a later release.

Test: run vts -m VtsHalRadioV1_2Target
Bug: 110118713
Change-Id: Id9dd3d7bac99bed36ceb9c906189f1fea78d5a2c
(cherry picked from commit a7587b5a7f)
2018-06-25 11:39:04 -07:00
sqian
617c98b537 Add REQUEST_NOT_SUPPORTED for changeIccPinForApp and changeIccPin2ForApp
Bug: 110037298
Test: run vts -m VtsHalRadioV1_0Target
Change-Id: Iaba800814c5a6950d086a2f105714d01fdaa14a4
Merged-In: Iaba800814c5a6950d086a2f105714d01fdaa14a4
(cherry picked from commit 7470cbd04d)
2018-06-22 16:32:07 -07:00
Amit Mahajan
2c36d90716 Allow general errors for getImsiForApp().
This is to match it with other 1.0 tests where general errors are
allowed. For newer tests we have decided to not allow these errors,
but a failure for this old test is reported when run with SIM
present.

Test: run vts -m VtsHalRadioV1_0Target
Bug: 109889468
Change-Id: If36083b7832706a50805932e8ba08e4eb397f3fe
2018-06-14 17:18:38 +00:00
Steven Moreland
913c071391 Update comments for doc comments.
Doc comments look like "/** ... */" and they
can only be in certain places.

Bug: 79865343
Test: m
Change-Id: Ic15c08ff7dc6e4f9827c1dbe7f7236c11a572ec1
Merged-In: Ic15c08ff7dc6e4f9827c1dbe7f7236c11a572ec1
2018-05-21 14:36:29 -07:00
sqian
2a60b89b9c Sim Status Present VTS
Fix and enhance sim-present tests,
Save VTS running time,
Fix serial number inconsistancy issue

Fix and enhance sim-present tests:
In 1.0:
- setupDataCall timeout, need more waiting time
- requestIccSimAuthentication returns REQUEST_NOT_SUPPORTED,
need to check it
- sendSms timeout, would need more waiting time
- sendSMSExpectMore timeout, would need more waiting time
- getAllowedCarriers, getting CardState::RESTRICTED, the previous test
of setAllowedCarriers is doing resetting back to no carrier restriction,
but that needs some time to populate.
In 1.1:
- setSimCardPower_1_1 set sim card power down that makes other tests
fail, reset it back with sim card power on.

Save VTS running time,
- Use waiting loop and prevent unnecessary waiting to save the whole
running time.

Fix serial number inconsistancy issue
- During the enforcement running, it is liked the serial number is
not consistent. And it happens in b/78249227. Suspect that when sim
card is inserted, during the testing running time, the radio may
request some response that is not triggered from the test, but the
test may receive it and think it is what is triggered by the test. The
fix is to check serial number before notifying of unlock the test
lock.

Bug: 76125134
Bug: 78248071
Bug: 78139665
Bug: 78249227
Test: run vts -m VtsHalRadioV1_0Target; run vts -m VtsHalRadioV1_1Target
Change-Id: I08fe9d7ac16283c7ce1a5aeb6b3b372786a8d5c3
Merged-In: I08fe9d7ac16283c7ce1a5aeb6b3b372786a8d5c3
(cherry picked from commit 788eb80830)
2018-04-20 14:54:12 -07:00
sqian
031a6a87c9 Radio Sap 1.2 default implementation
Checked points:
- service is on
- vts can run on it
- provided a dummy implementation that a VTS test can pass it
- applied with recent update in radio 1.2 hal
- format repaired
- pass on a 1.0 VTS test, a 1.1 VTS test, and a 1.2 VTS test

Bug: 74114758
Test: run vts

Change-Id: I8a052e3cedb41db9028552ab88f1e26492718497
Merged-In: I8a052e3cedb41db9028552ab88f1e26492718497
(cherry picked from commit 0de4d31569)
2018-04-16 12:01:50 -07:00
sqian
7f3b78408c Fix Radio response/indication 1.2
Radio VTS client 1.2 radio response cannot be cast from radio response
in the service. To fix it, the client radio response and indication
should extend 1.2 IRadioResponse and IRadioIndication

Bug: 77815815
Test: ran it on the default service
Change-Id: Ib014af98d52d9f208d2139f4a239e9d61ea4d569
Merged-In: Ib014af98d52d9f208d2139f4a239e9d61ea4d569
(cherry picked from commit 79bafb943b)
2018-04-12 18:15:36 -07:00
Nathan Harold
d07b5895e0 Add a Test for RadioBandMode to Ensure Auto Mode
The radio band mode is perilous because depending
on the setting and the detected locale, other
settings may be disabled. That can leave the modem
in a soft-brick state. Thus, BandMode = 0 = AUTOMATIC
should always be supported so that the modem can
update and select a band mode of its choosing.

Bug: 28124606
Test: vts radio - getAvailableBandModes
Merged-In: I1f25d9125ef06d290e3a89b5d2162c6bfe939eba
Change-Id: I1f25d9125ef06d290e3a89b5d2162c6bfe939eba
(cherry picked from commit c9e391801ba5ccd24b41481b26c2861b71ef03d0)
2018-04-11 13:00:05 -07:00
Eric Schwarzenbach
b004dbc19f Update RegState for new CellIdentity types
Bug: 74826109
Test: make, make vts
Change-Id: I6350e5da5bc064e665e54d161ee589c3eadf901a
Merged-In: I6350e5da5bc064e665e54d161ee589c3eadf901a
(cherry picked from commit 74befb69b9)
2018-03-30 15:57:24 -07:00
Treehugger Robot
6a83645f64 Merge "Add VTS test for getCellInfoList_1_2" 2018-03-02 07:42:33 +00:00
Cassie
65a3ad31b8 Add VTS test for getCellInfoList_1_2
Bug: 63984327
Test: VTS test
Change-Id: Ie6987f885dfe34c94b30370e1d4853084ee4030b
2018-03-01 15:49:51 -08:00
yinxu
2e6ed18055 Add vts response functions for Radio Response 1.2
Bug: 67750232
Test: Compile and Run VTS
Change-Id: I866cea94b1505b05dee336a53ab72ab685c8f441
2018-03-01 14:15:32 -08:00
Jack Yu
ac1844fac4 Added new VTS test cases for v1.2 data call APIs
Test: VtsHalRadioV1_2Target
Bug: 64132030
Change-Id: I3b9d94985f42a5dd9b9a24e0592cf1657da237d5
2018-03-01 04:31:11 +00:00
Eric Schwarzenbach
8bdc4e04e2 Add VTS tests for 1.2 reporting criteria
Bug: 72115876
Test: make
Change-Id: I7a7633994888d2f1781ac7d5730727112eb0c86d
2018-02-27 17:29:40 -08:00
Treehugger Robot
115484976b Merge "Update documentation for currentPhysicalChannelConfigs()" 2018-02-23 20:00:22 +00:00
Treehugger Robot
bc2e6fec16 Merge "Dot allow error OPERATION_NOT_ALLOWED and REQUEST_NOT_SUPPORTED for startNetworkScan in VTS test." 2018-02-22 22:30:58 +00:00
Eric Schwarzenbach
f9ec2f19bf Update documentation for currentPhysicalChannelConfigs()
Bug: 73739331
Test: n/a, documentation-only change
Change-Id: Ib35af6bc54ee22aaab2f043f7524548f65af1b82
2018-02-22 11:43:09 -08:00
Eric Schwarzenbach
591387fb4f Fix comments for link capacity and signal strength reporting.
Bug: 72110413
Test: n/a
Change-Id: Ie808f4dcb559a50bee111051290266ba47f676da
2018-02-15 16:49:17 -08:00
Treehugger Robot
e09fba4813 Merge "Use new AccessNetwork type in the reporting criteria API" 2018-02-16 00:25:08 +00:00
Nathan Harold
d32f1487a9 Fixes to Align TdScdma Reports with All Others
-Add uarfn to CellIdentityTdscdma
-Add OperatorNames to CellIdentityTdscdma
-Rename TdScdmaSignalStrength to TdsdcmaSignalStrength
-Add support for RSSI and BER reporting to match all
 the other signal strength structures
-Change the reporting format for RSCP to use the ASU
 format that is reported for all the other techs.

Bug: 73177585
Bug: 73177467
Bug: 73177872
Test: compilation
Change-Id: I4200ca603b03f182293de4960b01067263833d4a
2018-02-15 01:31:39 +00:00
Nathan Harold
d0f9466801 Update WcdmaSignalStrength to add RAT-specific fields
-Add RSCP and ECNO to WcdmaSignalStrength
-Add WcdmaSignalStrength to SignalStrength struct.

With this change we can now report the correct WCDMA
ASU due to our ability to now differentiate the SS
based on the RAT without needing additional info.

Bug: 71329173
Test: runtest frameworks-telephony
Change-Id: Ibce0ba38bf2d7e4f3e6c09f53303c0ba83dc6080
2018-02-14 23:49:44 +00:00
Eric Schwarzenbach
0c40e16935 Use new AccessNetwork type in the reporting criteria API
Bug: 72117365
Test: n/a
Change-Id: I55edcf5a317a544148e800bcc5b24b4bd504cecc
2018-02-13 16:32:16 -08:00
Cassie
d19ee31e6c Dot allow error OPERATION_NOT_ALLOWED and REQUEST_NOT_SUPPORTED for startNetworkScan in VTS test.
Bug: 71636480
Test: VTS test
Change-Id: I067f9fe94e20399fd0f07c6b2b0713544b717959
2018-02-13 23:02:32 +00:00
Nathan Harold
01c807fcc7 Update HIDL makefiles
Bug: 73175801
Test: compilation
Change-Id: I41510ffc7b7db4c09ed4e4f390775b9b9d0f79d6
2018-02-09 16:54:59 -08:00
Takumi Hori
5e2330370f Displaying HD audio indicator for GSM/CDMA calls
Return audio quality information during a voice call along with call
details from RIL. This information is expected to be used to display
HD audio indicator when wide band speech codec is notified.
This feature is necessary to fulfill some carriers requirement.

Test: manual - Checked that HD audio indicator is displayed on UI in
GSM/CDMA calls.
Bug: 30207043

Change-Id: Ic6518b7b5c37c4b9cfcd83bd0c5b836acd3f60da
2018-01-25 15:22:23 -08:00
Jack Yu
76499e9be5 HIDL changes for IWLAN refactoring
Added few more parameters required for IWLAN handover to
the existing data call setup/deactive APIs.

Test: Telephony sanity tests
bug: 64132030
Change-Id: I7bb04fc5f32908fa064370d5123252022a166abc
2018-01-24 10:48:08 -08:00
Eric Schwarzenbach
0f2a7358d6 Add bandwidth to cell info.
Bug: 70638175
Test: make
Change-Id: I1a4259542176cf44556131bb2b57107d51b2410e
2018-01-24 03:06:55 +00:00
Eric Schwarzenbach
20fd2c70ff Add physical channel configuration indication.
Also adds the new requisite types and an IndicationFilter for reporting.

Bug: 70638175
Test: n/a
Change-Id: I29f5fba4d1b21af3e7fda876c9a5c911936aeada
2018-01-24 03:06:47 +00:00
Eric Schwarzenbach
21c6dc3548 Add reporting criteria to radio interface.
Enables setting various reporting criteria for unsolicited signal
strength and LCE reports. Creates a new LCE report including both up and
down bandwidths. Updates documentation for various IndicationFilter bits
to add clarity.

Bug: 70638175
Test: n/a
Change-Id: If8141fbd89baf85ed5ee65d589f111907a9bf8b4
2018-01-24 03:06:37 +00:00
yinxu
26487e7a11 Add default implementation for radio config HAL
Bug: 64131518
Test: Basic telephony sanity
Change-Id: I6bd6c6c46f8f70fd13b6c02ddfe399e04190133a
2018-01-23 10:29:28 -08:00
yinxu
7fd46a30f3 Migrate the slot related APIs
SIM slot related APIs are not related to any radio/modem, so they need
to be migrate to a different HAL which is not related to any
radio/modem.

Bug: 64131518
Test: Basic telephony sanity

Change-Id: I626f13c5f6fb39091f6bddd5b6d373f09561af90
2018-01-22 10:36:53 -08:00
Cassie Han
ab6101db50 Merge "Add cellInfoList_1_2 in 1.2/IRadioIndication.hal." 2018-01-11 17:47:42 +00:00
Cassie
3fb7617b69 Add cellInfoList_1_2 in 1.2/IRadioIndication.hal.
As part of the new NetworkScan API project, we need to add V1_2
cellInfoList in RadioIndication to support the V1_2 CellInfo as well.

Bug: 63984327, 69058403
Test: Basic telephony sanity
Change-Id: I53deb0d3b6ba58a86a8f734618841ff91d6dc6fa
2018-01-10 09:46:20 -08:00
sqian
910a238c21 Remove unused functions
Test: Compile
Bug: 63760809
Change-Id: I582c259ca0787a701d434eea9592c9e8d7351f08
Merged-In: I582c259ca0787a701d434eea9592c9e8d7351f08
(cherry picked from commit 3ba20e6b6b)
2018-01-04 12:13:33 -08:00
Treehugger Robot
384fa7b6dc Merge "SIM slot related interface changes" 2018-01-02 22:17:21 +00:00
sqian
7fe9365e6f Modify VTS error check so that the error code can be displayed
- Add AssertionResult in gtest to display logs
- Refactor all the error checks

- Replace INTERNAL_ERR with INVALID_ARGUMENT for
requestIsimAuthentication

- Add missing SIM_ABSENT from ag/2582439/

- Fix incorrect indentation

Bug: 63760809
Bug: 65150146
Test: run vts
Change-Id: Id3d876ea515f47998e3e45be11db5edf306ffc24
Merged-In: Id3d876ea515f47998e3e45be11db5edf306ffc24
(cherry picked from commit e986b85fdd)
2017-12-28 20:20:24 +00:00
Sandeep Gutta
4a4d8cc197 SIM slot related interface changes
Add below new interfaces, corresponding response interface and structures.
- getSimSlotsStatus()
- setSimSlotsMapping()
- simSlotsStatusChanged()

Bug: 68998818
Test: compliation

Change-Id: Ia532c502782ef4d08d27f18ee0321a3ceaa94dcf
2017-12-22 11:29:06 -08:00
Nathan Harold
9acbfc2e6b Fix a typo in Enhanced Network Scan Request
Change RADIO_ACCESS_SPEFICIER_MAX_SIZE to
RADIO_ACCESS_SPECIFIER_MAX_SIZE

Bug: 63865942
Test: compliation
Change-Id: Idabac6ab42c90353a83d32483be46c77a85b7f1d
2017-12-14 13:13:22 -08:00
Steven Moreland
e5c6548346 Remove subdirs
Removing whenever I see these in code reviews.

Test: none
Merged-In: I4322f533a837d55618ec2ed2125e8966ace9d61d
Change-Id: I4322f533a837d55618ec2ed2125e8966ace9d61d
2017-11-28 14:23:43 -08:00
Iris Chang
0c9df89f88 Merge "VTS: fix RadioHidlTest.getAvailableNetworks issue"
am: 89b2d24fb0

Change-Id: I96c5b3873c53fba6fca5905f0a5897a7f8801f4a
2017-11-15 04:10:23 +00:00
Treehugger Robot
89b2d24fb0 Merge "VTS: fix RadioHidlTest.getAvailableNetworks issue" 2017-11-15 04:06:29 +00:00
Xin Li
bb9e38fef9 Merge commit '1a06284b24f5eb7bb9c1fea0817da8898b3b1bff' from
oc-mr1-dev-plus-aosp into stage-aosp-master

Change-Id: I2a044eb8c9981d0a8198ffe2df55559afbd76341
Merged-In: I4fb9f18884f7ef21162015a0032c4431444f7025
2017-11-14 12:08:38 -08:00
Iris Chang
6429f0677f VTS: fix RadioHidlTest.getAvailableNetworks issue
Analysis: VtsHalRadioV1_0Target's timeout is too short for
getAvailableNetworks, because this request duration depends on NW
environment or frequency.

Suggested solution: Add a timeout parameter to wait() and default
timeout value is 5 minutes in order to avoid timeout fail due to NW
environment.

Bug: 68834032
Test: getAvailableNetworks can be passed after we apply this patch and
      test result for all other telephony 1.0 and 1.1 test cases are not
      changed.
Change-Id: Iaae71e0abacd28275d86a19264813ff209ddb79c
2017-11-14 01:08:03 +00:00