Commit graph

118 commits

Author SHA1 Message Date
Devin Moore
9d67c77d35 Migrate sensors VTS to use libui
There is a new graphics.mapper HAL and instead of adding yet another
combination of mapper/allocator, use libui that handles all of that for
us.

Test: VtsAidlHalSensorsTargetTest
Bug: 304843606

Change-Id: Icf4a218de6afe0ae77a4520a6f78a4f7da9bedd4
2023-10-13 16:32:45 +00:00
Treehugger Robot
4613dd5efd Merge "Initialize mStopThread in Sensor constructor" into main am: 014b456a11 am: 9f52ca0fd2 am: b3114df058 am: 2dcf4ebe43 am: faa0f059af
Original change: https://android-review.googlesource.com/c/platform/hardware/interfaces/+/2717101

Change-Id: Ie793198f18545015e9c2531390bc66f79bf4b9b3
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-08-24 22:49:04 +00:00
Treehugger Robot
b3114df058 Merge "Initialize mStopThread in Sensor constructor" into main am: 014b456a11 am: 9f52ca0fd2
Original change: https://android-review.googlesource.com/c/platform/hardware/interfaces/+/2717101

Change-Id: I4fa80cb034c1fb573d4d679804b87299057cb976
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-08-24 20:49:38 +00:00
Aditya Chitnis
5d346fb79c Initialize mStopThread in Sensor constructor
Bug: 294653181
Bug: 294500012
Test: Presubmit
Change-Id: I9c9a9119eb75e364d3969ae77248370937f1f3c5
2023-08-24 18:41:36 +00:00
Arthur Ishiguro
6311a3cebd Add CPU_WRITE_RARELY flag am: 802c53da89 am: cefade7fa9
Original change: https://android-review.googlesource.com/c/platform/hardware/interfaces/+/2700498

Change-Id: I8ed2bd16e6180d368c3fa87bec1dd0a604933924
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-08-09 21:35:22 +00:00
Arthur Ishiguro
802c53da89 Add CPU_WRITE_RARELY flag
Without this flag, the test may fail with SEGV_ACCERR.

Bug: 293475360
Test: Run test
(cherry picked from https://googleplex-android-review.googlesource.com/q/commit:8c5976f06a9c9b0cb92735c3eeba7f7485f4e7ca)
Merged-In: I2d7cfba94145239afde196567400c966a2769419
Change-Id: I2d7cfba94145239afde196567400c966a2769419
2023-08-09 18:17:23 +00:00
Arthur Ishiguro
8c5976f06a Add CPU_WRITE_RARELY flag
Without this flag, the test may fail with SEGV_ACCERR.

Bug: 293475360
Test: Run test
Change-Id: I2d7cfba94145239afde196567400c966a2769419
2023-08-09 17:19:37 +00:00
Matthew Sedam
04cadfcdd6 Fix a segmentation fault in NoStaleEvents tests
This CL fixes an issue where a sensor may not generate any events
and the processing code calls .front() on an empty std::vector.

Bug: 291779133
Test: Presubmits
Change-Id: Ibb118f239ce9ea42fc25d1d05ba6bd46a60231f0
2023-07-24 17:00:57 +00:00
sangweilin
097d2ce929 catch mutex when notify sampling rate changed, otherwise signal may be lost am: e1e361ed43 am: ab8e9f1b2b am: c6a975ee1f
Original change: https://android-review.googlesource.com/c/platform/hardware/interfaces/+/2496635

Change-Id: Idff71b1768fe95ff55d091b577c458f5740c2d31
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-03-20 20:54:27 +00:00
sangweilin
e1e361ed43 catch mutex when notify sampling rate changed, otherwise signal may be lost
Change-Id: Ib52f26e731808ecbe5fd2a53fcd8a47ab3882902
Signed-off-by: sangweilin <sangweilin@xiaomi.com>
2023-03-19 06:48:32 +00:00
AOYAGI Takako
872cda3300 Fix for VTS test CleanupConnectionsOnInitialize am: 45a15ed8b9 am: c0fd000566 am: 16b926e728 am: e760f283cc am: 006acfa520 am: ee526c2d41
Original change: https://android-review.googlesource.com/c/platform/hardware/interfaces/+/2486695

Change-Id: I809ffc2b3f7d0f10a13ff1c97eff8084eeba09c2
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-03-16 02:03:51 +00:00
AOYAGI Takako
64412bb9cd Fix for VTS test CleanupConnectionsOnInitialize am: 45a15ed8b9 am: c0fd000566 am: 16b926e728 am: e760f283cc
Original change: https://android-review.googlesource.com/c/platform/hardware/interfaces/+/2486695

Change-Id: I48186f5bee46d4bb9486f42c0ce410450c51cc08
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-03-16 00:47:32 +00:00
AOYAGI Takako
e760f283cc Fix for VTS test CleanupConnectionsOnInitialize am: 45a15ed8b9 am: c0fd000566 am: 16b926e728
Original change: https://android-review.googlesource.com/c/platform/hardware/interfaces/+/2486695

Change-Id: I9d89b36e50daf41894930baeb7bc59f5d45d27a7
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-03-16 00:07:28 +00:00
AOYAGI Takako
c0fd000566 Fix for VTS test CleanupConnectionsOnInitialize am: 45a15ed8b9
Original change: https://android-review.googlesource.com/c/platform/hardware/interfaces/+/2486695

Change-Id: I105d3e8472f27f2d49a6ab675d173af739fca039
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-03-15 22:54:22 +00:00
AOYAGI Takako
45a15ed8b9 Fix for VTS test CleanupConnectionsOnInitialize
Sensor event never occur on DUT that has no sensor.
So, skip this test case on DUT that has no sensor.

Test: run vts -m VtsHalSensorsV2_0TargetTest

Bug: 273383821
Change-Id: I657b74ca3c67c105e40e58a7e4c700370a9db3e3
Signed-off-by: AOYAGI Takako <aoyagi.takako@jp.panasonic.com>
2023-03-15 21:50:31 +00:00
Matthew Sedam
2d85820979 Fix event collection in SensorsVtsEnvironmentBase.h
Only collect the events that match the description.

Bug: 270611181
Test: atest VtsAidlHalSensorsTargetTest
Test: atest VtsHalSensorsV2_0TargetTest
Change-Id: Iac4c4dc39b3a4d32dbfdb7770989204c1fe28c47
2023-03-08 15:37:47 +00:00
Treehugger Robot
6d065549e1 Merge "Remove uses of deprecated GTest macro." am: 3eed07ead0 am: c74317cabf am: c13f8756d3
Original change: https://android-review.googlesource.com/c/platform/hardware/interfaces/+/2469729

Change-Id: I00d3db902d583272919eba0891a92137bb02caa6
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-03-04 08:28:26 +00:00
Krzysztof Kosiński
c30ca3077d Remove uses of deprecated GTest macro.
Bug: 271622675
Test: local build, presubmit
Change-Id: I525be287361e65d0c4194bc93d7f17ce3369da5d
2023-03-04 00:46:48 +00:00
Treehugger Robot
7443fb11d0 Merge "sensors: cleanup OWNERS" am: c9f07f5fdc am: 3fef1c0f59 am: 1856eb00c4
Original change: https://android-review.googlesource.com/c/platform/hardware/interfaces/+/2372270

Change-Id: Icb51ff4a5b0191a5caea025c2839c4bd038e020c
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-01-04 01:29:58 +00:00
Steven Moreland
ddc9daad96 sensors: cleanup OWNERS
I wrote a script to do this.

Bug: N/A
Test: N/A
Change-Id: I2f53125790aea64d7a3c02569cecccc9cec9522b
2022-12-29 23:44:34 +00:00
Chris Kuiper
3c420b663d HalProxy: Forward 'lshal debug' options.
Bug: 262655635
Test: Temporarily added logs to verify option arguments are correctly
      forwarded.

Change-Id: Idef9b3371c332b8578cbfa88ba7d4bf4c68155e3
2022-12-14 20:46:34 -08:00
Devin Moore
e7e44e0022 Merge "Revert^2 "sensors: adding a common convert lib"" 2022-12-06 16:57:01 +00:00
Devin Moore
160d7a4504 Revert^2 "sensors: adding a common convert lib"
3633b6d4fe

Change-Id: Ie13caa288e8cba344225bb2e4fd01fc23b1d4a9d
2022-12-01 23:17:17 +00:00
Aditya Chitnis
e61b64baf5 Adding suport for multiple multihal config files
Bug: 259450346
Test: Presubmits
Change-Id: Ic7b113e6b8bf94e0c0ffe539f965232b24bdf66d
2022-12-01 10:07:31 +00:00
Krzysztof Kosiński
3633b6d4fe Revert "sensors: adding a common convert lib"
Revert submission 2313818-sensors_shared_convert

Reason for revert: Breaks wembley_2GB-userdebug
Reverted Changes:
Icf64c8809:sensorservice: use new convert functions
Ibc6ed5566:libandroid_sensor_headers: make host_supported and...
Ib80130fc0:sensors: adding a common convert lib

Change-Id: I3f4cb4dc228b5bf6f81f451c11c11d6ebf19639a
2022-11-30 05:16:15 +00:00
Devin Moore
d8598ec6db sensors: adding a common convert lib
This common convert library is used by both the HIDL and the AIDL
convert library to provide conversions between ASensorEvent and
sensors_event_t.

Test: atest VtsHalSensorManagerTargetTest
Test: atest VtsHalSensorManagerV1_0TargetTest
Bug: 259711109

Change-Id: Ib80130fc04339245527ed20479cd9212f016713b
2022-11-28 17:55:14 +00:00
Karthik Bharadwaj
4cea52915a Default accel Z direction value to +9.8
Default the accelerometer defaut Z value to +9.8 to indicate a
more 'natural' resting position of flat with screen up for the
device.

Bug: 242736284
Test: Presubmits, vts VtsHalSensorsV2_0TargetTest.
Change-Id: I92357119173dbc99a0a6665de5d733286ac30c3e
2022-11-21 18:28:44 +00:00
Sally Qi
a1c66a2993 Add cc_defaults wrapper for android.hardware.graphics.allocator ndk
package.

- to avoid manually rev up if needed.

Bug: 243429120
Test: builds
Change-Id: I25bfcc203cda61af308c37c3766fa9efe6c6784c
Merged-In: I25bfcc203cda61af308c37c3766fa9efe6c6784c
2022-10-20 18:27:12 -04:00
heqiang1008 thundersoft
d6ef4fb700 Use EXPECT_LE instead of EXPECT_LT for some iio sensors that do not support runtime suspend.
Change-Id: I646511f9d6c62f2967cedf6a2abc19aa621ee073
2022-09-09 09:11:10 +00:00
Brian Duddie
c325337352 Support AIDL IAllocator for direct channel tests
Bug: 234673324
Test: atest VtsHalSensorsV2_1TargetTest -> DirectChannelGralloc pass on
      device using AIDL IAllocator
Change-Id: I169d3bc863f7e588f42e408f151064066b9960cc
2022-06-10 02:09:11 +00:00
Brian Duddie
739ae49519 Fix sub-HAL handle in dynamic sensor meta events
Need to apply the sub-HAL index byte to ensure handles provided in
DYNAMIC_SENSOR_META events align properly with the [dis]connected
callbacks.

Bug: 228879057
Test: try on device with dynamic sensors sub-HAL at index > 0
Merged-In: Ic7290b51733bb829a5494ef41e9430b51dc6074e
Change-Id: Ic7290b51733bb829a5494ef41e9430b51dc6074e
2022-04-27 09:43:22 -07:00
Chih-hung Hsieh
34593d4e2a Merge "Add timed out test files to tidy_timeout_srcs" am: ff54f73b4f am: fa83970b3a am: 581616e658
Original change: https://android-review.googlesource.com/c/platform/hardware/interfaces/+/1992232

Change-Id: I2eac13fe3b5ab0b4f15d6ceadf376e5e74124a81
2022-02-24 01:32:09 +00:00
Chih-Hung Hsieh
ad1bf31b78 Add timed out test files to tidy_timeout_srcs
* Timed out runs do not show any warning messages.
* These test files cannot finish clang-tidy runs with
  the following settings:
    TIDY_TIMEOUT=90
    WITH_TIDY=1
    CLANG_ANALYZER_CHECKS=1
* When TIDY_TIMEOUT is set, in Android continuous builds,
  tidy_timeout_srcs files will not be compiled by clang-tidy.
  When developers build locally without TIDY_TIMEOUT,
  tidy_timeout_srcs files will be compiled.
* Some of these test modules may be split into smaller ones,
  or disable some time consuming checks, and then
  enable clang-tidy to run within limited time.

Bug: 201099167
Test: make droid tidy-hardware-interfaces_subset
Change-Id: I1de28f1572fff368f67eab512fffec9f2e5c2a9b
2022-02-18 17:25:41 -08:00
Chih-hung Hsieh
41be2d8fa5 Merge "Fix cert-dcl16-c warnings" am: 2d028894c7 am: 2f22222a1c am: e18edd3ffd am: 3a8019b93a
Original change: https://android-review.googlesource.com/c/platform/hardware/interfaces/+/1978297

Change-Id: I17838676d19fa572050bd7372bddd65eb405fa8a
2022-02-10 19:33:44 +00:00
Chih-Hung Hsieh
4f4d365aa5 Fix cert-dcl16-c warnings
Bug: 120614316
Test: make tidy-hardware-interfaces_subset
Change-Id: I6bbeddb9990e4771155ec7d49a68f0e161789030
2022-02-09 15:38:45 -08:00
Treehugger Robot
653d588e32 Merge "Remove early break for sub-HAL initialization failure" am: 6e503b7a4e am: fa9af8de75 am: 0774f2b58e am: b222bd47a3
Original change: https://android-review.googlesource.com/c/platform/hardware/interfaces/+/1961241

Change-Id: I4baa7f43717bbb84cdee578dcd510b97efcd5e5e
2022-01-27 23:24:32 +00:00
Yixuan Wang
105da222fb Remove early break for sub-HAL initialization failure
Bug: 212420575
Test: none
Change-Id: I38099a4edbdeffe99ae2d91fc9dc518c9da98b13
2022-01-26 21:22:44 +00:00
Tyler Trephan
17857cc469 Updated multihal to use new sensors AIDL interface.
Test: make android.hardware.sensors@aidl-multihal
Fix: 206867060
Change-Id: I9b78a0f25117d11fdf4beb1e0913393c1c14620d
2022-01-11 21:09:17 +00:00
Arthur Ishiguro
b0b47e318a Add conversion code for sensor_t to v2.1 SensorInfo
Bug: 195593357
Test: Compile
Change-Id: I0c7239b23896c44f7835430bad7e45f1dbde87ed
2021-11-16 00:20:35 +00:00
Arthur Ishiguro
d3c693e6b4 Refactor collectEvent method in SensorsHidlTestBase
Bug: 195593357
Test: Compile, run VTS
Change-Id: Ie4db0bfd88841ce2821ed664053e27ab18262a56
2021-11-10 18:53:54 +00:00
Arthur Ishiguro
7040ab262a Rename SensorsHidlEnvironmentBase to SensorsVtsEnvironmentBase
Can be used by new AIDL VTS tests.

Bug: 195593357
Test: Compile
Change-Id: Iaa279b4dd65da06042de8c560ae2a98b32771659
2021-11-09 17:21:56 +00:00
Treehugger Robot
c6e82fe78c Merge "Add OWNERS for VTS module VtsHalSensorsV2_0TargetTest" am: 3f295c0a74
Original change: https://android-review.googlesource.com/c/platform/hardware/interfaces/+/1792999

Change-Id: I4de3006d2c3d6ec32f7a88d9e4e4a45f2af29d30
2021-09-23 00:47:09 +00:00
Yiming Pan
2f5b640243 Add OWNERS for VTS module VtsHalSensorsV2_0TargetTest
Each VTS module is required to have OWNERS file. The ownership is based on
go/vts-owners. For more information about ownership policy, please visit
go/xts-owners-policy.

Test: Tree Hugger
Bug: 143903671
Change-Id: I918fdb16d05e0dbf5b189eca2f41a9ad1b5b1255
2021-09-22 15:58:49 -07:00
Hsin-Yi Chen
6bdfc478cf Merge "Use CLOCK_BOOTTIME for default sensor implementation" am: bd0d99e730
Original change: https://android-review.googlesource.com/c/platform/hardware/interfaces/+/1817938

Change-Id: Ib02ef91ee0f8e60fcbb3d95a8ad5e1eb0530286e
2021-09-06 03:58:40 +00:00
Hsin-Yi Chen
adac97fa08 Use CLOCK_BOOTTIME for default sensor implementation
The sensor implementation used to generate periodic signals according to
CLOCK_REALTIME. The clock can be adjusted by user or synchronization
service and results in wrong period. This commit changes it to
CLOCK_BOOTTIME which is monotonic.

Test: atest VtsHalSensorsV2_0TargetTest
Test: atest VtsHalSensorsV2_1TargetTest
Test: atest CtsSensorTestCases
Bug: 194030777
Change-Id: Iac39c93d6d2518b1abe8fc07fd695b9bb2cf30a5
2021-09-03 12:07:15 +08:00
karthik bharadwaj
a5b5c359cb Enforce sensors of the same type having a unique name.
Bug: 179076515
Test: run vts -m VtsHalSensorsV2_0Target
Change-Id: Ibf0d90afdcdce5ee5908dc35f8c392ee06e4b49e
2021-06-17 14:50:01 -07:00
masonwang
92912b6300 Fix VTS BatchingOperation Test.
Change list:
1. Cap minFifoCount to batching period worth of samples.
2. Modify the test period:
From :
batchingPeriodInNs * (0.8 + 0.8) = 1.6 times the batchingPeriodInNs
To
batchingPeriodInNs * (0.8 + 0.2) = batchingPeriodInNs

Bug: 185972775
Test: Verify pass by checking event count if it is closed to the
criteria.

Change-Id: Ied178150788e1a80d6fa6c87afbd1738ade48a0b
2021-05-10 15:49:32 +08:00
Anthony Stange
0b72e2e105 Don't assert while a callback is registered
If an assert fails while a callback is registered and some data
is delivered that attempts to invoke the callback, it'll cause a
segfault since the callback is allocated on a part of the stack
that's no longer valid.

Bug: 183362725
Change-Id: I3a1f8fbf15c24e344fde8e5b44bb93681ef47d38
Test: Run VTS
2021-03-25 16:36:10 +00:00
Anthony Stange
93d11f50df Don't assert while a callback is registered
If an assert fails while a callback is registered and some data
is delivered that attempts to invoke the callback, it'll cause a
segfault since the callback is allocated on a part of the stack
that's no longer valid.

Bug: 183362725
Change-Id: I3a1f8fbf15c24e344fde8e5b44bb93681ef47d38
Test: Run VTS
2021-03-25 16:35:41 +00:00
Jintao Zhu
cfefc7b5e8 Fix RefBase Explicit destruction
For an object to be managed by std smart pointer, its base class should NOT be "RefBase".  It is not only unnecessary but also risking the object being owned by android smart pointer as well, which may destroy the object two times.

This issue may be detected by the destructor of class RefBase, with the log complaint "RefBase: Explicit destruction,..."

Test: monkey test for one day and one night

Signed-off-by: Jintao Zhu <zhujtcsieee@gmail.com>
Change-Id: If7736770983e17f5a4125b19dfbd1745ee5a9589
2021-03-18 23:39:11 +08:00