Commit graph

247 commits

Author SHA1 Message Date
Anil Admal
a12498abf8 Merge "Update @2.0::IGnss.hal setCallback() method documentation" into qt-dev 2019-05-10 16:00:07 +00:00
Anil Admal
2f28bb0c19 Clarify when IGnss.hal cleanup() and setCallback() methods are called
Update IGnss.hal cleanup() and setCallback() method documentation to
clarify when the framework calls these methods so that the GNSS engine
knows when to shut down for power savings.

This CL updates @1.1::IGnss.hal and @1.0::IGnss.hal interfaces only.
@2.0::IGnss.hal is updated in another CL.

Bug: 124104175
Test: Existing tests pass
Change-Id: I8181251677dab78ce0619fa1e2a667b36e115f25
2019-05-09 16:32:06 -07:00
Anil Admal
a3afa5c65c Update @2.0::IGnss.hal setCallback() method documentation
The IGnss.hal setCallback() and cleanup() methods need to be updated
to clarify when the framework calls them so that that the GNSS engine
knows when to shut down for power savings.

This CL updates the @2.0::IGnss.hal setCallback() method documenation
only. The @1.1::IGnss.hal and @1.0::IGnss.hal setCallback() and cleanup()
method documentation is updated in another CL.

Bug: 124104175
Test: Existing tests pass
Change-Id: I6a2dd6f82becc0adef8b4b56fe83e7c004aefd7a
2019-05-09 15:58:00 -07:00
Anil Admal
2690a27d8d Fix wait/notify logic in GNSS VTS 2.0 test cases (part 2)
Addresses follow up code review comments after merge of ag/7324643.

Fixes: 131869042
Test: atest VtsHalGnssV2_0TargetTest
Change-Id: I0177ee60c5edfb6855ce6a1d45b8805166a33cf2
2019-05-06 12:09:57 -07:00
Anil Admal
7f9c13e198 Fix wait/notify logic in GNSS VTS 2.0 test cases
Fixes: 131869042
Test: atest VtsHalGnssV2_0TargetTest
Change-Id: I6fe5713c0f1d329f2738a2d4ba4a7d5aa58efec9
2019-05-03 17:31:20 -07:00
Anil Admal
62d2ca7687 Update GNSS VTS 2.0 tests to address sub-HAL support requirements
- IGnssConfiguration.hal@2.0 must be supported.
- If IAGnss.hal is supported, it must be at IAGnss.hal@2.0
- If IAGnssRil.hal is supported, it must be at IAGnssRil.hal@2.0
- gnss.visibility_control sub-HAL is optional
- gnss.measurement_corrections sub HAL is optional.
- IGnssBatching.hal@2.0 support is optional.

Bug: 70978505
Test: atest VtsHalGnssV2_0TargetTest
Change-Id: Icf98c13ef32bdea7dafda8f79b685466712b16b6
2019-05-02 13:52:53 -07:00
Anil Admal
f45338a356 Restore gnss@1.1 HAL capability bits removed in gnss@2.0 (hal)
In the IGnssCallback.hal@2.0 introduced in Android Q, the
capability bits in IGnssCallback.hal@1.1 that represent sub-HAL
interfaces have been removed as they are derivable from the
existing getExtensionXXX() family of methods in the IGnss.hal
interface.

These need to be restored back as the synchronous nature of the
getExtensionXXX() methods called by the framework has an impact on
partner implementations that need to communicate with the modem to
get the capabilities.

Additionally, the capability bit MEASUREMENT_CORRECTIONS needs to be
added for the new optional measurement_corrections@1.0 sub-HAL
introduced in gnss@2.0.

Fixes: 129870126
Test: Verified through cuttlefish default implementation and VTS tests.
Change-Id: Ib4164c9501b8db9f09eb5429a077d477d0a4a7f9
2019-04-04 17:16:10 +00:00
Anil Admal
704bc613e0 Revert "Revert "Update GNSS Batching to use new GnssLocation with elapsed realtime (HAL)""
This reverts commit b3721a68f2.

Reason for revert: 
It appears that the build includes ag/6721678 but not ag/6762021 even though they both were submitted together. Hence the build errors.

Change-Id: I4e58b29239d291ae3621b90e4507de8eb8838298
2019-03-21 18:45:30 +00:00
Donghui Han
b3721a68f2 Revert "Update GNSS Batching to use new GnssLocation with elapsed realtime (HAL)"
This reverts commit 992cdabf3a.

Reason for revert: <INSERT REASONING HERE>

Change-Id: I0215f172f2d37654937ca72522e110a33c2f63c7
2019-03-21 17:42:42 +00:00
Anil Admal
992cdabf3a Update GNSS Batching to use new GnssLocation with elapsed realtime (HAL)
The ElapsedRealTime field was added to the GnssLocation in
gnss@2.0 HAL to additionally report elapsed time since boot.
The IGnssBatchingCallback.hal@1.0 must be extended to use this
new version of GnssLocation so that the location reported in
gnssLocationBatchCb() method includes the ElapsedRealTime field.

Fixes: 128034260
Test: Tested the new GNSS Batching extension using default
      implementation, VTS test, and cuttlefish.
Change-Id: I326655130782a04fbe168d4582462a123edd9ac2
2019-03-20 14:21:54 -07:00
Yu-Han Yang
6999a0f547 Add IRNSS to GnssConstellationType (HAL)
Bug: 119270132
Test: atest VtsHalGnssV2_0TestTarget
Change-Id: I3a5da40412a1e5dbe9410573ae2bc263643c585c
2019-03-19 22:00:17 -07:00
Anil Admal
86450fa579 Add new GNSS capabilities for year of hardware deprecation (HAL)
The following capabilities need to be added to the GNSS HAL interface
to enforce support through the CTS/VTS tests.

-Add low power mode capability.
-Add satellite blacklisting capability.
-Add measurement corrections capability and move capabilities in
 IGnssCallback.hal that are specific to measurement correctons
 to its own sub-HAL measurement_corrections@1.0.

Bug: 128028791
Bug: 127434062
Bug: 128309220
Test: Tested on cuttlefish using default implementation and VTS tests
Change-Id: I60dbd2ce3cce3cb871aa5f6b690ef881f8dc5705
2019-03-18 19:09:48 -07:00
Yu-Han Yang
221a85e014 Change CodeType from enum to string (HAL)
Bug: 127464982
Test: atest VtsHalGnssV2_0TargetTest
Change-Id: Ia8635c3c071bcb03b75d17ac1ba36767dc7eda72
2019-03-12 12:12:17 -07:00
TreeHugger Robot
dae56d57f4 Merge "Add VTS test for gnss.measurement_corrections@1.0" 2019-03-06 07:22:39 +00:00
Yu-Han Yang
08642f98a4 Add VTS test for gnss.measurement_corrections@1.0
- also implemented default implementation

Bug: 120529158
Fixes: 120529158
Test: tested on cuttlefish
Change-Id: I9e63dc35284effff351eabedade05ed147d1ef17
2019-03-05 19:30:39 -08:00
Steven Moreland
87f43604b9 Merge "Update makefies: no 'types' internal" 2019-03-05 17:40:03 +00:00
Steven Moreland
7f4e21adda Merge "Update makefies: no 'types'" am: 4ee5ec1469 am: bab622f6a6
am: 7224bc9bcf

Change-Id: I434939e0770afa436c532a945542fce30a71ef7d
2019-03-04 16:05:59 -08:00
Steven Moreland
b91ac5c6a0 Update makefies: no 'types' internal
Bug: 123976090
Test: N/A
Change-Id: I84b659b163b63d39535b462a3df8a9c19f680976
2019-03-04 14:09:25 -08:00
Steven Moreland
a878aee9ab Update makefies: no 'types'
Bug: 123976090
Test: N/A
Change-Id: I30fb04c81889b62775e1b764b965fdb0f893de17
2019-03-04 11:27:17 -08:00
TreeHugger Robot
9ad042133c Merge "Enable GNSS Measurement capability in default implementation" 2019-03-01 00:14:06 +00:00
Yu-Han Yang
99f88da61b Enable GNSS Measurement capability in default implementation
Bug: 126573522
Fixes: 126573522
Test: tested on cuttlefish
Change-Id: I1cb6d22a7d721c6e8bda37ca8966d1f45c734a16
2019-02-28 11:55:40 -08:00
Yu-Han Yang
75b35de21d Add isEmergency flag to gnssRequestLocationCb
Bug: 124106337

Test: atest VtsHalGnssV2_0TargetTest
Change-Id: I1d89b4065e3f40b5a4e0714bacd3e305aa94eaa0
2019-02-27 14:07:48 -08:00
Pierre Fite-Georgel
12ac2b5d0f Adding Elapsed Time since boot field to GnssData [HAL].
Test: Added VTS and did a build check.
Bug: 121353225
Change-Id: I3cb329c16b0bfbff68c45033bcfdc85d53914f18
2019-02-22 21:18:35 -08:00
Yu-Han Yang
a509861a59 Report mock locations in 2.0 default implementation
- Create android.hardware.gnss@common-default-lib for sharing common
default implementation code.
- Create android.hardware.gnss@common-vts-lib for sharing common VTS
code.

Bug: 121217686
Change-Id: I35c127c23d97ab9a5c6ee13b36fbfe9c3708e3f3
Fixes: 121217686
Test: tested on cuttlefish
2019-02-15 09:42:43 -08:00
Yu-Han Yang
031738baa6 Use V2_0 GnssMeasurement.state in default implementation
Bug: 123297074
Test: tested on cuttlefish
Change-Id: Ia4479a3f3bf6f962acdebf9cf01ec5cbeab5fff7
2019-02-01 20:01:34 -08:00
TreeHugger Robot
7a7e837c47 Merge "Add STATE_2ND_CODE_LOCK to GnssMeasurementState" 2019-02-02 00:26:24 +00:00
Sasha Smundak
791b843bcb Merge "Explicitly include log/log.h or android/log.h instead of cutils/log.h" am: b5db125860 am: 4a1f714ed0
am: 1e45903dd5

Change-Id: I1a54776b7560154304573a8cd3dfeae5babf43e5
2019-02-01 13:22:37 -08:00
Yu-Han Yang
9e2eaf1d2e Add STATE_2ND_CODE_LOCK to GnssMeasurementState
Bug: 123297074
Test: atest VtsHalGnssV2_0TargetTest
Change-Id: I289669de2c88bbab85d510602b042491c09c4315
2019-02-01 11:47:32 -08:00
Sasha Smundak
769c053d7c Explicitly include log/log.h or android/log.h instead of cutils/log.h
Eliminates the warning.
Test: treehugger

Bug: 123758136
Change-Id: Ibe50261efc18d659a10129977342bc765a9ba9d5
2019-02-01 10:52:09 -08:00
TreeHugger Robot
9e20d2fe06 Merge "Add OTHER to GnssMeasurementCodeType" 2019-02-01 02:56:54 +00:00
Yu-Han Yang
49cbed0a71 Add OTHER to GnssMeasurementCodeType
Bug: 112260995
Test: atest VtsHalGnssV2_0TargetTest
Change-Id: I3e1b466186bff382bddb76975616d8408a951da5
2019-01-31 14:18:37 -08:00
gomo
2fa104b2d1 Bluesky add position uncertainty field
Add the horizontal position uncertainty for the provided location
by Bluesky at which the corrections are computed.
This is a bug fix as these fields were missing in the original submit.

Bug: 111441283
Test: Existing tests pass.
Change-Id: I3c6df7bcd72d6bab11c4e1cc4908e24034958ad7
2019-01-30 02:37:14 +00:00
gomo
92e7f6cc7c Bluesky change Sat LOS field from bool to flaot
Bug: 111441283
Test: Existing tests pass.
Change-Id: I61eb1979e01c15ac7d1830637d7072b69fa1da28
2019-01-17 20:37:02 -08:00
Anil Admal
4d739e7201 Non-framework location access visibility and control (HAL)
Define IGnssVisibilityControl(Callback).hal interfaces to tell
the GNSS HAL implementation for which non-framework non-user
initiated emergency use cases, the framework user has granted
permission to the HAL implementation to provide GNSS location
information and to notify the framework user of these GNSS location
information deliveries.

Bug: 119560261
Test: Partial testing with cuttlefish
Change-Id: Ife704eb9fa4e6113196729b002bc9dc08bb47bc3
2019-01-15 14:45:32 -08:00
Anil Admal
4e50a4cd57 Add emergency session extension duration (HAL)
Add new method in IGnssConfiguration.hal to pass emergency
session extension duration to GNSS HAL implemenation so that
network initiated emergency location requests can be served
for this extra duration post emergency call.

Bug: 121204694
Test: atest VtsHalGnssV2_0TargetTest on cuttlefish
Change-Id: Ibdd280252874dcd34499acfcb7ae5d5a773501a4
2019-01-08 18:12:04 -08:00
Anil Admal
3a405c5905 Extend IAGnss.hal to address requestRouteToHost deprecation
The framework networking component method requestRouteToHost() in
class ConnectivityManager used to support the IAGnss.hal interface
is deprecated. This requires changes to the IAGnss.hal interface
to pass network handle to the GNSS HAL implementation in order
to setup SUPL connections.

Bug: 25876485
Test: atest VtsHalGnssV2_0TargetTest on cuttlefish
Change-Id: If0ecd480879da37508f710620975a198e674f3df
2018-12-21 15:28:35 -08:00
TreeHugger Robot
ba83d1eaa2 Merge "Bluesky flags to follow bit shift represntation" 2018-12-19 21:06:48 +00:00
gomo
8cb5e3e639 Bluesky flags to follow bit shift represntation
Bug: 111441283
Test: Existing tests pass
Change-Id: I62eae7272d63d07fbb0e2d841288444f5e9af3d2
2018-12-19 00:20:23 -08:00
Yu-Han Yang
030d033b3f Add TestGnssMeasurementCodeType VTS test
- add default implementation to mock reporting measurements.

Bug: 120277977
Fixes: 120277977

Test: atest VtsHalGnssV2_0TargetTest
Change-Id: I881f105874a992327551ef616860d7bd61e4bf83
2018-12-18 17:45:45 -08:00
Yu-Han Yang
4010c21bbe Merge "Add vintf_fragment to GNSS HAL 2.0" 2018-12-19 01:34:11 +00:00
Anil Admal
b02bcc130c Replace network type with network capabilities in IAgnssRil.hal
The NetworkType enumerator in IAGnssRil.hal is mapped to the
transport type constants (TYPE_MOBILE, TYPE_WIFI, etc.) in the
framework class ConnectivityManager. These constants are deprecated
and their use should be replaced with network capabilities instead.

The GNSS HAL implementation should make decisions based on the
reported capabilities of a network and not on the type of the network.

Bug: 117768826
Test: Tested with code instrumentation to verify that the
      @2.0::AGnssRil.hal updateNetwork_2_0() method implementation
      is called with correct arguments.
Test: Verified @1.0::AGnssRil.hal backward compatibility on a
      Pixel 3 device.
Change-Id: I8f7f8ca8f5254815702b6d5a89dcb4e53a289cfe
2018-12-15 02:21:31 +00:00
Yu-Han Yang
74addd29c2 Add vintf_fragment to GNSS HAL 2.0
Bug: 120277977
Test: atest VtsHalGnssV2_0TargetTest
Change-Id: I272d0736537047bce6783e678a93560858033ada
2018-12-14 11:01:57 -08:00
gomo
36eb55c4e2 Minor edits to the correction definitions
Bug: 111441283
Test: Existing tests pass.
Change-Id: I370efcf4ca018c99e8d3aa8106b83129f1c54aac
2018-12-10 23:18:25 -08:00
Keun Soo YIM
68ae05dd2d pack VTS cc_test binaries as general-tests
Test: make general-tests
Bug: 120093339
Merged-In: I363450d205868f900e4925ccff1430e2a569f2a4
Change-Id: I363450d205868f900e4925ccff1430e2a569f2a4
2018-12-07 10:49:56 -08:00
gomo
1da4b5c44c Bluesky(go/bluesky) HAL and Default Implementation
- Create new sub-package of gnss with the name Bluesky
- Add bluesky/1/0/IBlueskyCorrections.hal
- Add bluesky/1.0/types.hal
- Modify IGnss.hal adding getExtensionBlueskyCorrections()
- Modify IGnssCallback.hal exteding capability enum for Bluesky
- Default Implementation

Bug: 111441283
Change-Id: I4ab2ecae7f0c43bb2b708741e3a55aba1b015db0
Test: Existing tests pass.
2018-12-02 04:46:37 -08:00
Yu-Han Yang
b0469ebebd Merge "Add GNSS HAL v2.0" 2018-11-30 01:34:33 +00:00
Yu-Han Yang
9c6c20b506 Add GNSS HAL v2.0
- Add GnssMeasurementCodeType in IGnssMeasurementCallback.
- Add VTS tests.
- Add default implementation.

Bug: 112260995
Change-Id: Ie319cc793e9b23e86d672c826c4f5fd6a0f90d04
Fixes: 112260995
Test: atest VtsHalGnssV2_0TargetTest
2018-11-28 15:17:28 -08:00
Keun Soo YIM
ff84c37bc1 pack VTS cc_test binaries as general-tests
Test: make general-tests
Bug: 120093339
Change-Id: I363450d205868f900e4925ccff1430e2a569f2a4
2018-11-27 16:11:41 -08:00
Yu-Han Yang
2cf6611343 Fix typo in Javadoc of GnssSvInfo
There is no behavioral change.

Bug: 119107672
Change-Id: Iac1452fca311025e2a4b9b194a6e69265736330d
Fixes: 119107672
Test: Javadoc update only.
2018-11-12 17:35:07 -08:00
Yu-Han Yang
3cce904a01 Clarify C/No reflects the tracked portion of a GnssMeasurement
Test: Comment updates only. Verified it builds.
Bug: 117942478
Change-Id: Ia069fbdb396b5bfc76d3dbeabd0c54622f568ade
Fixes: 117942478
2018-10-19 12:39:22 -07:00