Commit graph

2219 commits

Author SHA1 Message Date
Eva Chen
af66916e2c Merge changes from topic "vhal_v3" into main
* changes:
  Add UNKNOWN to VehicleAreaSeat aidl.
  Update VHAL property version to v3.
2023-08-24 19:51:21 +00:00
Krzysztof Kosiński
3d3baed1bc Add missing gRPC include.
Othewise the header is not self contained and breaks when
upgrading gRPC.

Bug: 279548314
Test: presubmit
Change-Id: Ife50863bd16eda6bc639261b1f91fdfcf48f6294
2023-08-19 02:07:47 +00:00
Eva Chen
46d65626e2 Add UNKNOWN to VehicleAreaSeat aidl.
Bug: 293521207
Test: atest VtsHalAutomotiveVehicle_TargetTest
Test: atest CtsCarTestCases:CarPropertyManagerTest
Test: atest CtsCarTestCases:VehiclePropertyIdsTest
Change-Id: Idf42a5735eb8e187759c3d84cc4891a473d97d35
2023-08-11 13:24:29 -07:00
Eva Chen
b36d24d12a Update VHAL property version to v3.
Bug: 295405997
Test: Manual Build
Change-Id: I2faf065006e6889309caf69a9b277f42fdc00702
2023-08-11 13:24:21 -07:00
Treehugger Robot
ab51d34ef7 Merge "Changed radius to diameter in INFO_EXTERIOR_DIMENSIONS docs in HAL layer" into main 2023-07-25 19:31:19 +00:00
shrikar
c665f4e34f Changed radius to diameter in INFO_EXTERIOR_DIMENSIONS docs in HAL layer
Bug: 284972202
Test: manual build
Change-Id: Ib72aa4d93d2fcf8c9961fd143842018efe27c18c
2023-07-24 18:30:28 +00:00
Yu Shan
8ddd65dbc0 Add script to parse VehicleProperty.aidl to CSV.
Allow parsing the VHAL property definitions/annotations in
VehicleProperty.aidl into a CSV file so that we can generate
documentation.

Test: python generate_annotation_enums.py --output_csv /tmp/prop.csv
Bug: 288331747
Change-Id: Icc5d023c8efdc01ead220313d6a7c66d22c63a0a
2023-07-11 14:33:36 -07:00
Yu Shan
bc614aeae0 Minor update on access annotation.
Test: None
Bug: 288331747
Change-Id: I3a2246c1c5fd02d06fa2c8f08dc69ac0506bfbcb
2023-07-11 14:33:36 -07:00
Yu Shan
595c1da89f Add more access annotations.
For some READ_WRITE property, READ is also allowed. Add the annotations
to reflect that.

Test: None
Bug: 288331747
Change-Id: I46d86606087e747e217269db028ddf03c9bdc0b6
2023-07-10 16:57:45 -07:00
Yu Shan
733c744072 Merge "Minor fix to comment style." into main 2023-07-10 18:35:34 +00:00
Treehugger Robot
fb867bc8a6 Merge "Cleanup dead code." into main 2023-07-08 03:45:03 +00:00
Treehugger Robot
9c5889cecb Merge "Pass property set error to subscribed clients." into main 2023-07-07 01:41:20 +00:00
Yu Shan
52c0a3dd9d Minor fix to comment style.
Use a separate block for HVAC properties comments since we will use
the first line as description for the property and hvac fan speed
description will not be correct.

Test: None
Bug: 288331747
Change-Id: Ie6518dec394a3d9c90bd2cb5b38939a2cdd7cccf
2023-07-06 17:41:01 -07:00
Yu Shan
4ea2dbc27b Cleanup dead code.
We no longer implement subscription by periodically requesting
get from VHAL layer, so most of the logic in subscriptionClient
is no longer useful.

Test: atest DefaultVehicleHalTest, manually run on emulator verify
subscription works.
Bug: 288627179

Change-Id: Ice3824514b3205ca3446baf0086be81eda0c47d6
2023-07-06 17:41:01 -07:00
Yu Shan
7b1448edcf Pass property set error to subscribed clients.
Pass the async property set error generated by VehicleHardware layer
to subscribed clients

Test: atest DefaultVehicleHalTest
Bug: 286384730
Change-Id: Iadd92e1c0c741ad6450a0508fe9e6301bdfe66c5
2023-07-06 17:18:18 -07:00
Yu Shan
76d7fbf6a1 Fix flaky recurrent timer test.
Do not rely on sleep in tests, but wait for the events to happen
before timeout. Set the timeout to be large enough (5s) so that the
tests are more stable.

Test: atest RecurrentTimerTest
Bug: 289759453
Change-Id: Iff271ca440426871ed3a798bab50b9532f9256f0
2023-07-05 17:16:59 -07:00
Yu Shan
76aaef448f Fix a type conversion bug.
Convert int64_t to long on x86 platform loses info.

Test: atest FakeVehicleHardwareTest on cf_gwear_x86.
Bug: 288376096
Change-Id: I8826e2c0ba6c3e26af858a1d8f1388b75d537082
2023-06-30 19:07:17 +00:00
Yu Shan
51b5c77534 Move flaky HIDL VHAL impl test to post submit.
The tests is flaky by nature because it depends on timer. Although
the flakiness is low, it is too flaky to run as presubmit.

Test: atest -s emulator-5554 DefaultVhalImplTest
Bug: 288197123
Change-Id: I735e3e6197769e47372f025d7eb82d54159a8ff8
2023-06-29 17:52:20 -07:00
Yu Shan
d68149e363 Support VEHICLE_IN_USE and SHUTDOWN_REQUEST.
Support VEHICLE_IN_USE and SHUTDOWN_REQUEST properties in reference
VHAL. They are used for remote access feature.

Test: atest FakeVehicleHardwareTest
Bug: 285205122
Change-Id: Ideb964d1ee625b127bc8e708b46f9639dd59c011
2023-06-22 20:48:23 -07:00
Changyeon Jo
a842eea300 Increase frame counters in the same critical section am: 928a4535c8 am: a343d0cf0c am: c070b5a14b am: 55baee93d6 am: e0868c4484 am: ca64f5b140 am: 9e8d44aba4 am: 0a4815e73a
Original change: https://android-review.googlesource.com/c/platform/hardware/interfaces/+/2594993

Change-Id: I9382ebec2b2960627f03e99ac243cfd11e99599e
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-06-16 03:52:37 +00:00
Changyeon Jo
9e8d44aba4 Increase frame counters in the same critical section am: 928a4535c8 am: a343d0cf0c am: c070b5a14b am: 55baee93d6 am: e0868c4484 am: ca64f5b140
Original change: https://android-review.googlesource.com/c/platform/hardware/interfaces/+/2594993

Change-Id: If414ff886a8c2e6c336289e89f73719d740ac73c
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-06-16 02:24:19 +00:00
Changyeon Jo
55baee93d6 Increase frame counters in the same critical section am: 928a4535c8 am: a343d0cf0c am: c070b5a14b
Original change: https://android-review.googlesource.com/c/platform/hardware/interfaces/+/2594993

Change-Id: Ic0db29743b092a5a2d01860e76356a38e3e4788b
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-06-16 00:04:30 +00:00
Changyeon Jo
c070b5a14b Increase frame counters in the same critical section am: 928a4535c8 am: a343d0cf0c
Original change: https://android-review.googlesource.com/c/platform/hardware/interfaces/+/2594993

Change-Id: Ibcaac170949c319d2cff5b45bc8114238d0ada7b
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-06-15 23:21:50 +00:00
Changyeon Jo
a343d0cf0c Increase frame counters in the same critical section am: 928a4535c8
Original change: https://android-review.googlesource.com/c/platform/hardware/interfaces/+/2594993

Change-Id: I8a59e6173179a284bb90960b30e2e5a35de075a1
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-06-15 22:39:21 +00:00
Changyeon Jo
928a4535c8 Increase frame counters in the same critical section
Bug: 275049370
Test: atest VtsHalEvsV1_0TargetTest
Change-Id: I814aac4edec142027d3802f5ee0d7a444ae2ee86
2023-06-15 21:11:09 +00:00
Keith Mok
57baaafe40 Fix repo upload fail if no symbolic link to python3
generate_annotation_enums.py was added to repo hook but it specific
pthon instrad of python3, on system without symbolic link to python3 from python, repo upload would failed with a file not found error.

Test: Manual test
Bug: 287123042
Change-Id: I61167c5e97bcabb0b0c1b86971f19ce483ff198f
2023-06-13 23:15:05 +00:00
Yu Shan
41dd7f18fc Add generate_vehicle_property_enums repo hook.
This repo hook will check whether the generated enum definition files
require update if VehicleProperty.aidl is updated and prompt user
to run generate_annotation_enums.py if requires update.

The repo hook will do nothing if the preupload files does not contain
VehicleProperty.aidl file.

Test: Manual test
Bug: 286286188
Change-Id: Iea1fdb26d8a76c5aff346ca5cb38ed145fe957d7
2023-06-08 18:34:57 +00:00
Raj Goparaju
a110a96d6d Merge "AudioControl: add version check for module change callback APIs" into udc-dev am: a5f9277262 am: 47795b1cdc
Original change: https://googleplex-android-review.googlesource.com/c/platform/hardware/interfaces/+/23231662

Change-Id: Id5240e8fc02af6107b57c5369450e0c712a6732c
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-05-16 20:13:12 +00:00
Raj Goparaju
a5f9277262 Merge "AudioControl: add version check for module change callback APIs" into udc-dev 2023-05-16 18:06:58 +00:00
Raj Goparaju
4a118d4e10 AudioControl: add version check for module change callback APIs
With Stable-AIDL structure, we have the same VTS test serving
multiple versions. It is possible that vendors implement older
version on the latest tree.

Therefore, the new API tests should not add new requirements on
older versions. Protect the new tests with version check to
ensure they are only executed if meeting version requirements.

Bug: 281945739
Test: run vts --module VtsAidlHalAudioControlTest
Change-Id: Ia186313088a3e8551b11a92259667edd0c6a3878
2023-05-15 18:00:15 -07:00
Treehugger Robot
a32c790e06 Merge "Update the remote access test folder." into udc-dev am: 2047ab0aae am: c70db0d765
Original change: https://googleplex-android-review.googlesource.com/c/platform/hardware/interfaces/+/23223616

Change-Id: I424a3a2058c402674ed8ae9c1c856c92452dee54
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-05-13 03:34:24 +00:00
Treehugger Robot
2047ab0aae Merge "Update the remote access test folder." into udc-dev 2023-05-13 02:38:40 +00:00
Yu Shan
58ff09197b Update the remote access test folder.
Update the test folder directory. The previous temp directory
is not allowed to be accessed by selinux rule.

Test: Manual follow remote access test plan on seahawk.
Bug: 272773565
Change-Id: I2b8b05f56560d3d28d0d61e816d345f8d03f59a5
2023-05-12 18:00:59 -07:00
Terry Guan
3204e6cfea Merge "Adding for adding async large parcelalbe callbacks functionality" into udc-dev am: 7059468d04 am: 37a380ee3c
Original change: https://googleplex-android-review.googlesource.com/c/platform/hardware/interfaces/+/23071837

Change-Id: Id4a670c82eb618a9f0491cad6ed09d5d77c6fd5c
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-05-10 14:37:51 +00:00
Terry Guan
7059468d04 Merge "Adding for adding async large parcelalbe callbacks functionality" into udc-dev 2023-05-10 13:12:49 +00:00
Eva Chen
aab3c500ea Merge "Remove note for ADAS properties." into udc-dev am: d795ebd56c am: b8dce6ec8e
Original change: https://googleplex-android-review.googlesource.com/c/platform/hardware/interfaces/+/23065866

Change-Id: Ic64ecbddc880e31f90dc299f19699bfa6f0c3ee0
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-05-10 01:07:56 +00:00
Eva Chen
d795ebd56c Merge "Remove note for ADAS properties." into udc-dev 2023-05-09 23:11:49 +00:00
Yu Shan
99e4ee0d7e Add inject-task-next-reboot debug command. am: 194757d25f am: 196213ce59
Original change: https://googleplex-android-review.googlesource.com/c/platform/hardware/interfaces/+/22748582

Change-Id: I2f968df2994a18c8a4c34465d2d561a3586ead61
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-05-09 11:07:37 +00:00
Yu Shan
194757d25f Add inject-task-next-reboot debug command.
Support a debug command that will inject a fake remote task for
testing on next reboot with specified latency. This is used to
simulate the situation when a remote task arrives while the device
is not booted up and the task will be delivered once the device
boots up.

Test: Manually test on seahawk.
Bug: 275880463
Change-Id: I6eb064893bea0700da80dfa2dcf3079ddb0b59a1
2023-05-08 15:42:56 -07:00
terryguan
a2fa508d3f Adding for adding async large parcelalbe callbacks functionality
Bug: 270740905
Test: atest com.android.car.CarPropertyManagerTest
Test: atest android.car.apitest.CarPropertyManagerTest
Test: atest com.android.car.hal.PropertyHalServiceTest
Test: manual, verified largeParcelable using shared memeory
Change-Id: Ic01402ceb58ea93957777bec4965121c594fa35e
2023-05-08 08:48:58 -07:00
Terry Guan
fd899003df Merge "Added debug statement and refresh in default vehicle hal" into udc-dev am: 9368d6dc23 am: d65b493cd7
Original change: https://googleplex-android-review.googlesource.com/c/platform/hardware/interfaces/+/22531494

Change-Id: I809711595420d500b2105aade81726e0f1f2fe1d
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-05-06 02:17:53 +00:00
Eva Chen
49281ae7a6 Remove note for ADAS properties.
Bug: 281133179
Test: Comment only change
Change-Id: I6d9c8dfa0fead76195616023442e09887ae74aac
2023-05-05 15:19:22 -07:00
terryguan
f3cd073e86 Added debug statement and refresh in default vehicle hal
Added a debug statement to allow for a debug command to generate a large
amount of propConfigs to test large parcelables. DefaultVehicleHal
needed to refresh the properties when DefaultVehicleHal's
getAllPropConfigs is called

Bug: 270740905
Test: atest DefaultVehicleHalTest
Test: atest android.car.apitest.CarPropertyManagerTest
Test: --rerun-until-failure 3
Test: Manual
Change-Id: I95eb98cef64e327894760783ffe9883975359d89
2023-05-04 13:37:06 -07:00
Krzysztof Kosiński
6078da87ca Use internal gRPC headers in BindToDeviceSocketMutatorLib.
Bug: 280043032
Test: presubmit
Change-Id: I53c413ab3dbbfb056f3b7f22c1db336aa68ba611
Merged-In: I53c413ab3dbbfb056f3b7f22c1db336aa68ba611
2023-05-03 22:26:13 +00:00
Krzysztof Kosiński
ed6e03c5e1 Merge "Use internal gRPC headers in BindToDeviceSocketMutatorLib." into udc-dev-plus-aosp am: 8b1688f576 am: 01ab41b431 am: f5099bb73f
Original change: https://googleplex-android-review.googlesource.com/c/platform/hardware/interfaces/+/22985550

Change-Id: Ie599b7865d308ec012d69ea224f87c8bc01af1f6
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-05-03 21:02:45 +00:00
Krzysztof Kosiński
1837983a6f Use internal gRPC headers in BindToDeviceSocketMutatorLib.
Bug: 280043032
Test: presubmit
Change-Id: I53c413ab3dbbfb056f3b7f22c1db336aa68ba611
2023-05-03 06:49:16 +00:00
Krzysztof Kosiński
f5a74c1d83 Merge "Refactor BindToDeviceSocketMutator." into udc-dev am: 50f5adc5fd am: ca13526e4c
Original change: https://googleplex-android-review.googlesource.com/c/platform/hardware/interfaces/+/22945262

Change-Id: Id8f0dfdb91adab35b70f969b5cc504d49f14e238
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-05-02 12:40:30 +00:00
Krzysztof Kosiński
50f5adc5fd Merge "Refactor BindToDeviceSocketMutator." into udc-dev 2023-05-02 04:55:55 +00:00
Yu Shan
b0565fc3f9 Merge changes I76f90d5a,I3d882dcf into udc-dev am: aa3a1395ea am: a942e675ec
Original change: https://googleplex-android-review.googlesource.com/c/platform/hardware/interfaces/+/22656963

Change-Id: I637e02a076549e65c4460942deeb6227c4fb327e
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-05-02 02:53:57 +00:00
Yu Shan
c413c484ee Add VTS for IVN HAL.
Test: atest VtsHalIvnTargetTest
Bug: 274139217
Change-Id: I76f90d5aa1cec2821bb3345e8315743bc8f51b03
2023-05-01 16:01:06 -07:00