Commit graph

13391 commits

Author SHA1 Message Date
Steven Moreland
ad04de7f13 Revert "Revert "nfc: reflect style guide."" am: 106bc9d27a am: 22fa3244c7
am: afc722acbe

Change-Id: Iba48516670b8a996d7f30d26c7903a2638bf7620
2016-10-05 17:33:38 +00:00
Steven Moreland
3313147682 Merge "Revert "Revert "nfc: update default implementation to match style.""" am: 67f700350a
am: 4484643519

Change-Id: Id4f363bfd90ce712df23a8028007d02cdd68ebbf
2016-10-05 17:30:41 +00:00
Steven Moreland
afc722acbe Revert "Revert "nfc: reflect style guide."" am: 106bc9d27a
am: 22fa3244c7

Change-Id: I5bd5967521395f9979ebe7944960bea69840b444
2016-10-05 17:30:40 +00:00
Roshan Pius
271f2c2d9c wifi(interface): Rename interface to iface
The HIDL objects are called "interface", so rename the wifi interface to
iface to distinguish between them better.

This is especially needed in the follow up CL.

Bug: 31943042
Test: mmm -j32 hardware/interfaces/wifi/1.0/
Change-Id: I3bc34930f75159d26321c0e071af9084d0585508
2016-10-05 10:30:24 -07:00
Roshan Pius
6f31d92e59 wifi(interface): Add/Correct docstring params
Changes in the CL:
1. Add missing docstring params in the HIDL interface.
2. Reword some method docs. Occurences of "will" is replaced
by "must" (based on comments received on supplicant HIDL interface:
go/aog/275115).
3. Add onFailure callbacks for all the methods and added docstrings for
them.

Bug: 31352200
Test: mmma -j32 hardware/interfaces/wifi/1.0
Change-Id: Ib7152625851023d6244f742bb77a8fdc0829e00d
2016-10-05 10:30:15 -07:00
Steven Moreland
4484643519 Merge "Revert "Revert "nfc: update default implementation to match style."""
am: 67f700350a

Change-Id: I383cbfde9f5812fa0af02cc6419d25aea08ca4d5
2016-10-05 17:28:09 +00:00
Steven Moreland
22fa3244c7 Revert "Revert "nfc: reflect style guide.""
am: 106bc9d27a

Change-Id: I0d29f4064a8b4fc84fe5d3a4d09d94ad9854cccb
2016-10-05 17:28:08 +00:00
Treehugger Robot
67f700350a Merge "Revert "Revert "nfc: update default implementation to match style.""" 2016-10-05 17:22:30 +00:00
Roshan Pius
cdb77f3cf2 wifi: Add implementation of driver/firmware memory dumps
Bug: 31352200
Test: mmma -j32 hardware/interfaces/wifi/1.0/default
Change-Id: I25d42cfd4c2b1ea7e63bdc036f37f81aed93c565
2016-10-05 09:22:06 -07:00
Roshan Pius
4b26c832ed wifi: Add Implementation of IWifiChip.requestChipDebugInfo
Bug: 31352200
Test: mmma -j32 hardware/interfaces/wifi/1.0/default
Change-Id: Id0c02e37dac66de6f830785881cb67f113c0fb19
2016-10-05 09:21:07 -07:00
Steven Moreland
22be21e864 Revert "Revert "nfc: update default implementation to match style.""
This reverts commit 3768be324b.

Change-Id: Ifecd3ac227af14b49eba83c1126d51996ce3b8f5
2016-10-05 15:46:37 +00:00
Steven Moreland
106bc9d27a Revert "Revert "nfc: reflect style guide.""
This reverts commit 69bb15e06e.

Change-Id: Icd6ac819606c83e1518c4b6252f6416f55e618fd
2016-10-05 15:46:21 +00:00
Roshan Pius
908a69a53a wifi: Use hal_tool & if_tool
Changes in the CL:
1. Currently |WifiNative.cpp|, uses |hal_tool| to initialize the
function table and |if_tool| to set the interface up when |startHAL|
method is invoked. Use the same sequence in the HIDL'ized HAL.
2. Remove the assertion if the function table initialization fails. This
will result in a failure indication on starting the HAL now.

Bug: 31352200
Test: mmma -j32 hardware/interfaces/wifi/1.0/default
Change-Id: I268845ed62158b6a2ff36659f0bb15c4100a7222
2016-10-04 18:36:25 -07:00
Roshan Pius
aabe575536 wifi: Restructure wifi legacy HAL implementation
Restructured the existing code to create a new class called
|WifiLegacyHal|. This class will be used as a wrapper to invoke
all the legacy HAL functions and handle the "C" style callbacks.

Bug: 31936700
Test: mmma -j32 hardware/interfaces/wifi/1.0/default
Change-Id: I63e8543f49886f8446101320a97d1e96e30d1035
2016-10-04 18:36:22 -07:00
Yifan Hong
effb0d1ee2 Add test for referring to nested types. am: 61db854465 am: a30e27f697 am: c799177c3e
am: e409df1e55

Change-Id: I06119bcf4f27260a2275ed6e56a9c51b11580892
2016-10-04 21:19:44 +00:00
Yifan Hong
e409df1e55 Add test for referring to nested types. am: 61db854465 am: a30e27f697
am: c799177c3e

Change-Id: I16e6fa76a3c810df40e93a06ccac799f7c8207ad
2016-10-04 21:18:09 +00:00
Yifan Hong
c799177c3e Add test for referring to nested types. am: 61db854465
am: a30e27f697

Change-Id: I47800ef8ff8d6aa53580f09cfa9417c41b6f3098
2016-10-04 21:12:13 +00:00
Yifan Hong
a30e27f697 Add test for referring to nested types.
am: 61db854465

Change-Id: Ie4a21561afd882184fe0d9aa1c2772b5849222f7
2016-10-04 21:10:15 +00:00
Roshan Pius
79a9975d07 wifi: Change namespace
Move the implementation to "android::hardware::wifi:V1_0::implementation"
namespace.
This is following the style guidelines in NFC HIDL
implementation(go/aog/279421).

While there,
Run checkstyle to correct formatting issues.

Bug:31936700
Test: mmma -j32 hardware/interfaces/wifi/1.0/default
Change-Id: I5600a60a0041b3318ed9289823ec335a8ed8a83d
2016-10-04 13:23:20 -07:00
Roshan Pius
3c4e8a358c wifi: Move legacy HAL implementation
Changes in the CL:
1. Move the legacy HAL implementation from
"frameworks/opt/net/wifi/wifi_hal_legacy" to
"hardware/interfaces/wifi/1.0/default".
2. Renamed the .rc file and the module name in makefile to
conform to the HIDL style guide.

Files renamed from:
wifi_hal_service.cpp/h -> wifi.cpp/h
wifi_chip_service.cpp/h -> wifi_chip.cpp/h
main.cpp -> service

Bug: 31821133
Test: mmma -j32 hardware/interfaces/wifi/1.0/default
Change-Id: I5e65e2fdb5596346bde6963588031dcea42d633a
2016-10-04 13:10:25 -07:00
Yifan Hong
61db854465 Add test for referring to nested types.
Bug: 31821285

Test: `make hidl_test && adb sync && adb shell hidl_test`
Change-Id: Iae030baa5bbe6e890512b494a0b657163c6a99a6
2016-10-04 10:40:55 -07:00
Martijn Coenen
2e9c369b2c Merge "Revert "nfc: reflect style guide."" am: ea4b569fee am: a2bdc9d012 am: 99af2885ee
am: fdff6ba374

Change-Id: I7ac7d469afdb944e8b8b49789e4557e43a1918fe
2016-10-04 16:54:25 +00:00
Steven Moreland
387356f3f5 Revert "nfc: update default implementation to match style." am: 3768be324b am: a9f5e70913 am: c01b2939c9
am: d71918f65e

Change-Id: Ib00dd2e0051d2adb43d59269256b97d54dfa0b53
2016-10-04 16:53:41 +00:00
Steven Moreland
ff467a47b6 Revert "nfc: reflect style guide." am: 69bb15e06e am: 523f7fc318 am: d61bc26a53
am: f56e40201f

Change-Id: Ibaf18b639880399cba08fc6a115ae7e165e9f41f
2016-10-04 16:53:40 +00:00
Martijn Coenen
fdff6ba374 Merge "Revert "nfc: reflect style guide."" am: ea4b569fee am: a2bdc9d012
am: 99af2885ee

Change-Id: Id4f8a63dd22750ba5311e30e626876f0763447a9
2016-10-04 16:53:28 +00:00
Steven Moreland
d71918f65e Revert "nfc: update default implementation to match style." am: 3768be324b am: a9f5e70913
am: c01b2939c9

Change-Id: I69dc6f064c79e3a08b06c1cacb03691cdb83f1fc
2016-10-04 16:51:14 +00:00
Steven Moreland
f56e40201f Revert "nfc: reflect style guide." am: 69bb15e06e am: 523f7fc318
am: d61bc26a53

Change-Id: I072343f221a302b97eb6ae9104ca43c8aa573807
2016-10-04 16:51:13 +00:00
Martijn Coenen
99af2885ee Merge "Revert "nfc: reflect style guide."" am: ea4b569fee
am: a2bdc9d012

Change-Id: Idbf1e89939936e3d62df7f565388a9a92922ccc2
2016-10-04 16:49:56 +00:00
Steven Moreland
c01b2939c9 Revert "nfc: update default implementation to match style." am: 3768be324b
am: a9f5e70913

Change-Id: Ie64fbc8d4975684e11e9eda797470ea780dffc55
2016-10-04 16:49:09 +00:00
Steven Moreland
d61bc26a53 Revert "nfc: reflect style guide." am: 69bb15e06e
am: 523f7fc318

Change-Id: Ic87635f8f4136f9384a0486267bbccc1c1afd5f1
2016-10-04 16:49:08 +00:00
Martijn Coenen
a2bdc9d012 Merge "Revert "nfc: reflect style guide.""
am: ea4b569fee

Change-Id: Ic814a2ff70dfca6f4268771750cbfedc7b116dc7
2016-10-04 16:48:28 +00:00
Steven Moreland
a9f5e70913 Revert "nfc: update default implementation to match style."
am: 3768be324b

Change-Id: I51ae622cd0ebc906b0b9ff11f5567869181d3879
2016-10-04 16:47:40 +00:00
Steven Moreland
523f7fc318 Revert "nfc: reflect style guide."
am: 69bb15e06e

Change-Id: Ic511eb65f2a43a981e44d5df5c9c74c48d66bd26
2016-10-04 16:47:39 +00:00
Martijn Coenen
ea4b569fee Merge "Revert "nfc: reflect style guide."" 2016-10-04 16:44:14 +00:00
Steven Moreland
3768be324b Revert "nfc: update default implementation to match style."
This reverts commit 6b6381cb58.

Change-Id: I2891a4ea774ad0047d9f99074fe773808dae0f7c
2016-10-04 16:37:11 +00:00
Steven Moreland
69bb15e06e Revert "nfc: reflect style guide."
This reverts commit e0c416a6f2.

Change-Id: I3fec772343d88a29225aef61bb549fef8ac9b797
2016-10-04 16:36:21 +00:00
Steven Moreland
60e96129be Merge changes from topic 'nfc-style' am: 1d4862a6c2 am: e7476a95f5 am: 974574da1a
am: 15b5e9a71c

Change-Id: I42699b8a5d1b63c021e80ede9f3f138ec6ef5274
2016-10-04 14:43:12 +00:00
Steven Moreland
06b2a1dcca nfc: update default implementation to match style. am: 6b6381cb58 am: 36108aadd4 am: cd1981c475
am: a06aacdc39

Change-Id: Ie907bff58e2a8d92e825a6f95bdaf411ab48f2ff
2016-10-04 14:42:32 +00:00
Steven Moreland
8e93cde7c7 nfc: reflect style guide. am: e0c416a6f2 am: ae83f47dd1 am: 7988bc0f40
am: ecfb4eeeb6

Change-Id: Ia321b59e5861235587e95887ab430f476f9554d4
2016-10-04 14:42:31 +00:00
Steven Moreland
15b5e9a71c Merge changes from topic 'nfc-style' am: 1d4862a6c2 am: e7476a95f5
am: 974574da1a

Change-Id: I8c96012743b13f20ffb941dc3a0c7ad3ed38005c
2016-10-04 14:42:15 +00:00
Steven Moreland
a06aacdc39 nfc: update default implementation to match style. am: 6b6381cb58 am: 36108aadd4
am: cd1981c475

Change-Id: I1968283d96ddb372945a16f3f4812d833de09028
2016-10-04 14:40:06 +00:00
Steven Moreland
ecfb4eeeb6 nfc: reflect style guide. am: e0c416a6f2 am: ae83f47dd1
am: 7988bc0f40

Change-Id: I2339add2fbc7300edd09275daf295529b4723a30
2016-10-04 14:40:05 +00:00
Steven Moreland
974574da1a Merge changes from topic 'nfc-style' am: 1d4862a6c2
am: e7476a95f5

Change-Id: I19a9f6db1356b4643c4e340173ef3bdedef9388f
2016-10-04 14:39:58 +00:00
Steven Moreland
e7476a95f5 Merge changes from topic 'nfc-style'
am: 1d4862a6c2

Change-Id: Ic1339a30f4122f3c1abbcc852cbd38a1b750c36c
2016-10-04 14:38:31 +00:00
Steven Moreland
cd1981c475 nfc: update default implementation to match style. am: 6b6381cb58
am: 36108aadd4

Change-Id: Iac25d37c46c04aa18357c77ace08c810f67ccf72
2016-10-04 14:38:03 +00:00
Steven Moreland
7988bc0f40 nfc: reflect style guide. am: e0c416a6f2
am: ae83f47dd1

Change-Id: I26a3c72524732fa39c815023113bda778ad3a2e8
2016-10-04 14:38:02 +00:00
Steven Moreland
36108aadd4 nfc: update default implementation to match style.
am: 6b6381cb58

Change-Id: Idaf00ade4652d5f38bd8fbbd85e841a4d1cb684d
2016-10-04 14:36:33 +00:00
Steven Moreland
ae83f47dd1 nfc: reflect style guide.
am: e0c416a6f2

Change-Id: I931b59e9ed4d017ba09f8d82c4de87f39b0fc9e7
2016-10-04 14:36:32 +00:00
Steven Moreland
1d4862a6c2 Merge changes from topic 'nfc-style'
* changes:
  nfc: update default implementation to match style.
  nfc: reflect style guide.
2016-10-04 14:33:43 +00:00
Steven Moreland
80f5cdba6d Auto hardware/interfaces/Android.bp am: 7b66dd9b23 am: 723aa3a593 am: 6a02ac55f3
am: c81393fb24

Change-Id: Ie88ee205db3bacd0e3aaaf09601c247c63ced3b3
2016-10-04 00:18:56 +00:00