Commit graph

219 commits

Author SHA1 Message Date
sqian
57c9e5fc37 resolve merge conflicts of ccda8d6296 to pi-dev
Test: I solemnly swear I tested this conflict resolution.
Bug: 72075328
Change-Id: I8c993cd2fa95c961dc7f976b5bd85a2826b42889
2018-07-16 21:20:47 +00:00
sqian
898d05a713 resolve merge conflicts of dfa79a6292 to oreo-mr1-vts-dev
Test: I solemnly swear I tested this conflict resolution.
Bug: None
Change-Id: I10919718b841fdb33ab0e873d1b4bbd787fafcd2
2018-07-16 08:36:50 -07:00
sqian
70805cffdd Add NONE for LceService
"Allow startLceService to succeed even in the
SIM_ABSENT case. The original RIL documentation
states that SUCCESS is valid for all LCE
operations, and there is no logical reason why
one of these operations must fail in a no-SIM
case (though a vendor may choose not to support
that configuration). Thus, a call to
startLceService should permit NONE when requested
in the no-SIM case for 1.0 VTS.

In addition, a successful call to startLceService
should also permit a successful call to
pullLceData, so also allow RadioError::NONE for
the pull operation. Ideally the tests would only
allow NONE for pull if startLceService also
returns NONE, but that's out of scope for now."

Bug: 110181475
Bug: 72075328
Test: confirmed in the discussion; compilation
2018-07-13 18:12:08 +00:00
sqian
c0a06f34c8 Add REQUEST_NOT_SUPPORTED for pin and pin2 Icc VTS
Bug: 111222834
Test: sanity
Change-Id: Ia3b96e83d6173c2c80bdbf7763a876883b167af9
2018-07-12 16:30:24 -07:00
sqian
4ed0a216ad Add SIM_PUK2 for Icc VTS tests
Add SIM_PUK2 for supplyIccPin2ForApp and changeIccPin2ForApp if sim
card is in the puk2 state.

Bug: 111211929
Test: sanity
Change-Id: I80d924cc4a61565887cbd2a65ee5927a42ad656e
2018-07-12 10:57:30 -07:00
TreeHugger Robot
01e286d5a7 Merge "Revert "Handle radio API in low version VTS for high version service"" into pi-dev 2018-06-27 01:51:07 +00:00
Shuo Qian
0215d11cf2 Revert "Handle radio API in low version VTS for high version service"
This reverts commit cabe101cd2.

Bug: 109839239

Reason for revert: Treble/VTS backward compatibility 

Change-Id: Ibef1d91261fe6318c65fd617a2bee7f5d69bebae
2018-06-27 00:33:10 +00:00
TreeHugger Robot
1e757749fb Merge "Handle radio API in low version VTS for high version service" into pi-dev 2018-06-26 20:08:32 +00:00
sqian
cabe101cd2 Handle radio API in low version VTS for high version service
There are some request/response pair that could be replaced in
higher-version hal. Radio service need to handle
these request/response pair specific to version number. For example,
e.g. getVoiceRegistrationStateResponse_1_2 replaces
getVoiceRegistrationStateResponse for getVoiceRegistrationState
in 1.2 radio service. We need to add util and update version number
of IRadio service to check the version for testing the correct
behavior.

Bug: 109839239
Test: run vts
Change-Id: I291690e77ea0e6e37fe75219e550f79fa44fb840
2018-06-26 12:03:22 -07:00
sqian
7470cbd04d Add REQUEST_NOT_SUPPORTED for changeIccPinForApp and changeIccPin2ForApp
Bug: 110037298
Test: run vts -m VtsHalRadioV1_0Target
Change-Id: Iaba800814c5a6950d086a2f105714d01fdaa14a4
2018-06-19 10:30:58 -07:00
sqian
ab2b8bf919 Fix setBandMode.
Bug: 67834975
Test: sanity

Merged-In: Ie907cdb464a44d92be47d898151d71eb2d83a11c
2018-06-18 17:10:08 +00:00
Amit Mahajan
817848e59e Allow general errors for getImsiForApp().
This is to match it with other 1.0 tests where general errors are
allowed. For newer tests we have decided to not allow these errors,
but a failure for this old test is reported when run with SIM
present.

Test: run vts -m VtsHalRadioV1_0Target
Bug: 109889468
Change-Id: If36083b7832706a50805932e8ba08e4eb397f3fe
2018-06-12 15:28:05 -07:00
sqian
788eb80830 Sim Status Present VTS
Fix and enhance sim-present tests,
Save VTS running time,
Fix serial number inconsistancy issue

Fix and enhance sim-present tests:
In 1.0:
- setupDataCall timeout, need more waiting time
- requestIccSimAuthentication returns REQUEST_NOT_SUPPORTED,
need to check it
- sendSms timeout, would need more waiting time
- sendSMSExpectMore timeout, would need more waiting time
- getAllowedCarriers, getting CardState::RESTRICTED, the previous test
of setAllowedCarriers is doing resetting back to no carrier restriction,
but that needs some time to populate.
In 1.1:
- setSimCardPower_1_1 set sim card power down that makes other tests
fail, reset it back with sim card power on.

Save VTS running time,
- Use waiting loop and prevent unnecessary waiting to save the whole
running time.

Fix serial number inconsistancy issue
- During the enforcement running, it is liked the serial number is
not consistent. And it happens in b/78249227. Suspect that when sim
card is inserted, during the testing running time, the radio may
request some response that is not triggered from the test, but the
test may receive it and think it is what is triggered by the test. The
fix is to check serial number before notifying of unlock the test
lock.

Bug: 76125134
Bug: 78248071
Bug: 78139665
Bug: 78249227
Test: run vts -m VtsHalRadioV1_0Target; run vts -m VtsHalRadioV1_1Target
Change-Id: I08fe9d7ac16283c7ce1a5aeb6b3b372786a8d5c3
2018-04-20 00:21:14 +00:00
Iris Chang
14ad821b0a VTS: fix RadioHidlTest.getAvailableNetworks issue
Analysis: VtsHalRadioV1_0Target's timeout is too short for
getAvailableNetworks, because this request duration depends on NW
environment or frequency.

Suggested solution: Add a timeout parameter to wait() and default
timeout value is 5 minutes in order to avoid timeout fail due to NW
environment.

Bug: 68834032
Test: getAvailableNetworks can be passed after we apply this patch and
      test result for all other telephony 1.0 test cases are not changed.

Change-Id: Iaef7e8eefa8fcfde0ff8030cba1f9753a28eac61
Merged-In: Iaae71e0abacd28275d86a19264813ff209ddb79c
2018-04-16 05:53:27 +00:00
Zhuoyao Zhang
21b0a0ad25 Convert radio hal test to use VtsHalHidlTargetTestEnvBase
Bug: 64203181
Test: make vts
      vts-tradefed run vts -m VtsHalRadioV1_0Target
      vts-tradefed run vts -m VtsHalSapV1_0Target
      vts-tradefed run vts -m VtsHalRadioV1_1Target
      vts-tradefed run vts -m VtsHalRadioV1_2Target

Change-Id: I067ce9634e41c0400d9eb060065e9bb3bc511546
2018-02-12 15:22:32 -08:00
sqian
985866db5c Merge "Add None into cancelPendingUssd" into oreo-vts-dev am: 4ccc3b0140 am: efebbbeeea am: e7da333a91
am: 9b544fb083

Change-Id: I9b54f0d11f9150f22ad79daaa4b32b551ee1e763
2018-01-25 03:44:52 +00:00
sqian
9b544fb083 Merge "Add None into cancelPendingUssd" into oreo-vts-dev am: 4ccc3b0140 am: efebbbeeea
am: e7da333a91

Change-Id: Ia62e2a8ae1e8975ef33203142a4ebe20b45d60b9
2018-01-25 03:10:50 +00:00
sqian
efebbbeeea Merge "Add None into cancelPendingUssd" into oreo-vts-dev
am: 4ccc3b0140

Change-Id: Iad35b1764095d6b4bdd52dfd8f8e6a73940bfab5
2018-01-25 02:40:26 +00:00
sqian
40c4ff77c6 Add None into cancelPendingUssd
Bug: 67834975
Test: Compile
2018-01-23 16:36:05 -08:00
sqian
d4c4a4edfb Set time delay in the vts test setup
Bug: 69398018
Test: run vts
Change-Id: Ibe1e8f1b08342f1b0b867bfa7bcf1b2fe4a85622
Merged-In: Ibe1e8f1b08342f1b0b867bfa7bcf1b2fe4a85622
(cherry picked from commit 1a5c25dd95)
2018-01-23 22:38:12 +00:00
sqian
1d93dbfb3b Add REQUEST_NOT_SUPPORTED / SIM_ABSENT for vts tests
Bug: 65230472
Test: run vts
Merged-In: I1fab6f49f04a04a7f1cd3b613fe7049f927171d1
Change-Id: I1fab6f49f04a04a7f1cd3b613fe7049f927171d1
(cherry picked from commit 83cc3ab888)
2018-01-23 22:31:26 +00:00
Sanket Padawe
71620817a9 Fix VTS test which turns off radio.
Since the purpose of most of the test cases in current VTS is to check
if proper errors are returned and there is no crash seen in vendor code,
updating setRadioPower test case to turn on the radio instead of
turning off. We want to avoid test cases which turn off
radio or leads to modem shut down as those test cases affect other tests.

Test: VTS
Change-Id: I4fb9f18884f7ef21162015a0032c4431444f7025
Merged-In: I4fb9f18884f7ef21162015a0032c4431444f7025
Bug: 65230472
(cherry picked from commit 9a721b8087)
(cherry picked from commit 536818d17a)
2018-01-23 22:31:01 +00:00
sqian
40d93997b5 Add EMPTY_RECORD for getDeviceIdentity
Remove same unit test case with arguments "","0" for:
- sendEnvelope
- sendTerminalResponseToSim
- sendEnvelopeWithStatus

Test: verified by vendor, treehuger
Bug: 62926561
Change-Id: I5f535bdfc5821275a7ea2571d411374e0d7a8822
Merged-In: I5f535bdfc5821275a7ea2571d411374e0d7a8822
(cherry picked from commit 67901bf2ce)
2018-01-23 22:19:46 +00:00
sqian
fce53868fd Add corresponding error code to fix vts test
Test: run vts
Bug: 63152815
Bug: 62989786
Bug: 64041522
Change-Id: Ifbd17f85b39221de31ec7884b30dc176e1cbd3ab
Merged-In: Ifbd17f85b39221de31ec7884b30dc176e1cbd3ab
(cherry picked from commit 1e5b695016)
2018-01-23 22:11:47 +00:00
Legler Wu
a945baae7f Update VTS tests so that Mediatek pass more VTS for O.
Bug: b/62926561
Test: vts tests

Change-Id: Ic927f9efd437c6411fb14feac8c681334e4b5e60
Merged-in: Ic927f9efd437c6411fb14feac8c681334e4b5e60
(cherry picked from commit b36443a864)
2018-01-23 22:11:13 +00:00
sqian
4e81e1f726 Add Sim absent assertion in the 1.0 setup
Currently the VTS tests for radio are for Sim Absent only. Adding this
assertion in the set up before running VTS tests clarifies the current
tests running is for sim absent only.

Test: run vts
Bug: 63898623
Merged-In: Ie09fb8bcedfd0b35b14f0a70952f44b6f6b082aa
Change-Id: Ie09fb8bcedfd0b35b14f0a70952f44b6f6b082aa
(cherry picked from commit 69cfb0aa38)
2018-01-23 22:11:01 +00:00
sqian
44bd0bb4f4 Fix some VTS for 2017 devices
- sendDeviceState
- setIndicationFilter

Mentioned in b/63148938
- getNeighboringCids

Add Request_not_support for Apis mentioned in Bugs:
 - 62989786
 - 62986286
 - 62987946

Test: run vts
Bug: 63130111
Bug: 63148938
Bug: 62989786
Bug: 62986286
Bug: 62987946
Change-Id: Ib51f67d403bb27f409018a98c07d6aa6aa6d19f8
Merged-In: Ib51f67d403bb27f409018a98c07d6aa6aa6d19f8
(cherry picked from commit fe0699535e)
(cherry picked from commit c699ba3901)
2018-01-23 22:10:42 +00:00
sqian
a598754bf7 Remove unused functions am: 910a238c21
am: 6d06a6f7a9

Change-Id: Id4a9cb4e5b01c0529abd63ce768070be1e7037d9
2018-01-04 21:40:35 +00:00
sqian
910a238c21 Remove unused functions
Test: Compile
Bug: 63760809
Change-Id: I582c259ca0787a701d434eea9592c9e8d7351f08
Merged-In: I582c259ca0787a701d434eea9592c9e8d7351f08
(cherry picked from commit 3ba20e6b6b)
2018-01-04 12:13:33 -08:00
sqian
e611e86fec Modify VTS error check so that the error code can be displayed am: 7fe9365e6f
am: e93516c086

Change-Id: I7079a49624a6aed546c01fa3affd15f25b14769d
2018-01-02 19:35:59 +00:00
sqian
7fe9365e6f Modify VTS error check so that the error code can be displayed
- Add AssertionResult in gtest to display logs
- Refactor all the error checks

- Replace INTERNAL_ERR with INVALID_ARGUMENT for
requestIsimAuthentication

- Add missing SIM_ABSENT from ag/2582439/

- Fix incorrect indentation

Bug: 63760809
Bug: 65150146
Test: run vts
Change-Id: Id3d876ea515f47998e3e45be11db5edf306ffc24
Merged-In: Id3d876ea515f47998e3e45be11db5edf306ffc24
(cherry picked from commit e986b85fdd)
2017-12-28 20:20:24 +00:00
sqian
3ba20e6b6b Remove unused functions
Test: Compile
Bug: 63760809
Change-Id: I582c259ca0787a701d434eea9592c9e8d7351f08
2017-12-21 21:36:20 +00:00
sqian
ff785a0d24 Set time delay in the vts test setup am: a54dd6ca33
am: 88d5ef6944

Change-Id: I71bfb003f33fe9aa1c75f75191ade95ecf8b76ac
2017-11-29 00:09:52 +00:00
sqian
88d5ef6944 Set time delay in the vts test setup
am: a54dd6ca33

Change-Id: Ic6e95752069b452d81e5676999483bfb68249dd5
2017-11-29 00:06:38 +00:00
sqian
a54dd6ca33 Set time delay in the vts test setup
Bug: 69398018
Test: run vts
Change-Id: Ibe1e8f1b08342f1b0b867bfa7bcf1b2fe4a85622
Merged-In: Ibe1e8f1b08342f1b0b867bfa7bcf1b2fe4a85622
2017-11-27 14:22:28 -08:00
sqian
fe32af21bd Set time delay in the vts test setup
Bug: 69398018
Test: run vts
Change-Id: Ibe1e8f1b08342f1b0b867bfa7bcf1b2fe4a85622
2017-11-20 15:40:34 -08:00
sqian
5e5b441361 Add REQUEST_NOT_SUPPORTED / SIM_ABSENT for vts tests
Bug: 65230472
Test: run vts
Change-Id: I1fab6f49f04a04a7f1cd3b613fe7049f927171d1
2017-11-16 19:57:27 +00:00
Iris Chang
8dc6db217d VTS: fix RadioHidlTest.getAvailableNetworks issue
Analysis: VtsHalRadioV1_0Target's timeout is too short for
getAvailableNetworks, because this request duration depends on NW
environment or frequency.

Suggested solution: Add a timeout parameter to wait() and default
timeout value is 5 minutes in order to avoid timeout fail due to NW
environment.

Bug: 68834032
Test: getAvailableNetworks can be passed after we apply this patch and
      test result for all other telephony 1.0 and 1.1 test cases are not
      changed.
Change-Id: Iaae71e0abacd28275d86a19264813ff209ddb79c
Merged-In: Iaae71e0abacd28275d86a19264813ff209ddb79c
(cherry picked from commit 6429f0677f)
2017-11-15 07:08:05 +00:00
Iris Chang
eddb1d9a01 Merge "VTS: fix RadioHidlTest.getAvailableNetworks issue" am: 89b2d24fb0 am: 0c9df89f88
am: 2d47467288

Change-Id: Id5ddb114f2a31d39d844409b4444fbd4ca77745e
2017-11-15 04:13:54 +00:00
Iris Chang
0c9df89f88 Merge "VTS: fix RadioHidlTest.getAvailableNetworks issue"
am: 89b2d24fb0

Change-Id: I96c5b3873c53fba6fca5905f0a5897a7f8801f4a
2017-11-15 04:10:23 +00:00
Iris Chang
6429f0677f VTS: fix RadioHidlTest.getAvailableNetworks issue
Analysis: VtsHalRadioV1_0Target's timeout is too short for
getAvailableNetworks, because this request duration depends on NW
environment or frequency.

Suggested solution: Add a timeout parameter to wait() and default
timeout value is 5 minutes in order to avoid timeout fail due to NW
environment.

Bug: 68834032
Test: getAvailableNetworks can be passed after we apply this patch and
      test result for all other telephony 1.0 and 1.1 test cases are not
      changed.
Change-Id: Iaae71e0abacd28275d86a19264813ff209ddb79c
2017-11-14 01:08:03 +00:00
sqian
e986b85fdd Modify VTS error check so that the error code can be displayed
- Add AssertionResult in gtest to display logs
- Refactor all the error checks

- Replace INTERNAL_ERR with INVALID_ARGUMENT for
requestIsimAuthentication

Bug: 63760809
Bug: 65150146
Test: run vts
Change-Id: Id3d876ea515f47998e3e45be11db5edf306ffc24
2017-11-13 15:16:04 -08:00
Shuo Qian
33b550ce67 Revert "Modify VTS error check so that the error code can be displayed"
This reverts commit cf243eba43.

Change-Id: Idd42b12cdcbaab1476e460c34f3b4b60c38dead0
2017-11-13 22:17:42 +00:00
sqian
cf243eba43 Modify VTS error check so that the error code can be displayed
- Add AssertionResult in gtest to display logs
- Refactor all the error checks

- Replace INTERNAL_ERR with INVALID_ARGUMENT for 
requestIsimAuthentication

Bug: 63760809
Bug: 65150146
Test: run vts
Change-Id: Iec4bdfd89ccd8d8d8c6e1bd8f720a88d67f23cb3
2017-11-13 19:08:43 +00:00
Sanket Padawe
340619c703 Fix VTS test which turns off radio.
am: 536818d17a

Change-Id: I74ebfa3894e27bdf0e02671cbeccac83b1917424
2017-10-18 23:56:12 +00:00
Sanket Padawe
536818d17a Fix VTS test which turns off radio.
Since the purpose of most of the test cases in current VTS is to check
if proper errors are returned and there is no crash seen in vendor code,
updating setRadioPower test case to turn on the radio instead of
turning off. We want to avoid test cases which turn off
radio or leads to modem shut down as those test cases affect other tests.

Test: VTS
Change-Id: I4fb9f18884f7ef21162015a0032c4431444f7025
Merged-In: I4fb9f18884f7ef21162015a0032c4431444f7025
Bug: 65230472
(cherry picked from commit 9a721b8087)
2017-10-18 23:41:05 +00:00
sqian
18192d9b83 Merge "Add REQUEST_NOT_SUPPORTED / SIM_ABSENT for vts tests" into oc-mr1-dev am: b70f1bda1f
am: e99541ac02

Change-Id: Ic93e6a45afa6d4d5aff27a4d8f9e7b29ba9ae587
2017-10-18 03:43:37 +00:00
sqian
e99541ac02 Merge "Add REQUEST_NOT_SUPPORTED / SIM_ABSENT for vts tests" into oc-mr1-dev
am: b70f1bda1f

Change-Id: Ie8c2ee83c5c6102658a2627099c097c3f155feaa
2017-10-18 03:40:37 +00:00
sqian
bc1c9295a3 Add REQUEST_NOT_SUPPORTED / SIM_ABSENT for vts tests
Bug: 65230472
Test: run vts
Change-Id: I1fab6f49f04a04a7f1cd3b613fe7049f927171d1
2017-10-17 16:02:04 -07:00
sqian
336a914eb3 Refactor radio folder for 1.0 and 1.1 am: 8735a7d935
am: 2576f3505f

Change-Id: I999a8edb0cc1c37405cef6c20dcf5aaf262c4228
2017-10-15 01:54:55 +00:00