Commit graph

1389 commits

Author SHA1 Message Date
Aaqib Ismail
ba0124af54 Make 2.0-libproto-native visible to sdv_ivi_cf am: b5310066d4
Original change: https://googleplex-android-review.googlesource.com/c/platform/hardware/interfaces/+/24725582

Change-Id: Ie19139f92ade10a84f824921e9f5f0fb88a5c66c
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-09-23 23:18:45 +00:00
Yu Shan
c067a9b52e Merge "Rename reference VHAL to V3." into main 2023-09-19 19:41:03 +00:00
Aaqib Ismail
b5310066d4 Make 2.0-libproto-native visible to sdv_ivi_cf
Bug: 291278377
Test: m
Change-Id: I4eba410eef0b410299bde34265b0392114e33d7b
2023-09-19 12:38:27 -07:00
Yu Shan
c1ee98677e Rename reference VHAL to V3.
The current target is actually supporting VHAL v2
interface, but we did not update the name. Update its name to V3
since it is going to support VHAL v3 interface.

Test: Presubmit
Bug: 300694866
Change-Id: I54bd15edb83add03b0fe8272b6e8787fef7003cf
2023-09-15 17:55:15 -07:00
Aaqib Ismail
2dff22274c Fix clang lint warnings am: ccf273d307
Original change: https://googleplex-android-review.googlesource.com/c/platform/hardware/interfaces/+/24763110

Change-Id: Iac9e75bbb3e310feeae56c50d59d331e2ba34578
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-09-15 05:45:31 +00:00
Aaqib Ismail
ccf273d307 Fix clang lint warnings
Bug: 291278377
Test: m
Change-Id: Ifcfecc313c8d27fb04a20b4e6bf304b04f4a5b55
2023-09-15 04:40:17 +00:00
Treehugger Robot
089d39f69c Merge "Add buffer result for generating vendor configs" into main 2023-09-14 21:09:12 +00:00
Antonio Kantek
e226dcd2e8 Merge "Add visibility to "//cts/tests/tests/car_permission_tests"" into main 2023-09-08 18:14:38 +00:00
Aaqib Ismail
810144a168 Add missing supportedEnumValues
Bug: 299192013
Test: m
Change-Id: I36d1e4942cb44604539e384bde9300ac8ca8eba2
2023-09-05 17:52:12 -07:00
Aaqib Ismail
e279306e57 Add missing status codes
Bug: 299191602
Test: m
Change-Id: I65a74ac6e93ec5ffcf32b54b6a11c983b1c32262
2023-09-05 17:20:49 -07:00
Antonio Kantek
b22a274542 Add visibility to "//cts/tests/tests/car_permission_tests"
Bug: 298100097
Test: atest CarSecurityPermissionTest
Change-Id: Ia613cbb47fe2a6efd1c518aeee8b0cca15af7e13
2023-09-05 20:29:38 +00:00
Treehugger Robot
3c8c62f7ee Merge "Allow empty preuload_files." into main 2023-08-30 20:41:27 +00:00
Yu Shan
b1fc8c914f Allow empty preuload_files.
When a CL only removes file, the PREUPLOAD_FILES in repohook might
be empty.

Test: None
Bug: 298222655
Change-Id: I70bb347c02c5d09a0525313087acb9c38b9a2ff2
2023-08-30 11:51:04 -07:00
Yu Shan
2fd9496ecd Use AIDL for test vendor properties.
Use AIDL enum instead of hard coding the test vendor property
definitions so that we don't have to duplicate the value among VHAL
and the clients. This also shows how vendor can uses a custom AIDL
enum to define vendor properties.

Test: atest FakeVehicleHardwareTest
Bug: 296913406
Change-Id: Ief889b86bfbef136f8afd4a4f49405f2213b441c
2023-08-28 17:48:30 -07:00
Shrikar Amirisetty
892e1feaa0 Merge "Added logic for ACC properties to return NOT_AVAILABLE in standard CC." into main 2023-08-28 19:40:17 +00:00
Eva Chen
af66916e2c Merge changes from topic "vhal_v3" into main
* changes:
  Add UNKNOWN to VehicleAreaSeat aidl.
  Update VHAL property version to v3.
2023-08-24 19:51:21 +00:00
shrikar
cc3f5884cd Added logic for ACC properties to return NOT_AVAILABLE in standard CC.
ACC properties and certain CRUISE_CONTROL_COMMAND enums will return
StatusCode NOT_AVAILABLE_DISABLED when CRUISE_CONTROL_TYPE is STANDARD.

Bug: 268680457
Test: atest FakeVehicleHardwareTest
Change-Id: Id79c93a0dab6224dd3e6fae3aa747781a848aa94
2023-08-24 12:50:38 +00:00
terryguan
6791803d4a Add buffer result for generating vendor configs
Add buffers to verify the success of generating and restoring vendor
configs.

Bug: 281835821
Test: atest android.car.apitest.CarPropertyManagerTest
Change-Id: Ic3cb8bf3e606847ff55d719900ad0b764b56aaf4
2023-08-22 17:46:12 -07:00
Krzysztof Kosiński
9d92d55a55 Add missing gRPC include. am: c608187f21 am: e1ea603e02
Original change: https://googleplex-android-review.googlesource.com/c/platform/hardware/interfaces/+/24501312

Change-Id: I5730c9a2586715d4bcf36e7cbcbc55ebb89513fc
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-08-21 22:43:16 +00:00
Krzysztof Kosiński
c608187f21 Add missing gRPC include.
Othewise the header is not self contained and breaks when
upgrading gRPC.

Bug: 279548314
Test: presubmit
(cherry picked from https://googleplex-android-review.googlesource.com/q/commit:3d3baed1bc85f8ddddb2764a5a09cd4d578419f0)
Merged-In: Ife50863bd16eda6bc639261b1f91fdfcf48f6294
Change-Id: Ife50863bd16eda6bc639261b1f91fdfcf48f6294
2023-08-21 20:12:27 +00:00
Krzysztof Kosiński
3d3baed1bc Add missing gRPC include.
Othewise the header is not self contained and breaks when
upgrading gRPC.

Bug: 279548314
Test: presubmit
Change-Id: Ife50863bd16eda6bc639261b1f91fdfcf48f6294
2023-08-19 02:07:47 +00:00
Eva Chen
46d65626e2 Add UNKNOWN to VehicleAreaSeat aidl.
Bug: 293521207
Test: atest VtsHalAutomotiveVehicle_TargetTest
Test: atest CtsCarTestCases:CarPropertyManagerTest
Test: atest CtsCarTestCases:VehiclePropertyIdsTest
Change-Id: Idf42a5735eb8e187759c3d84cc4891a473d97d35
2023-08-11 13:24:29 -07:00
Eva Chen
b36d24d12a Update VHAL property version to v3.
Bug: 295405997
Test: Manual Build
Change-Id: I2faf065006e6889309caf69a9b277f42fdc00702
2023-08-11 13:24:21 -07:00
Treehugger Robot
ab51d34ef7 Merge "Changed radius to diameter in INFO_EXTERIOR_DIMENSIONS docs in HAL layer" into main 2023-07-25 19:31:19 +00:00
shrikar
c665f4e34f Changed radius to diameter in INFO_EXTERIOR_DIMENSIONS docs in HAL layer
Bug: 284972202
Test: manual build
Change-Id: Ib72aa4d93d2fcf8c9961fd143842018efe27c18c
2023-07-24 18:30:28 +00:00
Yu Shan
8ddd65dbc0 Add script to parse VehicleProperty.aidl to CSV.
Allow parsing the VHAL property definitions/annotations in
VehicleProperty.aidl into a CSV file so that we can generate
documentation.

Test: python generate_annotation_enums.py --output_csv /tmp/prop.csv
Bug: 288331747
Change-Id: Icc5d023c8efdc01ead220313d6a7c66d22c63a0a
2023-07-11 14:33:36 -07:00
Yu Shan
bc614aeae0 Minor update on access annotation.
Test: None
Bug: 288331747
Change-Id: I3a2246c1c5fd02d06fa2c8f08dc69ac0506bfbcb
2023-07-11 14:33:36 -07:00
Yu Shan
595c1da89f Add more access annotations.
For some READ_WRITE property, READ is also allowed. Add the annotations
to reflect that.

Test: None
Bug: 288331747
Change-Id: I46d86606087e747e217269db028ddf03c9bdc0b6
2023-07-10 16:57:45 -07:00
Treehugger Robot
795e58a333 Merge "Pass property set error to subscribed clients." into udc-qpr-dev am: 94a43b30ef
Original change: https://googleplex-android-review.googlesource.com/c/platform/hardware/interfaces/+/23880264

Change-Id: If342d76ba837924f37f051253326b7a0ecaf91c9
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-07-10 21:46:10 +00:00
Treehugger Robot
94a43b30ef Merge "Pass property set error to subscribed clients." into udc-qpr-dev 2023-07-10 21:07:10 +00:00
Yu Shan
733c744072 Merge "Minor fix to comment style." into main 2023-07-10 18:35:34 +00:00
Treehugger Robot
fb867bc8a6 Merge "Cleanup dead code." into main 2023-07-08 03:45:03 +00:00
Treehugger Robot
9eb7b82d9a Merge "Fix flaky recurrent timer test." into main am: d0cb2e73b2 am: 83e99ff3b1 am: b3f840a6ff am: d8ab63802a am: e993d4b849
Original change: https://android-review.googlesource.com/c/platform/hardware/interfaces/+/2651319

Change-Id: If412439e197b7d2cfbf5570314f2e9c81e287ec2
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-07-07 23:53:36 +00:00
Treehugger Robot
d8ab63802a Merge "Fix flaky recurrent timer test." into main am: d0cb2e73b2 am: 83e99ff3b1 am: b3f840a6ff
Original change: https://android-review.googlesource.com/c/platform/hardware/interfaces/+/2651319

Change-Id: Ia670893b8cebee92cb8d6f2248123009c434382c
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-07-07 22:28:53 +00:00
Yu Shan
fda1197d79 Pass property set error to subscribed clients.
Pass the async property set error generated by VehicleHardware layer
to subscribed clients

Test: atest DefaultVehicleHalTest
Bug: 286384730
(cherry picked from https://googleplex-android-review.googlesource.com/q/commit:7b1448edcfd3f88365932e2d94659952444aae2b)
Merged-In: Iadd92e1c0c741ad6450a0508fe9e6301bdfe66c5
Change-Id: Iadd92e1c0c741ad6450a0508fe9e6301bdfe66c5
2023-07-07 21:26:02 +00:00
Yu Shan
bdba2b578d Fix flaky recurrent timer test.
Do not rely on sleep in tests, but wait for the events to happen
before timeout. Set the timeout to be large enough (5s) so that the
tests are more stable.

Test: atest RecurrentTimerTest
Bug: 289759453
Change-Id: Iff271ca440426871ed3a798bab50b9532f9256f0
Merged-In: Iff271ca440426871ed3a798bab50b9532f9256f0
(cherry picked from commit 76d7fbf6a1)
2023-07-07 20:30:43 +00:00
Treehugger Robot
9c5889cecb Merge "Pass property set error to subscribed clients." into main 2023-07-07 01:41:20 +00:00
Yu Shan
52c0a3dd9d Minor fix to comment style.
Use a separate block for HVAC properties comments since we will use
the first line as description for the property and hvac fan speed
description will not be correct.

Test: None
Bug: 288331747
Change-Id: Ie6518dec394a3d9c90bd2cb5b38939a2cdd7cccf
2023-07-06 17:41:01 -07:00
Yu Shan
4ea2dbc27b Cleanup dead code.
We no longer implement subscription by periodically requesting
get from VHAL layer, so most of the logic in subscriptionClient
is no longer useful.

Test: atest DefaultVehicleHalTest, manually run on emulator verify
subscription works.
Bug: 288627179

Change-Id: Ice3824514b3205ca3446baf0086be81eda0c47d6
2023-07-06 17:41:01 -07:00
Yu Shan
7b1448edcf Pass property set error to subscribed clients.
Pass the async property set error generated by VehicleHardware layer
to subscribed clients

Test: atest DefaultVehicleHalTest
Bug: 286384730
Change-Id: Iadd92e1c0c741ad6450a0508fe9e6301bdfe66c5
2023-07-06 17:18:18 -07:00
Yu Shan
76d7fbf6a1 Fix flaky recurrent timer test.
Do not rely on sleep in tests, but wait for the events to happen
before timeout. Set the timeout to be large enough (5s) so that the
tests are more stable.

Test: atest RecurrentTimerTest
Bug: 289759453
Change-Id: Iff271ca440426871ed3a798bab50b9532f9256f0
2023-07-05 17:16:59 -07:00
Yu Shan
ddd7b58149 Fix a type conversion bug.
Convert int64_t to long on x86 platform loses info.

Test: atest FakeVehicleHardwareTest on cf_gwear_x86.
Bug: 288376096
(cherry picked from https://googleplex-android-review.googlesource.com/q/commit:76aaef448fcd9458b07b1d78ea4b79165af0cde0)
Merged-In: I8826e2c0ba6c3e26af858a1d8f1388b75d537082
Change-Id: I8826e2c0ba6c3e26af858a1d8f1388b75d537082
2023-06-30 20:55:19 +00:00
Yu Shan
76aaef448f Fix a type conversion bug.
Convert int64_t to long on x86 platform loses info.

Test: atest FakeVehicleHardwareTest on cf_gwear_x86.
Bug: 288376096
Change-Id: I8826e2c0ba6c3e26af858a1d8f1388b75d537082
2023-06-30 19:07:17 +00:00
Yu Shan
51b5c77534 Move flaky HIDL VHAL impl test to post submit.
The tests is flaky by nature because it depends on timer. Although
the flakiness is low, it is too flaky to run as presubmit.

Test: atest -s emulator-5554 DefaultVhalImplTest
Bug: 288197123
Change-Id: I735e3e6197769e47372f025d7eb82d54159a8ff8
2023-06-29 17:52:20 -07:00
Yu Shan
d68149e363 Support VEHICLE_IN_USE and SHUTDOWN_REQUEST.
Support VEHICLE_IN_USE and SHUTDOWN_REQUEST properties in reference
VHAL. They are used for remote access feature.

Test: atest FakeVehicleHardwareTest
Bug: 285205122
Change-Id: Ideb964d1ee625b127bc8e708b46f9639dd59c011
2023-06-22 20:48:23 -07:00
Keith Mok
57baaafe40 Fix repo upload fail if no symbolic link to python3
generate_annotation_enums.py was added to repo hook but it specific
pthon instrad of python3, on system without symbolic link to python3 from python, repo upload would failed with a file not found error.

Test: Manual test
Bug: 287123042
Change-Id: I61167c5e97bcabb0b0c1b86971f19ce483ff198f
2023-06-13 23:15:05 +00:00
Yu Shan
41dd7f18fc Add generate_vehicle_property_enums repo hook.
This repo hook will check whether the generated enum definition files
require update if VehicleProperty.aidl is updated and prompt user
to run generate_annotation_enums.py if requires update.

The repo hook will do nothing if the preupload files does not contain
VehicleProperty.aidl file.

Test: Manual test
Bug: 286286188
Change-Id: Iea1fdb26d8a76c5aff346ca5cb38ed145fe957d7
2023-06-08 18:34:57 +00:00
Terry Guan
3204e6cfea Merge "Adding for adding async large parcelalbe callbacks functionality" into udc-dev am: 7059468d04 am: 37a380ee3c
Original change: https://googleplex-android-review.googlesource.com/c/platform/hardware/interfaces/+/23071837

Change-Id: Id4a670c82eb618a9f0491cad6ed09d5d77c6fd5c
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-05-10 14:37:51 +00:00
Terry Guan
7059468d04 Merge "Adding for adding async large parcelalbe callbacks functionality" into udc-dev 2023-05-10 13:12:49 +00:00
Eva Chen
aab3c500ea Merge "Remove note for ADAS properties." into udc-dev am: d795ebd56c am: b8dce6ec8e
Original change: https://googleplex-android-review.googlesource.com/c/platform/hardware/interfaces/+/23065866

Change-Id: Ic64ecbddc880e31f90dc299f19699bfa6f0c3ee0
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-05-10 01:07:56 +00:00