Commit graph

428 commits

Author SHA1 Message Date
Marissa Wall
bd1ca51841 graphics: rev IAllocator and IMapper
Increase IAllocator and IMapper to 3.0. This patch does not add
any new features.

Bug: 120493579
Test: vts
Change-Id: I84d9887f94d91eca1cc5d845bb11ac1d8affbf62
2019-01-12 15:40:02 -08:00
Valerie Hau
c25748d22f Adding HDR10+ Dynamic Metadata Support
Bug: 118343714
Test: build, flash, boot
Test: VtsGraphicsComposerV2_3TargetTest should pass
Change-Id: Iee78818bc2704f4045b62251ea2cc75af72a0609
2018-12-20 13:15:37 -08:00
Chih-hung Hsieh
df66e3cb29 Merge "Fix performance-for-range-copy warnings" am: d01f7050ac am: 51e835ce22
am: 86fefab5e9

Change-Id: Ib139d710d47a7a51e24ba8ba582b252f5ff6e244
2018-12-17 14:09:52 -08:00
Chih-Hung Hsieh
65ab67312b Fix performance-for-range-copy warnings
Bug: 30413223
Test: make with WITH_TIDY=1 DEFAULT_GLOBAL_TIDY_CHECKS=-*,performance*
Change-Id: I1b76a22eab100a31e77048626e48169fe7eeaf92
2018-12-17 19:57:21 +00:00
Treehugger Robot
001a2cc09e Merge "HWC2OnFbAdapter: don't claim present fences work" 2018-12-12 20:35:03 +00:00
Chris Forbes
bdf93d0e68 HWC2OnFbAdapter: don't claim present fences work
We never produce real present fences, so indicate this to the
compositor. This will prevent GOOGLE_display_timing & friends from being
exposed in the client APIs.

Similar to previous change in HWC2On1Adapter.

Bug: b/111505197
Change-Id: I601a7f5628d4b218431fc0f1abb4807c9941ce64
(cherry picked from commit 3fac35a98a)
2018-12-11 18:31:06 -08:00
Keun Soo YIM
68ae05dd2d pack VTS cc_test binaries as general-tests
Test: make general-tests
Bug: 120093339
Merged-In: I363450d205868f900e4925ccff1430e2a569f2a4
Change-Id: I363450d205868f900e4925ccff1430e2a569f2a4
2018-12-07 10:49:56 -08:00
TreeHugger Robot
55c3df3e70 Merge "[Graphics] Fix some wordings." 2018-12-05 23:54:23 +00:00
Peiyong Lin
02dd3d3ae0 [Graphics] Fix some wordings.
BUG: 111562338
Test: N/A
Change-Id: If7e7141dc033dcce493eca408b302d7c57036144
2018-12-05 06:59:39 -08:00
Valerie Hau
467d88e1d0 Merge "Setting PowerMode to ON after SetPowerModeVariations" 2018-12-04 21:13:07 +00:00
Valerie Hau
ab3195bf21 Setting PowerMode to ON after SetPowerModeVariations
SetVsyncEnabled failure after SetPowerModeVariations on
sailfish
Test: ./VtsHalGraphicsComposerV2_1TargetTest on sailfish

Change-Id: I118988c4ac2b70978267b7c08f20861f4728ff8f
2018-12-03 10:29:47 -08:00
Peiyong Lin
55d50d6b77 [Graphics] Introduce per display capability.
Previously, the capability of skipping client color transform is global that
will apply on all displays. However, some hardwares are not capable of managing
it for all displays. This patch introduced a per display capability.

BUG: 69911676
Test: Build with mmma hardware/interfaces
Change-Id: I4a143ea89d06bd30ad2bf3f5307c8af9b17f0890
2018-11-29 00:23:44 -08:00
Keun Soo YIM
ff84c37bc1 pack VTS cc_test binaries as general-tests
Test: make general-tests
Bug: 120093339
Change-Id: I363450d205868f900e4925ccff1430e2a569f2a4
2018-11-27 16:11:41 -08:00
Valerie Hau
01c541c93f Removing USES_DISPLAY_RENDER_INTENTS check in ComposerClient.h
Test: ./VtsHalGraphicsComposerV2_2TargetTest
Change-Id: Ibe5800c22927c16619db864193594f70dc2a4b7f
2018-11-19 10:50:02 -08:00
Kevin DuBois
e52f011f42 Merge "graphics: Add display color sampling interface." 2018-11-07 17:39:04 +00:00
Kevin DuBois
bf141483fa graphics: Add display color sampling interface.
Add a graphics.composer@2.3 interface that will expose
color sampling hardware present on some devices to the
framework. Adds:
  getDisplayedContentSamplingAttributes
  setDisplayedContentSamplingEnabled
  getDisplayedContentSample

Test: boot up pixel3
Test: VtsHalGraphicsComposerV2_3TargetTest on revved Pixel3 hwcomposer
Bug: 116028976
Change-Id: I88455f200590926f677c47efc39e9b6678e2318c
2018-11-05 14:32:49 -08:00
Lloyd Pique
79d6d0c1d0 graphics: Base resource classes need virtual dtor
ComposerResources allows a derived class to define specializations of
the ComposerDisplayResource and ComposerLayerResource classes, which are
returned by overrides of the createDisplayResources() and
createLayerResources() member functions. The pointers are wrapped using
a std::unique_ptr, which destroys the owned instance via the base class
destructor.

As the destructor was not virtual, this meant that only the base class
destructor functionality would be used. Any additional cleanup done by
the derived class destructor would not be run!

This impacts the composer-hal 2.2 utility code for example, which adds a
readback buffer cache as a display resource. Any readback buffers that
are imported there will not be released, effectively leaking graphic
buffer memory.

It also affected an ARC++ specialization where a similar per-layer buffer
resource cache was added, and where the leak was observable since layers
are created and destroyed much more often than displays.

Bug: 117877825
Test: No leaks for ARC++ devices
Change-Id: I6e604b415d3ed787c2e51729a77278594e41e7a9
2018-11-02 23:08:08 +00:00
TreeHugger Robot
c1d5e507e6 Merge "remove USES_DISPLAY_RENDER_INTENTS from vts2.3" 2018-10-25 21:59:24 +00:00
Kevin DuBois
e4d3d5466d remove USES_DISPLAY_RENDER_INTENTS from vts2.3
Removes the USES_DISPLAY_RENDER_INTENTS macro from the 2.3 vts
suite.

Test: ./VtsHalGraphicsComposerV2_3TargetTest (passes same # of tests
Test: before and after)
Bug: 118434553

Change-Id: I32fbbf4f09d5ead1143af56f39bdf9e8dc2bfc4c
2018-10-25 09:48:59 -07:00
Pawin Vongmasa
95674af0c2 HAL interface for IGraphicBufferProducer V2
Test: Builds

Bug: 112508112

Change-Id: Ic3afaa1e27116d4ff9e5035dfce5c20de3d876e5
2018-10-23 17:33:22 -07:00
Valerie Hau
ec98306549 Adding Dataspace BT2020_SRGB and ColorMode BT2020_SRGB
BT2020_SRGB is BT2020 with SRGB transfer function.  Adding to types V1.2
and upgrading methods that utilize Dataspace and ColorMode

Bug: 115335239
Test: ./libsurfaceflinger_unittest --gtest_filter=GetBestColorMode.*
Change-Id: Ic807183ae2bd0212cd8c5d7a24c93db0a1bc28fb
2018-10-22 11:19:52 -07:00
Bill Yi
5989a2f631 Merge pi-dr1-dev to aosp-master
Change-Id: Ida0bc98526f4fc7a1c20f5bbd3210b2f6156d459
2018-10-19 12:20:42 -07:00
Chia-I Wu
7d49f30d3e graphics: composer@2.2 does not require mapper@2.1
am: 0eafa742c6

Change-Id: I6f045113a3c0218a4b8f2c8e794892a21c1fc306
2018-10-19 11:48:36 -07:00
Chia-I Wu
0eafa742c6 graphics: composer@2.2 does not require mapper@2.1
Fix composer@2.2 VTS to not require mapper@2.1.  We will need a
better test infra before things get too complex.

Bug: 112248843
Test: manual
Change-Id: Ia71a102742fd26f14e8edf3f43f3351786350ccd
Merged-In: Ia71a102742fd26f14e8edf3f43f3351786350ccd
2018-10-18 11:22:09 -07:00
Valerie Hau
babe4eb0de Fixing Readback Test failures related to auto-succeed
Prior implementation failed to clear command reader, causing test to
fail in TearDown.  Transform Readback Tests failed to return if readback
was not supported, moved GTEST_SUCCEED into test body from SetUp

Bug: 111563608
Test: ./VtsHalGraphicsComposerV2_2TargetTest
Change-Id: I4647f94efa216b219d0ef345df1ec3aa81dab4c0
2018-10-05 11:29:06 -07:00
Valerie Hau
55b73312d7 Merge "Adding more Readback tests and refactoring" 2018-10-03 23:37:07 +00:00
Valerie Hau
cfb29a4e7b Adding more Readback tests and refactoring
Bug: 111563608
Test: ./VtsHalGraphicsComposerV2_2TargetTest
--gtest_filter=GraphicsComposerReadbackTest.*

Change-Id: I0e4a8212bf08c2890747f99d5754f92821c2e2f4
2018-10-02 15:39:34 -07:00
Valerie Hau
f3440b34dd Merge "Adding command tests for VTS V2_1 HWC" 2018-09-20 22:59:08 +00:00
Valerie Hau
b50428170e Adding command tests for VTS V2_1 HWC
Bug: 111563608
Test: ./VtsHalGraphicsComposerV2_1TargetTest
Change-Id: I0ea1a26aa296a989f8b18fe8a95ec11e29a194c8
2018-09-18 15:13:23 -07:00
Peiyong Lin
729e6a109d Merge "[Graphics] Add setLayerColorTransform." 2018-09-18 00:10:44 +00:00
Peiyong Lin
830137fc08 [Graphics] Add setLayerColorTransform.
This patch adds HAL API to set per-layer color transformation with a 4x4
matrix. Given a 4x4 matrix, the matrix will be applied on the current layer
before composition.

BUG: 111562338
Test: Build, flash and boot, run VtsHalGraphicsComposerV2_3TargetTest
Change-Id: I673cfc2745d35947107dcab19f383ba5a8067605
2018-09-17 15:37:50 -07:00
Valerie Hau
cbe8e9ab03 Clearing reader and writer queues in executeCommands for HWC VTS Tests
Test: ./VtsHalGraphicsComposerV2_1TargetTest,
./VtsHalGraphicsComposerV2_2TargetTest

Change-Id: Ie47e486d191da30be47cde47d768d3cdde8e04e9
2018-09-17 10:58:03 -07:00
Peiyong Lin
8a7dc8e57b Merge "[Graphics] Only validate display in PresentOrValidateDisplay."
am: 0a0fa7209e

Change-Id: I174b127b17f6e9c2198da681f8272b26b110139d
2018-09-06 23:40:55 -07:00
Valerie Hau
8d782cbd8f Adding unit tests for IComposerClient V2_2 VTS tests
Bug: 111563608
Test: ./VtsHalGraphicsComposerV2_2TargetTest
Change-Id: I081cb065e8a574e667e0f49fb7caac24c34c5535
2018-09-06 09:50:02 -07:00
Valerie Hau
3a32a2b066 Fixing file descriptor close bug and display refresh bug
Test: ./VtsHalGraphicsComposerV2_2TargetTest
Change-Id: Ib3de65ab33496bb89c708d0b98966b0084f0bd10
2018-09-04 14:31:27 -07:00
TreeHugger Robot
1eda2be769 Merge "Fixing execute bug in VTS tests for hardware composer" 2018-08-31 23:12:14 +00:00
Valerie Hau
e6683e2b06 Fixing execute bug in VTS tests for hardware composer
Bug: 113532117
Test: ./VtsHalGraphicsComposerV2_1TargetTest &&
./VtsHalGraphicsComposerV2_2TargetTest
Change-Id: I5c3485d45c798c40377e4567ab14cce667dd17ea
2018-08-31 10:47:50 -07:00
Peiyong Lin
5b42b97ec5 [Graphics] Only validate display in PresentOrValidateDisplay.
Previously we require display to be validated in onRefresh, however, onRefresh
can be called while validateDisplay is executing, results in next
presentDisplay being skipped. This patch makes sure we don't check validation
state when presentDisplay is called.

BUG: 80063800
Test: build, flash, boot and play Youtube videos.
Change-Id: I3d8686db3274436afb6605812641768296f1af0e
Merged-In: I3d8686db3274436afb6605812641768296f1af0e
2018-08-29 14:45:15 -07:00
Peiyong Lin
c64f5f53af [Graphics] Only validate display in PresentOrValidateDisplay.
Previously we require display to be validated in onRefresh, however, onRefresh
can be called while validateDisplay is executing, results in next
presentDisplay being skipped. This patch makes sure we don't check validation
state when presentDisplay is called.

BUG: 80063800
Test: build, flash, boot and play Youtube videos.
Change-Id: I3d8686db3274436afb6605812641768296f1af0e
2018-08-28 15:29:22 -07:00
Valerie Hau
defbad198a Adding more unit tests for hwc VTS
Bug: 111563608
Test: ./VtsHalGraphicsComposerV2_1TargetTest
Change-Id: I41a815c3716db9059572a2dbbbc36a90b7e08289
2018-08-23 16:36:27 -07:00
Valerie Hau
b8485526c4 Merge "Hardware composer VTS test harness" 2018-08-21 01:28:23 +00:00
Valerie Hau
667f11ab3a Hardware composer VTS test harness
Bug: 111563608
Test: VtsHalGraphicsComposerV2_2TargetTest
Change-Id: I965efe8811e45a114978a9c8dd7a440c759787ec
2018-08-20 13:48:22 -07:00
TreeHugger Robot
0a6b9d9ea4 Merge "graphics: composer@2.2 does not require mapper@2.1" 2018-08-20 20:34:58 +00:00
Steven Moreland
fec4521e83 Merge "Update makefiles after native handle in Java." am: 1847a2f2e7 am: fb6a66b3f7
am: 9dc1ccc852

Change-Id: I30fda77e5c5657c00f57a85b959dfd853d535366
2018-08-14 19:38:07 -07:00
Steven Moreland
9dc1ccc852 Merge "Update makefiles after native handle in Java." am: 1847a2f2e7
am: fb6a66b3f7

Change-Id: Iee88bb1f9816230a1ea2373cca6a3f3bb5db2d6e
2018-08-14 15:59:59 -07:00
Steven Moreland
fb6a66b3f7 Merge "Update makefiles after native handle in Java."
am: 1847a2f2e7

Change-Id: I0f981009b2129436872e1e05a06c381c47701fdb
2018-08-14 15:53:31 -07:00
Steven Moreland
f5e4d7fb59 Update makefiles after native handle in Java.
Bug: 35098567
Test: N/A
Change-Id: I54b8d804e480cda09806f8028b966f28c4bd706e
2018-08-14 20:29:42 +00:00
Chia-I Wu
1c2621bf00 graphics: composer@2.2 does not require mapper@2.1
Fix composer@2.2 VTS to not require mapper@2.1.  We will need a
better test infra before things get too complex.

Bug: 112248843
Test: manual
Change-Id: Ia71a102742fd26f14e8edf3f43f3351786350ccd
2018-08-09 10:23:29 -07:00
Chia-I Wu
2209bcb186 graphics: test buffer allocation for thread safety
Bug: 111604912
Test: VTS
Change-Id: I1b6cacc8d6ff5e1c145425ff6f32001090b07b06
2018-08-01 10:01:38 -07:00
Chris Forbes
7df1440086 Merge "HWC2OnFbAdapter: don't claim present fences work" into pi-dev am: 1298fdb186
am: 243babadd0

Change-Id: I7a12386f7566896f18bfab51df97477c4e286b5d
2018-07-23 19:05:08 -07:00