Commit graph

776 commits

Author SHA1 Message Date
Jayant Chowdhary
4a8fd32ef2 Merge "Add some updates to documentation regarding concurrent camera operation." into rvc-dev am: 416e3d94f9
Original change: https://googleplex-android-review.googlesource.com/c/platform/hardware/interfaces/+/11832204

Change-Id: Ifcac52d68b3d3909b64d17ae05ec91778152ebcd
2020-06-11 20:42:06 +00:00
Jayant Chowdhary
416e3d94f9 Merge "Add some updates to documentation regarding concurrent camera operation." into rvc-dev 2020-06-11 20:25:10 +00:00
Jayant Chowdhary
ed8ec83813 Add some updates to documentation regarding concurrent camera operation.
- Add documentation about giving hints to camera HAL about concurrent
  operation before configuring sessions

- Limitations on ZOOM_RATIO_RANGE during concurrent operation.

Bug: 151891611

Test: builds

Change-Id: I79d0bd8be1ed9aa29a1ba080d01833f16eff580c
Signed-off-by: Jayant Chowdhary <jchowdhary@google.com>
2020-06-10 20:07:07 -07:00
Yin-Chia Yeh
12ef3c9929 Camera: add new VTS test config file
The old config file is no longer being used. Adding new config
file that has the proper 30 minutes timeout.

Test: atest VtsHalCameraProviderV2_4TargetTest on Pixel 4
Bug: 156007290
Change-Id: I97b0fff967f87712f8f96ed06b628c70ad30dde4
2020-06-09 14:15:52 -07:00
Shuzhen Wang
419d3b8fd8 Merge "Camera: Clarify ERROR_REQUEST callback" into rvc-dev am: ee71769ebc am: 2d58ef67de am: 8511acbc84 am: 29ef321787
Original change: https://googleplex-android-review.googlesource.com/c/platform/hardware/interfaces/+/11689356

Change-Id: Ib1453f5e234b20ed604d40f2d6d10d19d16de11a
2020-06-08 19:58:15 +00:00
Shuzhen Wang
2d58ef67de Merge "Camera: Clarify ERROR_REQUEST callback" into rvc-dev am: ee71769ebc
Original change: https://googleplex-android-review.googlesource.com/c/platform/hardware/interfaces/+/11689356

Change-Id: Ie4e22c25aaa119a91901a559e438063d86ebaf55
2020-06-08 19:21:09 +00:00
Shuzhen Wang
ee71769ebc Merge "Camera: Clarify ERROR_REQUEST callback" into rvc-dev 2020-06-08 19:07:04 +00:00
Jayant Chowdhary
eaa7a7e0da Merge changes from topic "vts-secure-only-camera" into rvc-dev am: ec37ce4947 am: 1487a9ebb3 am: acc8d9c7ce am: 2d71ac4ea6
Original change: undetermined

Change-Id: I275116cd0a751467375866af68f5149c927eebf9
2020-06-01 23:50:43 +00:00
Jayant Chowdhary
2d71ac4ea6 Merge changes from topic "vts-secure-only-camera" into rvc-dev am: ec37ce4947 am: 1487a9ebb3 am: acc8d9c7ce
Original change: undetermined

Change-Id: Ie8ac640400e1de5c129cadff1b3e87936e582002
2020-06-01 23:34:43 +00:00
Jayant Chowdhary
46a82de871 Merge changes from topic "vts-secure-only-camera" into rvc-dev am: ec37ce4947
Original change: undetermined

Change-Id: I7f99fe08f74082881ecdbe38daa8b21ebbc8dacd
2020-06-01 23:02:55 +00:00
Jayant Chowdhary
ec37ce4947 Merge changes from topic "vts-secure-only-camera" into rvc-dev
* changes:
  Camera VTS: Add a minimal test for secure only cameras.
  camera vts: Skip regular vts tests for secure only cameras.
2020-06-01 22:52:53 +00:00
Shuzhen Wang
643dd41944 Camera: Clarify ERROR_REQUEST callback
Allow partial result to be generated in the case of ERROR_REQUEST.

Test: Build
Bug: 155353799
Change-Id: I6ade958cac773e854d669aec3caf99191a875ec7
2020-06-01 12:28:28 -07:00
Jayant Chowdhary
a80974ca8c Camera VTS: Add a minimal test for secure only cameras.
Bug: 156749607

Test: VtsHalCameraProviderV2_4TargetTest
      --gtest_filter=PerInstance/CameraHidlTest.processSecureCaptureRequest* on device which
      SECURE_IMAGE_DATA.

Change-Id: I57f6210b69b383dc4f43cc4ee8272050a0432541
Signed-off-by: Jayant Chowdhary <jchowdhary@google.com>
2020-06-01 12:15:58 -07:00
Jayant Chowdhary
83b724a23f camera vts: Skip regular vts tests for secure only cameras.
Bug: 156749607

Test: fake mark a camera id as a secure only, see that it doesn't get
      tested unless a test calls getCameraDeviceNames with addSecure = true

Test: VtsHalCameraProviderV2_4TargetTest passes on device without any secure only
      cameras

Change-Id: Ibe428b663bd8024f46f0273ed5dfaa108a90dd43
Signed-off-by: Jayant Chowdhary <jchowdhary@google.com>
2020-06-01 12:14:47 -07:00
TreeHugger Robot
328f3c8871 Merge "Camera: Allow maxDigitalZoom to be less than maxZoomRatio" into rvc-dev am: 25ff02b703 am: 60747b7823 am: 6ec7a4846d am: 75bef4391f
Change-Id: I30cc9af1199ddc9e7cd851c77dff043d04d39734
2020-05-27 22:21:12 +00:00
TreeHugger Robot
75bef4391f Merge "Camera: Allow maxDigitalZoom to be less than maxZoomRatio" into rvc-dev am: 25ff02b703 am: 60747b7823 am: 6ec7a4846d
Change-Id: Ie7a5b01c3b48bd57d09eb7df05669fa2fe3fd277
2020-05-27 22:04:27 +00:00
TreeHugger Robot
a960704555 Merge "Camera: Allow maxDigitalZoom to be less than maxZoomRatio" into rvc-dev am: 25ff02b703
Change-Id: I81abe5918742929ebe7fd2d19415757d9f27d3e1
2020-05-27 21:36:38 +00:00
Shuzhen Wang
1d4e72f387 Camera: Allow maxDigitalZoom to be less than maxZoomRatio
For concurrent camera, we allow the maximum digital zoom to be smaller
than the maximum zoom ratio. Adjust VTS test accordingly.

Test: camera VTS test
Bug: 151891611
Change-Id: I1d3813ed93faa83689dcb6a83490fae5581c602f
2020-05-27 12:04:38 -07:00
Jason Macnak
382c0dc077 Merge "Implement lockYCbCr stub for Mapper 4.0" into rvc-dev am: 2540a38771 am: 6313157f6b am: 79836771da am: 49c442cf03
Change-Id: I27637bdf3bbcdf6d140668c26552ae51a83d6463
2020-05-15 16:09:13 +00:00
Eino-Ville Talvala
03362e43d6 Merge "Camera: Update documentation for rolling shutter skew" into rvc-dev am: 6d9c200198 am: 907694dc34 am: d24634cb43 am: 8894d2ab30
Change-Id: Ibd848580abec0adf26f83f673238aebe382f26da
2020-05-15 16:08:39 +00:00
Jason Macnak
125ccb95ee Merge "Implement lockYCbCr stub for Mapper 4.0" into rvc-dev am: 2540a38771
Change-Id: Ia78155463d85f6d3cb1b0003589cfdf3abf9426e
2020-05-15 15:54:35 +00:00
Eino-Ville Talvala
4f03969e11 Merge "Camera: Update documentation for rolling shutter skew" into rvc-dev am: 6d9c200198
Change-Id: Ic3c20086cec1c58e47941206b42d78913cd13375
2020-05-15 15:53:59 +00:00
Jason Macnak
49c442cf03 Merge "Implement lockYCbCr stub for Mapper 4.0" into rvc-dev am: 2540a38771 am: 6313157f6b am: 79836771da
Change-Id: I70adc55711ef4d13174dd1c72cd49dfff3202803
2020-05-15 15:51:31 +00:00
Eino-Ville Talvala
8894d2ab30 Merge "Camera: Update documentation for rolling shutter skew" into rvc-dev am: 6d9c200198 am: 907694dc34 am: d24634cb43
Change-Id: I6e22ffbcbae9f3746ad72bc52b41796c350518ce
2020-05-15 15:49:57 +00:00
Jason Macnak
2540a38771 Merge "Implement lockYCbCr stub for Mapper 4.0" into rvc-dev 2020-05-14 21:06:54 +00:00
Eino-Ville Talvala
6d9c200198 Merge "Camera: Update documentation for rolling shutter skew" into rvc-dev 2020-05-14 16:49:42 +00:00
Eino-Ville Talvala
34bb3064fe Camera: Update documentation for rolling shutter skew
Existing definition was inconsistent, so update it to be consistent
and match what implementations have actually done.

Test: Builds
Bug: 150331548
Change-Id: I5dfbe7c802bf4ac98f0c5556d5ac3af5d79cff7a
2020-05-13 21:13:20 +00:00
Jason Macnak
2168cda03c Merge "Adds a lock method to HandleImporter w/ access region" into rvc-dev am: 26b2e0b708 am: ae7d2186e8 am: b76ffdeccf am: 557e1b6cb0
Change-Id: I0315739a64a11c1ca2e4a52530a39713025d9a99
2020-05-12 22:58:43 +00:00
Jason Macnak
b76ffdeccf Merge "Adds a lock method to HandleImporter w/ access region" into rvc-dev am: 26b2e0b708 am: ae7d2186e8
Change-Id: I2ffe034e964e86e8ae666c093ae2278ee3d5c33d
2020-05-12 21:01:37 +00:00
Jason Macnak
5a48860817 Merge "Adds a lock method to HandleImporter w/ access region" into rvc-dev am: 26b2e0b708
Change-Id: I13915559610aa2f4813efca4bf99fd2946f96cbb
2020-05-12 20:57:22 +00:00
Jason Macnak
eda6dca45c Implement lockYCbCr stub for Mapper 4.0
(Includes bpfmt changes from repo hook)

Bug: b/146515640
Test: cts -m CtsCameraTestCases
Change-Id: Ibd882db1883e0976c2baf95257e51c29de6e6853
2020-05-12 11:40:20 -07:00
Jason Macnak
f2c9ed1309 Adds a lock method to HandleImporter w/ access region
... to allow locking 2D regions of non-BLOB buffers.

Bug: b/146515640
Test: cts -m CtsCameraTestCases
Change-Id: Ia68abf96ffe15891520833921e103efa3f7a80c5
2020-05-12 11:33:55 -07:00
TreeHugger Robot
054b6c788c Merge "Camera: move preCorrectionActiveArraySize override to cameraserver" into rvc-dev am: 7b938e3471 am: efe82e7dfc am: ff08b2c335 am: bf10f566be
Change-Id: I9d9e0791438103e3db01a2db41ff3f7dd8176e12
2020-05-04 06:23:55 +00:00
TreeHugger Robot
ff08b2c335 Merge "Camera: move preCorrectionActiveArraySize override to cameraserver" into rvc-dev am: 7b938e3471 am: efe82e7dfc
Change-Id: I78f0254ae0b372baff14c3cfe50854028c16608e
2020-05-04 05:53:14 +00:00
TreeHugger Robot
488ea65049 Merge "Camera: move preCorrectionActiveArraySize override to cameraserver" into rvc-dev am: 7b938e3471
Change-Id: I853ec94ee01b58a4be2a4afd53371b06bacc48e6
2020-05-04 05:44:00 +00:00
TreeHugger Robot
7b938e3471 Merge "Camera: move preCorrectionActiveArraySize override to cameraserver" into rvc-dev 2020-05-04 05:28:39 +00:00
Suren Baghdasaryan
608059a6bc Replace direct pid writes with setting task profiles for camera interfaces
For easy transition from SchedTune to UtilClamp, direct access to these
cgroups should be abstracted by using task profiles. Replace writepid
commands with new task_profiles command.

Bug: 155419956
Test: change .rc file and confirm task profile is applied
Signed-off-by: Suren Baghdasaryan <surenb@google.com>
Change-Id: I2732f7365351f132dbf0566319e3969c2a25b3e4
Merged-In: I2732f7365351f132dbf0566319e3969c2a25b3e4
2020-05-02 00:34:24 +00:00
Shuzhen Wang
75b0f0288c Camera: move preCorrectionActiveArraySize override to cameraserver
This is to handle the case where HAL isn't using the hidl shim.

Test: dumpsys on Pixel 2
Bug: 145300768
Change-Id: I74874a025904887cc27ec00518f4261dd24e291a
2020-05-01 11:59:10 -07:00
Suren Baghdasaryan
d6bf69dc9c Replace direct pid writes with setting task profiles for camera interfaces am: 849e9fc8b6 am: 264676daab am: 52d1ce7048 am: c96f32f908 am: 5379a9dcde
Change-Id: I0b4a60a06fe349483f1371389c2b0f5d8e106adb
2020-05-01 17:33:34 +00:00
Suren Baghdasaryan
52d1ce7048 Replace direct pid writes with setting task profiles for camera interfaces am: 849e9fc8b6 am: 264676daab
Change-Id: Ibc8b17e63a69f2b3da09af60465f692d22627cae
2020-05-01 17:03:57 +00:00
Suren Baghdasaryan
264676daab Replace direct pid writes with setting task profiles for camera interfaces am: 849e9fc8b6
Change-Id: I65da7a5b8636ea6677ab6820922bb5b18e5ff654
2020-05-01 16:49:32 +00:00
Suren Baghdasaryan
849e9fc8b6 Replace direct pid writes with setting task profiles for camera interfaces
For easy transition from SchedTune to UtilClamp, direct access to these
cgroups should be abstracted by using task profiles. Replace writepid
commands with new task_profiles command.

Bug: 155419956
Test: change .rc file and confirm task profile is applied
Signed-off-by: Suren Baghdasaryan <surenb@google.com>
Change-Id: I2732f7365351f132dbf0566319e3969c2a25b3e4
2020-04-30 13:45:23 -07:00
TreeHugger Robot
32cd27eb2f Merge "vts camera characteristtics: add tests for system camera restrictions." into rvc-dev am: 253be8a6b4 am: d35cbc1058 am: e6fe95ad85 am: 0f484be74c
Change-Id: Ib629b974c40a9f1c546e7041d62d8f80a4c70e0f
2020-04-28 20:24:29 +00:00
TreeHugger Robot
e6fe95ad85 Merge "vts camera characteristtics: add tests for system camera restrictions." into rvc-dev am: 253be8a6b4 am: d35cbc1058
Change-Id: I86a6b22cd9c4397d449cde3a831e2dd2463f3ab5
2020-04-28 19:52:05 +00:00
TreeHugger Robot
740f84aaef Merge "vts camera characteristtics: add tests for system camera restrictions." into rvc-dev am: 253be8a6b4
Change-Id: I0b3b23dc80ee32fa8c5614490887c0f349c3319e
2020-04-28 19:30:48 +00:00
TreeHugger Robot
253be8a6b4 Merge "vts camera characteristtics: add tests for system camera restrictions." into rvc-dev 2020-04-28 19:18:34 +00:00
Jayant Chowdhary
7612f161a7 vts camera characteristtics: add tests for system camera restrictions.
The system camera kind of physical cameras which are public, should be the same as the
system camera kind of the logical cameras they back.

The system camera kinds of all logical cameras that share the same
hidden physical cameras must be the same.

Bug: 152053830

Test: VtsHalCameraProviderV2_4TargetTest
      --gtest_filter=PerInstance/CameraHidlTest.getCameraCharacter*

Test: VtsHalCameraProviderV2_4TargetTest
      --gtest_filter=PerInstance/CameraHidlTest.systemCamera*

Change-Id: Iba07a6aa4a5fb465e9e0c4d0adedf6becaba7d14
Signed-off-by: Jayant Chowdhary <jchowdhary@google.com>
2020-04-28 10:32:06 -07:00
Tom Cherry
ebd35b4562 Include what you use: <fcntl.h> am: 10256e3ad8 am: bbf78ea50d am: a3a2e9c664 am: 336ba5e799 am: 9184fa2d43
Change-Id: Iab11ec9a80bda7aefc0c8b2d23a3873d3fba6043
2020-04-13 21:13:52 +00:00
Tom Cherry
a3a2e9c664 Include what you use: <fcntl.h> am: 10256e3ad8 am: bbf78ea50d
Change-Id: Id497f81dc9bfe8d5d5bd138e903119bbeb8e328c
2020-04-13 19:56:08 +00:00
Tom Cherry
bbf78ea50d Include what you use: <fcntl.h> am: 10256e3ad8
Change-Id: I29ee59072bc9157c907f93db17c64d6d9e33c256
2020-04-13 19:37:11 +00:00
Tom Cherry
10256e3ad8 Include what you use: <fcntl.h>
This was transitively included, but no longer is, so it must be
explicitly included.

Exempt-From-Owner-Approval: Janitorial
Test: build
Change-Id: I48d318c53cbfb76849f987029b0c8e775f576496
2020-04-13 11:09:42 -07:00
Dan Shi
aad51fa000 Rename vts-core to vts
Bug: 151896491
Test: local build
Exempt-From-Owner-Approval: This CL update suite name vts-core to vts as
the suite name is updated. This CL won't change test logic or behavior.

Change-Id: I562b4dc50765e953800a814a8fd84a01c1b9352b
Merged-In: I562b4dc50765e953800a814a8fd84a01c1b9352b
2020-04-07 16:37:40 -07:00
Dan Shi
3a8a650c61 Rename vts-core to vts
Bug: 151896491
Test: local build
Exempt-From-Owner-Approval: This CL update suite name vts-core to vts as
the suite name is updated. This CL won't change test logic or behavior.

Change-Id: I562b4dc50765e953800a814a8fd84a01c1b9352b
2020-04-07 18:03:49 +00:00
TreeHugger Robot
c0909faaa3 Merge "Camera: Update metadata docs to match current API" into rvc-dev am: 42b7037739 am: e1ff41dbe1
Change-Id: I366f9ff91b426d29a3242ec1f7feebb0a22a9c93
2020-03-24 19:05:28 +00:00
TreeHugger Robot
6ad97556cf Merge "Camera: Update metadata docs to match current API" into rvc-dev am: 42b7037739
Change-Id: Ide8dc0cf713e0d8aa246d670922f0003c179b585
2020-03-24 18:56:04 +00:00
TreeHugger Robot
42b7037739 Merge "Camera: Update metadata docs to match current API" into rvc-dev 2020-03-24 18:41:45 +00:00
Jayant Chowdhary
3f771f3a7e Merge "Clarify getConcurrentStreamingCameraids may return hidden physical camera ids as well." into rvc-dev am: 9b56a5a538 am: 4711132d0d
Change-Id: I4ea1dcd869fdf4d2c820c507e6a92ba3a302fcbf
2020-03-23 03:34:18 +00:00
Jayant Chowdhary
3f59f7aa1c Merge "Clarify getConcurrentStreamingCameraids may return hidden physical camera ids as well." into rvc-dev am: 9b56a5a538
Change-Id: I569f0e42b0eb3e7a677528c591032d35bbaa2a11
2020-03-23 03:18:02 +00:00
Jayant Chowdhary
9b56a5a538 Merge "Clarify getConcurrentStreamingCameraids may return hidden physical camera ids as well." into rvc-dev 2020-03-23 03:01:23 +00:00
Shuzhen Wang
013ae8eba4 Camera: Migrate BOKEH_MODE to EXTENDED_SCENE_MODE am: acf026ec78 am: 48e41d4863
Change-Id: Ia382190620e2d34cdc0b79bb74d8abe9fc5a712c
2020-03-21 05:02:03 +00:00
Shuzhen Wang
3803c1970f Camera: Migrate BOKEH_MODE to EXTENDED_SCENE_MODE am: acf026ec78
Change-Id: I216a46285b8c67b230f890a58171fce0a4771d3a
2020-03-21 04:40:36 +00:00
Shuzhen Wang
48e41d4863 Camera: Migrate BOKEH_MODE to EXTENDED_SCENE_MODE am: acf026ec78
Change-Id: I60d1ad7cc1d5dc5ce816d549efb2d75754a6a6c2
2020-03-21 04:40:13 +00:00
TreeHugger Robot
ed52cf6f83 Merge "Camera: Migrate BOKEH_MODE to EXTENDED_SCENE_MODE" into rvc-dev 2020-03-21 04:25:09 +00:00
Jayant Chowdhary
61c3ac2a69 Clarify getConcurrentStreamingCameraids may return hidden physical camera ids as well.
Bug: 151891611

Test: builds

Change-Id: I889065b379d9966e9cc8a225fb335685f2f065cd
Signed-off-by: Jayant Chowdhary <jchowdhary@google.com>
2020-03-20 16:25:05 -07:00
Eino-Ville Talvala
4befcfdddb Camera: Update metadata docs to match current API
Test: Builds
Bug: 150036107
Change-Id: I3e5321e91458d980ad96d3665d9f11bbafb047f1
2020-03-20 15:42:16 -07:00
TreeHugger Robot
806cd29563 Merge "Camera: Avoid adding uninitialized hal requests" into rvc-dev am: 104fe8332f am: f193aa7ffb
Change-Id: I505c9de4f40708d2a63b66981a052d3d5ada8e22
2020-03-20 18:38:23 +00:00
TreeHugger Robot
19d25d08aa Merge "Camera: Avoid adding uninitialized hal requests" into rvc-dev am: 104fe8332f
Change-Id: Id06c238c7e656b94f87aae6596edaee1367dd1cf
2020-03-20 18:17:44 +00:00
TreeHugger Robot
104fe8332f Merge "Camera: Avoid adding uninitialized hal requests" into rvc-dev 2020-03-20 17:59:15 +00:00
Shuzhen Wang
acf026ec78 Camera: Migrate BOKEH_MODE to EXTENDED_SCENE_MODE
Migrate BOKEH_MODE_STILL_CAPTURE and BOKEH_MODE_CONTINUOUS to be 2 enums
of CONTROL_EXTENDED_SCENE_MODE.

Test: VtsHalCameraProviderV2_4TargetTest
Bug: 151759402
Change-Id: I4ee88ab550902edadbd8dc446677c5a02ea582cb
2020-03-19 09:49:03 -07:00
TreeHugger Robot
211533c556 Merge "Camera: Advertise numbered string ID for external cameras" into rvc-dev am: 7bf05d75bc
Change-Id: Ie249d2be0b955cfae416672df52e78aea3483d63
2020-03-18 21:52:15 +00:00
Anton D. Kachalov
34cdbcde50 Camera: Advertise numbered string ID for external cameras
With current implementation cameraId is part of something like:

  device@3.5/external//dev/video0

This doesn't work well with Camera2 API based apps.

Adding CameraIdOffset tag to Provider as a base offset.

Test: presubmit builds
Bug: 151350336

Merged-In: I6309d16be565616f048fb24a70e9be5b2f5ed480
Change-Id: I6309d16be565616f048fb24a70e9be5b2f5ed480
(cherry picked from commit 4f6022ae5d)
2020-03-12 21:21:09 +00:00
Automerger Merge Worker
8fe3efb604 Merge "Fix bugprone-use-after-move warnings" am: 1c7e676905 am: e59bd9e1a7
Change-Id: Ib55852613336c4def111922b010f938fa7eec14b
2020-03-10 17:47:10 +00:00
Automerger Merge Worker
ec4685de6c Merge "Fix bugprone-use-after-move warnings" am: 1c7e676905 am: e59bd9e1a7
Change-Id: Ifbbdf54efe22128725600f5da4956547fe5871cf
2020-03-10 17:47:01 +00:00
Chih-Hung Hsieh
ba3a1cb529 Fix bugprone-use-after-move warnings
Bug: 150783499
Test: WITH_TIDY=1 make
Change-Id: If257532523674ea6256b72ec765904a8de5bf565
2020-03-05 15:30:00 -08:00
Automerger Merge Worker
5d8f353ad6 Camera: Fix possible ExifUtils heap corruption am: aa5673385a am: 711ebe64dd am: f4481c4d98
Change-Id: Id9341512a4c547abd532bb96d70f9ac50cb1745c
2020-03-04 18:29:33 +00:00
Automerger Merge Worker
098aae3c96 Camera: Fix possible ExifUtils heap corruption am: aa5673385a am: 711ebe64dd am: f4481c4d98
Change-Id: I4b5e0308f7a5af5e0aaa4b85e458f0e90b4fac7b
2020-03-04 18:28:55 +00:00
Automerger Merge Worker
711ebe64dd Camera: Fix possible ExifUtils heap corruption am: aa5673385a
Change-Id: I209742be498ea65b6763cf673514e74241b75717
2020-03-04 17:58:31 +00:00
Jayant Chowdhary
7d69fc8ffa camera: Add more VTS tests for ICameraProvider@2.6
Add initial test exercising getConcurrentStreamingCameraIds() and
isConcurrentSessionConfigurationSupported()

Bug : 148180006

Test: VtsHalCameraProviderV2_4TargetTest --gtest_filter=PerInstance/CameraHidlTest.configureConc*
      on cuttlefish

Change-Id: If3821ba5452d487e9a0d83d01e2da86ddf509b50
Signed-off-by: Jayant Chowdhary <jchowdhary@google.com>
2020-03-02 00:15:00 -08:00
Emilian Peev
36aa827f70 Camera: Avoid adding uninitialized hal requests
The offline requests deque is constructed with
specific amount of entries. Initialize the
the already allocated entries before pushing
new ones.

Bug: 149346795
Test: Camera CTS
Change-Id: I6db8d48949caf753429702b60c48698c95ecf4ad
2020-02-26 16:41:57 -08:00
Jayant Chowdhary
6ae828b6f0 ICameraProvider@2.6: Add documentation about resource cost constraints for concurrent camera combinations.
- Also clarify requirements for MONOCHROME devices supporting Y8 outputs.

Bug: 150225538

Test: builds (doc change only)

Change-Id: I992f1bcee4bf266b6e66ddb32ece8291381c8e56
Signed-off-by: Jayant Chowdhary <jchowdhary@google.com>
2020-02-26 22:44:00 +00:00
Yin-Chia Yeh
6e082e8581 Camera: clarify depth camera requirement for OFFLINE_PROCESSING
Test: build (doc only change)
Bug: 135142453
Change-Id: I48589e6f7fad6ff291a57de305b4a549dbb843b2
2020-02-20 22:44:27 +00:00
Jayant Chowdhary
3a0030faab ICameraProvider@2.6 : Update documentation for getConcurrentStreamingCameraIds.
Bug: 148995918

Test: builds

Change-Id: I89df3be9e15881e081b76d6c0312bc54da931dea
Signed-off-by: Jayant Chowdhary <jchowdhary@google.com>
2020-02-19 14:16:44 -08:00
Jayant Chowdhary
653ea6c323 ICameraProvider@2.6: Update mandatory concurrent stream combinations.
Bug: 77960042

Test: builds

Change-Id: Ic56d6a10ee3521901aae5d8e7289dead7c20b086
Signed-off-by: Jayant Chowdhary <jchowdhary@google.com>
2020-02-19 13:36:39 -08:00
Emilian Peev
aa5673385a Camera: Fix possible ExifUtils heap corruption
Both EXIF_TAG_IMAGE_WIDTH and EXIF_TAG_IMAGE_LENGTH
expect short values as per EXIF spec. Call appropriate
libexif function to avoid possible heap corruption.

Bug: 148223871
Test: Successful build
Change-Id: Ib16bf1ae8ab2093da529efe6ff0778331c3e9eb3
2020-02-18 10:20:02 -08:00
Emilian Peev
f0aa3f0107 Camera: Add ICameraDevice@3.6 subinterface
Camera device subinterface version 3.6 must inherit
from the previous version 3.5 and continue to support
device sessions with versions 3.2, 3.5 as well as the
most recent 3.6.

Bug: 148235329
Test: VtsHalCameraProviderV2_4TargetTest
--gtest_filter=PerInstance/CameraHidlTest.switchToOffline/0_external_0

Change-Id: Ia46cbd771eb1d2624cc0cee808a3eb074fc775b6
2020-02-04 10:12:15 -08:00
Yin-Chia Yeh
64479a583b Merge changes from topic "OfflineReproc-impl-tests"
* changes:
  Camera: fix offline processing VTS/CTS
  Camera: Verify offline session behavior in VTS
2020-02-04 17:52:00 +00:00
TreeHugger Robot
4aff0ab86f Merge "Camera: add webcam offline processing support" 2020-02-03 19:40:26 +00:00
Yin-Chia Yeh
97978fbe32 Camera: fix offline processing VTS/CTS
Test: camera VTS test + add manual delay to webcam HAL output thread
      so there will be some requests left for offline processing
      camera CTS OfflineSessionTest
Bug: 135142453
Change-Id: If5718350707ef051f96b96da75f934089b10467d
2020-02-03 10:30:05 -08:00
Emilian Peev
9ab6b3eb3e Camera: Verify offline session behavior in VTS
Camera offline sessions can be used as way to
free up and share camera resources. Check that
the corresponding HIDL API behaves as per
documentation.

Bug: 135142453
Test: adb shell /system/bin/VtsHalCameraProviderV2_4TargetTest
--hal_service_instance=android.hardware.camera.provider@2.4::ICameraProvider/internal/0

Change-Id: I5b714061894eb2b0179a44dcedf81b0155fb4b54
2020-02-03 10:29:45 -08:00
Yin-Chia Yeh
5dab7280b3 Camera: add webcam offline processing support
Test: CTS/VTS in follow up changes
Bug: 135142453
Change-Id: Ie95f22795f4807ed384443de0fffc65c5dde16d1
2020-02-03 10:09:56 -08:00
Paul Chen
17859d49aa Revert "Camera: add webcam offline processing support"
This reverts commit 7f2ce25f64.

Reason for revert: aosp_x86-userdebug build break

Change-Id: Ie8ad10066ae5c473e183d930ab03e63b61a2dd75
2020-01-31 11:23:26 +00:00
TreeHugger Robot
9ef8268471 Merge "Camera: add webcam offline processing support" 2020-01-31 01:29:38 +00:00
TreeHugger Robot
cd3f355937 Merge "Camera: add webcam HAL@3.6 support" 2020-01-30 23:10:52 +00:00
Yin-Chia Yeh
7f2ce25f64 Camera: add webcam offline processing support
Test: CTS/VTS in follow up change
Bug: 135142453
Change-Id: I3e4dc201ac495e0966e47d45494a0db6c1c3b24a
2020-01-30 10:49:22 -08:00
Yin-Chia Yeh
4da7c6c997 Camera: add webcam HAL@3.6 support
First CL to setup webcam HAL to support HIDL camera device 3.6.
Follow up CL will add actual offline processing capability.

Test: TestingCamera.apk
Bug: 135142453
Change-Id: Ifcd1b22f42d08b0fa5dc6039125c1d979b8104c2
2020-01-29 11:22:20 -08:00
Jayant Chowdhary
6248100ed6 camera: Add ICameraProvider@2.6.
ICameraProvider@2.6 adds the following new apis:

- getConcurrentStreamingCameraIds()
    tells the camera framework which combinations of camera ids may
    stream concurrently with guaranteed stream combinations

- isConcurrentSessionConfigurationSupported()
    in order to assist the camera framework in knowing which camera ids may stream
    concurrently and whether certain concurrent session configurations will
    be supported by the camera HAL.

Bug: 77960042

Test: builds

Change-Id: I47caddb7ae5c7b1b2e926f7b877f53a367564d2a
Signed-off-by: Jayant Chowdhary <jchowdhary@google.com>
2020-01-24 08:50:50 -08:00
Eino-Ville Talvala
b0ab1b8f74 Merge "Camera: Add android.scaler.rotateAndCrop control" 2020-01-24 06:04:15 +00:00
Shuzhen Wang
05066109ff Camera: Add ICameraProviderCallback version 2.6
The new version adds callback for physical sub-camera status callback.

Test: VtsHalCameraProviderV2_4TargetTest --hal_service_instance=android.hardware.camera.provider@2.6::ICameraProvider/internal/1
Bug: 119325027
Change-Id: I8148f6c55f80d7f4092d2fe5ccf92509bb8c069d
2020-01-23 10:47:54 -08:00
Eino-Ville Talvala
de45c29522 Camera: Add android.scaler.rotateAndCrop control
Test: New CTS tests pass
Bug: 134631897
Change-Id: Ibdfee75b9e77f661e1db5c26faeecae7853342bd
2020-01-21 00:29:31 -08:00
Shuzhen Wang
c5ae069c79 Camera: Add new pose reference value UNDEFINED
If a camera device's location/orientation changes due to user action
(such as phone fold/unfold), its pose reference can be set to UNDEFINED.

Bug: 119325027
Test: VtsHalCameraProviderV2_4TargetTest
Change-Id: I227be31db64db049a8fad57e6765e1b6e025529a
2020-01-15 11:09:26 -08:00