Commit graph

103 commits

Author SHA1 Message Date
Jaekyun Seok
81104ae5ef Add 'vendor.' prefix to a vendor HAL service name
To prevent property name collisions between properties of system and
vendor, 'vendor.' prefix must be added to a vendor HAL service name.
You can see the details in http://go/treble-sysprop-compatibility.

Test: succeeded building and tested on a walleye device
Bug: 36796459
Change-Id: I4e8fbee791ec917a8f627a1366f4d44ec7e6febc
2017-09-12 08:01:42 +09:00
Jeff Vander Stoep
60ced29112 configstore: Allow syscalls needed by crash_dump
Information such as tombstones and callstack are important when
debugging why a process crashed. configstore's seccomp filter
and selinux policy are currently overly strict and are blocking
the collection of crash data.

In order to keep configstore's sandbox as strict as possible, use
Crash_dump's fallback mechanism to collect crash data. This uses a
local socket to send crash data to tombstoned.

Bug: 64768925
Test: killall -ABRT android.hardware.configstore@1.1-service
    Verify that configstore callstack gets dumped to logcat.
    Verify that a crash tombstone gets recorded to /data/tombstones
Test: proto_fuzzer runs without crashing

Change-Id: I3c3e13d6aa1c1e2dda2a619dfa815375ee7ebff6
2017-08-18 13:51:43 -07:00
Steven Moreland
6da35570df Updating all makefiles.
Bug: 64487114
Test: none
Change-Id: I8608c8f636c35f21e4246a805a9eff6d14124e0a
2017-08-10 23:43:46 +00:00
Tri Vo
2b2ba2fa83 Merge "VTS tests now static link to HAL def libs. #2" into oc-mr1-dev am: 2883486706
am: a6969cdd68

Change-Id: Iecd7cfd4e02aea837647e2f12446e7375744f004
2017-08-10 18:38:53 +00:00
Tri Vo
a6969cdd68 Merge "VTS tests now static link to HAL def libs. #2" into oc-mr1-dev
am: 2883486706

Change-Id: I763622ff5280ade458da82e95df50a1b6d104f93
2017-08-10 18:08:27 +00:00
Tri Vo
0c2ce357b1 VTS tests now static link to HAL def libs. #2
And use VtsHalTargetTestDefaults.

Bug: 64040096
Test: crop out all non-affected tests from vts-hal-hidl.xml and run
vts-tradefed run commandAndExit vts-hal-hidl --skip-all-system-status-check 
--skip-preconditions
2 failures, same as without this change:
GatekeeperHidlTest.DeleteAllUsersTest
GatekeeperHidlTest.DeleteUserTest

Change-Id: I8f6995e9536a9aefe283ee3effec9f5a7f03b620
2017-08-10 17:44:57 +00:00
TreeHugger Robot
cf3dd6faed Merge "configstore: sandbox with seccomp filter" 2017-08-07 21:07:57 +00:00
Justin Yun
f628856a98 Merge changes from topic 'hidl-vndk-enabled-oc-mr1' into oc-mr1-dev am: 0a21415efa
am: fc85237365

Change-Id: I9857a7cb84520cca5ca66d5a8a84b29ed1559f0f
2017-08-05 02:17:44 +00:00
Justin Yun
723c2dbd43 Update make file for vndk enabled. am: 608d773ef8
am: d66371512c

Change-Id: I35b778c39c2349346278deb6dea56b8cd3701f7d
2017-08-05 02:17:38 +00:00
Justin Yun
fc85237365 Merge changes from topic 'hidl-vndk-enabled-oc-mr1' into oc-mr1-dev
am: 0a21415efa

Change-Id: Ib7d2fb35840ad0789da37e4452f150100fd911a2
2017-08-05 02:10:49 +00:00
Justin Yun
d66371512c Update make file for vndk enabled.
am: 608d773ef8

Change-Id: I6ea2891c61edaa2f8e1657544e3d2fb5011626c8
2017-08-05 02:10:40 +00:00
Justin Yun
eff28dc3ba Mark hidl utils as vndk
As a VNDK module, Android.bp must have 'vndk' tag as well as
'vendor_available: true'.

The 'vndk' tag for VNDK module is formated as below:
vndk: {
    enabled: true,
},

VNDK modules will be installed both in system/lib(64) as normal and
in system/lib(64)/vndk as a vendor variant.

Bug: 63866913
Test: build and boot with BOARD_VNDK_VERSION=current
Change-Id: If0eb0c1bddfa5bdc7ea0ca4635d4e53b59836582
2017-08-04 15:25:13 +09:00
Justin Yun
608d773ef8 Update make file for vndk enabled.
Update the Android.bp generated with hidl-gen.

Test: build with and without BOARD_VNDK_VERSION=current
Bug: 63866913
Change-Id: I1a9db1df49e0f13c5790da2b118ae9ec63ba34a7
2017-08-04 14:12:23 +09:00
Steven Moreland
250aa2ae25 Merge "Update makefiles for vndk enabled." into oc-mr1-dev am: d9b12c13e5
am: a7a300a13b

Change-Id: I4624aae28e0ccd493af5030c8e507aff25bc5743
2017-08-04 05:01:56 +00:00
Steven Moreland
a7a300a13b Merge "Update makefiles for vndk enabled." into oc-mr1-dev
am: d9b12c13e5

Change-Id: Id70e58e6b4d20dada4aab107b2aa98c58cf167ca
2017-08-04 01:04:40 +00:00
TreeHugger Robot
d9b12c13e5 Merge "Update makefiles for vndk enabled." into oc-mr1-dev 2017-08-04 00:52:06 +00:00
Steven Moreland
6ae7aad171 Update makefiles (frameworks.jar).
Test: links at runtime and buildtime
Bug: 35771640
Change-Id: Ic7a71653d659115205e5bdbb782f73b774af0b29
2017-08-03 23:02:46 +00:00
Tri Vo
7694738e26 Update Android.bp HIDL makefiles
am: f5d136c231

Change-Id: Iaabf86403c85f7cbf57d78de5abbfaff0c53fec5
2017-08-03 15:20:54 +00:00
Steven Moreland
c716b8c307 Update makefiles for vndk enabled.
Test: none
Bug: 63866913
Change-Id: I29174fdadca2828455ef49f14e53bc95c5238dbb
2017-08-02 18:00:14 -07:00
Tri Vo
f5d136c231 Update Android.bp HIDL makefiles
Allow HAL definition libs to be static.

Bug: 32920003
Bug: 64040096
Test: update-all-google-makefiles.sh
Change-Id: I1483d572bea6799717d1614fb7d52fe225e31104
2017-08-03 00:30:01 +00:00
Steven Moreland
208a586cf8 Update HIDL makefiles.
Allow them to be static.

This is required for a couple of reasons:
- enabling HIDL passthrough in recovery
- enabling VTS tests to be static blobs

Bug: 32920003
Bug: 64040096
Test: update-all-google-makefiles.sh
Merged-In: I1b2401fb273ab80819e3870aa71fe742269674ba
Change-Id: I1b2401fb273ab80819e3870aa71fe742269674ba
(cherry picked from commit 7206708528)
2017-08-02 12:52:41 -07:00
Sundong Ahn
3bee656e84 Change dependency library am: 94293086f8 am: 79e801cb18 am: aad41e85d4
am: 8ca20771e7

Change-Id: I1b2b68a760751ec6dcb05db1ee6fdead0f00db33
2017-08-02 17:23:11 +00:00
Sundong Ahn
8ca20771e7 Change dependency library am: 94293086f8 am: 79e801cb18
am: aad41e85d4

Change-Id: I079faa1a1438b0d2b0d8e5ed7929c77e73519ca1
2017-08-02 17:14:59 +00:00
Sundong Ahn
79e801cb18 Change dependency library
am: 94293086f8

Change-Id: I3b024890195dad8fa3435a4ff493adbddb63ef20
2017-08-02 16:56:46 +00:00
Sundong Ahn
94293086f8 Change dependency library
hwbinder.jar will be used instead of framework.jar on build-time, but
on runtime framework.jar will be used.

This is to cut the circular dependency when using configstore from
Android framework.

Bug: 35771640
Test: no test.
Change-Id: I04cab676c91d2ea423f5e2c1b2b9efa15e522f37
2017-08-01 11:24:01 +09:00
Steven Moreland
07b399b6ec Merge "Update HIDL makefiles." am: 49dad304a5 am: 68a25d22e3 am: 27e608f01c
am: a1a7a39695

Change-Id: I4eb55db8907fcccdaa605b26c3bbf3549cbc3e7e
2017-07-31 19:43:30 +00:00
Steven Moreland
a1a7a39695 Merge "Update HIDL makefiles." am: 49dad304a5 am: 68a25d22e3
am: 27e608f01c

Change-Id: I1d9c2c1d1b15f865890f3c11310abd4096497ff5
2017-07-31 19:40:02 +00:00
Steven Moreland
68a25d22e3 Merge "Update HIDL makefiles."
am: 49dad304a5

Change-Id: I29f1de44312f589ba6e1df9498809cbb31315a2b
2017-07-31 19:33:34 +00:00
Steven Moreland
7206708528 Update HIDL makefiles.
Allow them to be static.

This is required for a couple of reasons:
- enabling HIDL passthrough in recovery
- enabling VTS tests to be static blobs

Bug: 32920003
Bug: 64040096
Test: update-all-google-makefiles.sh
Change-Id: I1b2401fb273ab80819e3870aa71fe742269674ba
2017-07-26 10:14:57 -07:00
Jiyong Park
e786494ff3 Remove TODO comment for configstore threadpool size
No problem with current configuration has been reported.

Bug: 34857894
Test: not required
Change-Id: Ie23b234eccb2707323032e37b27b387eb96918e5
2017-07-14 10:53:26 +09:00
Jeff Vander Stoep
ed95043d64 configstore: sandbox with seccomp filter
Configstore HAL is accessible to third party apps and thus requires
a tight sandbox that reflects the limited system access this HAL
needs.

We use two primary mechanisms to sandbox configstore, selinux and
seccomp, with the goal of restricting its access to userspace and
the kernel. The addition of a seccomp filter is primarily aimed
at reducing the kernel's attack surface that is reachable by
configstore HAL.

Seccomp filters are architecture dependent, so filters need to be
added for each architecture. This change adds a seccomp filter for
arm64 and issues a non-fatal runtime warning for other architectures
which still require a seccomp filter.

Bug: 36453956
Test: boot Marlin and Angler. Verify that configstore is not aborting
    due to seccomp violations.
Test: "cat proc/<configstore pid>/status | grep seccomp " returns:
    seccomp: 2
    Which indicates that configstore is using seccomp-bpf.

Change-Id: Iab014ff357b7329085a5e18a92f51838d2c72371
2017-07-12 12:58:01 -07:00
Jae Shin
6e3ec61aab Add structural test VtsHalConfigstoreV1_1Target
Add vts test module for configstore@1.1

Test: make vts -j40 && run commandAndExit vts -m
VtsHalConfigstoreV1_1Target
Bug: 63071317

Change-Id: I405f4409bc2ac4acdf07728b950ba9b653eb3328
2017-07-03 13:47:11 +09:00
Jae Shin
97478a5ca0 Assert getService does not return nullptr
Make sure getService return value is not null before running
testcase

Test: make vts -j40 && vts-tradefed run commandAndExit vts -m
VtsHalConfigstoreV1_0Target
Bug:62931371

Merged-In: I432e07c0c61a308b814d88cab9027a95ff24d8b5
(cherry picked from commit 60ff24c62e)

Change-Id: Id9bb2a3fb2c4caf02c7e03c1529cefe2570c5453
2017-06-30 13:11:23 +09:00
Steven Moreland
f04fdeb83e Update internal makefiles.
These makefiles are not in dev topic branches
or AOSP currently so they were not updated. This
update adds hidl-generated-module defaults.

Test: pass
Change-Id: Ie52c54877d795bf5358aa600e6d1a13a4f166d25
2017-06-05 17:47:36 -07:00
Jaesoo Lee
eb72e4ff97 Merge "configstore-utils: add feature to cache service handles" am: 03b02609ff am: fbb8bb0671 am: c028065f5e
am: 1c231dfdad

Change-Id: I86407072bf4bbef94dc625dede248a2e9b29719f
2017-05-25 01:26:33 +00:00
Jaesoo Lee
1c231dfdad Merge "configstore-utils: add feature to cache service handles" am: 03b02609ff am: fbb8bb0671
am: c028065f5e

Change-Id: I30de198a55d1a283db949498e887a06f9565bbe2
2017-05-25 01:24:03 +00:00
Jaesoo Lee
056d77d523 configstore-utils: add feature to cache service handles
Previously, the service handle for the configstore needs to be retrieved
for every calls. This change reduces the time for retrieving multiple
configstore items from a same client by caching the service handle per a
configstore interface class.

Bug: 38411900
Test: built and tested on sailfish.
Change-Id: Iaff81e9f2b026aee0bd3865f5d5ed3fb7b6056e0
2017-05-24 10:04:32 +09:00
Steven Moreland
aeef430de6 Merge "Update makefiles." am: 9119d4ccd1 am: 242b2288d7 am: c6da54569f
am: 67b9ae7d9c

Change-Id: I8462abc85f4f87840c4cee13361290e42746ce82
2017-05-20 00:22:03 +00:00
Steven Moreland
67b9ae7d9c Merge "Update makefiles." am: 9119d4ccd1 am: 242b2288d7
am: c6da54569f

Change-Id: Ib7f7a9cdb64985d545443edac5bb8e9c169fc592
2017-05-20 00:19:40 +00:00
Steven Moreland
06c85d986a Update makefiles.
Adds default configuration to all hals.

Test: pass
Change-Id: Icdf6b56df82c4b7b7de815e7febea9a07ab96856
2017-05-18 16:14:16 -07:00
Jaesoo Lee
812e85e126 configstore: configstore HAL is up-revisioned to 1.1
This change provides a reference implementation of the configstore HAL
v1.1.

Bug: 37727469
Test: Built sailfish-userdebug and configstore-1.1 works
Change-Id: I75e7fd1da8e90ae48d779a3ba28957c5a93a5529
2017-05-17 15:30:17 +09:00
Jaesoo Lee
4c15eccb92 configstore: include types.h instead of ISurfaceFlingerConfigs.h am: 92c77bd6e7 am: 4b1848247f
am: d21a105380

Change-Id: I1a674bd0827b0dccdb01fded168cf3122de81afa
2017-05-12 05:16:36 +00:00
Jaesoo Lee
92c77bd6e7 configstore: include types.h instead of ISurfaceFlingerConfigs.h
Utils.h does not need to include ISurfaceFlingerConfigs.h.

Bug: 37727469
Test: successfully built sailfish-userdebug
Change-Id: I6650020bfc3b265d871ca3244b8900c336f98419
2017-05-11 09:37:03 +09:00
Steven Moreland
8e89a43590 Update makefiles for c++-sources and c++-headers. am: cb360c60d8 am: 4bd4e7fb3b
am: 127b116fe5

Change-Id: I3a2aa76acef0f0d1455bfad775e87e8089d357e8
2017-05-10 02:58:00 +00:00
Steven Moreland
cb360c60d8 Update makefiles for c++-sources and c++-headers.
Test: pass
Bug: 38174080
Change-Id: I683455736eed35e6ced24e2763c2bdb5fb6c9601
2017-05-09 14:34:19 -07:00
Steven Moreland
f90189a79f Merge "Remove redundant dependencies" am: 62769b7196 am: 170e2e85a2
am: 5fba1db1d2

Change-Id: I661fff75d140b4359af055a0f08f08ef33c889c3
2017-05-01 23:37:04 +00:00
Treehugger Robot
62769b7196 Merge "Remove redundant dependencies" 2017-05-01 23:19:25 +00:00
Steven Moreland
ee1d248ae2 Remove redundant dependencies
android.hidl.base@1.0 and android.hidlmanager@1.0 are built into libhidltransport.

Test: links
Bug: 33276472
Change-Id: I424371932af129bba9d58dcf8652c64297f35f05
2017-05-01 09:47:58 -07:00
Steven Moreland
c2af01d66b Merge "configstore-utils: vendor_available" am: c3e640c7f0 am: 759e1d28bd
am: 51ba6a1e43

Change-Id: I9fc5652422f983e37c195abec84ba594993d1407
2017-04-28 03:18:22 +00:00
Steven Moreland
65af0612ce configstore-utils: vendor_available
Test: with BOARD_VNDK_VERSION := current
Change-Id: I4fe86224d18bc7e7579c13f9273bc4efa25df1ea
2017-04-27 18:34:24 -07:00